bpmnlint 11.6.0 → 11.7.0

package/README.md

@@ -75,12 +75,33 @@ You may also extend from multiple configurations, including those provided by [c
 
 This will amend core `recommended` rules with `recommended` rulesets provided by `bpmnlint-plugin-foo` and `@bar/bpmnlint-plugin-bar`, respectively.
 
+Plug-ins will be resolved relative to the configuration file location, using [node module resolution](https://nodejs.org/api/modules.html#loading-from-node_modules-folders).
+
+
 ### Available Configurations
 
 * [`bpmnlint:all`](./config/all.js) - all rules as errors
 * [`bpmnlint:recommended`](./config/recommended.js) - opinionated rules ("best practices") and rules enforcing BPMN compliance
 * [`bpmnlint:correctness`](./config/correctness.js) - rules enforcing BPMN compliance
 
+### Moddle extensions
+
+To validate your diagrams with custom [moddle](https://github.com/bpmn-io/moddle) extensions, add `moddleExtensions` to the root configuration file:
+
+```json
+{
+  "extends": [
+    "bpmnlint:recommended",
+    "plugin:custom/recommended"
+  ],
+  "moddleExtensions": {
+    "custom": "custom-bpmn-moddle/resources/custom.json"
+  }
+}
+```
+
+The extension will be resolved relative to the configuration file location, using [node module resolution](https://nodejs.org/api/modules.html#loading-from-node_modules-folders).
+
 ## API
 
 Invoke the tool directly from [NodeJS](https://nodejs.org/en):

package/config/all.js

@@ -2,6 +2,7 @@ const allRules = [
   'ad-hoc-sub-process',
   'conditional-flows',
   'end-event-required',
+  'event-based-gateway',
   'event-sub-process-typed-start-event',
   'fake-join',
   'global',

package/config/correctness.js

@@ -1,6 +1,7 @@
 module.exports = {
   rules: {
     'ad-hoc-sub-process': 'error',
+    'event-based-gateway': 'error',
     'event-sub-process-typed-start-event': 'error',
     'link-event': 'error',
     'no-duplicate-sequence-flows': 'warn',

package/config/recommended.js

@@ -3,6 +3,7 @@ module.exports = {
     'ad-hoc-sub-process': 'error',
     'conditional-flows': 'error',
     'end-event-required': 'error',
+    'event-based-gateway': 'error',
     'event-sub-process-typed-start-event': 'error',
     'fake-join': 'warn',
     'global': 'warn',

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bpmnlint",
   "description": "Validate your BPMN diagrams based on configurable lint rules",
-  "version": "11.6.0",
+  "version": "11.7.0",
   "main": "lib/index.js",
   "keywords": [
     "bpmnlint",

package/rules/ad-hoc-sub-process.js

@@ -34,13 +34,6 @@ module.exports = function() {
       if (is(flowElement, 'bpmn:EndEvent')) {
         reporter.report(flowElement.id, 'An <End Event> is not allowed in <Ad Hoc Sub Process>');
       }
-
-      if (is(flowElement, 'bpmn:IntermediateCatchEvent')) {
-        if (!flowElement.outgoing || flowElement.outgoing.length === 0) {
-          reporter.report(flowElement.id, 'An intermediate catch event inside <Ad Hoc Sub Process> must have an outgoing sequence flow');
-        }
-      }
-
     });
   }
 

package/rules/event-based-gateway.js

@@ -0,0 +1,45 @@
+const {
+  is
+} = require('bpmnlint-utils');
+
+const {
+  annotateRule
+} = require('./helper');
+
+
+/**
+ * A rule that checks, whether an event-based gateway:
+ * - has at least two outgoing sequence flows
+ * - the outgoing sequence flows are not conditional
+ *
+ * @type { import('../lib/types.js').RuleFactory }
+ */
+module.exports = function() {
+
+  function check(node, reporter) {
+
+    if (!is(node, 'bpmn:EventBasedGateway')) {
+      return;
+    }
+
+    const outgoing = node.outgoing || [];
+
+    if (outgoing.length < 2) {
+      reporter.report(node.id, 'An <Event-based Gateway> must have at least 2 outgoing <Sequence Flow>');
+    }
+
+    outgoing.forEach((flow) => {
+      if (hasCondition(flow)) {
+        reporter.report(flow.id, 'A <Sequence Flow> outgoing from an <Event-based Gateway> must not be conditional');
+      }
+    });
+  }
+
+  return annotateRule('event-based-gateway', {
+    check
+  });
+};
+
+function hasCondition(flow) {
+  return !!flow.conditionExpression;
+}

package/rules/no-gateway-join-fork.js

@@ -29,7 +29,7 @@ module.exports = function() {
     }
   }
 
-  return annotateRule('no-gateway-fork-join', {
+  return annotateRule('no-gateway-join-fork', {
     check
   });