bpmnlint 11.15.0 → 12.0.0

package/lib/linter.js

@@ -1,543 +1,3 @@
-const testRule = require('./test-rule');
+const { createLinter } = require('@bpmn-io/lint-core/lib/linter');
 
-
-/**
- * @typedef { import('./types.js').ModdleElement } ModdleElement
- *
- * @typedef { import('./types.js').ReportingCategory } ReportingCategory
- * @typedef { import('./types.js').ReportingCategoryMap } ReportingCategoryMap
- * @typedef { import('./types.js').RuleErrorCategory } RuleErrorCategory
- *
- * @typedef { import('./types.js').Resolver } Resolver
- * @typedef { import('./types.js').Config } Config
- *
- * @typedef { import('./types.js').RuleFactory } RuleFactory
- *
- * @typedef { import('./types.js').RuleDefinition } RuleDefinition
- * @typedef { import('./types.js').RuleConfigs } RuleConfigs
- * @typedef { import('./types.js').RuleConfig } RuleConfig
- *
- * @typedef { {
- *   name: string,
- *   rule: RuleDefinition,
- *   config: any,
- *   category: ReportingCategory
- * } } ResolvedRuleDefinition
- *
- * @typedef { import('./types.js').Report } Report
- * @typedef { Report & Pick<RuleDefinition, 'meta'> & {
- *   category: ReportingCategory | RuleErrorCategory
- * } } AnnotatedReport
- *
- * @typedef { import('./types.js').TransformRuleFn } TransformRuleFn
- *
- * @typedef { Record<string, AnnotatedReport[]> } LintResults
- */
-
-
-/**
- * Transform a rule after it is loaded.
- *
- * @param { RuleDefinition } rule
- * @param { { pkg: string, ruleName: string } } options
- */
-const noopTransformRule = (rule, options) => {
-  return rule;
-};
-
-
-/**
- * @typeof { ReportingCategoryMap }
- */
-const categoryMap = {
-  0: 'off',
-  1: 'warn',
-  2: 'error',
-  3: 'info'
-};
-
-/**
- * @type { RuleErrorCategory }
- */
-const ruleErrorCategory = 'rule-error';
-
-/**
- * @param { {
- *   config?: Config,
- *   resolver: Resolver,
- *   transformRule?: TransformRuleFn
- * } } options
- */
-function Linter(options) {
-
-  const {
-    config = {},
-    resolver,
-    transformRule = noopTransformRule
-  } = options || {};
-
-  if (typeof resolver === 'undefined') {
-    throw new Error('must provide <options.resolver>');
-  }
-
-  this.config = config;
-  this.resolver = resolver;
-
-  this.transformRule = transformRule;
-
-  /**
-   * @type { Record<string, RuleDefinition> }
-   */
-  this.cachedRules = {};
-
-  /**
-   * @type { Record<string, Config> }
-   */
-  this.cachedConfigs = {};
-}
-
-
-module.exports = Linter;
-
-/**
- * Applies a rule on the moddleRoot and adds reports to the finalReport
- *
- * @param { ModdleElement } moddleRoot
- *
- * @param { ResolvedRuleDefinition } ruleDefinition
- *
- * @return { AnnotatedReport[] } reports
- */
-Linter.prototype.applyRule = function applyRule(moddleRoot, ruleDefinition) {
-
-  const {
-    config,
-    rule,
-    category,
-    name
-  } = ruleDefinition;
-
-  try {
-
-    const reports = testRule({
-      moddleRoot,
-      rule,
-      config
-    });
-
-    return reports.map(function(report) {
-      return {
-        ...report,
-        meta: rule.meta,
-        category
-      };
-    });
-  } catch (e) {
-    console.error('rule <' + name + '> failed with error: ', e);
-
-    return [
-      {
-        message: /** @type { Error } */ (e).message,
-        category: ruleErrorCategory
-      }
-    ];
-  }
-
-};
-
-
-/**
- * @param { string } name
- * @param  { RuleConfig } config
- *
- * @return { Promise<RuleDefinition> }
- */
-Linter.prototype.resolveRule = function(name, config) {
-
-  const {
-    pkg,
-    ruleName
-  } = this.parseRuleName(name);
-
-  const id = `${pkg}-${ruleName}`;
-
-  const rule = this.cachedRules[id];
-
-  if (rule) {
-    return Promise.resolve(rule);
-  }
-
-  return Promise.resolve(this.resolver.resolveRule(pkg, ruleName)).then((ruleFactory) => {
-
-    if (!ruleFactory) {
-      throw new Error(`unknown rule <${name}>`);
-    }
-
-    const rule = this.cachedRules[id] = this.transformRule(ruleFactory(config), { pkg, ruleName });
-
-    return rule;
-  });
-};
-
-/**
- * @param {string} name
- *
- * @return {Promise<Config>}
- */
-Linter.prototype.resolveConfig = function(name) {
-
-  const {
-    pkg,
-    configName
-  } = this.parseConfigName(name);
-
-  const id = `${pkg}-${configName}`;
-
-  const config = this.cachedConfigs[id];
-
-  if (config) {
-    return Promise.resolve(config);
-  }
-
-  return Promise.resolve(this.resolver.resolveConfig(pkg, configName)).then((config) => {
-
-    if (!config) {
-      throw new Error(`unknown config <${name}>`);
-    }
-
-    const actualConfig = this.cachedConfigs[id] = this.normalizeConfig(config, pkg);
-
-    return actualConfig;
-  });
-};
-
-/**
- * Take a linter config and return list of resolved rules.
- *
- * @param { Config } config
- *
- * @return { Promise<ResolvedRuleDefinition[]> }
- */
-Linter.prototype.resolveRules = function(config) {
-
-  return this.resolveConfiguredRules(config).then((rulesConfig) => {
-
-    // parse rule values
-    const parsedRules = Object.entries(rulesConfig).map(([ name, value ]) => {
-      const {
-        category,
-        config
-      } = this.parseRuleValue(value);
-
-      return {
-        name,
-        category,
-        config
-      };
-    });
-
-    // filter only for enabled rules
-    const enabledRules = parsedRules.filter(definition => definition.category !== 'off');
-
-    // load enabled rules
-    const loaders = enabledRules.map((definition) => {
-
-      const {
-        name,
-        config
-      } = definition;
-
-      return this.resolveRule(name, config).then(function(rule) {
-        return {
-          ...definition,
-          rule
-        };
-      });
-    });
-
-    return Promise.all(loaders);
-  });
-};
-
-/**
- * @param { Config } config
- *
- * @return { Promise<RuleConfigs> }
- */
-Linter.prototype.resolveConfiguredRules = function(config) {
-
-  let parents = config.extends;
-
-  if (typeof parents === 'string') {
-    parents = [ parents ];
-  }
-
-  if (typeof parents === 'undefined') {
-    parents = [];
-  }
-
-  return Promise.all(
-    parents.map((configName) => {
-      return this.resolveConfig(configName).then((config) => {
-        return this.resolveConfiguredRules(config);
-      });
-    })
-  ).then((inheritedRules) => {
-
-    const overrideRules = this.normalizeConfig(config, 'bpmnlint').rules;
-
-    const rules = [ ...inheritedRules, overrideRules ].reduce((rules, currentRules) => {
-      return {
-        ...rules,
-        ...currentRules
-      };
-    }, {});
-
-    return rules;
-  });
-};
-
-
-/**
- * Lint the given model root, using the specified linter config.
- *
- * @param { ModdleElement } moddleRoot
- * @param { Config } [config] the bpmnlint configuration to use
- *
- * @return { Promise<LintResults> } lint results, keyed by rule names
- */
-Linter.prototype.lint = function(moddleRoot, config) {
-
-  config = config || this.config;
-
-  // load rules
-  return this.resolveRules(config).then((ruleDefinitions) => {
-
-    /**
-     * @type { LintResults }
-     */
-    const allReports = {};
-
-    ruleDefinitions.forEach((ruleDefinition) => {
-
-      const {
-        name
-      } = ruleDefinition;
-
-      const reports = this.applyRule(moddleRoot, ruleDefinition);
-
-      if (reports.length) {
-        allReports[name] = reports;
-      }
-    });
-
-    return allReports;
-  });
-};
-
-/**
- * @param { import('./types.js').RuleConfig } value
- *
- * @return { { config: any, category: ReportingCategory } }
- */
-Linter.prototype.parseRuleValue = function(value) {
-
-  let category;
-  let config;
-
-  if (Array.isArray(value)) {
-    category = value[0];
-    config = value[1];
-  } else {
-    category = value;
-    config = {};
-  }
-
-  // normalize rule flag to <error> and <warn> which
-  // may be upper case or a number at this point
-  if (typeof category === 'string') {
-    category = category.toLowerCase();
-  }
-
-  category = categoryMap[category] || category;
-
-  return {
-    config,
-    category
-  };
-};
-
-Linter.prototype.parseRuleName = function(name, localPackage = 'bpmnlint') {
-
-  /**
-   * We recognize the following rule name patterns:
-   *
-   * {RULE_NAME} => PKG = 'bpmnlint'
-   * bpmnlint/{RULE_NAME} => PKG = 'bpmnlint'
-   * {PACKAGE_SHORTCUT}/{RULE_NAME} => PKG = 'bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   * bpmnlint-plugin-{PACKAGE_SHORTCUT}/{RULE_NAME} => PKG = 'bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   * @scope/{PACKAGE_SHORTCUT}/{RULE_NAME} => PKG = '@scope/bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   * @scope/bpmnlint-plugin-{PACKAGE_SHORTCUT}/{RULE_NAME} => PKG = '@scope/bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   */
-
-  const match = /^(?:(?:(@[^/]+)\/)?([^@]{1}[^/]*)\/)?([^/]+)$/.exec(name);
-
-  if (!match) {
-    throw new Error(`unparseable rule name <${name}>`);
-  }
-
-  const [
-    _,
-    ns,
-    packageName,
-    ruleName
-  ] = match;
-
-  if (!packageName) {
-    return {
-      pkg: localPackage,
-      ruleName
-    };
-  }
-
-  const pkg = `${ns ? ns + '/' : '' }${prefixPackage(packageName)}`;
-
-  return {
-    pkg,
-    ruleName
-  };
-};
-
-
-Linter.prototype.parseConfigName = function(name) {
-
-  /**
-   * We recognize the following config name patterns:
-   *
-   * bpmnlint:{CONFIG_NAME} => PKG = 'bpmnlint'
-   * plugin:{PACKAGE_SHORTCUT}/{CONFIG_NAME} => PKG = 'bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   * plugin:bpmnlint-plugin-{PACKAGE_SHORTCUT}/{CONFIG_NAME} => PKG = 'bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   * plugin:@scope/{PACKAGE_SHORTCUT}/{CONFIG_NAME} => PKG = '@scope/bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   * plugin:@scope/bpmnlint-plugin-{PACKAGE_SHORTCUT}/{CONFIG_NAME} => PKG = '@scope/bpmnlint-plugin-{PACKAGE_SHORTCUT}'
-   */
-
-  const match = /^(?:(?:plugin:(?:(@[^/]+)\/)?([^@]{1}[^/]*)\/)|bpmnlint:)([^/]+)$/.exec(name);
-
-  if (!match) {
-    throw new Error(`unparseable config name <${name}>`);
-  }
-
-  const [
-    _,
-    ns,
-    packageName,
-    configName
-  ] = match;
-
-  if (!packageName) {
-    return {
-      pkg: 'bpmnlint',
-      configName
-    };
-  }
-
-  const pkg = `${ns ? ns + '/' : '' }${prefixPackage(packageName)}`;
-
-  return {
-    pkg,
-    configName
-  };
-};
-
-
-Linter.prototype.getSimplePackageName = function(name) {
-
-  /**
-   * We recognize the following package name patterns:
-   *
-   * bpmnlint => PKG = 'bpmnlint'
-   * {PACKAGE_SHORTCUT} => PKG = PACKAGE_SHORTCUT
-   * bpmnlint-plugin-{PACKAGE_SHORTCUT}' => PKG = PACKAGE_SHORTCUT
-   * @scope/{PACKAGE_SHORTCUT} => PKG = '@scope/{PACKAGE_SHORTCUT}'
-   * @scope/bpmnlint-plugin-{PACKAGE_SHORTCUT}' => PKG = '@scope/PACKAGE_SHORTCUT'
-   */
-
-  const match = /^(?:(@[^/]+)\/)?([^/]+)$/.exec(name);
-
-  if (!match) {
-    throw new Error(`unparseable package name <${name}>`);
-  }
-
-  const [
-    _,
-    ns,
-    packageName
-  ] = match;
-
-  return `${ns ? ns + '/' : '' }${unprefixPackage(packageName)}`;
-};
-
-
-/**
- * Validate and return validated config.
- *
- * @param  {Object} config
- * @param  {String} localPackage
- *
- * @return {Object} validated config
- */
-Linter.prototype.normalizeConfig = function(config, localPackage) {
-
-  const rules = config.rules || {};
-
-  const validatedRules = Object.keys(rules).reduce((normalizedRules, name) => {
-
-    const value = rules[name];
-
-    const {
-      pkg,
-      ruleName
-    } = this.parseRuleName(name, localPackage);
-
-    const normalizedName = (
-      pkg === 'bpmnlint'
-        ? ruleName
-        : `${this.getSimplePackageName(pkg)}/${ruleName}`
-    );
-
-    normalizedRules[normalizedName] = value;
-
-    return normalizedRules;
-  }, {});
-
-  return {
-    ...config,
-    rules: validatedRules
-  };
-};
-
-
-// helpers ///////////////////////////
-
-function prefixPackage(pkg) {
-
-  if (pkg === 'bpmnlint') {
-    return 'bpmnlint';
-  }
-
-  if (pkg.startsWith('bpmnlint-plugin-')) {
-    return pkg;
-  }
-
-  return `bpmnlint-plugin-${pkg}`;
-}
-
-
-function unprefixPackage(pkg) {
-
-  if (pkg.startsWith('bpmnlint-plugin-')) {
-    return pkg.substring('bpmnlint-plugin-'.length);
-  }
-
-  return pkg;
-}
+module.exports = createLinter(require('./product'));

package/lib/product.js

@@ -0,0 +1,6 @@
+/**
+ * @type { import('@bpmn-io/lint-core/lib/types').Product }
+ */
+module.exports = {
+  name: 'bpmnlint'
+};

package/lib/resolver/helper.js

@@ -1,12 +1 @@
-const Module = require('node:module');
-const path = require('node:path');
-
-/**
- * Create require function for a given path.
- *
- * @param {string} cwd
- * @returns {NodeRequire}
- */
-module.exports.createScopedRequire = function(cwd) {
-  return Module.createRequire(path.join(cwd, '__placeholder__.js'));
-};
+module.exports = require('@bpmn-io/lint-core/lib/resolver/helper');

package/lib/resolver/node-resolver.js

@@ -1,136 +1,7 @@
-const path = require('node:path');
-const { cwd } = require('node:process');
+const { createNodeResolver } = require('@bpmn-io/lint-core/lib/resolver/node-resolver');
 
-const { isString } = require('min-dash');
-
-/**
- * @typedef { import('../types.js').RuleFactory } RuleFactory
- * @typedef { import('../types.js').Config } Config
- */
-
-const { createScopedRequire } = require('./helper');
-
-/**
- * A resolver that locates rules and configurations
- * using node module resolution.
- *
- * @param { { require?: NodeRequire, requireLocal?: NodeRequire } } [options]
- */
-function NodeResolver(options) {
-  this.require = options && options.require || createScopedRequire(cwd());
-
-  this.requireLocal = options && options.requireLocal || require;
-
-  try {
-    this.pkg = this.require('./package.json').name;
-  } catch (err) {
-    this.pkg = '__unknown';
-  }
-}
-
-module.exports = NodeResolver;
-
-
-/**
- * @param { string } pkg
- * @param { string } ruleName
- *
- * @return { RuleFactory }
- */
-NodeResolver.prototype.resolveRule = function(pkg, ruleName) {
-
-  const originalPkg = pkg;
-
-  pkg = this.normalizePkg(pkg);
-
-  let pkgInstance;
-
-  // (1) try resolving rule via $PKG.rules[$NAME]
-  try {
-    pkgInstance = this.require(pkg);
-  } catch (err) {
-
-    /* ignore */
-  }
-
-  if (pkgInstance) {
-    const rules = pkgInstance.rules || {};
-
-    if (ruleName in rules) {
-      const rule = rules[ruleName];
-
-      if (!isString(rule)) {
-        throw new Error('cannot resolve rule <' + ruleName + '> from <' + originalPkg + '>: illegal rule export (expected path reference)');
-      }
-
-      // local reference, resolved relative to pkg location
-      if (rule.startsWith('.')) {
-        const pkgDir = path.dirname(this.require.resolve(pkg));
-
-        return this.require(path.posix.normalize(`${ pkgDir }/${ rule }`));
-      }
-
-      // absolute reference
-      return this.require(rule);
-    }
-  }
-
-  // (2) try resolving rule via $PKG/rules/$NAME
-  try {
-    if (pkg === 'bpmnlint') {
-      return this.requireLocal(`../../rules/${ruleName}`);
-    } else {
-      return this.require(`${pkg}/rules/${ruleName}`);
-    }
-  } catch (err) { /* ignore */ }
-
-  throw new Error('cannot resolve rule <' + ruleName + '> from <' + originalPkg + '>');
-};
-
-/**
- * @param { string } pkg
- * @param { string } configName
- *
- * @return { Config }
- */
-NodeResolver.prototype.resolveConfig = function(pkg, configName) {
-
-  const originalPkg = pkg;
-
-  pkg = this.normalizePkg(pkg);
-
-  // (1) try resolving config via $PKG.configs[$NAME]
-  try {
-    const instance = this.require(pkg);
-
-    const configs = instance.configs || {};
-
-    if (configName in configs) {
-      return configs[configName];
-    }
-  } catch (err) {
-
-    /* ignore */
-  }
-
-  // (2) try resolving config via $PKG/config/$NAME
-  try {
-    if (pkg === 'bpmnlint') {
-      return this.requireLocal(`../../config/${configName}`);
-    } else {
-      return this.require(`${pkg}/config/${configName}`);
-    }
-  } catch (err) { /* ignore */ }
-
-  throw new Error(
-    'cannot resolve config <' + configName + '> from <' + originalPkg + '>'
-  );
-};
-
-NodeResolver.prototype.normalizePkg = function(pkg) {
-  if (pkg !== 'bpmnlint' && pkg === this.pkg) {
-    pkg = '.';
-  }
-
-  return pkg;
-};
+// rules and configs of this package are resolved relative to this file,
+// i.e. via ../../rules/* and ../../config/*
+module.exports = createNodeResolver(require('../product'), {
+  requireLocal: require
+});