bpmnlint 10.0.0 → 10.1.0

package/config/all.js

@@ -9,8 +9,8 @@ const allRules = [
   'no-disconnected',
   'no-duplicate-sequence-flows',
   'no-gateway-join-fork',
-  'no-implicit-split',
   'no-implicit-end',
+  'no-implicit-split',
   'no-implicit-start',
   'no-inclusive-gateway',
   'no-overlapping-elements',
@@ -18,7 +18,8 @@ const allRules = [
   'single-event-definition',
   'start-event-required',
   'sub-process-blank-start-event',
-  'superfluous-gateway'
+  'superfluous-gateway',
+  'superfluous-termination'
 ];
 
 

package/config/recommended.js

@@ -19,6 +19,7 @@ module.exports = {
     'single-event-definition': 'error',
     'start-event-required': 'error',
     'sub-process-blank-start-event': 'error',
-    'superfluous-gateway': 'warn'
+    'superfluous-gateway': 'warn',
+    'superfluous-termination': 'warn'
   }
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bpmnlint",
   "description": "Validate your BPMN diagrams based on configurable lint rules",
-  "version": "10.0.0",
+  "version": "10.1.0",
   "main": "lib/index.js",
   "keywords": [
     "bpmnlint",

package/rules/superfluous-termination.js

@@ -0,0 +1,63 @@
+const {
+  is, isAny
+} = require('bpmnlint-utils');
+
+/**
+ * A rule that checks, whether a gateway has only one source and target.
+ *
+ * Those gateways are superfluous since they don't do anything.
+ */
+module.exports = function() {
+
+  function check(node, reporter) {
+
+    if (!isAny(node, [ 'bpmn:Process', 'bpmn:SubProcess' ])) {
+      return;
+    }
+
+    const flowElements = node.flowElements || [];
+
+    const ends = flowElements.filter(
+      element => is(element, 'bpmn:FlowNode') && (element.outgoing || []).length === 0
+    );
+
+    const terminateEnds = ends.filter(isTerminateEnd);
+
+    if (terminateEnds.length !== 1) {
+
+      // TODO(nikku): only detect basic cases, do not
+      // do any kinds of elaborate flow analysis
+      return;
+    }
+
+    const superfluous = ends.every(
+      (end) => isInterruptingEventSub(end) || isTerminateEnd(end)
+    );
+
+    if (superfluous) {
+
+      for (const node of terminateEnds) {
+        reporter.report(node.id, 'Termination is superfluous.');
+      }
+    }
+  }
+
+  return {
+    check
+  };
+
+};
+
+function isTerminateEnd(element) {
+  return is(element, 'bpmn:EndEvent') && (element.eventDefinitions || []).some(
+    eventDefinition => is(eventDefinition, 'bpmn:TerminateEventDefinition')
+  );
+}
+
+function isInterruptingEventSub(element) {
+  const isEventSub = is(element, 'bpmn:SubProcess') && element.triggeredByEvent;
+
+  return isEventSub && (element.flowElements || []).some(
+    element => is(element, 'bpmn:StartEvent') && element.isInterrupting
+  );
+}