bpmnlint-plugin-camunda-compat 2.7.0 → 2.8.0

package/index.js

@@ -35,7 +35,6 @@ const camundaCloud13Rules = withConfig(camundaCloud12Rules, { version: '1.3' });
 
 const camundaCloud80Rules = withConfig({
   ...omit(camundaCloud13Rules, 'no-template'),
-  'secrets': 'error'
 }, { version: '8.0' });
 
 const camundaCloud81Rules = withConfig({
@@ -58,8 +57,10 @@ const camundaCloud82Rules = withConfig({
 
 const camundaCloud83Rules = withConfig({
   ...omit(camundaCloud82Rules, [
-    'start-form'
+    'start-form',
+    'no-signal-event-sub-process'
   ]),
+  'secrets': 'warn',
   'signal-reference': 'error'
 }, { version: '8.3' });
 
@@ -155,10 +156,11 @@ module.exports = {
   rules
 };
 
-function withConfig(rules, config, type = 'error') {
+function withConfig(rules, config) {
   let rulesWithConfig = {};
 
   for (let name in rules) {
+    const type = Array.isArray(rules[ name ]) ? rules[ name ][0] : rules[ name ];
     rulesWithConfig[ name ] = [ type, config ];
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.7.0",
+  "version": "2.8.0",
   "description": "A bpmnlint plug-in for Camunda Platform compatibility",
   "main": "index.js",
   "scripts": {

package/rules/camunda-cloud/element-type/config.js

@@ -4,7 +4,8 @@ module.exports = {
     'bpmn:ErrorEventDefinition': '1.0',
     'bpmn:EscalationEventDefinition': '8.2',
     'bpmn:MessageEventDefinition': '1.0',
-    'bpmn:TimerEventDefinition': '1.0'
+    'bpmn:TimerEventDefinition': '1.0',
+    'bpmn:SignalEventDefinition': '8.3',
   },
   'bpmn:BusinessRuleTask': '1.1',
   'bpmn:CallActivity': '1.0',
@@ -28,7 +29,8 @@ module.exports = {
   'bpmn:IntermediateCatchEvent': {
     'bpmn:MessageEventDefinition': '1.0',
     'bpmn:LinkEventDefinition': '8.2',
-    'bpmn:TimerEventDefinition': '1.0'
+    'bpmn:TimerEventDefinition': '1.0',
+    'bpmn:SignalEventDefinition': '8.3'
   },
   'bpmn:IntermediateThrowEvent': {
     '_': '1.1',

package/rules/camunda-cloud/no-signal-event-sub-process.js

@@ -31,7 +31,8 @@ module.exports = skipInNonExecutableProcess(function() {
           node,
           parentNode: null,
           eventDefinition,
-          parent
+          parent,
+          allowedVersion: '8.3'
         }
       };
 

package/rules/camunda-cloud/secrets.js

@@ -98,12 +98,12 @@ function getReport(propertyName, node, parentNode) {
   const path = getPath(node, parentNode);
 
   return {
-    message: `Property <${ propertyName }> is not a valid secret`,
+    message: `Property <${ propertyName }> uses deprecated secret expression format`,
     path: path
       ? [ ...getPath(node, parentNode), propertyName ]
       : [ propertyName ],
     data: {
-      type: ERROR_TYPES.SECRET_EXPRESSION_INVALID,
+      type: ERROR_TYPES.SECRET_EXPRESSION_FORMAT_DEPRECATED,
       node,
       parentNode: parentNode,
       property: propertyName

package/rules/utils/error-types.js

@@ -20,5 +20,5 @@ module.exports.ERROR_TYPES = Object.freeze({
   PROPERTY_VALUE_DUPLICATED: 'camunda.propertyValueDuplicated',
   PROPERTY_VALUE_NOT_ALLOWED: 'camunda.propertyValueNotAllowed',
   PROPERTY_VALUE_REQUIRED: 'camunda.propertyValueRequired',
-  SECRET_EXPRESSION_INVALID: 'camunda.secretExpressionInvalid'
+  SECRET_EXPRESSION_FORMAT_DEPRECATED: 'camunda.secretExpressionFormatDeprecated'
 });