bpmnlint-plugin-camunda-compat 2.57.0 → 2.58.0

package/index.js

@@ -13,6 +13,7 @@ const camundaCloud10Rules = withConfig({
   'message-reference': 'error',
   'io-mapping': 'error',
   'no-binding-type': 'error',
+  'no-business-id': 'error',
   'no-candidate-users': 'error',
   'no-cancel-execution-listener': 'error',
   'no-execution-listener-headers': 'error',
@@ -124,6 +125,7 @@ const camundaCloud89Rules = withConfig({
 
 const camundaCloud810Rules = withConfig({
   ...omit(camundaCloud89Rules, [
+    'no-business-id',
     'no-execution-listener-headers',
     'no-before-all-execution-listener',
     'no-cancel-execution-listener',
@@ -200,6 +202,7 @@ const rules = {
   'io-mapping': './rules/camunda-cloud/io-mapping',
   'message-reference': './rules/camunda-cloud/message-reference',
   'no-binding-type': './rules/camunda-cloud/no-binding-type',
+  'no-business-id': './rules/camunda-cloud/no-business-id',
   'no-before-all-execution-listener': './rules/camunda-cloud/no-before-all-execution-listener',
   'no-candidate-users': './rules/camunda-cloud/no-candidate-users',
   'no-cancel-execution-listener': './rules/camunda-cloud/no-cancel-execution-listener',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.57.0",
+  "version": "2.58.0",
   "description": "A bpmnlint plug-in for Camunda compatibility",
   "main": "index.js",
   "scripts": {
@@ -34,7 +34,7 @@
     "modeler-moddle": "^0.2.0",
     "sinon": "^21.0.1",
     "sinon-chai": "^4.0.1",
-    "zeebe-bpmn-moddle": "^1.15.0"
+    "zeebe-bpmn-moddle": "^1.17.0"
   },
   "dependencies": {
     "@bpmn-io/feel-analyzer": "^0.3.0",

package/rules/camunda-cloud/called-element.js

@@ -12,7 +12,13 @@ const { reportErrors } = require('../utils/reporter');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
 
-module.exports = skipInNonExecutableProcess(function() {
+const { greaterOrEqual } = require('../utils/version');
+
+const BUSINESS_ID_ALLOWED_VERSION = '8.10';
+
+const MAX_BUSINESS_ID_LENGTH = 256;
+
+module.exports = skipInNonExecutableProcess(function({ version }) {
   function check(node, reporter) {
     if (!is(node, 'bpmn:CallActivity')) {
       return;
@@ -31,6 +37,9 @@ module.exports = skipInNonExecutableProcess(function() {
     errors = hasProperties(calledElement, {
       processId: {
         required: true
+      },
+      businessId: {
+        allowed: (value) => isValidBusinessId(value, version)
       }
     }, node);
 
@@ -42,4 +51,22 @@ module.exports = skipInNonExecutableProcess(function() {
   return annotateRule('called-element', {
     check
   });
-});
+});
+
+
+// helpers //////////
+
+// Business ID is not supported before BUSINESS_ID_ALLOWED_VERSION; the
+// `no-business-id` rule flags its presence in that range, so it is treated
+// as valid here to avoid reporting the same value twice.
+function isValidBusinessId(value, version) {
+  if (!value || value.startsWith('=')) {
+    return true;
+  }
+
+  if (!greaterOrEqual(version, BUSINESS_ID_ALLOWED_VERSION)) {
+    return true;
+  }
+
+  return value.length < MAX_BUSINESS_ID_LENGTH;
+}

package/rules/camunda-cloud/no-business-id.js

@@ -0,0 +1,38 @@
+const { is } = require('bpmnlint-utils');
+
+const { hasProperties, findExtensionElement } = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+const ALLOWED_VERSION = '8.10';
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:CallActivity')) {
+      return;
+    }
+
+    const calledElement = findExtensionElement(node, 'zeebe:CalledElement');
+
+    if (!calledElement) {
+      return;
+    }
+
+    const errors = hasProperties(calledElement, {
+      businessId: {
+        allowed: false,
+        allowedVersion: ALLOWED_VERSION
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
+});