bpmnlint-plugin-camunda-compat 2.50.0 → 2.52.0

package/index.js

@@ -14,6 +14,7 @@ const camundaCloud10Rules = withConfig({
   'io-mapping': 'error',
   'no-binding-type': 'error',
   'no-candidate-users': 'error',
+  'no-cancel-execution-listener': 'error',
   'no-execution-listener-headers': 'error',
   'no-execution-listeners': 'error',
   'no-expression': 'error',
@@ -112,15 +113,18 @@ const camundaCloud88Rules = withConfig({
 }, { version: '8.8' });
 
 const camundaCloud89Rules = withConfig({
-  ...camundaCloud88Rules
+  ...camundaCloud88Rules,
+  'start-event-form-embedded': 'warn'
 }, { version: '8.9' });
 
 const camundaCloud810Rules = withConfig({
   ...omit(camundaCloud89Rules, [
     'no-execution-listener-headers',
     'no-before-all-execution-listener',
+    'no-cancel-execution-listener'
   ]),
   'before-all-execution-listener': 'error',
+  'cancel-execution-listener': 'error',
   'duplicate-execution-listener-headers': 'error'
 }, { version: '8.10' });
 
@@ -164,6 +168,7 @@ const rules = {
   'ad-hoc-sub-process': './rules/camunda-cloud/ad-hoc-sub-process',
   'before-all-execution-listener': './rules/camunda-cloud/before-all-execution-listener',
   'element-type': './rules/camunda-cloud/element-type',
+  'cancel-execution-listener': './rules/camunda-cloud/cancel-execution-listener',
   'called-element': './rules/camunda-cloud/called-element',
   'collapsed-subprocess': './rules/camunda-cloud/collapsed-subprocess',
   'connector-properties': './rules/camunda-cloud/connector-properties',
@@ -187,6 +192,7 @@ const rules = {
   'no-binding-type': './rules/camunda-cloud/no-binding-type',
   'no-before-all-execution-listener': './rules/camunda-cloud/no-before-all-execution-listener',
   'no-candidate-users': './rules/camunda-cloud/no-candidate-users',
+  'no-cancel-execution-listener': './rules/camunda-cloud/no-cancel-execution-listener',
   'no-execution-listener-headers': './rules/camunda-cloud/no-execution-listener-headers',
   'no-execution-listeners': './rules/camunda-cloud/no-execution-listeners',
   'no-expression': './rules/camunda-cloud/no-expression',
@@ -208,6 +214,7 @@ const rules = {
   'sequence-flow-condition': './rules/camunda-cloud/sequence-flow-condition',
   'signal-reference': './rules/camunda-cloud/signal-reference',
   'start-event-form': './rules/camunda-cloud/start-event-form',
+  'start-event-form-embedded': './rules/camunda-cloud/start-event-form-embedded',
   'subscription': './rules/camunda-cloud/subscription',
   'task-listener': './rules/camunda-cloud/task-listener',
   'task-schedule': './rules/camunda-cloud/task-schedule',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.50.0",
+  "version": "2.52.0",
   "description": "A bpmnlint plug-in for Camunda compatibility",
   "main": "index.js",
   "scripts": {

package/rules/camunda-cloud/cancel-execution-listener.js

@@ -0,0 +1,40 @@
+const { isAny } = require('bpmnlint-utils');
+
+const {
+  findExtensionElement,
+  hasProperties
+} = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (isAny(node, [ 'bpmn:Process', 'bpmn:Participant' ])) {
+      return;
+    }
+
+    const executionListeners = findExtensionElement(node, 'zeebe:ExecutionListeners');
+
+    if (!executionListeners) {
+      return;
+    }
+
+    const listeners = executionListeners.get('listeners');
+
+    const errors = listeners.flatMap(listener => hasProperties(listener, {
+      eventType: {
+        allowed: (value) => value !== 'cancel'
+      }
+    }, node));
+
+    if (errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
+});

package/rules/camunda-cloud/no-cancel-execution-listener.js

@@ -0,0 +1,37 @@
+const {
+  findExtensionElement,
+  hasProperties
+} = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+const ALLOWED_VERSION = '8.10';
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    const executionListeners = findExtensionElement(node, 'zeebe:ExecutionListeners');
+
+    if (!executionListeners) {
+      return;
+    }
+
+    const listeners = executionListeners.get('listeners');
+
+    const errors = listeners.flatMap(listener => hasProperties(listener, {
+      eventType: {
+        allowed: (value) => value !== 'cancel',
+        allowedVersion: ALLOWED_VERSION
+      }
+    }, node));
+
+    if (errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
+});

package/rules/camunda-cloud/start-event-form-embedded.js

@@ -0,0 +1,50 @@
+const { is } = require('bpmnlint-utils');
+
+const { findExtensionElement } = require('../utils/element');
+
+const { getPath } = require('@bpmn-io/moddle-utils');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+const { ERROR_TYPES } = require('../utils/error-types');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!node || !is(node, 'bpmn:StartEvent')) {
+      return;
+    }
+
+    const formDefinition = findExtensionElement(node, 'zeebe:FormDefinition');
+
+    if (!formDefinition) {
+      return;
+    }
+
+    const formKey = formDefinition.get('formKey');
+
+    if (!formKey || !formKey.startsWith('camunda-forms:bpmn:')) {
+      return;
+    }
+
+    const errors = [
+      {
+        message: 'Embedded forms on start events are deprecated; use a linked form instead',
+        path: getPath(formDefinition, node),
+        data: {
+          type: ERROR_TYPES.PROPERTY_DEPRECATED,
+          node: formDefinition,
+          parentNode: node,
+          property: 'formKey'
+        }
+      }
+    ];
+
+    reportErrors(node, reporter, errors);
+  }
+
+  return {
+    check
+  };
+});

package/rules/utils/error-types.js

@@ -17,6 +17,7 @@ module.exports.ERROR_TYPES = Object.freeze({
   ATTACHED_TO_REF_ELEMENT_TYPE_NOT_ALLOWED: 'camunda.attachedToRefElementTypeNotAllowed',
   PROPERTY_DEPENDENT_REQUIRED: 'camunda.propertyDependentRequired',
   PROPERTY_NOT_ALLOWED: 'camunda.propertyNotAllowed',
+  PROPERTY_DEPRECATED: 'camunda.propertyDeprecated',
   PROPERTY_REQUIRED: 'camunda.propertyRequired',
   PROPERTY_TYPE_NOT_ALLOWED: 'camunda.propertyTypeNotAllowed',
   PROPERTY_VALUE_DUPLICATED: 'camunda.propertyValueDuplicated',