bpmnlint-plugin-camunda-compat 2.37.0 → 2.38.0

package/index.js

@@ -11,6 +11,7 @@ const camundaCloud10Rules = withConfig({
   'executable-process': 'error',
   'loop-characteristics': 'error',
   'message-reference': 'error',
+  'io-mapping': 'error',
   'no-binding-type': 'error',
   'no-candidate-users': 'error',
   'no-execution-listeners': 'error',
@@ -157,6 +158,7 @@ const rules = {
   'inclusive-gateway': './rules/camunda-cloud/inclusive-gateway',
   'link-event': './rules/camunda-cloud/link-event',
   'loop-characteristics': './rules/camunda-cloud/loop-characteristics',
+  'io-mapping': './rules/camunda-cloud/io-mapping',
   'message-reference': './rules/camunda-cloud/message-reference',
   'no-binding-type': './rules/camunda-cloud/no-binding-type',
   'no-candidate-users': './rules/camunda-cloud/no-candidate-users',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.37.0",
+  "version": "2.38.0",
   "description": "A bpmnlint plug-in for Camunda compatibility",
   "main": "index.js",
   "scripts": {
@@ -37,8 +37,9 @@
     "zeebe-bpmn-moddle": "^1.9.0"
   },
   "dependencies": {
-    "@bpmn-io/feel-lint": "^1.4.0",
+    "@bpmn-io/feel-lint": "^2.0.0",
     "@bpmn-io/moddle-utils": "^0.2.1",
+    "@camunda/feel-builtins": "^0.2.0",
     "bpmnlint-utils": "^1.1.1",
     "min-dash": "^4.1.1",
     "semver-compare": "^1.0.0"

package/rules/camunda-cloud/feel.js

@@ -15,6 +15,7 @@ const { ERROR_TYPES } = require('../utils/error-types');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
 const { annotateRule } = require('../helper');
+const { camundaBuiltins } = require('@camunda/feel-builtins');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {
@@ -37,7 +38,8 @@ module.exports = skipInNonExecutableProcess(function() {
 
       if (isFeelProperty([ propertyName, propertyValue ])) {
         const lintErrors = lintExpression(propertyValue.substring(1), {
-          parserDialect: 'camunda'
+          parserDialect: 'camunda',
+          builtins: camundaBuiltins
         });
 
         // syntax error

package/rules/camunda-cloud/io-mapping.js

@@ -0,0 +1,45 @@
+const { findExtensionElement, hasProperties } = require('../utils/element');
+const { reportErrors } = require('../utils/reporter');
+const { skipInNonExecutableProcess } = require('../utils/rule');
+const { greaterOrEqual } = require('../utils/version');
+
+const ALLOWED_VERSION_NO_INPUT_SOURCE = '8.7';
+
+module.exports = skipInNonExecutableProcess(function({ version }) {
+  function check(node, reporter) {
+    const ioMapping = findExtensionElement(node, 'zeebe:IoMapping');
+
+    if (!ioMapping) {
+      return [];
+    }
+
+    const errors = [];
+
+    const inputParameters = ioMapping.get('inputParameters');
+    errors.push(...inputParameters.flatMap((parameter) => hasProperties(parameter, {
+      source: {
+        required: !greaterOrEqual(version, ALLOWED_VERSION_NO_INPUT_SOURCE),
+        allowedVersion: ALLOWED_VERSION_NO_INPUT_SOURCE
+      },
+      target: {
+        required: true
+      }
+    }, node)));
+
+    const outputParameters = ioMapping.get('outputParameters');
+    errors.push(...outputParameters.flatMap((parameter) => hasProperties(parameter, {
+      source: {
+        required: true
+      },
+      target: {
+        required: true
+      }
+    }, node)));
+
+    if (errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+
+  }
+  return { check };
+});

package/rules/camunda-cloud/no-loop.js

@@ -13,6 +13,7 @@ const { reportErrors } = require('../utils/reporter');
 const { ERROR_TYPES } = require('../utils/error-types');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
+const { annotateRule } = require('../helper');
 
 /**
  * @typedef {import('bpmn-moddle').BaseElement} ModdleElement
@@ -61,9 +62,9 @@ module.exports = skipInNonExecutableProcess(function() {
     }
   }
 
-  return {
+  return annotateRule('no-loop', {
     check
-  };
+  });
 });
 
 /**

package/rules/helper.js

@@ -1,4 +1,4 @@
-const modelingGuidanceBaseUrl = 'https://docs.camunda.io/docs/next/components/modeler/reference/modeling-guidance/rules';
+const modelingGuidanceBaseUrl = 'https://docs.camunda.io/docs/components/modeler/reference/modeling-guidance/rules';
 
 /**
  * @typedef { any } RuleDefinition