bpmnlint-plugin-camunda-compat 2.31.0 → 2.33.0

package/index.js

@@ -96,7 +96,8 @@ const camundaCloud86Rules = withConfig({
 }, { version: '8.6' });
 
 const camundaCloud87Rules = withConfig({
-  ...camundaCloud86Rules
+  ...camundaCloud86Rules,
+  'ad-hoc-sub-process': 'error',
 }, { version: '8.7' });
 
 const camundaCloud88Rules = withConfig({
@@ -132,6 +133,7 @@ const camundaPlatform723Rules = withConfig(camundaPlatform721Rules, {
 });
 
 const rules = {
+  'ad-hoc-sub-process': './rules/camunda-cloud/ad-hoc-sub-process',
   'element-type': './rules/camunda-cloud/element-type',
   'called-element': './rules/camunda-cloud/called-element',
   'collapsed-subprocess': './rules/camunda-cloud/collapsed-subprocess',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.31.0",
+  "version": "2.33.0",
   "description": "A bpmnlint plug-in for Camunda compatibility",
   "main": "index.js",
   "scripts": {
@@ -24,12 +24,12 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "bpmn-moddle": "^8.1.0",
-    "bpmnlint": "^10.2.0",
+    "bpmn-moddle": "^9.0.1",
+    "bpmnlint": "^11.2.0",
     "camunda-bpmn-moddle": "^7.0.1",
     "chai": "^4.4.1",
-    "eslint": "^8.56.0",
-    "eslint-plugin-bpmn-io": "^1.0.0",
+    "eslint": "^9.20.1",
+    "eslint-plugin-bpmn-io": "^2.2.0",
     "mocha": "^10.2.0",
     "modeler-moddle": "^0.2.0",
     "sinon": "^17.0.1",
@@ -37,9 +37,9 @@
     "zeebe-bpmn-moddle": "^1.9.0"
   },
   "dependencies": {
-    "@bpmn-io/feel-lint": "^1.2.0",
+    "@bpmn-io/feel-lint": "^1.4.0",
     "@bpmn-io/moddle-utils": "^0.2.1",
-    "bpmnlint-utils": "^1.0.2",
+    "bpmnlint-utils": "^1.1.1",
     "min-dash": "^4.1.1",
     "semver-compare": "^1.0.0"
   },
@@ -48,6 +48,6 @@
     "index.js"
   ],
   "engines": {
-    "node": "*"
+    "node": ">= 20"
   }
 }

package/rules/camunda-cloud/ad-hoc-sub-process.js

@@ -0,0 +1,34 @@
+const { is, isAny } = require('bpmnlint-utils');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:AdHocSubProcess')) {
+      return;
+    }
+
+    // Ad-Hoc Sub-Process must contain at least one activity
+    if (node.get('flowElements').some(isActivity)) {
+      return;
+    }
+
+    reportErrors(node, reporter, {
+      message: 'Element of type <bpmn:AdHocSubProcess> must contain at least one activity',
+      data: {
+        node,
+        parentNode: null
+      }
+    });
+  }
+
+  return {
+    check
+  };
+});
+
+function isActivity(element) {
+  return isAny(element, [ 'bpmn:Task', 'bpmn:SubProcess' ]);
+}

package/rules/camunda-cloud/called-element.js

@@ -6,6 +6,8 @@ const {
   hasProperties
 } = require('../utils/element');
 
+const { annotateRule } = require('../helper');
+
 const { reportErrors } = require('../utils/reporter');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
@@ -37,7 +39,7 @@ module.exports = skipInNonExecutableProcess(function() {
     }
   }
 
-  return {
+  return annotateRule('called-element', {
     check
-  };
+  });
 });

package/rules/camunda-cloud/element-type/index.js

@@ -14,6 +14,8 @@ const { reportErrors } = require('../../utils/reporter');
 
 const { skipInNonExecutableProcess } = require('../../utils/rule');
 
+const { annotateRule } = require('../../helper');
+
 module.exports = skipInNonExecutableProcess(function({ version }) {
   function check(node, reporter) {
     if (!isAny(node, [ 'bpmn:FlowElement', 'bpmn:FlowElementsContainer' ])) {
@@ -128,7 +130,7 @@ module.exports = skipInNonExecutableProcess(function({ version }) {
     }
   }
 
-  return {
+  return annotateRule('element-type', {
     check
-  };
+  });
 });

package/rules/camunda-cloud/error-reference.js

@@ -13,6 +13,7 @@ const { reportErrors } = require('../utils/reporter');
 const { skipInNonExecutableProcess } = require('../utils/rule');
 
 const { greaterOrEqual } = require('../utils/version');
+const { annotateRule } = require('../helper');
 
 const noErrorRefAllowedVersion = '8.2';
 
@@ -62,9 +63,9 @@ module.exports = skipInNonExecutableProcess(function({ version }) {
     }
   }
 
-  return {
+  return annotateRule('error-reference', {
     check
-  };
+  });
 });
 
 function isNoErrorRefAllowed(node, version) {

package/rules/camunda-cloud/escalation-reference.js

@@ -11,6 +11,7 @@ const {
 const { reportErrors } = require('../utils/reporter');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
+const { annotateRule } = require('../helper');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {
@@ -57,9 +58,9 @@ module.exports = skipInNonExecutableProcess(function() {
     }
   }
 
-  return {
+  return annotateRule('escalation-reference', {
     check
-  };
+  });
 });
 
 function isNoEscalationRefAllowed(node) {

package/rules/camunda-cloud/feel.js

@@ -14,6 +14,7 @@ const { reportErrors } = require('../utils/reporter');
 const { ERROR_TYPES } = require('../utils/error-types');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
+const { annotateRule } = require('../helper');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {
@@ -64,9 +65,9 @@ module.exports = skipInNonExecutableProcess(function() {
     }
   }
 
-  return {
+  return annotateRule('feel', {
     check
-  };
+  });
 });
 
 const isFeelProperty = ([ propertyName, value ]) => {

package/rules/camunda-cloud/message-reference.js

@@ -11,6 +11,7 @@ const {
 const { reportErrors } = require('../utils/reporter');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
+const { annotateRule } = require('../helper');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {
@@ -55,7 +56,7 @@ module.exports = skipInNonExecutableProcess(function() {
     }
   }
 
-  return {
+  return annotateRule('message-reference', {
     check
-  };
+  });
 });

package/rules/camunda-cloud/zeebe-user-task.js

@@ -20,6 +20,11 @@ module.exports = skipInNonExecutableProcess(function() {
   }
 
   return {
+    meta: {
+      documentation: {
+        url: 'https://docs.camunda.io/docs/next/apis-tools/migration-manuals/migrate-to-zeebe-user-tasks'
+      }
+    },
     check
   };
 });

package/rules/camunda-platform/history-time-to-live.js

@@ -1,5 +1,7 @@
 const { is } = require('bpmnlint-utils');
 
+const { annotateRule } = require('../helper');
+
 const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
@@ -14,7 +16,7 @@ module.exports = skipInNonExecutableProcess(function() {
     }
   }
 
-  return {
+  return annotateRule('history-time-to-live', {
     check
-  };
+  });
 });

package/rules/helper.js

@@ -0,0 +1,39 @@
+const modelingGuidanceBaseUrl = 'https://docs.camunda.io/docs/next/components/modeler/reference/modeling-guidance/rules';
+
+/**
+ * @typedef { any } RuleDefinition
+ */
+
+/**
+ * Annotate a rule with core information, such as the documentation url.
+ *
+ * @param { string } ruleName
+ * @param { RuleDefinition } options
+ *
+ * @return { RuleDefinition }
+ */
+function annotateRule(ruleName, options) {
+
+  const {
+    meta: {
+      documentation = {},
+      ...restMeta
+    } = {},
+    ...restOptions
+  } = options;
+
+  const documentationUrl = `${modelingGuidanceBaseUrl}/${ruleName}.md`;
+
+  return {
+    meta: {
+      documentation: {
+        url: documentationUrl,
+        ...documentation
+      },
+      ...restMeta
+    },
+    ...restOptions
+  };
+}
+
+module.exports.annotateRule = annotateRule;