bpmnlint-plugin-camunda-compat 2.27.0 → 2.28.1

package/index.js

@@ -19,6 +19,7 @@ const camundaCloud10Rules = withConfig({
   'no-multiple-none-start-events': 'error',
   'no-priority-definition': 'error',
   'no-propagate-all-parent-variables': 'error',
+  'no-task-listeners': 'error',
   'no-task-schedule': 'error',
   'no-template': 'error',
   'no-version-tag': 'error',
@@ -94,8 +95,8 @@ const camundaCloud86Rules = withConfig({
 }, { version: '8.6' });
 
 const camundaCloud87Rules = withConfig({
-  ...camundaCloud86Rules,
-  'zeebe-user-task': 'error'
+  ...omit(camundaCloud86Rules, [ 'no-task-listeners' ]),
+  'task-listener': 'error'
 }, { version: '8.7' });
 
 const camundaPlatform719Rules = withConfig({
@@ -155,6 +156,7 @@ const rules = {
   'no-propagate-all-parent-variables': './rules/camunda-cloud/no-propagate-all-parent-variables',
   'no-signal-event-sub-process': './rules/camunda-cloud/no-signal-event-sub-process',
   'no-task-schedule': './rules/camunda-cloud/no-task-schedule',
+  'no-task-listeners': './rules/camunda-cloud/no-task-listeners',
   'no-template': './rules/camunda-cloud/no-template',
   'no-version-tag': './rules/camunda-cloud/no-version-tag',
   'no-zeebe-properties': './rules/camunda-cloud/no-zeebe-properties',
@@ -165,13 +167,13 @@ const rules = {
   'signal-reference': './rules/camunda-cloud/signal-reference',
   'start-event-form': './rules/camunda-cloud/start-event-form',
   'subscription': './rules/camunda-cloud/subscription',
+  'task-listener': './rules/camunda-cloud/task-listener',
   'task-schedule': './rules/camunda-cloud/task-schedule',
   'timer': './rules/camunda-cloud/timer',
   'user-task-definition': './rules/camunda-cloud/user-task-definition',
   'user-task-form': './rules/camunda-cloud/user-task-form',
   'version-tag': './rules/camunda-cloud/version-tag',
-  'wait-for-completion': './rules/camunda-cloud/wait-for-completion',
-  'zeebe-user-task': './rules/camunda-cloud/zeebe-user-task'
+  'wait-for-completion': './rules/camunda-cloud/wait-for-completion'
 };
 
 const configs = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.27.0",
+  "version": "2.28.1",
   "description": "A bpmnlint plug-in for Camunda compatibility",
   "main": "index.js",
   "scripts": {
@@ -34,7 +34,7 @@
     "modeler-moddle": "^0.2.0",
     "sinon": "^17.0.1",
     "sinon-chai": "^3.7.0",
-    "zeebe-bpmn-moddle": "^1.6.0"
+    "zeebe-bpmn-moddle": "^1.7.0"
   },
   "dependencies": {
     "@bpmn-io/feel-lint": "^1.2.0",

package/rules/camunda-cloud/{zeebe-user-task.js → no-task-listeners.js}

@@ -1,18 +1,14 @@
-const { is } = require('bpmnlint-utils');
-
 const { reportErrors } = require('../utils/reporter');
 
 const { skipInNonExecutableProcess } = require('../utils/rule');
 
-const { hasExtensionElement } = require('../utils/element');
+const { hasNoExtensionElement } = require('../utils/element');
+
+const ALLOWED_VERSION = '8.7';
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {
-    if (!is(node, 'bpmn:UserTask')) {
-      return;
-    }
-
-    const errors = hasExtensionElement(node, 'zeebe:UserTask', node);
+    const errors = hasNoExtensionElement(node, 'zeebe:TaskListeners', node, ALLOWED_VERSION);
 
     if (errors && errors.length) {
       reportErrors(node, reporter, errors);

package/rules/camunda-cloud/task-listener.js

@@ -0,0 +1,40 @@
+const { is } = require('bpmnlint-utils');
+
+const {
+  findExtensionElement,
+  hasProperties
+} = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:UserTask')) {
+      return;
+    }
+
+    const taskListeners = findExtensionElement(node, 'zeebe:TaskListeners');
+
+    if (!taskListeners) {
+      return;
+    }
+
+    const listeners = taskListeners.get('listeners');
+    const errors = listeners.flatMap(listener => hasProperties(listener, {
+      type: {
+        required: true
+      }
+    }, node));
+
+    if (errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
+});