bpmnlint-plugin-camunda-compat 2.21.1 → 2.23.0

package/rules/camunda-cloud/link-event.js

@@ -1,143 +1,143 @@
-const { getPath } = require('@bpmn-io/moddle-utils');
-
-const {
-  is,
-  isAny
-} = require('bpmnlint-utils');
-
-const {
-  getEventDefinition,
-  hasProperties
-} = require('../utils/element');
-
-const { ERROR_TYPES } = require('../utils/error-types');
-
-const { reportErrors } = require('../utils/reporter');
-
-const { skipInNonExecutableProcess } = require('../utils/rule');
-
-module.exports = skipInNonExecutableProcess(function() {
-  function check(node, reporter) {
-
-    // check for duplicate link catch event names
-    if (is(node, 'bpmn:Process')) {
-      const linkCatchEvents = getLinkCatchEvents(node);
-
-      const { duplicateNames } = linkCatchEvents.reduce(({ duplicateNames, names }, linkCatchEvent, index) => {
-        const linkEventDefinition = getEventDefinition(linkCatchEvent, 'bpmn:LinkEventDefinition');
-
-        const name = linkEventDefinition.get('name');
-
-        names = [
-          ...names,
-          name
-        ];
-
-        if (!name) {
-          return {
-            duplicateNames,
-            names
-          };
-        }
-
-        if (names.indexOf(name) !== index && !duplicateNames.includes(name)) {
-          duplicateNames = [
-            ...duplicateNames,
-            name
-          ];
-        }
-
-        return {
-          duplicateNames,
-          names
-        };
-      }, {
-        duplicateNames: [],
-        names: []
-      });
-
-      duplicateNames.forEach((name) => {
-        const duplicates = linkCatchEvents
-          .filter(linkCatchEvent => {
-            const linkEventDefinition = getEventDefinition(linkCatchEvent, 'bpmn:LinkEventDefinition');
-
-            return linkEventDefinition.get('name') === name;
-          });
-
-        duplicates
-          .forEach(linkCatchEvent => {
-            const linkEventDefinition = getEventDefinition(linkCatchEvent, 'bpmn:LinkEventDefinition');
-
-            const path = getPath(linkEventDefinition, linkCatchEvent);
-
-            reportErrors(linkCatchEvent, reporter, {
-              message: `Property of type <bpmn:LinkEventDefinition> has property <name> with duplicate value of <${ name }>`,
-              path: path
-                ? [ ...path, 'name' ]
-                : [ 'name' ],
-              data: {
-                type: ERROR_TYPES.ELEMENT_PROPERTY_VALUE_DUPLICATED,
-                node: linkEventDefinition,
-                parentNode: linkCatchEvent,
-                duplicatedProperty: 'name',
-                duplicatedPropertyValue: name
-              }
-            });
-          });
-      });
-    }
-
-    // check for missing link catch & throw event names
-    if (isLinkEvent(node)) {
-      const linkEventDefinition = getEventDefinition(node);
-
-      const errors = hasProperties(linkEventDefinition, {
-        name: {
-          required: true
-        }
-      }, node);
-
-      if (errors.length) {
-        reportErrors(node, reporter, errors);
-      }
-    }
-  }
-
-  return {
-    check
-  };
-});
-
-function isLinkEvent(element) {
-  const eventDefinition = getEventDefinition(element);
-
-  return isAny(element, [
-    'bpmn:IntermediateCatchEvent',
-    'bpmn:IntermediateThrowEvent'
-  ]) && eventDefinition && is(eventDefinition, 'bpmn:LinkEventDefinition');
-}
-
-function isLinkCatchEvent(element) {
-  const eventDefinition = getEventDefinition(element);
-
-  return is(element, 'bpmn:IntermediateCatchEvent')
-    && eventDefinition && is(eventDefinition, 'bpmn:LinkEventDefinition');
-}
-
-function getLinkCatchEvents(flowElementsContainer) {
-  return flowElementsContainer.get('flowElements').reduce((linkCatchEvents, flowElement) => {
-    if (isLinkCatchEvent(flowElement)) {
-      return [
-        ...linkCatchEvents,
-        flowElement
-      ];
-    } else if (is(flowElement, 'bpmn:SubProcess')) {
-      return [
-        ...linkCatchEvents,
-        ...getLinkCatchEvents(flowElement)
-      ];
-    }
-
-    return linkCatchEvents;
-  }, []);
+const { getPath } = require('@bpmn-io/moddle-utils');
+
+const {
+  is,
+  isAny
+} = require('bpmnlint-utils');
+
+const {
+  getEventDefinition,
+  hasProperties
+} = require('../utils/element');
+
+const { ERROR_TYPES } = require('../utils/error-types');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+
+    // check for duplicate link catch event names
+    if (is(node, 'bpmn:Process')) {
+      const linkCatchEvents = getLinkCatchEvents(node);
+
+      const { duplicateNames } = linkCatchEvents.reduce(({ duplicateNames, names }, linkCatchEvent, index) => {
+        const linkEventDefinition = getEventDefinition(linkCatchEvent, 'bpmn:LinkEventDefinition');
+
+        const name = linkEventDefinition.get('name');
+
+        names = [
+          ...names,
+          name
+        ];
+
+        if (!name) {
+          return {
+            duplicateNames,
+            names
+          };
+        }
+
+        if (names.indexOf(name) !== index && !duplicateNames.includes(name)) {
+          duplicateNames = [
+            ...duplicateNames,
+            name
+          ];
+        }
+
+        return {
+          duplicateNames,
+          names
+        };
+      }, {
+        duplicateNames: [],
+        names: []
+      });
+
+      duplicateNames.forEach((name) => {
+        const duplicates = linkCatchEvents
+          .filter(linkCatchEvent => {
+            const linkEventDefinition = getEventDefinition(linkCatchEvent, 'bpmn:LinkEventDefinition');
+
+            return linkEventDefinition.get('name') === name;
+          });
+
+        duplicates
+          .forEach(linkCatchEvent => {
+            const linkEventDefinition = getEventDefinition(linkCatchEvent, 'bpmn:LinkEventDefinition');
+
+            const path = getPath(linkEventDefinition, linkCatchEvent);
+
+            reportErrors(linkCatchEvent, reporter, {
+              message: `Property of type <bpmn:LinkEventDefinition> has property <name> with duplicate value of <${ name }>`,
+              path: path
+                ? [ ...path, 'name' ]
+                : [ 'name' ],
+              data: {
+                type: ERROR_TYPES.ELEMENT_PROPERTY_VALUE_DUPLICATED,
+                node: linkEventDefinition,
+                parentNode: linkCatchEvent,
+                duplicatedProperty: 'name',
+                duplicatedPropertyValue: name
+              }
+            });
+          });
+      });
+    }
+
+    // check for missing link catch & throw event names
+    if (isLinkEvent(node)) {
+      const linkEventDefinition = getEventDefinition(node);
+
+      const errors = hasProperties(linkEventDefinition, {
+        name: {
+          required: true
+        }
+      }, node);
+
+      if (errors.length) {
+        reportErrors(node, reporter, errors);
+      }
+    }
+  }
+
+  return {
+    check
+  };
+});
+
+function isLinkEvent(element) {
+  const eventDefinition = getEventDefinition(element);
+
+  return isAny(element, [
+    'bpmn:IntermediateCatchEvent',
+    'bpmn:IntermediateThrowEvent'
+  ]) && eventDefinition && is(eventDefinition, 'bpmn:LinkEventDefinition');
+}
+
+function isLinkCatchEvent(element) {
+  const eventDefinition = getEventDefinition(element);
+
+  return is(element, 'bpmn:IntermediateCatchEvent')
+    && eventDefinition && is(eventDefinition, 'bpmn:LinkEventDefinition');
+}
+
+function getLinkCatchEvents(flowElementsContainer) {
+  return flowElementsContainer.get('flowElements').reduce((linkCatchEvents, flowElement) => {
+    if (isLinkCatchEvent(flowElement)) {
+      return [
+        ...linkCatchEvents,
+        flowElement
+      ];
+    } else if (is(flowElement, 'bpmn:SubProcess')) {
+      return [
+        ...linkCatchEvents,
+        ...getLinkCatchEvents(flowElement)
+      ];
+    }
+
+    return linkCatchEvents;
+  }, []);
 }

package/rules/camunda-cloud/loop-characteristics.js

@@ -1,67 +1,67 @@
-const { is } = require('bpmnlint-utils');
-
-const {
-  findExtensionElement,
-  hasProperties,
-  hasExtensionElement
-} = require('../utils/element');
-
-const { reportErrors } = require('../utils/reporter');
-
-const { skipInNonExecutableProcess } = require('../utils/rule');
-
-module.exports = skipInNonExecutableProcess(function() {
-  function check(node, reporter) {
-    if (!is(node, 'bpmn:Activity')) {
-      return;
-    }
-
-    let loopCharacteristics = node.get('loopCharacteristics');
-
-    if (!loopCharacteristics) {
-      return;
-    }
-
-    let errors = hasProperties(node, {
-      loopCharacteristics: {
-        type: 'bpmn:MultiInstanceLoopCharacteristics'
-      }
-    }, node);
-
-    if (errors && errors.length) {
-      reportErrors(node, reporter, errors);
-
-      return;
-    }
-
-    errors = hasExtensionElement(loopCharacteristics, 'zeebe:LoopCharacteristics', node);
-
-    if (errors && errors.length) {
-      reportErrors(node, reporter, errors);
-
-      return;
-    }
-
-    loopCharacteristics = findExtensionElement(loopCharacteristics, 'zeebe:LoopCharacteristics');
-
-    errors = hasProperties(loopCharacteristics, {
-      inputCollection: {
-        required: true
-      },
-      outputCollection: {
-        dependentRequired: 'outputElement'
-      },
-      outputElement: {
-        dependentRequired: 'outputCollection'
-      }
-    }, node);
-
-    if (errors && errors.length) {
-      reportErrors(node, reporter, errors);
-    }
-  }
-
-  return {
-    check
-  };
+const { is } = require('bpmnlint-utils');
+
+const {
+  findExtensionElement,
+  hasProperties,
+  hasExtensionElement
+} = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:Activity')) {
+      return;
+    }
+
+    let loopCharacteristics = node.get('loopCharacteristics');
+
+    if (!loopCharacteristics) {
+      return;
+    }
+
+    let errors = hasProperties(node, {
+      loopCharacteristics: {
+        type: 'bpmn:MultiInstanceLoopCharacteristics'
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+
+      return;
+    }
+
+    errors = hasExtensionElement(loopCharacteristics, 'zeebe:LoopCharacteristics', node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+
+      return;
+    }
+
+    loopCharacteristics = findExtensionElement(loopCharacteristics, 'zeebe:LoopCharacteristics');
+
+    errors = hasProperties(loopCharacteristics, {
+      inputCollection: {
+        required: true
+      },
+      outputCollection: {
+        dependentRequired: 'outputElement'
+      },
+      outputElement: {
+        dependentRequired: 'outputCollection'
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
 });

package/rules/camunda-cloud/message-reference.js

@@ -1,61 +1,61 @@
-const {
-  is,
-  isAny
-} = require('bpmnlint-utils');
-
-const {
-  getEventDefinition,
-  hasProperties
-} = require('../utils/element');
-
-const { reportErrors } = require('../utils/reporter');
-
-const { skipInNonExecutableProcess } = require('../utils/rule');
-
-module.exports = skipInNonExecutableProcess(function() {
-  function check(node, reporter) {
-    if (!isAny(node, [ 'bpmn:CatchEvent', 'bpmn:ReceiveTask' ])) {
-      return;
-    }
-
-    let eventDefinitionOrReceiveTask = node;
-
-    if (!is(node, 'bpmn:ReceiveTask')) {
-      const eventDefinition = getEventDefinition(node);
-
-      if (!eventDefinition || !is(eventDefinition, 'bpmn:MessageEventDefinition')) {
-        return;
-      }
-
-      eventDefinitionOrReceiveTask = eventDefinition;
-    }
-
-    let errors = hasProperties(eventDefinitionOrReceiveTask, {
-      messageRef: {
-        required: true
-      }
-    }, node);
-
-    if (errors && errors.length) {
-      reportErrors(node, reporter, errors);
-
-      return;
-    }
-
-    const messageRef = eventDefinitionOrReceiveTask.get('messageRef');
-
-    errors = hasProperties(messageRef, {
-      name: {
-        required: true
-      }
-    }, node);
-
-    if (errors && errors.length) {
-      reportErrors(node, reporter, errors);
-    }
-  }
-
-  return {
-    check
-  };
+const {
+  is,
+  isAny
+} = require('bpmnlint-utils');
+
+const {
+  getEventDefinition,
+  hasProperties
+} = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!isAny(node, [ 'bpmn:CatchEvent', 'bpmn:ReceiveTask' ])) {
+      return;
+    }
+
+    let eventDefinitionOrReceiveTask = node;
+
+    if (!is(node, 'bpmn:ReceiveTask')) {
+      const eventDefinition = getEventDefinition(node);
+
+      if (!eventDefinition || !is(eventDefinition, 'bpmn:MessageEventDefinition')) {
+        return;
+      }
+
+      eventDefinitionOrReceiveTask = eventDefinition;
+    }
+
+    let errors = hasProperties(eventDefinitionOrReceiveTask, {
+      messageRef: {
+        required: true
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+
+      return;
+    }
+
+    const messageRef = eventDefinitionOrReceiveTask.get('messageRef');
+
+    errors = hasProperties(messageRef, {
+      name: {
+        required: true
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
 });

package/rules/camunda-cloud/no-binding-type.js

@@ -0,0 +1,44 @@
+const { isAny } = require('bpmnlint-utils');
+
+const { hasProperties, findExtensionElement } = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!isAny(node, [
+      'bpmn:BusinessRuleTask',
+      'bpmn:CallActivity',
+      'bpmn:UserTask'
+    ])) {
+      return;
+    }
+
+    const extensionElement = findExtensionElement(node, [
+      'zeebe:CalledDecision',
+      'zeebe:CalledElement',
+      'zeebe:FormDefinition'
+    ]);
+
+    if (!extensionElement) {
+      return;
+    }
+
+    const errors = hasProperties(extensionElement, {
+      bindingType: {
+        allowed: (value) => !value || value === 'latest',
+        allowedVersion: '8.6'
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
+});

package/rules/camunda-cloud/no-candidate-users.js

@@ -1,39 +1,39 @@
-const { is } = require('bpmnlint-utils');
-
-const {
-  findExtensionElement,
-  hasProperties
-} = require('../utils/element');
-
-const { reportErrors } = require('../utils/reporter');
-
-const { skipInNonExecutableProcess } = require('../utils/rule');
-
-module.exports = skipInNonExecutableProcess(function() {
-  function check(node, reporter) {
-    if (!is(node, 'bpmn:UserTask')) {
-      return;
-    }
-
-    const assignmentDefinition = findExtensionElement(node, 'zeebe:AssignmentDefinition');
-
-    if (!assignmentDefinition) {
-      return;
-    }
-
-    const errors = hasProperties(assignmentDefinition, {
-      candidateUsers: {
-        allowed: false,
-        allowedVersion: '8.2'
-      }
-    }, node);
-
-    if (errors && errors.length) {
-      reportErrors(node, reporter, errors);
-    }
-  }
-
-  return {
-    check
-  };
+const { is } = require('bpmnlint-utils');
+
+const {
+  findExtensionElement,
+  hasProperties
+} = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:UserTask')) {
+      return;
+    }
+
+    const assignmentDefinition = findExtensionElement(node, 'zeebe:AssignmentDefinition');
+
+    if (!assignmentDefinition) {
+      return;
+    }
+
+    const errors = hasProperties(assignmentDefinition, {
+      candidateUsers: {
+        allowed: false,
+        allowedVersion: '8.2'
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
 });

package/rules/camunda-cloud/no-execution-listeners.js

@@ -0,0 +1,21 @@
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+const { hasNoExtensionElement } = require('../utils/element');
+
+const ALLOWED_VERSION = '8.6';
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    const errors = hasNoExtensionElement(node, 'zeebe:ExecutionListeners', node, ALLOWED_VERSION);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+  return {
+    check
+  };
+});