bpmnlint-plugin-camunda-compat 2.17.0 → 2.18.0

package/index.js

@@ -66,11 +66,13 @@ const camundaCloud83Rules = withConfig({
 const camundaCloud84Rules = withConfig(
   omit(camundaCloud83Rules, 'collapsed-subprocess'), { version: '8.4' });
 
-const camundaCloud85Rules = withConfig(
-  omit(camundaCloud83Rules, [
+const camundaCloud85Rules = withConfig({
+  ...omit(camundaCloud83Rules, [
     'collapsed-subprocess',
     'no-zeebe-user-task'
-  ]), { version: '8.5' });
+  ]),
+  'wait-for-completion': 'error'
+}, { version: '8.5' });
 
 const camundaPlatform719Rules = withConfig({
   'history-time-to-live': 'info'
@@ -124,7 +126,8 @@ const rules = {
   'task-schedule': './rules/camunda-cloud/task-schedule',
   'timer': './rules/camunda-cloud/timer',
   'user-task-definition': './rules/camunda-cloud/user-task-definition',
-  'user-task-form': './rules/camunda-cloud/user-task-form'
+  'user-task-form': './rules/camunda-cloud/user-task-form',
+  'wait-for-completion': './rules/camunda-cloud/wait-for-completion'
 };
 
 const configs = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.17.0",
+  "version": "2.18.0",
   "description": "A bpmnlint plug-in for Camunda compatibility",
   "main": "index.js",
   "scripts": {

package/rules/camunda-cloud/element-type/config.js

@@ -1,6 +1,7 @@
 module.exports = {
   'bpmn:Association': '1.0',
   'bpmn:BoundaryEvent': {
+    'bpmn:CompensateEventDefinition': '8.5',
     'bpmn:ErrorEventDefinition': '1.0',
     'bpmn:EscalationEventDefinition': '8.2',
     'bpmn:MessageEventDefinition': '1.0',
@@ -16,6 +17,7 @@ module.exports = {
   'bpmn:Definitions': '1.0',
   'bpmn:EndEvent': {
     '_': '1.0',
+    'bpmn:CompensateEventDefinition': '8.5',
     'bpmn:ErrorEventDefinition': '1.0',
     'bpmn:EscalationEventDefinition': '8.2',
     'bpmn:MessageEventDefinition': '1.2',
@@ -34,6 +36,7 @@ module.exports = {
   },
   'bpmn:IntermediateThrowEvent': {
     '_': '1.1',
+    'bpmn:CompensateEventDefinition': '8.5',
     'bpmn:EscalationEventDefinition': '8.2',
     'bpmn:LinkEventDefinition': '8.2',
     'bpmn:MessageEventDefinition': '1.2',

package/rules/camunda-cloud/wait-for-completion.js

@@ -0,0 +1,46 @@
+const {
+  is
+} = require('bpmnlint-utils');
+
+const {
+  getEventDefinition,
+  hasProperties
+} = require('../utils/element');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(waitForCompletion);
+
+/**
+ * Make sure that wait for completion is NOT set to false.
+ */
+function waitForCompletion() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:ThrowEvent')) {
+      return;
+    }
+
+    const eventDefinition = getEventDefinition(node);
+
+    if (!eventDefinition || !is(eventDefinition, 'bpmn:CompensateEventDefinition')) {
+      return;
+    }
+
+    const errors = hasProperties(eventDefinition, {
+      waitForCompletion: {
+        value: true
+      }
+    }, node);
+
+    if (errors && errors.length) {
+      reportErrors(node, reporter, errors);
+    }
+  }
+
+
+  return {
+    check
+  };
+}