bpmnlint-plugin-camunda-compat 2.11.0 → 2.11.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "2.11.0",
+  "version": "2.11.1",
   "description": "A bpmnlint plug-in for Camunda compatibility",
   "main": "index.js",
   "scripts": {

package/rules/camunda-cloud/user-task-form.js

@@ -14,7 +14,7 @@ const { skipInNonExecutableProcess } = require('../utils/rule');
 
 const { greaterOrEqual } = require('../utils/version');
 
-const formIdAllowedVersion = '8.3';
+const formIdAllowedVersion = '8.4';
 
 module.exports = skipInNonExecutableProcess(function({ version }) {
   function check(node, reporter) {

package/rules/utils/element.js

@@ -4,6 +4,8 @@ const {
   isFunction,
   isNil,
   isObject,
+  isString,
+  isUndefined,
   some
 } = require('min-dash');
 
@@ -141,7 +143,7 @@ module.exports.hasProperties = function(node, properties, parentNode = null) {
 
     const propertyValue = node.get(propertyName);
 
-    if (propertyChecks.required && !propertyValue) {
+    if (propertyChecks.required && isEmptyValue(propertyValue)) {
       return [
         ...results,
         {
@@ -164,7 +166,7 @@ module.exports.hasProperties = function(node, properties, parentNode = null) {
     if (propertyChecks.dependentRequired) {
       const dependency = node.get(propertyChecks.dependentRequired);
 
-      if (dependency && !propertyValue) {
+      if (dependency && isEmptyValue(propertyValue)) {
         return [
           ...results,
           {
@@ -303,7 +305,9 @@ function findProperties(node, propertyNames) {
   const properties = [];
 
   for (const propertyName of propertyNames) {
-    if (isDefined(node.get(propertyName))) {
+    const propertyValue = node.get(propertyName);
+
+    if (!isEmptyValue(propertyValue)) {
       properties.push(node.get(propertyName));
     }
   }
@@ -470,4 +474,12 @@ function findParent(node, type) {
   return findParent(parent, type);
 }
 
-module.exports.findParent = findParent;
+module.exports.findParent = findParent;
+
+function isEmptyString(value) {
+  return isString(value) && value.trim() === '';
+}
+
+function isEmptyValue(value) {
+  return isUndefined(value) || isNil(value) || isEmptyString(value);
+}