bpmnlint-plugin-camunda-compat 1.4.0 → 2.1.0

package/index.js

@@ -13,6 +13,7 @@ const camundaCloud10Rules = withConfig({
   'message-reference': 'error',
   'no-candidate-users': 'error',
   'no-expression': 'error',
+  'no-multiple-none-start-events': 'error',
   'no-task-schedule': 'error',
   'no-template': 'error',
   'no-zeebe-properties': 'error',
@@ -65,6 +66,36 @@ const camundaPlatform720Rules = withConfig(camundaPlatform719Rules, {
   version: '7.20'
 });
 
+const rules = {
+  'element-type': './rules/camunda-cloud/element-type',
+  'called-element': './rules/camunda-cloud/called-element',
+  'collapsed-subprocess': './rules/camunda-cloud/collapsed-subprocess',
+  'duplicate-task-headers': './rules/camunda-cloud/duplicate-task-headers',
+  'error-reference': './rules/camunda-cloud/error-reference',
+  'escalation-reference': './rules/camunda-cloud/escalation-reference',
+  'event-based-gateway-target': './rules/camunda-cloud/event-based-gateway-target',
+  'executable-process': './rules/camunda-cloud/executable-process',
+  'feel': './rules/camunda-cloud/feel',
+  'history-time-to-live': './rules/camunda-platform/history-time-to-live',
+  'implementation': './rules/camunda-cloud/implementation',
+  'inclusive-gateway': './rules/camunda-cloud/inclusive-gateway',
+  'loop-characteristics': './rules/camunda-cloud/loop-characteristics',
+  'message-reference': './rules/camunda-cloud/message-reference',
+  'no-candidate-users': './rules/camunda-cloud/no-candidate-users',
+  'no-expression': './rules/camunda-cloud/no-expression',
+  'no-multiple-none-start-events': './rules/camunda-cloud/no-multiple-none-start-events',
+  'no-signal-event-sub-process': './rules/camunda-cloud/no-signal-event-sub-process',
+  'no-task-schedule': './rules/camunda-cloud/no-task-schedule',
+  'no-template': './rules/camunda-cloud/no-template',
+  'no-zeebe-properties': './rules/camunda-cloud/no-zeebe-properties',
+  'sequence-flow-condition': './rules/camunda-cloud/sequence-flow-condition',
+  'signal-reference': './rules/camunda-cloud/signal-reference',
+  'subscription': './rules/camunda-cloud/subscription',
+  'task-schedule': './rules/camunda-cloud/task-schedule',
+  'timer': './rules/camunda-cloud/timer',
+  'user-task-form': './rules/camunda-cloud/user-task-form'
+};
+
 module.exports = {
   configs: {
     'camunda-cloud-1-0': {
@@ -96,8 +127,17 @@ module.exports = {
     },
     'camunda-platform-7-20': {
       rules: camundaPlatform720Rules
+    },
+    'all': {
+      rules: Object.keys(rules).reduce((allRules, rule) => {
+        return {
+          ...allRules,
+          [ rule ]: 'error'
+        };
+      }, {})
     }
-  }
+  },
+  rules
 };
 
 function withConfig(rules, config, type = 'error') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "1.4.0",
+  "version": "2.1.0",
   "description": "A bpmnlint plug-in for Camunda Platform compatibility",
   "main": "index.js",
   "scripts": {
@@ -25,7 +25,7 @@
   "license": "MIT",
   "devDependencies": {
     "bpmn-moddle": "^7.1.3",
-    "bpmnlint": "^7.8.0",
+    "bpmnlint": "^9.0.0",
     "chai": "^4.3.6",
     "eslint": "^8.23.0",
     "eslint-plugin-bpmn-io": "^0.14.1",

package/rules/{called-element.js → camunda-cloud/called-element.js}

@@ -4,11 +4,11 @@ const {
   findExtensionElement,
   hasExtensionElement,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{collapsed-subprocess.js → camunda-cloud/collapsed-subprocess.js}

@@ -1,10 +1,10 @@
 const { is } = require('bpmnlint-utils');
 
-const { ERROR_TYPES } = require('./utils/element');
+const { ERROR_TYPES } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(di, reporter) {

package/rules/{duplicate-task-headers.js → camunda-cloud/duplicate-task-headers.js}

@@ -7,11 +7,11 @@ const {
   findExtensionElement,
   getMessageEventDefinition,
   hasDuplicatedPropertyValues
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{element-type → camunda-cloud/element-type}/index.js

@@ -4,15 +4,15 @@ const { isAny } = require('bpmnlint-utils');
 
 const config = require('./config');
 
-const { greaterOrEqual } = require('../utils/version');
+const { greaterOrEqual } = require('../../utils/version');
 
-const { getEventDefinition } = require('../utils/element');
+const { getEventDefinition } = require('../../utils/element');
 
-const { ERROR_TYPES } = require('../utils/error-types');
+const { ERROR_TYPES } = require('../../utils/error-types');
 
-const { reportErrors } = require('../utils/reporter');
+const { reportErrors } = require('../../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('../utils/rule');
+const { skipInNonExecutableProcess } = require('../../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function({ version }) {
   function check(node, reporter) {

package/rules/{error-reference.js → camunda-cloud/error-reference.js}

@@ -6,13 +6,13 @@ const {
 const {
   getEventDefinition,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
-const { greaterOrEqual } = require('./utils/version');
+const { greaterOrEqual } = require('../utils/version');
 
 const noErrorRefAllowedVersion = '8.2';
 

package/rules/{escalation-reference.js → camunda-cloud/escalation-reference.js}

@@ -6,11 +6,11 @@ const {
 const {
   getEventDefinition,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{event-based-gateway-target.js → camunda-cloud/event-based-gateway-target.js}

@@ -1,10 +1,10 @@
 const { is } = require('bpmnlint-utils');
 
-const { ERROR_TYPES } = require('./utils/element');
+const { ERROR_TYPES } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{executable-process.js → camunda-cloud/executable-process.js}

@@ -1,8 +1,8 @@
 const { is } = require('bpmnlint-utils');
 
-const { hasProperties } = require('./utils/element');
+const { hasProperties } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
 module.exports = function() {
   function check(node, reporter) {

package/rules/{feel.js → camunda-cloud/feel.js}

@@ -6,11 +6,11 @@ const { lintExpression } = require('@bpmn-io/feel-lint');
 
 const { getPath } = require('@bpmn-io/moddle-utils');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { ERROR_TYPES } = require('./utils/error-types');
+const { ERROR_TYPES } = require('../utils/error-types');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{implementation → camunda-cloud/implementation}/index.js

@@ -6,20 +6,20 @@ const { isString } = require('min-dash');
 
 const config = require('./config');
 
-const { greaterOrEqual } = require('../utils/version');
+const { greaterOrEqual } = require('../../utils/version');
 
 const {
   findExtensionElement,
   getEventDefinition,
   hasExtensionElement,
   hasProperties
-} = require('../utils/element');
+} = require('../../utils/element');
 
-const { reportErrors } = require('../utils/reporter');
+const { reportErrors } = require('../../utils/reporter');
 
-const { ERROR_TYPES } = require('../utils/error-types');
+const { ERROR_TYPES } = require('../../utils/error-types');
 
-const { skipInNonExecutableProcess } = require('../utils/rule');
+const { skipInNonExecutableProcess } = require('../../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function({ version }) {
   function check(node, reporter) {

package/rules/{inclusive-gateway.js → camunda-cloud/inclusive-gateway.js}

@@ -1,10 +1,10 @@
 const { is } = require('bpmnlint-utils');
 
-const { ERROR_TYPES } = require('./utils/element');
+const { ERROR_TYPES } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{loop-characteristics.js → camunda-cloud/loop-characteristics.js}

@@ -4,11 +4,11 @@ const {
   findExtensionElement,
   hasProperties,
   hasExtensionElement
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{message-reference.js → camunda-cloud/message-reference.js}

@@ -6,11 +6,11 @@ const {
 const {
   getEventDefinition,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{no-candidate-users.js → camunda-cloud/no-candidate-users.js}

@@ -3,11 +3,11 @@ const { is } = require('bpmnlint-utils');
 const {
   findExtensionElement,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{no-expression.js → camunda-cloud/no-expression.js}

@@ -7,11 +7,11 @@ const { getPath } = require('@bpmn-io/moddle-utils');
 const {
   ERROR_TYPES,
   getEventDefinition
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 const handlersMap = {
   '1.0': [

package/rules/camunda-cloud/no-multiple-none-start-events.js

@@ -0,0 +1,41 @@
+const { is } = require('bpmnlint-utils');
+
+const { reportErrors } = require('../utils/reporter');
+
+const { ERROR_TYPES } = require('../utils/element');
+
+const { skipInNonExecutableProcess } = require('../utils/rule');
+
+module.exports = skipInNonExecutableProcess(function() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:Process')) {
+      return;
+    }
+
+    const flowElements = node.get('flowElements') || [];
+
+    const noneStartEvents = flowElements.filter(flowElement => {
+      return is(flowElement, 'bpmn:StartEvent') && !flowElement.get('eventDefinitions').length;
+    });
+
+    if (noneStartEvents.length <= 1) {
+      return;
+    }
+
+    noneStartEvents.forEach(startEvent => {
+      reportErrors(startEvent, reporter, {
+        message: 'Multiple elements of type <bpmn:StartEvent> with no event definition not allowed as children of <bpmn:Process>',
+        path: null,
+        data: {
+          type: ERROR_TYPES.ELEMENT_MULTIPLE_NOT_ALLOWED,
+          node: startEvent,
+          parent: null
+        }
+      });
+    });
+  }
+
+  return {
+    check
+  };
+});

package/rules/{no-signal-event-sub-process.js → camunda-cloud/no-signal-event-sub-process.js}

@@ -1,12 +1,12 @@
 const { is } = require('bpmnlint-utils');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { getEventDefinition } = require('./utils/element');
+const { getEventDefinition } = require('../utils/element');
 
-const { ERROR_TYPES } = require('./utils/error-types');
+const { ERROR_TYPES } = require('../utils/error-types');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{no-task-schedule.js → camunda-cloud/no-task-schedule.js}

@@ -1,8 +1,8 @@
-const { hasNoExtensionElement } = require('./utils/element');
+const { hasNoExtensionElement } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{no-template.js → camunda-cloud/no-template.js}

@@ -1,8 +1,8 @@
-const { hasProperties } = require('./utils/element');
+const { hasProperties } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{no-zeebe-properties.js → camunda-cloud/no-zeebe-properties.js}

@@ -1,8 +1,8 @@
-const { hasNoExtensionElement } = require('./utils/element');
+const { hasNoExtensionElement } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{sequence-flow-condition.js → camunda-cloud/sequence-flow-condition.js}

@@ -6,11 +6,11 @@ const {
 const {
   ERROR_TYPES,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{signal-reference.js → camunda-cloud/signal-reference.js}

@@ -6,11 +6,11 @@ const {
 const {
   getEventDefinition,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{subscription.js → camunda-cloud/subscription.js}

@@ -8,11 +8,11 @@ const {
   getEventDefinition,
   hasExtensionElement,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{task-schedule.js → camunda-cloud/task-schedule.js}

@@ -5,13 +5,13 @@ const { isDefined } = require('min-dash');
 const {
   findExtensionElement,
   hasExpression
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { validateDate: validateISO8601Date } = require('./utils/iso8601');
+const { validateDate: validateISO8601Date } = require('../utils/iso8601');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{timer → camunda-cloud/timer}/index.js

@@ -9,26 +9,26 @@ const {
   expressionType: expressionTypeConfig
 } = require('./config');
 
-const { greaterOrEqual } = require('../utils/version');
+const { greaterOrEqual } = require('../../utils/version');
 
 const {
   getEventDefinition,
   hasExpression,
   hasProperties,
   hasProperty
-} = require('../utils/element');
+} = require('../../utils/element');
 
-const { validateCronExpression } = require('../utils/cron');
+const { validateCronExpression } = require('../../utils/cron');
 
 const {
   validateCycle: validateISO8601Cycle,
   validateDate: validateISO8601Date,
   validateDuration: validateISO8601Duration
-} = require('../utils/iso8601');
+} = require('../../utils/iso8601');
 
-const { reportErrors } = require('../utils/reporter');
+const { reportErrors } = require('../../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('../utils/rule');
+const { skipInNonExecutableProcess } = require('../../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function({ version }) {
   function check(node, reporter) {

package/rules/{user-task-form.js → camunda-cloud/user-task-form.js}

@@ -4,11 +4,11 @@ const {
   findExtensionElement,
   findExtensionElements,
   hasProperties
-} = require('./utils/element');
+} = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/{history-time-to-live.js → camunda-platform/history-time-to-live.js}

@@ -1,10 +1,10 @@
 const { is } = require('bpmnlint-utils');
 
-const { hasProperties } = require('./utils/element');
+const { hasProperties } = require('../utils/element');
 
-const { reportErrors } = require('./utils/reporter');
+const { reportErrors } = require('../utils/reporter');
 
-const { skipInNonExecutableProcess } = require('./utils/rule');
+const { skipInNonExecutableProcess } = require('../utils/rule');
 
 module.exports = skipInNonExecutableProcess(function() {
   function check(node, reporter) {

package/rules/utils/error-types.js

@@ -1,6 +1,7 @@
 module.exports.ERROR_TYPES = Object.freeze({
   ELEMENT_COLLAPSED_NOT_ALLOWED: 'camunda.elementCollapsedNotAllowed',
   CHILD_ELEMENT_TYPE_NOT_ALLOWED: 'camunda.childElementTypeNotAllowed',
+  ELEMENT_MULTIPLE_NOT_ALLOWED: 'camunda.elementMultipleNotAllowed',
   ELEMENT_TYPE_NOT_ALLOWED: 'camunda.elementTypeNotAllowed',
   EVENT_BASED_GATEWAY_TARGET_NOT_ALLOWED: 'camunda.eventBasedGatewayTargetNotAllowed',
   EXPRESSION_NOT_ALLOWED: 'camunda.expressionNotAllowed',

package/rules/utils/iso8601.js

@@ -8,10 +8,11 @@ const SECOND = '[0-5][0-9]';
 const ZONE_ID = '(\\[[^\\]]+\\])';
 const TIMEZONE = `(Z|([+-](0[0-9]|1[0-3]):[0-5][0-9]${ZONE_ID}?))`;
 
-const ISO_DATE_REGEX = new RegExp(`^${DATE}T${HOUR}:${MINUTE}:${SECOND}${TIMEZONE}$`);
+const ISO_DATE = `${DATE}T${HOUR}:${MINUTE}:${SECOND}${TIMEZONE}`;
+const ISO_DATE_REGEX = new RegExp(`^${ISO_DATE}$`);
 const ISO_DURATION = 'P(?!$)(\\d+(\\.\\d+)?[Yy])?(\\d+(\\.\\d+)?[Mm])?(\\d+(\\.\\d+)?[Ww])?(\\d+(\\.\\d+)?[Dd])?(T(?!$)(\\d+(\\.\\d+)?[Hh])?(\\d+(\\.\\d+)?[Mm])?(\\d+(\\.\\d+)?[Ss])?)?$';
 const ISO_DURATION_REGEX = new RegExp(`^${ISO_DURATION}$`);
-const ISO_CYCLE = `R(-1|\\d+)?/${ISO_DURATION}`;
+const ISO_CYCLE = `R(-1|\\d+)?/(${ISO_DATE}/)?${ISO_DURATION}`;
 const ISO_CYCLE_REGEX = new RegExp(`^${ISO_CYCLE}$`);
 
 module.exports = {