bpmnlint-plugin-camunda-compat 1.0.0 → 1.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "A bpmnlint plug-in for Camunda Platform compatibility",
   "main": "index.js",
   "scripts": {

package/rules/error-reference.js

@@ -14,44 +14,50 @@ const { skipInNonExecutableProcess } = require('./utils/rule');
 
 const { greaterOrEqual } = require('./utils/version');
 
+const noErrorRefAllowedVersion = '8.2';
+
 module.exports = skipInNonExecutableProcess(function({ version }) {
   function check(node, reporter) {
     if (!isAny(node, [ 'bpmn:CatchEvent', 'bpmn:ThrowEvent' ])) {
       return;
     }
 
-    if (is(node, 'bpmn:CatchEvent') && greaterOrEqual(version, '8.2')) {
-      return;
-    }
-
     const eventDefinition = getEventDefinition(node);
 
     if (!eventDefinition || !is(eventDefinition, 'bpmn:ErrorEventDefinition')) {
       return;
     }
 
-    let errors = hasProperties(eventDefinition, {
-      errorRef: {
-        required: true,
-        allowedVersion: '8.2'
-      }
-    }, node);
+    let errors = [];
 
-    if (errors && errors.length) {
-      reportErrors(node, reporter, errors);
+    if (!isNoErrorRefAllowed(node, version)) {
+      errors = hasProperties(eventDefinition, {
+        errorRef: {
+          required: true,
+          allowedVersion: '8.2'
+        }
+      }, node);
 
-      return;
+      if (errors.length) {
+        reportErrors(node, reporter, errors);
+
+        return;
+      }
     }
 
     const errorRef = eventDefinition.get('errorRef');
 
+    if (!errorRef) {
+      return;
+    }
+
     errors = hasProperties(errorRef, {
       errorCode: {
         required: true
       }
     }, node);
 
-    if (errors && errors.length) {
+    if (errors.length) {
       reportErrors(node, reporter, errors);
     }
   }
@@ -59,4 +65,8 @@ module.exports = skipInNonExecutableProcess(function({ version }) {
   return {
     check
   };
-});
+});
+
+function isNoErrorRefAllowed(node, version) {
+  return is(node, 'bpmn:CatchEvent') && greaterOrEqual(version, noErrorRefAllowedVersion);
+}