bpmnlint-plugin-camunda-compat 0.6.0 → 0.6.3

package/CHANGELOG.md

@@ -6,6 +6,18 @@ All notable changes to [bpmnlint-plugin-camunda-compat](https://github.com/camun
 
 ___Note:__ Yet to be released changes appear here._
 
+## 0.6.3
+
+* `FIX`: backport of ([#34](https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/34)) to v0.6
+
+## 0.6.2
+
+* `FIX`: fix error message formatting ([#27](https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/27))
+
+## 0.6.1
+
+* `FIX`: lanes supported ([#26](https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/26))
+
 ## 0.6.0
 
 * `FEAT`: adjust error messages to be more friendly ([#22](https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/22))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "0.6.0",
+  "version": "0.6.3",
   "description": "A bpmnlint plug-in for Camunda Cloud and Platform compatibility",
   "main": "index.js",
   "scripts": {

package/rules/camunda-cloud-1-0-checks.js

@@ -1,3 +1,5 @@
+const { is } = require('bpmnlint-utils');
+
 const {
   checkEventDefinition,
   checkFlowNode,
@@ -6,7 +8,6 @@ const {
   hasEventDefinitionOfType,
   hasEventDefinitionOfTypeOrNone,
   hasMessageReference,
-  hasNoLanes,
   isNotBpmn,
   withTranslations
 } = require('./utils/element');
@@ -36,6 +37,7 @@ module.exports = [
   'bpmn:MessageFlow',
   'bpmn:ParallelGateway',
   'bpmn:Participant',
+  'bpmn:Process',
   'bpmn:SequenceFlow',
   'bpmn:TextAnnotation',
   {
@@ -135,15 +137,6 @@ module.exports = [
       }
     )
   },
-  {
-    type: 'bpmn:Process',
-    check: withTranslations(
-      hasNoLanes,
-      {
-        'Element of type <bpmn:Process> (<bpmn:LaneSet>) not supported by {{ executionPlatform }}': 'A <Lane> is not supported by Camunda Platform 8 (Zeebe 1.0)'
-      }
-    )
-  },
   {
     type: 'bpmn:ReceiveTask',
     check: withTranslations(
@@ -202,7 +195,14 @@ module.exports = [
             checkEventDefinition(hasMessageReference),
             checkIf(
               checkEventDefinition(hasZeebeSubscription),
-              checkEventDefinition(hasMessageReference)
+              checkEvery(
+                checkEventDefinition(hasMessageReference),
+                (node) => {
+                  const { $parent } = node;
+
+                  return $parent && is($parent, 'bpmn:SubProcess');
+                }
+              )
             )
           ),
           hasEventDefinitionOfType('bpmn:MessageEventDefinition')

package/rules/camunda-cloud-1-3-checks.js

@@ -26,7 +26,7 @@ module.exports = [
         'Element of type <bpmn:BusinessRuleTask> must have one or many extension elements of type <zeebe:CalledDecision> or <zeebe:TaskDefinition>': 'A <Business Rule Task> must have a defined <Implementation>',
         'Element of type <zeebe:TaskDefinition> must have property <type>': 'A <Business Rule Task> with <Implementation: Job worker> must have a defined <Task definition type>',
         'Element of type <zeebe:CalledDecision> must have property <decisionId>': 'A <Business Rule Task> with <Implementation: DMN decision> must have a defined <Called decision ID>',
-        'Element of type <zeebe:CalledDecision> must have property <resultVariable>': 'A Business Rule Task with <Implementation: DMN decision> must have a defined <Result variable>',
+        'Element of type <zeebe:CalledDecision> must have property <resultVariable>': 'A <Business Rule Task> with <Implementation: DMN decision> must have a defined <Result variable>',
         'Element of type <bpmn:MultiInstanceLoopCharacteristics> must have extension element of type <zeebe:LoopCharacteristics>': 'A <Business Rule Task> with <Multi-instance marker> must have a defined <Input collection>',
         'Element of type <zeebe:LoopCharacteristics> must have property <inputCollection>': 'A <Business Rule Task> with <Multi-instance marker> must have a defined <Input collection>',
         'Element of type <zeebe:LoopCharacteristics> must have property <outputElement> if it has property <outputCollection>': 'A <Business Rule Task> with <Multi-instance marker> and defined <Output collection> must have a defined <Output element>',

package/rules/utils/element.js

@@ -131,14 +131,6 @@ module.exports.hasMultiInstanceLoopCharacteristics = function(node) {
   return true;
 };
 
-module.exports.hasNoLanes = function(node) {
-  const laneSets = node.get('laneSets');
-
-  return !laneSets
-    || !laneSets.length
-    || getElementNotSupportedError(node.$type, 'bpmn:LaneSet', [ 'laneSets' ]);
-};
-
 module.exports.isNotBpmn = function(node) {
   return !is(node, 'bpmn:BaseElement');
 };