bpmnlint-plugin-camunda-compat 0.2.0 → 0.3.0

package/README.md

@@ -23,8 +23,8 @@ To validate a diagram it must be pinned to a particular execution platform via t
 
 ## Resources
 
-* [Documentation](https://github.com/camunda/bpmnlint-plugin-camunda-compat/tree/master/docs/rules)
 * [Issues](https://github.com/camunda/bpmnlint-plugin-camunda-compat/issues)
+* BPMN coverage for [Camunda Cloud](https://docs.camunda.io/docs/reference/bpmn-processes/bpmn-coverage/) and [Camunda Platform](https://docs.camunda.org/manual/latest/reference/bpmn20/)
 
 
 ## License

package/index.js

@@ -1,19 +1,43 @@
 module.exports = {
   configs: {
+    all: {
+      rules: {
+        'camunda-cloud-1-0': 'error',
+        'camunda-cloud-1-1': 'error',
+        'camunda-cloud-1-2': 'error',
+        'camunda-cloud-1-3': 'error',
+        'camunda-cloud-1-4': 'error',
+        'camunda-platform-7-15': 'error',
+        'camunda-platform-7-16': 'error',
+        'camunda-platform-7-17': 'error'
+      }
+    },
     recommended: {
       rules: {
         'camunda-cloud-1-0': 'error',
         'camunda-cloud-1-1': 'error',
         'camunda-cloud-1-2': 'error',
-        'camunda-cloud-1-3': 'error'
+        'camunda-cloud-1-3': 'error',
+        'camunda-cloud-1-4': 'error',
+        'camunda-platform-7-15': 'error',
+        'camunda-platform-7-16': 'error',
+        'camunda-platform-7-17': 'error'
       }
     },
-    all: {
+    cloud: {
+      rules: {
+        'camunda-cloud-1-0': 'error',
+        'camunda-cloud-1-1': 'error',
+        'camunda-cloud-1-2': 'error',
+        'camunda-cloud-1-3': 'error',
+        'camunda-cloud-1-4': 'error'
+      }
+    },
+    platform: {
       rules: {
-        'camunda-cloud-1-0': 'warn',
-        'camunda-cloud-1-1': 'warn',
-        'camunda-cloud-1-2': 'warn',
-        'camunda-cloud-1-3': 'warn'
+        'camunda-platform-7-15': 'error',
+        'camunda-platform-7-16': 'error',
+        'camunda-platform-7-17': 'error'
       }
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "description": "A bpmnlint plug-in for Camunda Cloud and Platform compatibility",
   "main": "index.js",
   "scripts": {
@@ -23,7 +23,7 @@
   "devDependencies": {
     "bpmn-moddle": "^7.1.2",
     "bpmnlint": "^6.1.0",
-    "chai": "^4.2.0",
+    "chai": "^4.3.5",
     "mocha": "^5.2.0",
     "modeler-moddle": "^0.1.0",
     "zeebe-bpmn-moddle": "^0.10.0"

package/rules/camunda-cloud-1-0-checks.js

@@ -82,7 +82,10 @@ module.exports = [
   },
   {
     type: 'bpmn:SubProcess',
-    check: hasNoLoopCharacteristics
+    check: checkSome(
+      hasNoLoopCharacteristics,
+      hasLoopCharacteristicsOfType('bpmn:MultiInstanceLoopCharacteristics')
+    )
   },
   {
     type: 'bpmn:UserTask',
@@ -91,4 +94,4 @@ module.exports = [
       hasLoopCharacteristicsOfType('bpmn:MultiInstanceLoopCharacteristics')
     )
   }
-];
+];

package/rules/camunda-cloud-1-4-checks.js

@@ -0,0 +1,5 @@
+const camundaCloud13Checks = require('./camunda-cloud-1-3-checks');
+
+module.exports = [
+  ...camundaCloud13Checks
+];

package/rules/camunda-cloud-1-4.js

@@ -0,0 +1,5 @@
+const { createRule } = require('./utils/rule');
+
+const checks = require('./camunda-cloud-1-4-checks');
+
+module.exports = createRule('Camunda Cloud', '1.4', checks);

package/rules/camunda-platform-7-15.js

@@ -0,0 +1,3 @@
+const { createNoopRule } = require('./utils/rule');
+
+module.exports = createNoopRule();

package/rules/camunda-platform-7-16.js

@@ -0,0 +1,3 @@
+const { createNoopRule } = require('./utils/rule');
+
+module.exports = createNoopRule();

package/rules/camunda-platform-7-17.js

@@ -0,0 +1,3 @@
+const { createNoopRule } = require('./utils/rule');
+
+module.exports = createNoopRule();

package/rules/utils/rule.js

@@ -41,7 +41,15 @@ module.exports.createRule = function(ruleExecutionPlatform, ruleExecutionPlatfor
       }
     };
   };
-}
+};
+
+module.exports.createNoopRule = function() {
+  return () => {
+    return {
+      check: () => false
+    };
+  };
+};
 
 /**
  * @param {ModdleElement} node