bpmnlint-plugin-camunda-compat 0.14.1 → 0.15.1

package/index.js

@@ -7,10 +7,12 @@ const camundaCloud10Rules = {
   'duplicate-task-headers': 'error',
   'element-type': [ 'error', { version: '1.0' } ],
   'error-reference': 'error',
+  'executable-process': 'error',
   'loop-characteristics': 'error',
   'message-reference': 'error',
   'no-template': 'error',
   'no-zeebe-properties': 'error',
+  'sequence-flow-condition': 'error',
   'subscription': 'error',
   'timer': [ 'error', { version: '1.0' } ],
   'user-task-form': 'error',
@@ -53,6 +55,13 @@ const camundaCloud81Rules = {
   'timer': [ 'error', { version: '8.1' } ]
 };
 
+const camundaCloud82Rules = {
+  ...camundaCloud81Rules,
+  'called-decision-or-task-definition': [ 'error', { version: '8.2' } ],
+  'element-type': [ 'error', { version: '8.2' } ],
+  'timer': [ 'error', { version: '8.2' } ]
+};
+
 module.exports = {
   configs: {
     'camunda-cloud-1-0': {
@@ -72,6 +81,9 @@ module.exports = {
     },
     'camunda-cloud-8-1': {
       rules: camundaCloud81Rules
+    },
+    'camunda-cloud-8-2': {
+      rules: camundaCloud82Rules
     }
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmnlint-plugin-camunda-compat",
-  "version": "0.14.1",
+  "version": "0.15.1",
   "description": "A bpmnlint plug-in for Camunda Platform compatibility",
   "main": "index.js",
   "scripts": {

package/rules/element-type/config.js

@@ -8,6 +8,9 @@ module.exports = {
   'bpmn:BusinessRuleTask': '1.1',
   'bpmn:CallActivity': '1.0',
   'bpmn:Collaboration': '1.0',
+  'bpmn:DataObject': '8.0',
+  'bpmn:DataObjectReference': '8.0',
+  'bpmn:DataStoreReference': '8.0',
   'bpmn:Definitions': '1.0',
   'bpmn:EndEvent': {
     '_': '1.0',
@@ -44,6 +47,7 @@ module.exports = {
     'bpmn:TimerEventDefinition': '1.0'
   },
   'bpmn:SubProcess': '1.0',
+  'bpmn:Task': '8.2',
   'bpmn:TextAnnotation': '1.0',
   'bpmn:UserTask': '1.0'
 };

package/rules/executable-process.js

@@ -0,0 +1,62 @@
+const { is } = require('bpmnlint-utils');
+
+const { hasProperties } = require('./utils/element');
+
+const { reportErrors } = require('./utils/reporter');
+
+module.exports = function() {
+  function check(node, reporter) {
+    if (!is(node, 'bpmn:Definitions')) {
+      return;
+    }
+
+    const rootElements = node.get('rootElements'),
+          collaboration = rootElements.find(rootElement => is(rootElement, 'bpmn:Collaboration')),
+          processes = rootElements.filter(rootElement => is(rootElement, 'bpmn:Process'));
+
+    let errors = [];
+
+    for (const process of processes) {
+      const parentNode = getParentNode(process, collaboration);
+
+      errors = [
+        ...errors,
+        ...hasProperties(process, {
+          isExecutable: {
+            value: true
+          }
+        }, parentNode)
+      ];
+    }
+
+    if (errors.length > processes.length - 1) {
+      errors.forEach(error => {
+        const { data } = error;
+
+        const { node: process } = data;
+
+        reportErrors(getParentNode(process, collaboration), reporter, error);
+      });
+    }
+  }
+
+  return {
+    check
+  };
+};
+
+function getParentNode(process, collaboration) {
+  if (!collaboration) {
+    return process;
+  }
+
+  const participants = collaboration.get('participants');
+
+  const participant = participants.find(participant => participant.get('processRef') === process);
+
+  if (participant) {
+    return participant;
+  }
+
+  return process;
+}

package/rules/inclusive-gateway.js

@@ -1,6 +1,6 @@
 const { is } = require('bpmnlint-utils');
 
-const { hasProperties, ERROR_TYPES } = require('./utils/element');
+const { ERROR_TYPES } = require('./utils/element');
 
 const { reportErrors } = require('./utils/reporter');
 
@@ -26,24 +26,6 @@ module.exports = function() {
 
       reportErrors(node, reporter, error);
     }
-
-    const outgoing = node.get('outgoing');
-
-    if (outgoing && outgoing.length > 1) {
-      for (let sequenceFlow of outgoing) {
-        if (node.get('default') !== sequenceFlow) {
-          const errors = hasProperties(sequenceFlow, {
-            conditionExpression: {
-              required: true
-            }
-          }, sequenceFlow);
-
-          if (errors.length) {
-            reportErrors(sequenceFlow, reporter, errors);
-          }
-        }
-      }
-    }
   }
 
   return {

package/rules/sequence-flow-condition.js

@@ -0,0 +1,35 @@
+const { isAny } = require('bpmnlint-utils');
+
+const { hasProperties } = require('./utils/element');
+
+const { reportErrors } = require('./utils/reporter');
+
+module.exports = function() {
+  function check(node, reporter) {
+    if (!isAny(node, [ 'bpmn:ExclusiveGateway', 'bpmn:InclusiveGateway' ])) {
+      return;
+    }
+
+    const outgoing = node.get('outgoing');
+
+    if (outgoing && outgoing.length > 1) {
+      for (let sequenceFlow of outgoing) {
+        if (node.get('default') !== sequenceFlow) {
+          const errors = hasProperties(sequenceFlow, {
+            conditionExpression: {
+              required: true
+            }
+          }, sequenceFlow);
+
+          if (errors.length) {
+            reportErrors(sequenceFlow, reporter, errors);
+          }
+        }
+      }
+    }
+  }
+
+  return {
+    check
+  };
+};

package/rules/utils/element.js

@@ -212,6 +212,25 @@ module.exports.hasProperties = function(node, properties, parentNode = null) {
       ];
     }
 
+    if ('value' in propertyChecks && propertyChecks.value !== propertyValue) {
+      return [
+        ...results,
+        {
+          message: `Property <${ propertyName }> must have value of <${ propertyChecks.value }>`,
+          path: path
+            ? [ ...path, propertyName ]
+            : [ propertyName ],
+          data: {
+            type: ERROR_TYPES.PROPERTY_VALUE_REQUIRED,
+            node,
+            parentNode: parentNode == node ? null : parentNode,
+            property: propertyName,
+            requiredValue: propertyChecks.value
+          }
+        }
+      ];
+    }
+
     if (propertyChecks.allowed === false && isDefined(propertyValue) && !isNil(propertyValue)) {
       return [
         ...results,

package/rules/utils/error-types.js

@@ -11,5 +11,6 @@ module.exports.ERROR_TYPES = Object.freeze({
   PROPERTY_REQUIRED: 'camunda.propertyRequired',
   PROPERTY_TYPE_NOT_ALLOWED: 'camunda.propertyTypeNotAllowed',
   PROPERTY_VALUE_DUPLICATED: 'camunda.propertyValueDuplicated',
-  PROPERTY_VALUE_NOT_ALLOWED: 'camunda.propertyValueNotAllowed'
+  PROPERTY_VALUE_NOT_ALLOWED: 'camunda.propertyValueNotAllowed',
+  PROPERTY_VALUE_REQUIRED: 'camunda.propertyValueRequired'
 });