bpmn-js 9.1.0 → 9.2.2

package/lib/features/popup-menu/ReplaceMenuProvider.js

@@ -427,18 +427,19 @@ ReplaceMenuProvider.prototype._getLoopEntries = function(element) {
   var translate = this._translate;
 
   function toggleLoopEntry(event, entry) {
-    var loopCharacteristics = getBusinessObject(element).loopCharacteristics;
+    var newLoopCharacteristics = getBusinessObject(element).loopCharacteristics;
 
     if (entry.active) {
-      loopCharacteristics = undefined;
+      newLoopCharacteristics = undefined;
     } else {
-      if (isUndefined(entry.options.isSequential) || !loopCharacteristics) {
-        loopCharacteristics = self._moddle.create(entry.options.loopCharacteristics);
+      if (isUndefined(entry.options.isSequential) || !newLoopCharacteristics
+      || !is(newLoopCharacteristics, entry.options.loopCharacteristics)) {
+        newLoopCharacteristics = self._moddle.create(entry.options.loopCharacteristics);
       }
 
-      loopCharacteristics.isSequential = entry.options.isSequential;
+      newLoopCharacteristics.isSequential = entry.options.isSequential;
     }
-    self._modeling.updateProperties(element, { loopCharacteristics: loopCharacteristics });
+    self._modeling.updateProperties(element, { loopCharacteristics: newLoopCharacteristics });
   }
 
   var businessObject = getBusinessObject(element),

package/lib/features/replace-preview/BpmnReplacePreview.js

@@ -1,6 +1,6 @@
 import CommandInterceptor from 'diagram-js/lib/command/CommandInterceptor';
 
-import inherits from 'inherits';
+import inherits from 'inherits-browser';
 
 import cssEscape from 'css.escape';
 

package/lib/features/rules/BpmnRules.js

@@ -5,7 +5,7 @@ import {
   some
 } from 'min-dash';
 
-import inherits from 'inherits';
+import inherits from 'inherits-browser';
 
 import {
   is,
@@ -819,11 +819,6 @@ function isOneTextAnnotation(source, target) {
 
 function canConnectAssociation(source, target) {
 
-  // do not connect connections
-  if (isConnection(source) || isConnection(target)) {
-    return false;
-  }
-
   // compensation boundary events are exception
   if (isCompensationBoundary(source) && isForCompensation(target)) {
     return true;

package/lib/features/snapping/BpmnCreateMoveSnapping.js

@@ -1,4 +1,4 @@
-import inherits from 'inherits';
+import inherits from 'inherits-browser';
 
 import CreateMoveSnapping from 'diagram-js/lib/features/snapping/CreateMoveSnapping';
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmn-js",
-  "version": "9.1.0",
+  "version": "9.2.2",
   "description": "A bpmn 2.0 toolkit and web modeler",
   "main": "index.js",
   "files": [
@@ -100,10 +100,10 @@
   "dependencies": {
     "bpmn-moddle": "^7.1.2",
     "css.escape": "^1.5.1",
-    "diagram-js": "^8.3.0",
-    "diagram-js-direct-editing": "^1.6.3",
+    "diagram-js": "^8.5.0",
+    "diagram-js-direct-editing": "^1.7.0",
     "ids": "^1.0.0",
-    "inherits": "^2.0.4",
+    "inherits-browser": "0.0.1",
     "min-dash": "^3.5.2",
     "min-dom": "^3.2.0",
     "object-refs": "^0.3.0",

package/test/util/custom-rules/CustomRules.js

@@ -1,4 +1,4 @@
-import inherits from 'inherits';
+import inherits from 'inherits-browser';
 
 import RuleProvider from 'diagram-js/lib/features/rules/RuleProvider';