bpmn-js 17.0.2 → 17.2.0

package/lib/BaseViewer.d.ts

@@ -5,7 +5,7 @@
  * bundles that include actual features.
  *
  */
-export default class BaseViewer extends Diagram {
+export default class BaseViewer extends Diagram<null> {
   /**
    * @param options The options to configure the viewer.
    */

package/lib/features/context-pad/ContextPadProvider.js

@@ -11,6 +11,7 @@ import {
 
 import {
   isExpanded,
+  isHorizontal,
   isEventSubProcess
 } from '../../util/DiUtil';
 
@@ -312,7 +313,7 @@ ContextPadProvider.prototype.getContextPadEntries = function(element) {
 
     if (childLanes.length < 2) {
 
-      if (element.height >= 120) {
+      if (isHorizontal(element) ? element.height >= 120 : element.width >= 120) {
         assign(actions, {
           'lane-divide-two': {
             group: 'lane-divide',
@@ -325,7 +326,7 @@ ContextPadProvider.prototype.getContextPadEntries = function(element) {
         });
       }
 
-      if (element.height >= 180) {
+      if (isHorizontal(element) ? element.height >= 180 : element.width >= 180) {
         assign(actions, {
           'lane-divide-three': {
             group: 'lane-divide',

package/lib/features/modeling/cmd/SplitLaneHandler.js

@@ -3,6 +3,10 @@ import {
   LANE_INDENTATION
 } from '../util/LaneUtil';
 
+import {
+  isHorizontal
+} from '../../../util/DiUtil';
+
 /**
  * @typedef {import('diagram-js/lib/command/CommandHandler').default} CommandHandler
  *
@@ -45,36 +49,41 @@ SplitLaneHandler.prototype.preExecute = function(context) {
     throw new Error(translate('more than {count} child lanes', { count: newLanesCount }));
   }
 
-  var newLanesHeight = Math.round(shape.height / newLanesCount);
+  var isHorizontalLane = isHorizontal(shape);
 
-  // Iterate from top to bottom in child lane order,
+  var laneBaseSize = isHorizontalLane ? shape.height : shape.width;
+  var newLanesSize = Math.round(laneBaseSize / newLanesCount);
+
+  // Iterate from first to last in child lane order,
   // resizing existing lanes and creating new ones
   // so that they split the parent proportionally.
   //
-  // Due to rounding related errors, the bottom lane
+  // Due to rounding related errors, the last lane
   // needs to take up all the remaining space.
-  var laneY,
-      laneHeight,
+  var laneSize,
       laneBounds,
       newLaneAttrs,
       idx;
 
   for (idx = 0; idx < newLanesCount; idx++) {
 
-    laneY = shape.y + idx * newLanesHeight;
-
-    // if bottom lane
+    // if last lane
     if (idx === newLanesCount - 1) {
-      laneHeight = shape.height - (newLanesHeight * idx);
+      laneSize = laneBaseSize - (newLanesSize * idx);
     } else {
-      laneHeight = newLanesHeight;
+      laneSize = newLanesSize;
     }
 
-    laneBounds = {
+    laneBounds = isHorizontalLane ? {
       x: shape.x + LANE_INDENTATION,
-      y: laneY,
+      y: shape.y + idx * newLanesSize,
       width: shape.width - LANE_INDENTATION,
-      height: laneHeight
+      height: laneSize
+    } : {
+      x: shape.x + idx * newLanesSize,
+      y: shape.y + LANE_INDENTATION,
+      width: laneSize,
+      height: shape.height - LANE_INDENTATION
     };
 
     if (idx < existingLanesCount) {
@@ -85,7 +94,8 @@ SplitLaneHandler.prototype.preExecute = function(context) {
 
       // create a new lane at position
       newLaneAttrs = {
-        type: 'bpmn:Lane'
+        type: 'bpmn:Lane',
+        isHorizontal: isHorizontalLane
       };
 
       modeling.createShape(newLaneAttrs, laneBounds, shape);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmn-js",
-  "version": "17.0.2",
+  "version": "17.2.0",
   "description": "A bpmn 2.0 toolkit and web modeler",
   "main": "index.js",
   "files": [
@@ -71,7 +71,7 @@
     "@rollup/plugin-terser": "^0.4.0",
     "babel-loader": "^9.1.0",
     "babel-plugin-istanbul": "^6.1.1",
-    "bio-dts": "^0.8.1",
+    "bio-dts": "^0.11.0",
     "bpmn-font": "^0.12.1",
     "camunda-bpmn-moddle": "^4.0.1",
     "chai": "4.1.2",
@@ -111,8 +111,8 @@
   },
   "dependencies": {
     "bpmn-moddle": "^8.1.0",
-    "diagram-js": "^14.0.0",
-    "diagram-js-direct-editing": "^2.1.1",
+    "diagram-js": "^14.3.0",
+    "diagram-js-direct-editing": "^2.1.2",
     "ids": "^1.0.5",
     "inherits-browser": "^0.1.0",
     "min-dash": "^4.1.1",