bpmn-js 17.0.1 → 17.1.0

package/lib/features/modeling/cmd/SplitLaneHandler.js

@@ -3,6 +3,10 @@ import {
   LANE_INDENTATION
 } from '../util/LaneUtil';
 
+import {
+  isHorizontal
+} from '../../../util/DiUtil';
+
 /**
  * @typedef {import('diagram-js/lib/command/CommandHandler').default} CommandHandler
  *
@@ -45,36 +49,41 @@ SplitLaneHandler.prototype.preExecute = function(context) {
     throw new Error(translate('more than {count} child lanes', { count: newLanesCount }));
   }
 
-  var newLanesHeight = Math.round(shape.height / newLanesCount);
+  var isHorizontalLane = isHorizontal(shape);
 
-  // Iterate from top to bottom in child lane order,
+  var laneBaseSize = isHorizontalLane ? shape.height : shape.width;
+  var newLanesSize = Math.round(laneBaseSize / newLanesCount);
+
+  // Iterate from first to last in child lane order,
   // resizing existing lanes and creating new ones
   // so that they split the parent proportionally.
   //
-  // Due to rounding related errors, the bottom lane
+  // Due to rounding related errors, the last lane
   // needs to take up all the remaining space.
-  var laneY,
-      laneHeight,
+  var laneSize,
       laneBounds,
       newLaneAttrs,
       idx;
 
   for (idx = 0; idx < newLanesCount; idx++) {
 
-    laneY = shape.y + idx * newLanesHeight;
-
-    // if bottom lane
+    // if last lane
     if (idx === newLanesCount - 1) {
-      laneHeight = shape.height - (newLanesHeight * idx);
+      laneSize = laneBaseSize - (newLanesSize * idx);
     } else {
-      laneHeight = newLanesHeight;
+      laneSize = newLanesSize;
     }
 
-    laneBounds = {
+    laneBounds = isHorizontalLane ? {
       x: shape.x + LANE_INDENTATION,
-      y: laneY,
+      y: shape.y + idx * newLanesSize,
       width: shape.width - LANE_INDENTATION,
-      height: laneHeight
+      height: laneSize
+    } : {
+      x: shape.x + idx * newLanesSize,
+      y: shape.y + LANE_INDENTATION,
+      width: laneSize,
+      height: shape.height - LANE_INDENTATION
     };
 
     if (idx < existingLanesCount) {
@@ -85,7 +94,8 @@ SplitLaneHandler.prototype.preExecute = function(context) {
 
       // create a new lane at position
       newLaneAttrs = {
-        type: 'bpmn:Lane'
+        type: 'bpmn:Lane',
+        isHorizontal: isHorizontalLane
       };
 
       modeling.createShape(newLaneAttrs, laneBounds, shape);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmn-js",
-  "version": "17.0.1",
+  "version": "17.1.0",
   "description": "A bpmn 2.0 toolkit and web modeler",
   "main": "index.js",
   "files": [