bpmn-elements 13.1.1 → 13.1.2

package/CHANGELOG.md

@@ -1,9 +1,13 @@
 Changelog
 =========
 
+# 13.1.2
+
+- fix another lingering leave message. Now it was the definition execution that kept `process.leave` messages around for sentimental reasons
+
 # 13.1.1
 
-- found the real reason for massive state size - `activity.leave` messages where not acked by process execution. Doh!
+- found the real reason behind ever groving state size - `activity.leave` messages were not acked by process execution. Doh!
 
 # 13.1.0
 

package/dist/definition/DefinitionExecution.js

@@ -412,6 +412,7 @@ DefinitionExecution.prototype._onProcessMessage = function onProcessMessage(rout
       }
     case 'process.error':
       {
+        // message.ack();
         if (inbound && inbound.length) {
           const calledFrom = inbound[0];
           this._getProcessApi({
@@ -454,13 +455,13 @@ DefinitionExecution.prototype._onProcessCompleted = function onProcessCompleted(
     type,
     inbound
   } = message.content;
+  message.ack();
   this._debug(`left <${executionId} (${id})> (${type}), pending runs ${this.postponedCount}`);
   if (inbound && inbound.length) {
     const bp = this._removeProcessByExecutionId(executionId);
     this._deactivateProcess(bp);
   }
   if (!this.postponedCount) {
-    message.ack();
     this._complete('completed');
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmn-elements",
-  "version": "13.1.1",
+  "version": "13.1.2",
   "description": "Executable workflow elements based on BPMN 2.0",
   "type": "module",
   "main": "./dist/index.js",

package/src/definition/DefinitionExecution.js

@@ -422,6 +422,7 @@ DefinitionExecution.prototype._onProcessMessage = function onProcessMessage(rout
       break;
     }
     case 'process.error': {
+      // message.ack();
       if (inbound && inbound.length) {
         const calledFrom = inbound[0];
 
@@ -458,6 +459,7 @@ DefinitionExecution.prototype._onProcessCompleted = function onProcessCompleted(
   if (message.fields.redelivered) return message.ack();
 
   const {id, executionId, type, inbound} = message.content;
+  message.ack();
   this._debug(`left <${executionId} (${id})> (${type}), pending runs ${this.postponedCount}`);
 
   if (inbound && inbound.length) {
@@ -466,7 +468,6 @@ DefinitionExecution.prototype._onProcessCompleted = function onProcessCompleted(
   }
 
   if (!this.postponedCount) {
-    message.ack();
     this._complete('completed');
   }
 };