bpmn-elements 13.1.0 → 13.1.2

package/CHANGELOG.md

@@ -1,6 +1,14 @@
 Changelog
 =========
 
+# 13.1.2
+
+- fix another lingering leave message. Now it was the definition execution that kept `process.leave` messages around for sentimental reasons
+
+# 13.1.1
+
+- found the real reason behind ever groving state size - `activity.leave` messages were not acked by process execution. Doh!
+
 # 13.1.0
 
 - introduce `disableTrackState` setting. Tracking of elements is done by counters, e.g. activity taken or discarded, sequence flow taken and discarded. Counters are saved when getting state. If you run really big flows the state will keep all elements just to be able to recover the number of times an element has been touched. Needless to say it the state will grow out of it's comfort zone. Setting `disableTrackState` to true will only return state for elements that are actually running

package/dist/definition/DefinitionExecution.js

@@ -412,6 +412,7 @@ DefinitionExecution.prototype._onProcessMessage = function onProcessMessage(rout
       }
     case 'process.error':
       {
+        // message.ack();
         if (inbound && inbound.length) {
           const calledFrom = inbound[0];
           this._getProcessApi({
@@ -454,13 +455,13 @@ DefinitionExecution.prototype._onProcessCompleted = function onProcessCompleted(
     type,
     inbound
   } = message.content;
+  message.ack();
   this._debug(`left <${executionId} (${id})> (${type}), pending runs ${this.postponedCount}`);
   if (inbound && inbound.length) {
     const bp = this._removeProcessByExecutionId(executionId);
     this._deactivateProcess(bp);
   }
   if (!this.postponedCount) {
-    message.ack();
     this._complete('completed');
   }
 };

package/dist/process/ProcessExecution.js

@@ -641,6 +641,7 @@ ProcessExecution.prototype._onChildCompleted = function onChildCompleted(message
     message.ack();
     return this._complete('completed');
   }
+  message.ack();
   this._debug(`left <${id}> (${type}), pending runs ${postponedCount}, ${postponed.map(a => a.content.id).join(',')}`);
   if (postponedCount && postponedCount === detachedActivities.length) {
     return this[kActivityQ].queueMessage({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bpmn-elements",
-  "version": "13.1.0",
+  "version": "13.1.2",
   "description": "Executable workflow elements based on BPMN 2.0",
   "type": "module",
   "main": "./dist/index.js",

package/src/definition/DefinitionExecution.js

@@ -422,6 +422,7 @@ DefinitionExecution.prototype._onProcessMessage = function onProcessMessage(rout
       break;
     }
     case 'process.error': {
+      // message.ack();
       if (inbound && inbound.length) {
         const calledFrom = inbound[0];
 
@@ -458,6 +459,7 @@ DefinitionExecution.prototype._onProcessCompleted = function onProcessCompleted(
   if (message.fields.redelivered) return message.ack();
 
   const {id, executionId, type, inbound} = message.content;
+  message.ack();
   this._debug(`left <${executionId} (${id})> (${type}), pending runs ${this.postponedCount}`);
 
   if (inbound && inbound.length) {
@@ -466,7 +468,6 @@ DefinitionExecution.prototype._onProcessCompleted = function onProcessCompleted(
   }
 
   if (!this.postponedCount) {
-    message.ack();
     this._complete('completed');
   }
 };

package/src/process/ProcessExecution.js

@@ -635,6 +635,7 @@ ProcessExecution.prototype._onChildCompleted = function onChildCompleted(message
     return this._complete('completed');
   }
 
+  message.ack();
   this._debug(`left <${id}> (${type}), pending runs ${postponedCount}, ${postponed.map((a) => a.content.id).join(',')}`);
 
   if (postponedCount && postponedCount === detachedActivities.length) {