botium-core 1.14.1 → 1.14.4

package/test/scripting/asserters/convos/convo_step_parameter_matchmode_failed_wer.convo.txt

@@ -0,0 +1,9 @@
+convo_step_parameter_matchmode_failed_wer
+
+#me
+Hello1
+
+#bot
+You said Hello1 Hello2 Hello3 Hello4
+CONVO_STEP_PARAMETERS {"matchingMode":"wer","matchingModeWer":25}
+

package/test/scripting/asserters/convos/convo_step_parameter_retry_asserters_all_good.convo.txt

@@ -0,0 +1,9 @@
+convo_step_parameter_retry_asserters_good
+
+#me
+Hello
+Button
+
+#bot
+BUTTONS button1|button2
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 200, "allAsserters": true}}

package/test/scripting/asserters/convos/convo_step_parameter_retry_asserters_botium_timeout.convo.txt

@@ -0,0 +1,9 @@
+convo_step_parameter_retry_asserters_good
+
+#me
+Hello
+Button
+
+#bot
+BUTTONS button1|buttonXXXXXX
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 200, "asserters": ["BUTTONS"]}}

package/test/scripting/asserters/convos/convo_step_parameter_retry_asserters_good.convo.txt

@@ -0,0 +1,9 @@
+convo_step_parameter_retry_asserters_good
+
+#me
+Hello
+Button
+
+#bot
+BUTTONS button1|button2
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 200, "asserters": ["BUTTONS"]}}

package/test/scripting/asserters/convos/convo_step_parameter_retry_asserters_good_global.convo.txt

@@ -0,0 +1,9 @@
+convo_step_parameter_retry_asserters_good_global
+
+
+#me
+Hello1
+Intent
+
+#bot
+INTENT someIntent

package/test/scripting/asserters/convos/convo_step_parameter_retry_main_and_asserter.convo.txt

@@ -0,0 +1,10 @@
+convo_step_parameter_retry_main_and_asserter
+
+#me
+Butt
+Button
+
+#bot
+You said Butt
+BUTTONS button1|button2
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 200, "mainAsserter": true, "allAsserters": true}}

package/test/scripting/asserters/convos/convo_step_parameter_retry_main_botium_timeout.convo.txt

@@ -0,0 +1,9 @@
+convo_step_parameter_retry_main_botium_timeout
+
+#me
+Hello1
+Hello2
+
+#bot
+You said Hello3
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 200, "mainAsserter": true}}

package/test/scripting/asserters/convos/convo_step_parameter_retry_main_but_no_button.convo.txt

@@ -0,0 +1,10 @@
+convo_step_parameter_retry_main_but_no_button
+
+#me
+Hello1
+Hello2
+
+#bot
+You said Hello2
+BUTTONS some not existing button
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 200, "mainAsserter": true}}

package/test/scripting/asserters/convos/convo_step_parameter_retry_main_good.convo.txt

@@ -0,0 +1,9 @@
+convo_step_parameter_retry_main_good
+
+#me
+Hello1
+Hello2
+
+#bot
+You said Hello2
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 201, "mainAsserter": true}}

package/test/scripting/asserters/convos/convo_step_parameter_retry_main_good_begin.convo.txt

@@ -0,0 +1,11 @@
+convo_step_parameter_retry_main_good_begin
+
+#begin
+CONVO_STEP_PARAMETERS {"ignoreNotMatchedBotResponses": {"timeout": 200, "mainAsserter": true}}
+
+#me
+Hello1
+Hello2
+
+#bot
+You said Hello2

package/test/scripting/logichooks/convos/scripting_memory_overwrite_and_check.convo.txt

@@ -7,7 +7,7 @@ this is a variable: VARVALUE1
 this is a variable: $myvar
 
 #me
-this is a variable: VARVALUE2 
+this is a variable: VARVALUE2
 
 #bot
-this is a variable: $myvar
+this is a variable: $myvar

package/test/scripting/matching/matchingmode.spec.js

@@ -207,7 +207,10 @@ describe('scripting.matching.matchingmode', function () {
         'umm',
         'interesting',
         'really?'
-      ], 'test')
+      ],
+      'test',
+      null,
+      {})
     })
   })
 

package/test/scripting/scriptingProvider.spec.js

@@ -5,6 +5,7 @@ const { Convo } = require('../../src/scripting/Convo')
 const ScriptingProvider = require('../../src/scripting/ScriptingProvider')
 const DefaultCapabilities = require('../../src/Defaults').Capabilities
 const Capabilities = require('../../src/Capabilities')
+const { LOGIC_HOOK_EVENTS } = require('../../src/scripting/logichook/LogicHookConsts')
 
 describe('scripting.scriptingProvider', function () {
   describe('ReadScriptsFromDirectory', function () {
@@ -65,7 +66,7 @@ describe('scripting.scriptingProvider', function () {
       assert.equal(tomatch.length, 2)
       assert.equal(tomatch[0], 'TEXT1')
       assert.equal(tomatch[1], 'TEXT2')
-      scriptingContext.scriptingEvents.assertBotResponse('TEXT1', tomatch, 'test1')
+      scriptingContext.scriptingEvents.assertBotResponse('TEXT1', tomatch, 'test1', null, {})
     })
     it('should resolve multiple utterance', async function () {
       const scriptingProvider = new ScriptingProvider(DefaultCapabilities)
@@ -85,7 +86,7 @@ describe('scripting.scriptingProvider', function () {
       assert.equal(tomatchUtt1.length, 2)
       assert.equal(tomatchUtt1[0], 'TEXT1')
       assert.equal(tomatchUtt1[1], 'TEXT2')
-      scriptingContext.scriptingEvents.assertBotResponse('TEXT1', tomatchUtt1, 'test1')
+      scriptingContext.scriptingEvents.assertBotResponse('TEXT1', tomatchUtt1, 'test1', null, {})
       const tomatchUtt2 = scriptingContext.scriptingEvents.resolveUtterance({ utterance: 'utt2' })
       assert.isArray(tomatchUtt2)
       assert.equal(tomatchUtt2.length, 2)
@@ -121,7 +122,7 @@ describe('scripting.scriptingProvider', function () {
       assert.equal(tomatch.length, 1)
       assert.equal(tomatch[0], 'utt2')
       try {
-        scriptingContext.scriptingEvents.assertBotResponse('TEXT1', tomatch, 'test1')
+        scriptingContext.scriptingEvents.assertBotResponse('TEXT1', tomatch, 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.isTrue(err.message.indexOf('Bot response') > 0)
@@ -141,7 +142,7 @@ describe('scripting.scriptingProvider', function () {
         utterances: ['TEXT1', 'TEXT2']
       })
       try {
-        scriptingContext.scriptingEvents.assertBotResponse('TEXT1', 'utt1', 'test1')
+        scriptingContext.scriptingEvents.assertBotResponse('TEXT1', 'utt1', 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.isTrue(err.message.indexOf('Bot response') > 0)
@@ -166,7 +167,7 @@ describe('scripting.scriptingProvider', function () {
       assert.equal(tomatch.length, 2)
       assert.equal(tomatch[0], 'TEXT1 hello')
       assert.equal(tomatch[1], 'TEXT2 hello')
-      scriptingContext.scriptingEvents.assertBotResponse('TEXT1 hello', tomatch, 'test1')
+      scriptingContext.scriptingEvents.assertBotResponse('TEXT1 hello', tomatch, 'test1', null, {})
     })
     it('should resolve and append utterance args', async function () {
       const scriptingProvider = new ScriptingProvider(DefaultCapabilities)
@@ -182,7 +183,7 @@ describe('scripting.scriptingProvider', function () {
       assert.equal(tomatch.length, 2)
       assert.equal(tomatch[0], 'TEXT1 hello')
       assert.equal(tomatch[1], 'TEXT2 hello')
-      scriptingContext.scriptingEvents.assertBotResponse('TEXT1 hello', tomatch, 'test1')
+      scriptingContext.scriptingEvents.assertBotResponse('TEXT1 hello', tomatch, 'test1', null, {})
     })
 
     describe('should resolve utterance with ambiguous scripting memory variable (with a debug message)', function () {
@@ -909,7 +910,7 @@ describe('scripting.scriptingProvider', function () {
       await scriptingProvider.Build()
       const scriptingContext = scriptingProvider._buildScriptContext()
       try {
-        scriptingContext.scriptingEvents.assertBotResponse('actual', 'expected', 'test1')
+        scriptingContext.scriptingEvents.assertBotResponse('actual', 'expected', 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.equal(err.message, 'test1: Bot response "actual" expected to match "expected"')
@@ -920,7 +921,7 @@ describe('scripting.scriptingProvider', function () {
       await scriptingProvider.Build()
       const scriptingContext = scriptingProvider._buildScriptContext()
       try {
-        scriptingContext.scriptingEvents.assertBotResponse(null, 'expected', 'test1')
+        scriptingContext.scriptingEvents.assertBotResponse(null, 'expected', 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.equal(err.message, 'test1: Bot response <no response> expected to match "expected"')
@@ -931,7 +932,7 @@ describe('scripting.scriptingProvider', function () {
       await scriptingProvider.Build()
       const scriptingContext = scriptingProvider._buildScriptContext()
       try {
-        scriptingContext.scriptingEvents.assertBotResponse('actual', ['expected1', 'expected2'], 'test1')
+        scriptingContext.scriptingEvents.assertBotResponse('actual', ['expected1', 'expected2'], 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.equal(err.message, 'test1: Bot response "actual" expected to match one of "expected1", "expected2"')
@@ -945,7 +946,7 @@ describe('scripting.scriptingProvider', function () {
       await scriptingProvider.Build()
       const scriptingContext = scriptingProvider._buildScriptContext()
       try {
-        scriptingContext.scriptingEvents.assertBotNotResponse('Keine Antwort gefunden!', ['Keine Antwort gefunden'], 'test1')
+        scriptingContext.scriptingEvents.assertBotNotResponse('Keine Antwort gefunden!', ['Keine Antwort gefunden'], 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.equal(err.message, 'test1: Bot response "Keine Antwort gefunden!" expected NOT to match "Keine Antwort gefunden"')
@@ -956,7 +957,7 @@ describe('scripting.scriptingProvider', function () {
       await scriptingProvider.Build()
       const scriptingContext = scriptingProvider._buildScriptContext()
       try {
-        scriptingContext.scriptingEvents.assertBotNotResponse('Keine Antwort gefunden!', [''], 'test1')
+        scriptingContext.scriptingEvents.assertBotNotResponse('Keine Antwort gefunden!', [''], 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.equal(err.message, 'test1: Bot response "Keine Antwort gefunden!" expected NOT to match <any response>')
@@ -967,11 +968,36 @@ describe('scripting.scriptingProvider', function () {
       await scriptingProvider.Build()
       const scriptingContext = scriptingProvider._buildScriptContext()
       try {
-        scriptingContext.scriptingEvents.assertBotNotResponse('', [''], 'test1')
+        scriptingContext.scriptingEvents.assertBotNotResponse('', [''], 'test1', null, {})
         assert.fail('expected error')
       } catch (err) {
         assert.equal(err.message, 'test1: Bot response <no response> expected NOT to match <any response>')
       }
     })
   })
+
+  describe('should call logichooks and userinputs even if there is no convo (logichook from livechat, and crawler)', function () {
+    LOGIC_HOOK_EVENTS.forEach(async (eventName) => {
+      it(`Logichook, event: ${eventName}`, async function () {
+        const scriptingProvider = new ScriptingProvider(Object.assign({}, DefaultCapabilities, {
+          [Capabilities.LOGIC_HOOKS]: [{
+            ref: 'SET_TEXT_FROM_HOOK',
+            src: {
+              [eventName]: ({ someobject, args }) => {
+                someobject.testAttribute = 'testAttributeValue'
+              }
+            },
+            global: true
+          }]
+        }))
+        await scriptingProvider.Build()
+        const scriptingContext = scriptingProvider._buildScriptContext()
+        const someobject = {}
+        await scriptingContext.scriptingEvents[eventName]({
+          someobject
+        })
+        assert.equal(someobject.testAttribute, 'testAttributeValue')
+      })
+    })
+  })
 })