botium-core 1.13.4 → 1.13.5

package/test/convo/transcript.spec.js

@@ -398,4 +398,13 @@ describe('convo.transcript', function () {
       assert.equal(err.transcript.steps.length, 5)
     }
   })
+  it('should calculate assertion count', async function () {
+    this.compiler.ReadScript(path.resolve(__dirname, 'convos'), '2steps.convo.txt')
+    assert.equal(this.compiler.convos.length, 1)
+    assert.equal(this.compiler.GetAssertionCount(this.compiler.convos[0]), 2)
+
+    this.compiler.ReadScript(path.resolve(__dirname, 'convos'), 'asserters.convo.txt')
+    assert.equal(this.compiler.convos.length, 2)
+    assert.equal(this.compiler.GetAssertionCount(this.compiler.convos[1]), 1)
+  })
 })

package/test/scripting/asserters/intentConfidenceAsserter.spec.js

@@ -61,16 +61,12 @@ describe('scripting.asserters.intentConfidenceAsserter', function () {
     [false, 80, 85, false]
   ]
 
-  cases.forEach((cse) => {
-    const useWithGlobal = cse[0]
-    const expected = cse[1]
-    const found = cse[2]
-    const negative = cse[3]
+  for (const [useWithGlobal, expected, found, negative] of cases) {
     const message = `${negative ? 'negative' : 'positive'} case for intent confidence asserter ${useWithGlobal ? 'with global args' : 'without global args'}, exp: ${expected}, found: ${found}`
     it(message,
       async function () {
-        return _assert(...cse)
+        return _assert(useWithGlobal, expected, found, negative)
       }
     )
-  })
+  }
 })

package/test/scripting/scriptingProvider.spec.js

@@ -293,6 +293,48 @@ describe('scripting.scriptingProvider', function () {
       assert.equal(scriptingProvider.convos[1].header.name, 'test convo/utt1-L2')
       assert.equal(scriptingProvider.convos[1].conversation[0].messageText, 'TEXT2')
     })
+    it('should build convos for utterance using iterator', async function () {
+      const scriptingProvider = new ScriptingProvider(DefaultCapabilities)
+      await scriptingProvider.Build()
+      scriptingProvider.AddUtterances({
+        name: 'utt1',
+        utterances: ['TEXT1', 'TEXT2']
+      })
+      scriptingProvider.AddConvos(new Convo(scriptingProvider._buildScriptContext(), {
+        header: {
+          name: 'test convo'
+        },
+        conversation: [
+          {
+            sender: 'me',
+            messageText: 'utt1'
+          }
+        ]
+      }))
+
+      scriptingProvider.ExpandConvosIterable()
+      const expected = [
+        {
+          header: { name: 'test convo/utt1-L1' },
+          conversation: [{ messageText: 'TEXT1' }]
+        },
+        {
+          header: { name: 'test convo/utt1-L2' },
+          conversation: [{ messageText: 'TEXT2' }]
+        }
+      ]
+      let i = 0
+      for (const c of scriptingProvider.convosIterable) {
+        const exp = expected[i++]
+        assert.equal(c.header.name, exp.header.name)
+        assert.equal(c.conversation.length, exp.conversation.length)
+        assert.deepEqual(c.conversation.map(s => s.messageText), exp.conversation.map(s => s.messageText))
+      }
+      assert.equal(i, 2)
+      // scriptingProvider.convosIterable.forEach((iteratedConvo, index) => {
+      //   assert.deepEqual(iteratedConvo, expected[index])
+      // })
+    })
     it('should build convos for utterance with parameters', async function () {
       const scriptingProvider = new ScriptingProvider(DefaultCapabilities)
       await scriptingProvider.Build()
@@ -350,10 +392,12 @@ describe('scripting.scriptingProvider', function () {
       assert.equal(scriptingProvider.convos[1].conversation[0].messageText, 'TEXT2')
     })
     describe('should build convos for SCRIPTING_UTTEXPANSION_NAMING_MODE', function () {
-      const utterances = {
-        name: 'uttText',
-        utterances: ['TEXT1 01234567890123456789', 'TEXT2 01234567890123456789']
-      }
+      const utterances = [
+        {
+          name: 'uttText',
+          utterances: ['TEXT1 01234567890123456789', 'TEXT2 01234567890123456789']
+        }
+      ]
       const convoUtterances = {
         header: {
           name: 'test convo'
@@ -397,7 +441,38 @@ describe('scripting.scriptingProvider', function () {
         assert.equal(scriptingProvider.convos[0].header.name, 'test convo/uttText-L1-TEXT1 0123456...')
         assert.equal(scriptingProvider.convos[1].header.name, 'test convo/uttText-L2-TEXT2 0123456...')
       })
+      it('SCRIPTING_UTTEXPANSION_NAMING_MODE=utterance len=1', async function () {
+        const scriptingProvider = new ScriptingProvider(Object.assign(
+          {},
+          DefaultCapabilities,
+          {
+            [Capabilities.SCRIPTING_UTTEXPANSION_NAMING_MODE]: 'utterance'
+          }
+        ))
+        await scriptingProvider.Build()
+        scriptingProvider.AddUtterances([
+          {
+            name: 'uttText1',
+            utterances: ['TEXT1 01234567890123456789']
+          }
+        ])
+        scriptingProvider.AddConvos(new Convo(scriptingProvider._buildScriptContext(), {
+          header: {
+            name: 'test convo'
+          },
+          conversation: [
+            {
+              sender: 'me',
+              messageText: 'uttText1'
+            }
+          ]
+        }))
 
+        scriptingProvider.ExpandConvos()
+        assert.equal(scriptingProvider.convos.length, 1)
+        assert.equal(scriptingProvider.convos[0].conversation.length, 1)
+        assert.equal(scriptingProvider.convos[0].header.name, 'test convo')
+      })
       it('SCRIPTING_UTTEXPANSION_NAMING_MODE=utterance, turn length off', async function () {
         const scriptingProvider = new ScriptingProvider(Object.assign(
           {},
@@ -475,6 +550,42 @@ describe('scripting.scriptingProvider', function () {
         assert.equal(scriptingProvider.convos[1].header.name, 'test convo/MEDIA-L2-test2 0123456...')
         assert.equal(scriptingProvider.convos[2].header.name, 'test convo/MEDIA-L3-test3.jpg')
       })
+      it('SCRIPTING_UTTEXPANSION_NAMING_MODE=utterance userinputs len=1', async function () {
+        const scriptingProvider = new ScriptingProvider(Object.assign(
+          {},
+          DefaultCapabilities,
+          {
+            [Capabilities.SCRIPTING_UTTEXPANSION_NAMING_MODE]: 'utterance'
+          }
+        ))
+        await scriptingProvider.Build()
+        scriptingProvider.AddConvos(new Convo(scriptingProvider._buildScriptContext(), {
+          header: {
+            name: 'test convo'
+          },
+          sourceTag: {},
+          conversation: [
+            {
+              sender: 'me',
+              userInputs: [
+                {
+                  name: 'BUTTON',
+                  args: ['button1']
+                },
+                {
+                  name: 'MEDIA',
+                  args: ['test1.jpg']
+                }
+              ]
+            }
+          ]
+        }))
+
+        scriptingProvider.ExpandConvos()
+        assert.equal(scriptingProvider.convos.length, 1)
+        assert.equal(scriptingProvider.convos[0].conversation.length, 1)
+        assert.equal(scriptingProvider.convos[0].header.name, 'test convo')
+      })
       it('SCRIPTING_UTTEXPANSION_NAMING_MODE=utterance userinputs and utterances', async function () {
         const scriptingProvider = new ScriptingProvider(Object.assign(
           {},
@@ -518,6 +629,47 @@ describe('scripting.scriptingProvider', function () {
         assert.equal(scriptingProvider.convos[4].header.name, 'test convo/uttText-L2-TEXT2 0123456...')
       })
     })
+    describe('should have be possible to generate / store convos partially', function () {
+      const _createConvos = async () => {
+        const scriptingProvider = new ScriptingProvider(DefaultCapabilities)
+        await scriptingProvider.Build()
+        scriptingProvider.AddUtterances({
+          name: 'utt1',
+          utterances: ['TEXT1', 'TEXT2', 'TEXT3', 'TEXT4', 'TEXT5']
+        })
+        scriptingProvider.AddConvos(new Convo(scriptingProvider._buildScriptContext(), {
+          header: {
+            name: 'test convo'
+          },
+          conversation: [
+            {
+              sender: 'me',
+              messageText: 'utt1'
+            },
+            {
+              sender: 'bot',
+              messageText: 'some text'
+            },
+            {
+              sender: 'me',
+              messageText: 'utt1'
+            }
+          ]
+        }))
+        return scriptingProvider
+      }
+
+      it('should build convos with nulls (to detect convo count)', async function () {
+        const scriptingProvider = await _createConvos()
+        scriptingProvider.ExpandConvos({ justHeader: true })
+        assert.equal(scriptingProvider.convos.length, 25)
+        for (let i = 0; i < 25; i++) {
+          const keys = Object.keys(scriptingProvider.convos[i])
+          assert.equal(keys.length, 1)
+          assert.equal(keys[0], 'header')
+        }
+      })
+    })
   })
 
   describe('ExpandUtterancesToConvos', function () {

package/test/scripting/utteranceexpansion/associateByIndex.spec.js

@@ -70,15 +70,15 @@ describe('scripting.utteranceexpansion.associateByIndex', function () {
     scriptingProvider.ExpandConvos()
 
     assert.equal(scriptingProvider.convos.length, 5)
-    assert.equal(scriptingProvider.convos[0].header.name, 'test convo/UTT_HELLO-L1/UTT_BODY-L1/UTT_GOODBYE-L1')
+    assert.equal(scriptingProvider.convos[0].header.name, 'test convo/UTT_HELLO-L1/UTT_GOODBYE-L1')
     assert.deepEqual(scriptingProvider.convos[0].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[1].header.name, 'test convo/UTT_HELLO-L2/UTT_BODY-L1/UTT_GOODBYE-L2')
+    assert.equal(scriptingProvider.convos[1].header.name, 'test convo/UTT_HELLO-L2/UTT_GOODBYE-L2')
     assert.deepEqual(scriptingProvider.convos[1].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[2].header.name, 'test convo/UTT_HELLO-L3/UTT_BODY-L1/UTT_GOODBYE-L3')
+    assert.equal(scriptingProvider.convos[2].header.name, 'test convo/UTT_HELLO-L3/UTT_GOODBYE-L3')
     assert.deepEqual(scriptingProvider.convos[2].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[3].header.name, 'test convo/UTT_HELLO-L3/UTT_BODY-L1/UTT_GOODBYE-L4')
+    assert.equal(scriptingProvider.convos[3].header.name, 'test convo/UTT_HELLO-L3/UTT_GOODBYE-L4')
     assert.deepEqual(scriptingProvider.convos[3].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[4].header.name, 'test convo/UTT_HELLO-L3/UTT_BODY-L1/UTT_GOODBYE-L5')
+    assert.equal(scriptingProvider.convos[4].header.name, 'test convo/UTT_HELLO-L3/UTT_GOODBYE-L5')
     assert.deepEqual(scriptingProvider.convos[4].conversation.length, 6)
   })
   it('should associate media by index', async function () {
@@ -140,15 +140,15 @@ describe('scripting.utteranceexpansion.associateByIndex', function () {
     scriptingProvider.ExpandConvos()
 
     assert.equal(scriptingProvider.convos.length, 5)
-    assert.equal(scriptingProvider.convos[0].header.name, 'test convo/MEDIA-L1/MEDIA-L1/MEDIA-L1')
+    assert.equal(scriptingProvider.convos[0].header.name, 'test convo/MEDIA-step0voice0.wav/MEDIA-step2voice0.wav')
     assert.deepEqual(scriptingProvider.convos[0].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[1].header.name, 'test convo/MEDIA-L2/MEDIA-L1/MEDIA-L2')
+    assert.equal(scriptingProvider.convos[1].header.name, 'test convo/MEDIA-step0voice1.wav/MEDIA-step2voice1.wav')
     assert.deepEqual(scriptingProvider.convos[1].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[2].header.name, 'test convo/MEDIA-L3/MEDIA-L1/MEDIA-L3')
+    assert.equal(scriptingProvider.convos[2].header.name, 'test convo/MEDIA-step0voice2.wav/MEDIA-step2voice2.wav')
     assert.deepEqual(scriptingProvider.convos[2].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[3].header.name, 'test convo/MEDIA-L3/MEDIA-L1/MEDIA-L4')
+    assert.equal(scriptingProvider.convos[3].header.name, 'test convo/MEDIA-step0voice2.wav/MEDIA-step2voice4.wav')
     assert.deepEqual(scriptingProvider.convos[3].conversation.length, 6)
-    assert.equal(scriptingProvider.convos[4].header.name, 'test convo/MEDIA-L3/MEDIA-L1/MEDIA-L5')
+    assert.equal(scriptingProvider.convos[4].header.name, 'test convo/MEDIA-step0voice2.wav/MEDIA-step2voice5.wav')
     assert.deepEqual(scriptingProvider.convos[4].conversation.length, 6)
   })
   it('should associate utterance and media by index', async function () {
@@ -245,15 +245,15 @@ describe('scripting.utteranceexpansion.associateByIndex', function () {
     scriptingProvider.ExpandConvos()
 
     assert.equal(scriptingProvider.convos.length, 5)
-    assert.equal(scriptingProvider.convos[0].header.name, 'test convo/UTT_HELLO-L1/UTT_BODY-L1/UTT_GOODBYE-L1/MEDIA-L1/MEDIA-L1/MEDIA-L1')
+    assert.equal(scriptingProvider.convos[0].header.name, 'test convo/UTT_HELLO-L1/UTT_GOODBYE-L1/MEDIA-step0voice0.wav/MEDIA-step2voice0.wav')
     assert.deepEqual(scriptingProvider.convos[0].conversation.length, 12)
-    assert.equal(scriptingProvider.convos[1].header.name, 'test convo/UTT_HELLO-L2/UTT_BODY-L1/UTT_GOODBYE-L2/MEDIA-L2/MEDIA-L1/MEDIA-L2')
+    assert.equal(scriptingProvider.convos[1].header.name, 'test convo/UTT_HELLO-L2/UTT_GOODBYE-L2/MEDIA-step0voice1.wav/MEDIA-step2voice1.wav')
     assert.deepEqual(scriptingProvider.convos[1].conversation.length, 12)
-    assert.equal(scriptingProvider.convos[2].header.name, 'test convo/UTT_HELLO-L3/UTT_BODY-L1/UTT_GOODBYE-L3/MEDIA-L3/MEDIA-L1/MEDIA-L3')
+    assert.equal(scriptingProvider.convos[2].header.name, 'test convo/UTT_HELLO-L3/UTT_GOODBYE-L3/MEDIA-step0voice2.wav/MEDIA-step2voice2.wav')
     assert.deepEqual(scriptingProvider.convos[2].conversation.length, 12)
-    assert.equal(scriptingProvider.convos[3].header.name, 'test convo/UTT_HELLO-L3/UTT_BODY-L1/UTT_GOODBYE-L4/MEDIA-L3/MEDIA-L1/MEDIA-L4')
+    assert.equal(scriptingProvider.convos[3].header.name, 'test convo/UTT_HELLO-L3/UTT_GOODBYE-L4/MEDIA-step0voice2.wav/MEDIA-step2voice4.wav')
     assert.deepEqual(scriptingProvider.convos[3].conversation.length, 12)
-    assert.equal(scriptingProvider.convos[4].header.name, 'test convo/UTT_HELLO-L3/UTT_BODY-L1/UTT_GOODBYE-L5/MEDIA-L3/MEDIA-L1/MEDIA-L5')
+    assert.equal(scriptingProvider.convos[4].header.name, 'test convo/UTT_HELLO-L3/UTT_GOODBYE-L5/MEDIA-step0voice2.wav/MEDIA-step2voice5.wav')
     assert.deepEqual(scriptingProvider.convos[4].conversation.length, 12)
   })
 })