botium-core 1.13.15 → 1.13.17

package/index.js

@@ -12,6 +12,8 @@ module.exports = {
   HookUtils: require('./src/helpers/HookUtils'),
   TranscriptUtils: require('./src/helpers/TranscriptUtils'),
 
+  RetryHelper: require('./src/helpers/RetryHelper'),
+
   BotiumMockRichMessageTypes: require('./src/mocks/BotiumMockRichMessageTypes'),
 
   BotiumError: require('./src/scripting/BotiumError').BotiumError,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "botium-core",
-  "version": "1.13.15",
+  "version": "1.13.17",
   "description": "The Selenium for Chatbots",
   "main": "index.js",
   "module": "dist/botium-es.js",
@@ -32,66 +32,66 @@
   },
   "homepage": "https://www.botium.ai",
   "dependencies": {
-    "@babel/runtime": "^7.20.6",
+    "@babel/runtime": "^7.21.5",
     "async": "^3.2.4",
-    "body-parser": "^1.20.1",
+    "body-parser": "^1.20.2",
     "boolean": "^3.2.0",
     "bottleneck": "^2.19.5",
-    "csv-parse": "^5.3.3",
+    "csv-parse": "^5.3.10",
     "debug": "^4.3.4",
     "esprima": "^4.0.1",
     "express": "^4.18.2",
     "globby": "11.0.4",
-    "ioredis": "^5.2.4",
+    "ioredis": "^5.3.2",
     "is-class": "^0.0.9",
     "is-json": "^2.0.1",
     "jsonpath": "^1.1.1",
     "lodash": "^4.17.21",
     "markdown-it": "^13.0.1",
     "mime-types": "^2.1.35",
-    "mkdirp": "^1.0.4",
+    "mkdirp": "^3.0.1",
     "moment": "^2.29.4",
     "mustache": "^4.2.0",
     "promise-retry": "^2.0.1",
     "promise.allsettled": "^1.0.6",
     "randomatic": "^3.1.1",
     "request": "^2.88.2",
-    "rimraf": "^3.0.2",
+    "rimraf": "^5.0.0",
     "sanitize-filename": "^1.6.3",
-    "slugify": "^1.6.5",
-    "socket.io": "^4.5.4",
-    "socket.io-client": "^4.5.4",
+    "slugify": "^1.6.6",
+    "socket.io": "^4.6.1",
+    "socket.io-client": "^4.6.1",
     "socketio-auth": "^0.1.1",
-    "swagger-jsdoc": "^6.2.5",
-    "swagger-ui-express": "^4.6.0",
+    "swagger-jsdoc": "^6.2.8",
+    "swagger-ui-express": "^4.6.3",
     "uuid": "^9.0.0",
-    "vm2": "^3.9.13",
+    "vm2": "^3.9.17",
     "word-error-rate": "0.0.7",
     "write-yaml": "^1.0.0",
     "xlsx": "^0.18.5",
     "xregexp": "^5.1.1",
-    "yaml": "^2.1.3"
+    "yaml": "^2.2.2"
   },
   "devDependencies": {
-    "@babel/core": "^7.20.5",
-    "@babel/node": "^7.20.5",
-    "@babel/plugin-transform-runtime": "^7.19.6",
-    "@babel/preset-env": "^7.20.2",
+    "@babel/core": "^7.21.8",
+    "@babel/node": "^7.20.7",
+    "@babel/plugin-transform-runtime": "^7.21.4",
+    "@babel/preset-env": "^7.21.5",
     "chai": "^4.3.7",
     "chai-as-promised": "^7.1.1",
     "cross-env": "^7.0.3",
-    "eslint": "^8.29.0",
+    "eslint": "^8.40.0",
     "eslint-config-standard": "^17.0.0",
-    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-mocha": "^10.1.0",
-    "eslint-plugin-n": "^15.6.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-promise": "^6.1.1",
     "eslint-plugin-standard": "^4.1.0",
     "license-checker": "^25.0.1",
     "license-compatibility-checker": "^0.3.5",
     "mocha": "^10.2.0",
-    "nock": "^13.2.9",
-    "npm-check-updates": "^16.5.6",
+    "nock": "^13.3.1",
+    "npm-check-updates": "^16.10.12",
     "nyc": "^15.1.0",
     "rollup": "2.79.1",
     "rollup-plugin-babel": "^4.4.0",

package/src/BotDriver.js

@@ -2,8 +2,8 @@ const util = require('util')
 const fs = require('fs')
 const path = require('path')
 const async = require('async')
-const rimraf = require('rimraf')
-const mkdirp = require('mkdirp')
+const { rimraf } = require('rimraf')
+const { mkdirpSync } = require('mkdirp')
 const sanitize = require('sanitize-filename')
 const moment = require('moment')
 const randomize = require('randomatic')
@@ -130,7 +130,7 @@ module.exports = class BotDriver {
         (tempDirectoryCreated) => {
           tempDirectory = path.resolve(process.cwd(), this.caps[Capabilities.TEMPDIR], sanitize(`${this.caps[Capabilities.PROJECTNAME]} ${moment().format('YYYYMMDD HHmmss')} ${randomize('Aa0', 5)}`))
           try {
-            mkdirp.sync(tempDirectory)
+            mkdirpSync(tempDirectory)
             tempDirectoryCreated()
           } catch (err) {
             tempDirectoryCreated(new Error(`Unable to create temp directory ${tempDirectory}: ${err.message}`))
@@ -168,9 +168,7 @@ module.exports = class BotDriver {
           debug(`BotDriver Build error: ${err}`)
           this.eventEmitter.emit(Events.CONTAINER_BUILD_ERROR, err)
           if (tempDirectory) {
-            rimraf(tempDirectory, (err) => {
-              if (err) debug(`Cleanup temp dir ${tempDirectory} failed: ${util.inspect(err)}`)
-            })
+            rimraf(tempDirectory).catch((err) => debug(`Cleanup temp dir ${tempDirectory} failed: ${util.inspect(err)}`))
           }
           return reject(err)
         }

package/src/Events.js

@@ -13,6 +13,7 @@ module.exports = {
   CONTAINER_CLEANED: 'CONTAINER_CLEANED',
   CONTAINER_CLEAN_ERROR: 'CONTAINER_CLEAN_ERROR',
   BOT_CONNECTED: 'BOT_CONNECTED',
+  CONVO_STEP_NEXT: 'CONVO_STEP_NEXT',
   // Chatbot Events
   MESSAGE_SENTTOBOT: 'MESSAGE_SENTTOBOT',
   MESSAGE_SENDTOBOT_ERROR: 'MESSAGE_SENDTOBOT_ERROR',

package/src/containers/BaseContainer.js

@@ -1,6 +1,6 @@
 const util = require('util')
 const async = require('async')
-const rimraf = require('rimraf')
+const { rimraf } = require('rimraf')
 const Bottleneck = require('bottleneck')
 const _ = require('lodash')
 const request = require('request')
@@ -173,10 +173,9 @@ module.exports = class BaseContainer {
         (rimraffed) => {
           if (this.caps[Capabilities.CLEANUPTEMPDIR]) {
             debug(`Cleanup rimrafing temp dir ${this.tempDirectory}`)
-            rimraf(this.tempDirectory, (err) => {
-              if (err) debug(`Cleanup temp dir ${this.tempDirectory} failed: ${util.inspect(err)}`)
-              rimraffed()
-            })
+            rimraf(this.tempDirectory)
+              .catch((err) => debug(`Cleanup temp dir ${this.tempDirectory} failed: ${util.inspect(err)}`))
+              .finally(() => rimraffed())
           } else {
             rimraffed()
           }

package/src/scripting/Convo.js

@@ -1,7 +1,6 @@
 const util = require('util')
 const _ = require('lodash')
 const debug = require('debug')('botium-core-Convo')
-const promiseRetry = require('promise-retry')
 
 const BotiumMockMessage = require('../mocks/BotiumMockMessage')
 const Capabilities = require('../Capabilities')
@@ -9,7 +8,6 @@ const Events = require('../Events')
 const ScriptingMemory = require('./ScriptingMemory')
 const { BotiumError, botiumErrorFromErr, botiumErrorFromList } = require('./BotiumError')
 const { normalizeText, toString, removeBuffers, splitStringInNonEmptyLines } = require('./helper')
-const RetryHelper = require('../helpers/RetryHelper')
 
 const { LOGIC_HOOK_INCLUDE } = require('./logichook/LogicHookConsts')
 
@@ -212,24 +210,6 @@ class Convo {
   }
 
   async Run (container) {
-    const retryHelper = new RetryHelper(container.caps, 'CONVO')
-    return promiseRetry(async (retry, number) => {
-      return this.RunImpl(container).catch(err => {
-        const retryRemaining = retryHelper.retrySettings.retries - number + 1
-        if (retryHelper.shouldRetry(err)) {
-          debug(`Convo failed with error "${err.message || JSON.stringify(err)}". Retry ${retryRemaining > 0 ? 'enabled' : 'disabled'} (remaining #${retryRemaining}/${retryHelper.retrySettings.retries}, criterion matches)`)
-          retry(err)
-        } else {
-          if (retryHelper.retryErrorPatterns.length > 0) {
-            debug(`Convo failed with error "${err.message || JSON.stringify(err)}". Retry 'disabled' (remaining (#${retryRemaining}/${retryHelper.retrySettings.retries}), criterion does not match)`)
-          }
-          throw err
-        }
-      })
-    }, retryHelper.retrySettings)
-  }
-
-  async RunImpl (container) {
     const transcript = new Transcript({
       steps: [],
       attachments: [],
@@ -298,6 +278,7 @@ class Convo {
       for (let i = 0; i < this.conversation.length; i++) {
         const convoStep = this.conversation[i]
         const currentStepIndex = i
+        container.eventEmitter.emit(Events.CONVO_STEP_NEXT, container, convoStep, i)
         skipTranscriptStep = false
         const transcriptStep = new TranscriptStep({
           expected: new BotiumMockMessage(convoStep),

package/src/scripting/ScriptingProvider.js

@@ -19,6 +19,7 @@ const { BotiumError, botiumErrorFromList, botiumErrorFromErr } = require('./Boti
 const RetryHelper = require('../helpers/RetryHelper')
 const { getMatchFunction } = require('./MatchFunctions')
 const precompilers = require('./precompilers')
+const { calculateWer, toPercent } = require('./helper')
 
 const globPattern = '**/+(*.convo.txt|*.utterances.txt|*.pconvo.txt|*.scriptingmemory.txt|*.xlsx|*.xlsm|*.convo.csv|*.pconvo.csv|*.utterances.csv|*.yaml|*.yml|*.json|*.md|*.markdown)'
 const skipPattern = /^skip[.\-_]/i
@@ -137,32 +138,57 @@ module.exports = class ScriptingProvider {
         const found = _.find(tomatch, (utt) => this.matchFn(botresponse, utt, this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS]))
         const asserterType = this.caps[Capabilities.SCRIPTING_MATCHING_MODE] === 'wer' ? 'Word Error Rate Asserter' : 'Text Match Asserter'
         if (_.isNil(found)) {
-          let message = `${stepTag}: Bot response `
-          message += meMsg ? `(on ${meMsg}) ` : ''
-          message += botresponse ? ('"' + botresponse + '"') : '<no response>'
-          message += ' expected to match '
-          message += tomatch && tomatch.length > 1 ? 'one of ' : ''
-          message += `${tomatch.map(e => e ? '"' + e + '"' : '<any response>').join(', ')}`
-          throw new BotiumError(
-            message,
-            {
-              type: 'asserter',
-              source: asserterType,
-              params: {
-                matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
-                args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
-              },
-              context: {
-                stepTag
-              },
-              cause: {
-                expected: tomatch,
-                actual: botresponse,
-                matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
-                args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+          if (this.caps[Capabilities.SCRIPTING_MATCHING_MODE] === 'wer') {
+            const wer = calculateWer(botresponse, tomatch[0])
+            const werArgs = this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS]
+            const threshold = ([',', '.'].find(p => `${werArgs[0]}`.includes(p)) ? parseFloat(werArgs[0]) : parseInt(werArgs[0]) / 100)
+            const message = `${stepTag}: Word Error Rate (${toPercent(wer)}) higher than accepted (${toPercent(threshold)})`
+            throw new BotiumError(
+              message,
+              {
+                type: 'asserter',
+                source: asserterType,
+                params: {
+                  matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
+                  args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+                },
+                context: {
+                  stepTag
+                },
+                cause: {
+                  expected: `<=${toPercent(threshold)} (${tomatch})`,
+                  actual: `${toPercent(wer)} (${botresponse})`
+                }
               }
-            }
-          )
+            )
+          } else {
+            let message = `${stepTag}: Bot response `
+            message += meMsg ? `(on ${meMsg}) ` : ''
+            message += botresponse ? ('"' + botresponse + '"') : '<no response>'
+            message += ' expected to match '
+            message += tomatch && tomatch.length > 1 ? 'one of ' : ''
+            message += `${tomatch.map(e => e ? '"' + e + '"' : '<any response>').join(', ')}`
+            throw new BotiumError(
+              message,
+              {
+                type: 'asserter',
+                source: asserterType,
+                params: {
+                  matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
+                  args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+                },
+                context: {
+                  stepTag
+                },
+                cause: {
+                  expected: tomatch,
+                  actual: botresponse,
+                  matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
+                  args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+                }
+              }
+            )
+          }
         }
       },
       assertBotNotResponse: (botresponse, nottomatch, stepTag, meMsg) => {
@@ -173,33 +199,58 @@ module.exports = class ScriptingProvider {
         const found = _.find(nottomatch, (utt) => this.matchFn(botresponse, utt, this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS]))
         const asserterType = this.caps[Capabilities.SCRIPTING_MATCHING_MODE] === 'wer' ? 'Word Error Rate Asserter' : 'Text Match Asserter'
         if (!_.isNil(found)) {
-          let message = `${stepTag}: Bot response `
-          message += meMsg ? `(on ${meMsg}) ` : ''
-          message += botresponse ? ('"' + botresponse + '"') : '<no response>'
-          message += ' expected NOT to match '
-          message += nottomatch && nottomatch.length > 1 ? 'one of ' : ''
-          message += `${nottomatch.map(e => e ? '"' + e + '"' : '<any response>').join(', ')}`
-          throw new BotiumError(
-            message,
-            {
-              type: 'asserter',
-              source: asserterType,
-              params: {
-                matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
-                args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
-              },
-              context: {
-                stepTag
-              },
-              cause: {
-                not: true,
-                expected: nottomatch,
-                actual: botresponse,
-                matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
-                args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+          if (this.caps[Capabilities.SCRIPTING_MATCHING_MODE] === 'wer') {
+            const wer = calculateWer(botresponse, nottomatch[0])
+            const werArgs = this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS]
+            const threshold = ([',', '.'].find(p => `${werArgs[0]}`.includes(p)) ? parseFloat(werArgs[0]) : parseInt(werArgs[0]) / 100)
+            const message = `${stepTag}: Word Error Rate (${toPercent(wer)}) lower than accepted (${toPercent(threshold)})`
+            throw new BotiumError(
+              message,
+              {
+                type: 'asserter',
+                source: asserterType,
+                params: {
+                  matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
+                  args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+                },
+                context: {
+                  stepTag
+                },
+                cause: {
+                  expected: `>=${toPercent(threshold)} (${nottomatch})`,
+                  actual: `${toPercent(wer)} (${botresponse})`
+                }
               }
-            }
-          )
+            )
+          } else {
+            let message = `${stepTag}: Bot response `
+            message += meMsg ? `(on ${meMsg}) ` : ''
+            message += botresponse ? ('"' + botresponse + '"') : '<no response>'
+            message += ' expected NOT to match '
+            message += nottomatch && nottomatch.length > 1 ? 'one of ' : ''
+            message += `${nottomatch.map(e => e ? '"' + e + '"' : '<any response>').join(', ')}`
+            throw new BotiumError(
+              message,
+              {
+                type: 'asserter',
+                source: asserterType,
+                params: {
+                  matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
+                  args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+                },
+                context: {
+                  stepTag
+                },
+                cause: {
+                  not: true,
+                  expected: nottomatch,
+                  actual: botresponse,
+                  matchingMode: this.caps[Capabilities.SCRIPTING_MATCHING_MODE],
+                  args: this.caps[Capabilities.SCRIPTING_MATCHING_MODE_ARGS] || null
+                }
+              }
+            )
+          }
         }
       },
       fail: null

package/src/scripting/helper.js

@@ -76,11 +76,11 @@ const toString = (value) => {
 }
 
 const flatString = (str) => {
-  return str ? str.split('\n').map(s => s.trim()).join(' ') : ''
+  return toString(str).split('\n').map(s => s.trim()).join(' ') || ''
 }
 
 const _formatAppendArgs = (args) => {
-  return args ? ` ${args.map(a => _.isString(a) ? a.replace(/\|/g, '\\|') : `${a}`).join('|')}` : ''
+  return (args && args.length > 0 && _.isArray(args) && ` ${args.map(a => _.isString(a) ? a.replace(/\|/g, '\\|') : `${a}`).join('|')}`) || ''
 }
 const _parseArgs = (str) => {
   return (str && str.length > 0 && str.replace(/\\\|/g, '###ESCAPESPLIT###').split('|').map(s => s.replace(/###ESCAPESPLIT###/g, '|').trim())) || []
@@ -553,6 +553,10 @@ const calculateWer = (str, pattern) => {
   const botMessageWords = botMessage.split(' ').map(bm => bm.trim())
   const utt = _prepareString(utterance)
 
+  // if no wildcards, just calculate WER
+  if (utt.indexOf('*') === -1) return speechScorer.wordErrorRate(botMessage, utt).toFixed(2)
+
+  // if there are wildcards, calculate WER for each wildcard part
   const errors = []
   for (let wildcardPart of utt.split('*')) {
     let wer = 1
@@ -572,7 +576,7 @@ const calculateWer = (str, pattern) => {
       }
     }
     if (_.isNil(subsetPhraseFound)) {
-      throw new Error('Word Error Asserter: Something went wrong here, please try to modify your assertion!')
+      throw new Error('Word Error Asserter: When using wild cards, please make sure that the length of the asserter text is smaller than the bot message!')
     }
     errors.push(_getErrors(_getWords(wildcardPart), _getWords(subsetPhraseFound)))
   }
@@ -586,6 +590,8 @@ const calculateWer = (str, pattern) => {
   return (errCount / allCount).toFixed(2)
 }
 
+const toPercent = (s) => `${(s * 100).toFixed(0)}%`
+
 module.exports = {
   normalizeText,
   splitStringInNonEmptyLines,
@@ -600,5 +606,6 @@ module.exports = {
   validateSender,
   validateConvo,
   linesToScriptingMemories,
-  calculateWer
+  calculateWer,
+  toPercent
 }

package/src/scripting/logichook/asserter/WerAsserter.js

@@ -1,6 +1,6 @@
 // const _ = require('lodash')
 const { BotiumError } = require('../../BotiumError')
-const { calculateWer } = require('../../helper')
+const { calculateWer, toPercent } = require('../../helper')
 
 module.exports = class WerAsserter {
   constructor (context, caps = {}) {
@@ -9,6 +9,55 @@ module.exports = class WerAsserter {
     this.name = 'Word Error Rate Asserter'
   }
 
+  assertNotConvoStep ({ convo, convoStep, args, botMsg }) {
+    if (!args || args.length < 1) {
+      return Promise.reject(new BotiumError(`${convoStep.stepTag}: ${this.name} - no argument given`,
+        {
+          type: 'asserter',
+          subtype: 'wrong parameters',
+          source: this.name,
+          cause: { args }
+        }
+      ))
+    }
+    if (args.length > 2) {
+      return Promise.reject(new BotiumError(`${convoStep.stepTag}: ${this.name} - too many arguments "${args}"`,
+        {
+          type: 'asserter',
+          subtype: 'wrong parameters',
+          source: this.name,
+          cause: { args }
+        }
+      ))
+    }
+
+    const utterance = args[0]
+    const threshold = ([',', '.'].find(p => `${args[1]}`.includes(p)) ? parseFloat(args[1]) : parseInt(args[1]) / 100).toFixed(2)
+
+    const wer = calculateWer(botMsg.messageText, utterance)
+
+    if (wer < threshold) {
+      return Promise.reject(new BotiumError(
+        `${convoStep.stepTag}: Word Error Rate (${toPercent(wer)}) lower than accepted (${toPercent(threshold)})`,
+        {
+          type: 'asserter',
+          source: this.name,
+          context: {
+            params: {
+              args
+            }
+          },
+          cause: {
+            expected: `>=${toPercent(threshold)} (${utterance})`,
+            actual: `${toPercent(wer)} (${botMsg.messageText})`
+          }
+        }
+      ))
+    }
+
+    return Promise.resolve()
+  }
+
   assertConvoStep ({ convo, convoStep, args, botMsg }) {
     if (!args || args.length < 1) {
       return Promise.reject(new BotiumError(`${convoStep.stepTag}: ${this.name} - no argument given`,
@@ -37,10 +86,8 @@ module.exports = class WerAsserter {
     const wer = calculateWer(botMsg.messageText, utterance)
 
     if (wer > threshold) {
-      const _toPercent = (s) => `${(s * 100).toFixed(0)}%`
-
       return Promise.reject(new BotiumError(
-        `${convoStep.stepTag}: Word Error Rate (${_toPercent(wer)}) higher than accepted (${_toPercent(threshold)})`,
+        `${convoStep.stepTag}: Word Error Rate (${toPercent(wer)}) higher than accepted (${toPercent(threshold)})`,
         {
           type: 'asserter',
           source: this.name,
@@ -50,8 +97,8 @@ module.exports = class WerAsserter {
             }
           },
           cause: {
-            expected: `<=${_toPercent(threshold)}`,
-            actual: `${_toPercent(wer)}`
+            expected: `<=${toPercent(threshold)} (${utterance})`,
+            actual: `${toPercent(wer)} (${botMsg.messageText})`
           }
         }
       ))

package/test/scripting/txt/decompile.spec.js

@@ -367,6 +367,33 @@ botText
 
 #bot
 botText
+`
+    )
+  })
+  it('should decompile button asserter with numeric text', async function () {
+    const scriptingProvider = new ScriptingProvider(DefaultCapabilities)
+    await scriptingProvider.Build()
+
+    const convo = {
+      header: {
+        name: 'test convo'
+      },
+      conversation: [
+        {
+          sender: 'bot',
+          buttons: [
+            { text: 123, payload: 'buttonpayload1' },
+            { text: 456, payload: 'buttonpayload2' }
+          ]
+        }
+      ]
+    }
+
+    const script = scriptingProvider.Decompile([convo], 'SCRIPTING_FORMAT_TXT')
+    assert.equal(script, `test convo
+
+#bot
+BUTTONS 123|456
 `
     )
   })

package/test/security/allowUnsafe.spec.js

@@ -10,13 +10,28 @@ const HookUtils = require('../../src/helpers/HookUtils')
 
 const myCapsSimpleRest = {
   [Capabilities.CONTAINERMODE]: 'simplerest',
-  [Capabilities.SIMPLEREST_URL]: 'http://my-host.com/api/endpoint',
+  [Capabilities.SIMPLEREST_URL]: 'http://my-non-existing-botium-host.com/api/endpoint',
   [Capabilities.SIMPLEREST_METHOD]: 'POST',
   [Capabilities.SECURITY_ALLOW_UNSAFE]: false,
   [Capabilities.SCRIPTING_ENABLE_MEMORY]: true,
   [Capabilities.SIMPLEREST_RESPONSE_JSONPATH]: ['$']
 }
 
+const echoConnector = ({ queueBotSays }) => {
+  return {
+    UserSays (msg) {
+      const botMsg = { sender: 'bot', sourceData: msg.sourceData, messageText: `You said: "${msg.messageText}"` }
+      queueBotSays(botMsg)
+    }
+  }
+}
+
+const myCapsEcho = {
+  [Capabilities.CONTAINERMODE]: echoConnector,
+  [Capabilities.SECURITY_ALLOW_UNSAFE]: false,
+  [Capabilities.SCRIPTING_ENABLE_MEMORY]: true
+}
+
 const _getSimpleRestCaps = (caps) => {
   return Object.assign(
     {},
@@ -83,20 +98,15 @@ describe('security.allowUnsafe', function () {
 
   describe('scripting memory', function () {
     it('should not throw security error for using inline function', async function () {
-      const driver = new BotDriver(myCapsSimpleRest)
+      const driver = new BotDriver(myCapsEcho)
       const compiler = driver.BuildCompiler()
       const container = await driver.Build()
       await container.Start()
 
-      try {
-        compiler.ReadScript(path.resolve(__dirname, 'convos'), 'withscriptingmemoryfunction.convo.txt')
-        await compiler.convos[0].Run(container)
-        assert.fail('should have failed')
-      } catch (err) {
-        assert.isFalse(err.message.indexOf('Security Error. Using unsafe scripting memory function $func is not allowed') >= 0)
-      }
+      compiler.ReadScript(path.resolve(__dirname, 'convos'), 'withscriptingmemoryfunction.convo.txt')
+      await compiler.convos[0].Run(container)
       await container.Clean()
-    })
+    }).timeout(50000)
   })
 
   describe('simple rest, scripting memory', function () {

package/test/security/convos/withscriptingmemoryfunction.convo.txt

@@ -2,3 +2,4 @@
 result: $func(1+1)
 
 #bot
+you said: "result: 2"