botium-core 1.12.3 → 1.12.6

package/test/connectors/simplerest.spec.js

@@ -142,7 +142,8 @@ describe('connectors.simplerest.nock', function () {
       [Capabilities.SIMPLEREST_URL]: 'http://my-host.com/api/endpoint/{{msg.messageText}}',
       [Capabilities.SIMPLEREST_HEADERS_TEMPLATE]: { HEADER1: 'HEADER1VALUE', HEADER2: '{{msg.token}}' },
       [Capabilities.SIMPLEREST_RESPONSE_JSONPATH]: ['$'],
-      [Capabilities.SIMPLEREST_PING_URL]: 'https://mock.com/pingget'
+      [Capabilities.SIMPLEREST_PING_URL]: 'https://mock.com/pingget',
+      [Capabilities.SIMPLEREST_COOKIE_REPLICATION]: false
     }
     const scope = nock('https://mock.com')
       .get('/pingget')
@@ -156,7 +157,7 @@ describe('connectors.simplerest.nock', function () {
     const pingConfig = {
       method: 'GET',
       uri: 'https://mock.com/pingget',
-      body: body,
+      body,
       timeout: 10000
     }
     const responseBody = await container.pluginInstance._waitForUrlResponse(pingConfig, 2)
@@ -170,8 +171,8 @@ describe('connectors.simplerest.nock', function () {
       [Capabilities.SIMPLEREST_HEADERS_TEMPLATE]: { HEADER1: 'HEADER1VALUE', HEADER2: '{{msg.token}}' },
       [Capabilities.SIMPLEREST_RESPONSE_JSONPATH]: ['$'],
       [Capabilities.SIMPLEREST_PING_URL]: 'https://mock.com/pingpost',
-      [Capabilities.SIMPLEREST_PING_RETRIES]: 2
-
+      [Capabilities.SIMPLEREST_PING_RETRIES]: 2,
+      [Capabilities.SIMPLEREST_COOKIE_REPLICATION]: false
     }
     const scope = nock('https://mock.com')
       .post('/pingpost', { status: 'ok?' }, null)
@@ -185,7 +186,7 @@ describe('connectors.simplerest.nock', function () {
     const pingConfig = {
       method: 'POST',
       uri: 'https://mock.com/pingpost',
-      body: body,
+      body,
       timeout: 100
     }
     const responseBody = await container.pluginInstance._waitForUrlResponse(pingConfig, 2)
@@ -201,7 +202,8 @@ describe('connectors.simplerest.nock', function () {
       [Capabilities.SIMPLEREST_STOP_URL]: 'https://mock.com/stoppost',
       [Capabilities.SIMPLEREST_STOP_RETRIES]: 2,
       [Capabilities.SIMPLEREST_STOP_VERB]: 'POST',
-      [Capabilities.SIMPLEREST_STOP_BODY]: { status: 'ok?' }
+      [Capabilities.SIMPLEREST_STOP_BODY]: { status: 'ok?' },
+      [Capabilities.SIMPLEREST_COOKIE_REPLICATION]: false
     }
     const scope = nock('https://mock.com')
       .post('/stoppost', { status: 'ok?' }, null)
@@ -222,7 +224,8 @@ describe('connectors.simplerest.nock', function () {
       [Capabilities.SIMPLEREST_HEADERS_TEMPLATE]: { HEADER1: 'HEADER1VALUE', HEADER2: '{{msg.token}}' },
       [Capabilities.SIMPLEREST_RESPONSE_JSONPATH]: ['$'],
       [Capabilities.SIMPLEREST_PING_URL]: 'https://mock.com/pingfail',
-      [Capabilities.SIMPLEREST_PING_RETRIES]: 2
+      [Capabilities.SIMPLEREST_PING_RETRIES]: 2,
+      [Capabilities.SIMPLEREST_COOKIE_REPLICATION]: false
     }
     const scope = nock('https://mock.com')
       .get('/pingfail')
@@ -236,7 +239,7 @@ describe('connectors.simplerest.nock', function () {
     const pingConfig = {
       method: 'GET',
       uri: 'https://mock.com/pingfail',
-      body: body,
+      body,
       timeout: 100
     }
     try {
@@ -246,6 +249,44 @@ describe('connectors.simplerest.nock', function () {
     }
     scope.persist(false)
   })
+  it('should store cookies from ping and use for user says request', async () => {
+    const caps = {
+      [Capabilities.CONTAINERMODE]: 'simplerest',
+      [Capabilities.SIMPLEREST_URL]: 'https://mock2.com/endpoint',
+      [Capabilities.SIMPLEREST_HEADERS_TEMPLATE]: { HEADER1: 'HEADER1VALUE', HEADER2: '{{msg.token}}' },
+      [Capabilities.SIMPLEREST_RESPONSE_JSONPATH]: ['$.text'],
+      [Capabilities.SIMPLEREST_PING_URL]: 'https://mock2.com/pingget'
+    }
+    const scope = nock('https://mock2.com')
+      .get('/pingget')
+      .reply(200, {
+        status: 'ok'
+      }, {
+        'set-cookie': 'botium=test-cookie'
+      }).persist()
+
+    const scope2 = nock('https://mock2.com', {
+      reqheaders: {
+        cookie: 'botium=test-cookie'
+      }
+    })
+      .get('/endpoint')
+      .reply(200, {
+        text: 'you called me'
+      })
+      .persist()
+    const driver = new BotDriver(caps)
+    const container = await driver.Build()
+    await container.Start()
+
+    await container.UserSays({ text: 'hallo' })
+    await container.WaitBotSays()
+
+    await container.Stop()
+    await container.Clean()
+    scope.persist(false)
+    scope2.persist(false)
+  })
 })
 
 describe('connectors.simplerest.build', function () {

package/test/convo/convos/continuefailing_timeout.convo.txt

@@ -0,0 +1,16 @@
+continuefailing
+
+#me
+Hello
+
+#bot
+Hello
+
+#me
+Hello again!
+
+#bot
+Hello again FAILING!
+
+#bot
+working again

package/test/convo/transcript.spec.js

@@ -47,7 +47,8 @@ describe('convo.transcript', function () {
       [Capabilities.PROJECTNAME]: 'convo.transcript',
       [Capabilities.CONTAINERMODE]: echoConnector,
       [Capabilities.SCRIPTING_ENABLE_MULTIPLE_ASSERT_ERRORS]: true,
-      [Capabilities.SCRIPTING_ENABLE_SKIP_ASSERT_ERRORS]: true
+      [Capabilities.SCRIPTING_ENABLE_SKIP_ASSERT_ERRORS]: true,
+      [Capabilities.WAITFORBOTTIMEOUT]: 500
     }
     this.driverSkipAssertErrors = new BotDriver(myCapsSkipAssertErrors)
     this.compilerSkipAssertErrors = this.driverSkipAssertErrors.BuildCompiler()
@@ -381,4 +382,20 @@ describe('convo.transcript', function () {
       assert.isNull(err.transcript.steps[5].err)
     }
   })
+  it('should continue on failing assertion with timeout', async function () {
+    this.compilerSkipAssertErrors.ReadScript(path.resolve(__dirname, 'convos'), 'continuefailing_timeout.convo.txt')
+    assert.equal(this.compilerSkipAssertErrors.convos.length, 1)
+
+    try {
+      await this.compilerSkipAssertErrors.convos[0].Run(this.containerSkipAssertErrors)
+      assert.fail('expected error')
+    } catch (err) {
+      assert.isDefined(err.cause)
+      assert.equal(err.cause.message, 'continuefailing/Line 12: Bot response (on Line 9: #me - Hello again!) "Hello again!" expected to match "Hello again FAILING!",\ncontinuefailing/Line 15: error waiting for bot - Bot did not respond within 500ms')
+      assert.equal(err.cause.context.errors.length, 2)
+
+      assert.isDefined(err.transcript)
+      assert.equal(err.transcript.steps.length, 5)
+    }
+  })
 })

package/test/logichooks/convos/WAITFORBOT_INFINITE.convo.txt

@@ -1,4 +1,4 @@
-WAITFORBOT INFINTE
+WAITFORBOT INFINITE
 
 #me
 Hello

package/test/logichooks/hookfromsrc.spec.js

@@ -69,7 +69,7 @@ describe('logichooks.hookfromsrc', function () {
       await compiler.convos[0].Run(container)
       assert.fail('it should have failed')
     } catch (err) {
-      assert.isTrue(err.message.includes('Line 6: assertion error - Unexpected token'))
+      assert.isTrue(err.message.includes('Line 6: assertion error - Unexpected end of input'))
     }
   })
 })

package/test/scripting/asserters/buttonsAsserter.spec.js

@@ -263,3 +263,50 @@ describe('scripting.asserters.buttonsCountAsserter', function () {
     })
   })
 })
+
+describe('scripting.asserters.buttonsNormalizeAsserter', function () {
+  beforeEach(async function () {
+    this.cardsAsserter = new ButtonsAsserter({
+      Match: (botresponse, utterance) => botresponse.toLowerCase().indexOf(utterance.toLowerCase()) >= 0
+    }, { SCRIPTING_NORMALIZE_TEXT: true })
+  })
+
+  it('should succeed with normalized text', async function () {
+    await this.cardsAsserter.assertConvoStep({
+      convoStep: { stepTag: 'test' },
+      args: ['Test Html header      test html text'],
+      botMsg: {
+        buttons: [
+          {
+            text: '<html><h1>test html header</h1><p>test html text</p>'
+          }
+        ]
+      }
+    })
+  })
+
+  it('should fail with normalized text', async function () {
+    try {
+      await this.cardsAsserter.assertConvoStep({
+        convoStep: { stepTag: 'test' },
+        args: ['Test Html header1      test html text'],
+        botMsg: {
+          buttons: [
+            {
+              text: '<html><h1>test html header</h1><p>test html text</p>'
+            }
+          ]
+        }
+      })
+      assert.fail('should have failed')
+    } catch (err) {
+      assert.isTrue(err.message.indexOf('Expected button(s) with text "Test Html header1      test html text"') > 0)
+      assert.isNotNull(err.context)
+      assert.isNotNull(err.context.cause)
+      assert.isArray(err.context.cause.expected)
+      assert.deepEqual(err.context.cause.expected, ['Test Html header1      test html text'])
+      assert.deepEqual(err.context.cause.actual, ['test html header test html text'])
+      assert.deepEqual(err.context.cause.diff, ['Test Html header1      test html text'])
+    }
+  })
+})

package/test/scripting/asserters/cardsAsserter.spec.js

@@ -243,3 +243,42 @@ describe('scripting.asserters.cardsCountAsserter', function () {
     })
   })
 })
+
+describe('scripting.asserters.cardsNormalizeAsserter', function () {
+  beforeEach(async function () {
+    this.cardsAsserter = new CardsAsserter({
+      Match: (botresponse, utterance) => botresponse.toLowerCase().indexOf(utterance.toLowerCase()) >= 0
+    }, { SCRIPTING_NORMALIZE_TEXT: true })
+  })
+
+  it('should succeed with normalized text', async function () {
+    await this.cardsAsserter.assertConvoStep({
+      convoStep: { stepTag: 'test' },
+      args: ['Test Html header      test html text'],
+      botMsg: {
+        cards: [{ text: '<html><h1>test html header</h1><p>test html text</p>' }]
+      }
+    })
+  })
+
+  it('should fail with normalized text', async function () {
+    try {
+      await this.cardsAsserter.assertConvoStep({
+        convoStep: { stepTag: 'test' },
+        args: ['Test Html header1      test html text'],
+        botMsg: {
+          cards: [{ text: '<html><h1>test html header</h1><p>test html text</p>' }]
+        }
+      })
+      assert.fail('should have failed')
+    } catch (err) {
+      assert.isTrue(err.message.indexOf('Expected card(s) with text "Test Html header1      test html text"') > 0)
+      assert.isNotNull(err.context)
+      assert.isNotNull(err.context.cause)
+      assert.isArray(err.context.cause.expected)
+      assert.deepEqual(err.context.cause.expected, ['Test Html header1      test html text'])
+      assert.deepEqual(err.context.cause.actual, ['test html header test html text'])
+      assert.deepEqual(err.context.cause.diff, ['Test Html header1      test html text'])
+    }
+  })
+})

package/test/scripting/scriptingProvider.spec.js

@@ -226,7 +226,7 @@ describe('scriptingProvider._tagAndCleanupUtterances', function () {
   it('positive case remove empty String from utterances', async function () {
     const scriptingProvider = new ScriptingProvider()
     const utterances = ['don\'t understand', 'sorry', '']
-    const fileUtterances = [{ name: 'INCOMPREHENSION', utterances: utterances }]
+    const fileUtterances = [{ name: 'INCOMPREHENSION', utterances }]
     const actualResult = scriptingProvider._tagAndCleanupUtterances(fileUtterances, 'mydir', 'incomprehension.utterances.txt')
     expect(actualResult[0].utterances).to.eql(utterances.slice(0, 2))
   })

package/test/scripting/txt/decompile.spec.js

@@ -634,6 +634,30 @@ CARDS text of card2
 #me
 some text
 CUSTOMINPUT arg1|arg2
+`
+    )
+  })
+  it('should escape pipe in args', async function () {
+    const scriptingProvider = new ScriptingProvider(DefaultCapabilities)
+    await scriptingProvider.Build()
+
+    const convo = {
+      header: {
+        name: 'test convo'
+      },
+      conversation: [
+        {
+          sender: 'me',
+          userInputs: [{ name: 'CUSTOMINPUT', args: ['arg|1', 'arg|2'] }]
+        }
+      ]
+    }
+
+    const script = scriptingProvider.Decompile([convo], 'SCRIPTING_FORMAT_TXT')
+    assert.equal(script, `test convo
+
+#me
+CUSTOMINPUT arg\\|1|arg\\|2
 `
     )
   })