botholomew 0.7.8 → 0.7.9

package/src/db/tasks.ts

@@ -109,6 +109,7 @@ export async function listTasks(
     status?: Task["status"];
     priority?: Task["priority"];
     limit?: number;
+    offset?: number;
   },
 ): Promise<Task[]> {
   const { where, params } = buildWhereClause([
@@ -116,13 +117,12 @@ export async function listTasks(
     ["priority", filters?.priority],
   ]);
   const limit = filters?.limit ? `LIMIT ${sanitizeInt(filters.limit)}` : "";
+  const offset = filters?.offset ? `OFFSET ${sanitizeInt(filters.offset)}` : "";
 
   const rows = await db.queryAll<TaskRow>(
     `SELECT * FROM tasks ${where}
-     ORDER BY
-       CASE priority WHEN 'high' THEN 0 WHEN 'medium' THEN 1 WHEN 'low' THEN 2 END,
-       created_at ASC
-     ${limit}`,
+     ORDER BY created_at DESC, id DESC
+     ${limit} ${offset}`,
     ...params,
   );
   return rows.map(rowToTask);

package/src/db/threads.ts

@@ -1,5 +1,5 @@
 import type { DbConnection } from "./connection.ts";
-import { buildWhereClause } from "./query.ts";
+import { buildWhereClause, sanitizeInt } from "./query.ts";
 import { uuidv7 } from "./uuid.ts";
 
 export interface Thread {
@@ -256,18 +256,20 @@ export async function listThreads(
     type?: Thread["type"];
     taskId?: string;
     limit?: number;
+    offset?: number;
   },
 ): Promise<Thread[]> {
   const { where, params } = buildWhereClause([
     ["type", filters?.type],
     ["task_id", filters?.taskId],
   ]);
-  const limit = filters?.limit ? `LIMIT ${filters.limit}` : "";
+  const limit = filters?.limit ? `LIMIT ${sanitizeInt(filters.limit)}` : "";
+  const offset = filters?.offset ? `OFFSET ${sanitizeInt(filters.offset)}` : "";
 
   const rows = await db.queryAll<ThreadRow>(
     `SELECT * FROM threads ${where}
-     ORDER BY started_at DESC
-     ${limit}`,
+     ORDER BY started_at DESC, id DESC
+     ${limit} ${offset}`,
     ...params,
   );
   return rows.map(rowToThread);

package/src/tools/tool.ts

@@ -5,7 +5,15 @@ import type { BotholomewConfig } from "../config/schemas.ts";
 import type { DbConnection } from "../db/connection.ts";
 
 export interface ToolContext {
+  /**
+   * Short-lived DB connection scoped to this tool call. Safe for single-query
+   * tools. Do NOT hold it across slow work (network, embedding, long loops) —
+   * the instance-level file lock stays held until every connection closes.
+   * For long-running tools, use `dbPath` with `withDb` per logical operation.
+   */
   conn: DbConnection;
+  /** Path to the DuckDB file. Use with `withDb` for long-running tools. */
+  dbPath: string;
   projectDir: string;
   config: Required<BotholomewConfig>;
   mcpxClient: McpxClient | null;

package/src/tui/App.tsx

@@ -7,6 +7,7 @@ import {
   startChatSession,
 } from "../chat/session.ts";
 import { MAX_INLINE_CHARS, PAGE_SIZE_CHARS } from "../daemon/large-results.ts";
+import { withDb } from "../db/connection.ts";
 import type { Interaction } from "../db/threads.ts";
 import { getThread } from "../db/threads.ts";
 import {
@@ -163,7 +164,9 @@ export function App({
         sessionRef.current = session;
 
         if (session.messages.length > 0) {
-          const threadData = await getThread(session.conn, session.threadId);
+          const threadData = await withDb(session.dbPath, (conn) =>
+            getThread(conn, session.threadId),
+          );
           if (threadData) {
             setMessages(
               restoreMessagesFromInteractions(threadData.interactions),
@@ -409,7 +412,9 @@ export function App({
     const refreshTitle = async () => {
       const session = sessionRef.current;
       if (!session) return;
-      const result = await getThread(session.conn, session.threadId);
+      const result = await withDb(session.dbPath, (conn) =>
+        getThread(conn, session.threadId),
+      );
       if (mounted && result?.thread.title) {
         setChatTitle(result.thread.title);
       }
@@ -547,18 +552,18 @@ export function App({
     [exit, processQueue, syncQueue],
   );
 
-  const sessionConn = sessionRef.current?.conn;
+  const sessionDbPath = sessionRef.current?.dbPath;
   const inputBarHeader = useMemo(
     () =>
-      sessionConn ? (
+      sessionDbPath ? (
         <StatusBar
           projectDir={projectDir}
-          conn={sessionConn}
+          dbPath={sessionDbPath}
           chatTitle={chatTitle}
           onDaemonStatusChange={setDaemonRunning}
         />
       ) : null,
-    [projectDir, sessionConn, chatTitle],
+    [projectDir, sessionDbPath, chatTitle],
   );
 
   const sessionSkills = ready ? sessionRef.current?.skills : undefined;
@@ -602,7 +607,7 @@ export function App({
     );
   }
 
-  const conn = sessionRef.current.conn;
+  const dbPath = sessionRef.current.dbPath;
   const threadId = sessionRef.current.threadId;
 
   return (
@@ -642,14 +647,14 @@ export function App({
         flexDirection="column"
         flexGrow={1}
       >
-        <ContextPanel conn={conn} isActive={activeTab === 3} />
+        <ContextPanel dbPath={dbPath} isActive={activeTab === 3} />
       </Box>
       <Box
         display={activeTab === 4 ? "flex" : "none"}
         flexDirection="column"
         flexGrow={1}
       >
-        <TaskPanel conn={conn} isActive={activeTab === 4} />
+        <TaskPanel dbPath={dbPath} isActive={activeTab === 4} />
       </Box>
       <Box
         display={activeTab === 5 ? "flex" : "none"}
@@ -657,7 +662,7 @@ export function App({
         flexGrow={1}
       >
         <ThreadPanel
-          conn={conn}
+          dbPath={dbPath}
           activeThreadId={threadId}
           isActive={activeTab === 5}
         />
@@ -667,7 +672,7 @@ export function App({
         flexDirection="column"
         flexGrow={1}
       >
-        <SchedulePanel conn={conn} isActive={activeTab === 6} />
+        <SchedulePanel dbPath={dbPath} isActive={activeTab === 6} />
       </Box>
       <Box
         display={activeTab === 7 ? "flex" : "none"}

package/src/tui/components/ContextPanel.tsx

@@ -1,6 +1,6 @@
 import { Box, Text, useInput, useStdout } from "ink";
 import { memo, useCallback, useEffect, useMemo, useState } from "react";
-import type { DbConnection } from "../../db/connection.ts";
+import { withDb } from "../../db/connection.ts";
 import {
   type ContextItem,
   deleteContextItem,
@@ -11,7 +11,7 @@ import {
 } from "../../db/context.ts";
 
 interface ContextPanelProps {
-  conn: DbConnection;
+  dbPath: string;
   isActive: boolean;
 }
 
@@ -32,7 +32,7 @@ type Entry = DirEntry | FileEntry;
 const CHROME_LINES = 8;
 
 export const ContextPanel = memo(function ContextPanel({
-  conn,
+  dbPath,
   isActive,
 }: ContextPanelProps) {
   const { stdout } = useStdout();
@@ -64,10 +64,10 @@ export const ContextPanel = memo(function ContextPanel({
 
   const loadEntries = useCallback(
     async (path: string) => {
-      const dirs = await getDistinctDirectories(conn, path);
-      const files = await listContextItemsByPrefix(conn, path, {
-        recursive: false,
-      });
+      const [dirs, files] = await withDb(dbPath, async (conn) => [
+        await getDistinctDirectories(conn, path),
+        await listContextItemsByPrefix(conn, path, { recursive: false }),
+      ]);
 
       const dirEntries: DirEntry[] = dirs.map((d) => ({
         type: "directory",
@@ -84,7 +84,7 @@ export const ContextPanel = memo(function ContextPanel({
       setScrollOffset(0);
       setPreview(null);
     },
-    [conn],
+    [dbPath],
   );
 
   useEffect(() => {
@@ -99,13 +99,15 @@ export const ContextPanel = memo(function ContextPanel({
         setSearchResults(null);
         return;
       }
-      const results = await searchContextByKeyword(conn, query.trim(), 50);
+      const results = await withDb(dbPath, (conn) =>
+        searchContextByKeyword(conn, query.trim(), 50),
+      );
       setSearchResults(results);
       setCursor(0);
       setScrollOffset(0);
       setPreview(null);
     },
-    [conn],
+    [dbPath],
   );
 
   // Compute the items list and visible window for the current view
@@ -171,11 +173,13 @@ export const ContextPanel = memo(function ContextPanel({
         if (input === "y" || input === "d") {
           const entry = entries[cursor];
           if (entry) {
-            if (entry.type === "directory") {
-              deleteContextItemsByPrefix(conn, entry.path);
-            } else {
-              deleteContextItem(conn, entry.item.id);
-            }
+            void withDb(dbPath, async (conn) => {
+              if (entry.type === "directory") {
+                await deleteContextItemsByPrefix(conn, entry.path);
+              } else {
+                await deleteContextItem(conn, entry.item.id);
+              }
+            });
             setConfirmDelete(false);
             loadEntries(currentPath);
           }

package/src/tui/components/SchedulePanel.tsx

@@ -1,6 +1,6 @@
 import { Box, Text, useInput, useStdout } from "ink";
 import { memo, useCallback, useEffect, useMemo, useState } from "react";
-import type { DbConnection } from "../../db/connection.ts";
+import { withDb } from "../../db/connection.ts";
 import {
   deleteSchedule,
   listSchedules,
@@ -10,7 +10,7 @@ import {
 import { ansi, theme } from "../theme.ts";
 
 interface SchedulePanelProps {
-  conn: DbConnection;
+  dbPath: string;
   isActive: boolean;
 }
 
@@ -108,7 +108,7 @@ function cycleFilter<T>(current: T | null, values: readonly T[]): T | null {
 }
 
 export const SchedulePanel = memo(function SchedulePanel({
-  conn,
+  dbPath,
   isActive,
 }: SchedulePanelProps) {
   const { stdout } = useStdout();
@@ -127,7 +127,9 @@ export const SchedulePanel = memo(function SchedulePanel({
     const refresh = async () => {
       const filters: { enabled?: boolean } = {};
       if (enabledFilter !== null) filters.enabled = enabledFilter;
-      const result = await listSchedules(conn, filters);
+      const result = await withDb(dbPath, (conn) =>
+        listSchedules(conn, filters),
+      );
       if (mounted) {
         setSchedules(result);
         setSelectedIndex((prev) =>
@@ -142,7 +144,7 @@ export const SchedulePanel = memo(function SchedulePanel({
       mounted = false;
       clearInterval(interval);
     };
-  }, [conn, enabledFilter, refreshTick]);
+  }, [dbPath, enabledFilter, refreshTick]);
 
   const selectedSchedule = schedules[selectedIndex];
 
@@ -182,7 +184,9 @@ export const SchedulePanel = memo(function SchedulePanel({
       if (confirmDelete) {
         if (input === "y" || input === "d") {
           if (selectedSchedule) {
-            deleteSchedule(conn, selectedSchedule.id).then(() => {
+            withDb(dbPath, (conn) =>
+              deleteSchedule(conn, selectedSchedule.id),
+            ).then(() => {
               forceRefresh();
             });
           }
@@ -242,9 +246,11 @@ export const SchedulePanel = memo(function SchedulePanel({
         return;
       }
       if (input === "e" && selectedSchedule) {
-        updateSchedule(conn, selectedSchedule.id, {
-          enabled: !selectedSchedule.enabled,
-        }).then(() => {
+        withDb(dbPath, (conn) =>
+          updateSchedule(conn, selectedSchedule.id, {
+            enabled: !selectedSchedule.enabled,
+          }),
+        ).then(() => {
           forceRefresh();
         });
         return;

package/src/tui/components/StatusBar.tsx

@@ -1,13 +1,13 @@
 import { Box, Text } from "ink";
 import { useEffect, useState } from "react";
-import type { DbConnection } from "../../db/connection.ts";
+import { withDb } from "../../db/connection.ts";
 import { listTasks } from "../../db/tasks.ts";
 import { getDaemonStatus } from "../../utils/pid.ts";
 import { LogoChar } from "./Logo.tsx";
 
 interface StatusBarProps {
   projectDir: string;
-  conn: DbConnection;
+  dbPath: string;
   chatTitle?: string;
   onDaemonStatusChange?: (running: boolean) => void;
 }
@@ -20,7 +20,7 @@ interface Status {
 
 export function StatusBar({
   projectDir,
-  conn,
+  dbPath,
   chatTitle,
   onDaemonStatusChange,
 }: StatusBarProps) {
@@ -35,8 +35,10 @@ export function StatusBar({
 
     const refresh = async () => {
       const daemon = await getDaemonStatus(projectDir);
-      const pending = await listTasks(conn, { status: "pending" });
-      const inProgress = await listTasks(conn, { status: "in_progress" });
+      const [pending, inProgress] = await withDb(dbPath, async (conn) => [
+        await listTasks(conn, { status: "pending" }),
+        await listTasks(conn, { status: "in_progress" }),
+      ]);
       if (mounted) {
         const daemonRunning = daemon !== null;
         setStatus({
@@ -54,7 +56,7 @@ export function StatusBar({
       mounted = false;
       clearInterval(interval);
     };
-  }, [projectDir, conn, onDaemonStatusChange]);
+  }, [projectDir, dbPath, onDaemonStatusChange]);
 
   return (
     <Box paddingX={0}>

package/src/tui/components/TaskPanel.tsx

@@ -1,6 +1,6 @@
 import { Box, Text, useInput, useStdout } from "ink";
 import { memo, useCallback, useEffect, useMemo, useState } from "react";
-import type { DbConnection } from "../../db/connection.ts";
+import { withDb } from "../../db/connection.ts";
 import {
   deleteTask,
   listTasks,
@@ -11,7 +11,7 @@ import {
 import { ansi, theme } from "../theme.ts";
 
 interface TaskPanelProps {
-  conn: DbConnection;
+  dbPath: string;
   isActive: boolean;
 }
 
@@ -145,7 +145,7 @@ function cycleFilter<T>(current: T | null, values: readonly T[]): T | null {
 }
 
 export const TaskPanel = memo(function TaskPanel({
-  conn,
+  dbPath,
   isActive,
 }: TaskPanelProps) {
   const { stdout } = useStdout();
@@ -171,7 +171,7 @@ export const TaskPanel = memo(function TaskPanel({
       } = {};
       if (statusFilter) filters.status = statusFilter;
       if (priorityFilter) filters.priority = priorityFilter;
-      const result = await listTasks(conn, filters);
+      const result = await withDb(dbPath, (conn) => listTasks(conn, filters));
       if (mounted) {
         setTasks(result);
         setSelectedIndex((prev) =>
@@ -186,7 +186,7 @@ export const TaskPanel = memo(function TaskPanel({
       mounted = false;
       clearInterval(interval);
     };
-  }, [conn, statusFilter, priorityFilter, refreshTick]);
+  }, [dbPath, statusFilter, priorityFilter, refreshTick]);
 
   const selectedTask = tasks[selectedIndex];
 
@@ -275,7 +275,7 @@ export const TaskPanel = memo(function TaskPanel({
         return;
       }
       if (input === "d" && selectedTask) {
-        deleteTask(conn, selectedTask.id).then(() => {
+        withDb(dbPath, (conn) => deleteTask(conn, selectedTask.id)).then(() => {
           forceRefresh();
         });
         return;

package/src/tui/components/ThreadPanel.tsx

@@ -1,6 +1,6 @@
 import { Box, Text, useInput, useStdout } from "ink";
 import { memo, useCallback, useEffect, useMemo, useRef, useState } from "react";
-import type { DbConnection } from "../../db/connection.ts";
+import { withDb } from "../../db/connection.ts";
 import {
   deleteThread,
   getInteractionsAfter,
@@ -13,7 +13,7 @@ import {
 import { ansi, theme } from "../theme.ts";
 
 interface ThreadPanelProps {
-  conn: DbConnection;
+  dbPath: string;
   activeThreadId: string;
   isActive: boolean;
 }
@@ -181,7 +181,7 @@ function cycleFilter<T>(current: T | null, values: readonly T[]): T | null {
 }
 
 export const ThreadPanel = memo(function ThreadPanel({
-  conn,
+  dbPath,
   activeThreadId,
   isActive,
 }: ThreadPanelProps) {
@@ -210,7 +210,7 @@ export const ThreadPanel = memo(function ThreadPanel({
     const refresh = async () => {
       const filters: { type?: Thread["type"] } = {};
       if (typeFilter) filters.type = typeFilter;
-      const result = await listThreads(conn, filters);
+      const result = await withDb(dbPath, (conn) => listThreads(conn, filters));
       if (mounted) {
         setThreads(result);
         setSelectedIndex((prev) =>
@@ -225,7 +225,7 @@ export const ThreadPanel = memo(function ThreadPanel({
       mounted = false;
       clearInterval(interval);
     };
-  }, [conn, typeFilter, refreshTick]);
+  }, [dbPath, typeFilter, refreshTick]);
 
   // Filter threads by search query
   const filteredThreads = useMemo(() => {
@@ -245,16 +245,18 @@ export const ThreadPanel = memo(function ThreadPanel({
       return;
     }
 
-    getThread(conn, selectedThread.id).then((result) => {
-      if (mounted && result) {
-        setSelectedDetail(result);
-      }
-    });
+    withDb(dbPath, (conn) => getThread(conn, selectedThread.id)).then(
+      (result) => {
+        if (mounted && result) {
+          setSelectedDetail(result);
+        }
+      },
+    );
 
     return () => {
       mounted = false;
     };
-  }, [conn, selectedThread?.id, following]);
+  }, [dbPath, selectedThread?.id, following]);
 
   // Follow mode: poll for new interactions every 1s
   // biome-ignore lint/correctness/useExhaustiveDependencies: following and selectedThread?.id are the intentional triggers
@@ -264,10 +266,12 @@ export const ThreadPanel = memo(function ThreadPanel({
 
     const poll = async () => {
       try {
-        const newInteractions = await getInteractionsAfter(
-          conn,
-          selectedThread.id,
-          lastSeenSequenceRef.current,
+        const newInteractions = await withDb(dbPath, (conn) =>
+          getInteractionsAfter(
+            conn,
+            selectedThread.id,
+            lastSeenSequenceRef.current,
+          ),
         );
         if (!mounted || newInteractions.length === 0) return;
 
@@ -286,11 +290,15 @@ export const ThreadPanel = memo(function ThreadPanel({
         // Auto-scroll will be handled by the detailLines/maxDetailScroll recalc
         setDetailScroll(Number.MAX_SAFE_INTEGER);
 
-        const ended = await isThreadEnded(conn, selectedThread.id);
+        const ended = await withDb(dbPath, (conn) =>
+          isThreadEnded(conn, selectedThread.id),
+        );
         if (mounted && ended) {
           setFollowing(false);
           // Refresh the thread to get the ended_at timestamp
-          const result = await getThread(conn, selectedThread.id);
+          const result = await withDb(dbPath, (conn) =>
+            getThread(conn, selectedThread.id),
+          );
           if (mounted && result) {
             setSelectedDetail(result);
           }
@@ -306,7 +314,7 @@ export const ThreadPanel = memo(function ThreadPanel({
       mounted = false;
       clearInterval(interval);
     };
-  }, [conn, following, selectedThread?.id]);
+  }, [dbPath, following, selectedThread?.id]);
 
   const isActiveSelected = selectedThread?.id === activeThreadId;
 
@@ -375,7 +383,9 @@ export const ThreadPanel = memo(function ThreadPanel({
       if (confirmDelete) {
         if (input === "y" || input === "d") {
           if (selectedThread && !isActiveSelected) {
-            deleteThread(conn, selectedThread.id).then(() => {
+            withDb(dbPath, (conn) =>
+              deleteThread(conn, selectedThread.id),
+            ).then(() => {
               forceRefresh();
             });
           }

package/src/utils/title.ts

@@ -1,16 +1,18 @@
 import Anthropic from "@anthropic-ai/sdk";
 import type { BotholomewConfig } from "../config/schemas.ts";
-import type { DbConnection } from "../db/connection.ts";
+import { withDb } from "../db/connection.ts";
 import { updateThreadTitle } from "../db/threads.ts";
 import { logger } from "./logger.ts";
 
 /**
  * Generate a short title for a thread using the chunker model (Haiku).
  * Fire-and-forget — errors are logged at debug level and never propagated.
+ * Opens its own short-lived DB connection for the write so callers can
+ * safely `void`-chain without holding a connection during the LLM call.
  */
 export async function generateThreadTitle(
   config: Required<BotholomewConfig>,
-  conn: DbConnection,
+  dbPath: string,
   threadId: string,
   context: string,
 ): Promise<void> {
@@ -39,7 +41,7 @@ export async function generateThreadTitle(
       .trim();
 
     if (title) {
-      await updateThreadTitle(conn, threadId, title);
+      await withDb(dbPath, (conn) => updateThreadTitle(conn, threadId, title));
     }
   } catch (err) {
     logger.warn(`Failed to generate thread title: ${err}`);