bopodev-api 0.1.25 → 0.1.27

package/src/scripts/onboard-seed.ts

@@ -26,12 +26,10 @@ import { normalizeRuntimeConfig, runtimeConfigToDb, runtimeConfigToStateBlobPatc
 import {
   normalizeAbsolutePath,
   normalizeCompanyWorkspacePath,
-  resolveAgentFallbackWorkspacePath,
   resolveProjectWorkspacePath
 } from "../lib/instance-paths";
 import { buildDefaultCeoBootstrapPrompt } from "../lib/ceo-bootstrap-prompt";
 import { resolveDefaultRuntimeCwdForCompany } from "../lib/workspace-policy";
-import { ensureCompanyModelPricingDefaults } from "../services/model-pricing";
 import { applyTemplateManifest } from "../services/template-apply-service";
 import { ensureCompanyBuiltinTemplateDefaults } from "../services/template-catalog";
 
@@ -212,8 +210,6 @@ export async function ensureOnboardingSeed(input: {
       templateApplied = true;
       appliedTemplateId = template.id;
     }
-    await ensureCompanyModelPricingDefaults(db, companyId);
-
     return {
       companyId,
       companyName: resolvedCompanyName,
@@ -305,15 +301,16 @@ async function ensureCeoStartupTask(
       typeof issue.body === "string" &&
       issue.body.includes(CEO_STARTUP_TASK_MARKER)
   );
-  const ceoWorkspaceRoot = resolveAgentFallbackWorkspacePath(input.companyId, input.ceoId);
-  const ceoOperatingFolder = `${ceoWorkspaceRoot}/operating`;
-  const ceoTmpFolder = `${ceoWorkspaceRoot}/tmp`;
+  const companyScopedCeoRoot = `workspace/${input.companyId}/agents/${input.ceoId}`;
+  const ceoOperatingFolder = `${companyScopedCeoRoot}/operating`;
+  const ceoTmpFolder = `${companyScopedCeoRoot}/tmp`;
   const body = [
     CEO_STARTUP_TASK_MARKER,
     "",
     "Stand up your leadership operating baseline before taking on additional delivery work.",
     "",
-    `1. Create your operating folder at \`${ceoOperatingFolder}/\` (system path, outside project workspaces).`,
+    `1. Create your operating folder at \`${ceoOperatingFolder}/\`.`,
+    "   During heartbeats, prefer the absolute path in `$BOPODEV_AGENT_OPERATING_DIR` (set by the runtime) so files land under your agent folder even when the shell cwd is a project workspace.",
     "2. Author these files with your own voice and responsibilities:",
     `   - \`${ceoOperatingFolder}/AGENTS.md\``,
     `   - \`${ceoOperatingFolder}/HEARTBEAT.md\``,
@@ -335,7 +332,7 @@ async function ensureCeoStartupTask(
     "7. Do not use unsupported hire fields such as `adapterType`, `adapterConfig`, or `reportsTo`.",
     "",
     "Safety checks before requesting hire:",
-    "- Do not write operating/system files under any project workspace folder.",
+    `- Keep operating/system files inside \`workspace/${input.companyId}/agents/${input.ceoId}/\` only.`,
     "- Do not request duplicates if a Founding Engineer already exists.",
     "- Do not request duplicates if a pending approval for the same role is already open.",
     "- For control-plane calls, prefer direct header env vars (`BOPODEV_COMPANY_ID`, `BOPODEV_ACTOR_TYPE`, `BOPODEV_ACTOR_ID`, `BOPODEV_ACTOR_COMPANIES`, `BOPODEV_ACTOR_PERMISSIONS`) instead of parsing `BOPODEV_REQUEST_HEADERS_JSON`.",

package/src/server.ts

@@ -3,7 +3,7 @@ import { dirname, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
 import { sql } from "drizzle-orm";
 import { config as loadDotenv } from "dotenv";
-import { bootstrapDatabase, listCompanies } from "bopodev-db";
+import { bootstrapDatabase, listCompanies, resolveDefaultDbPath } from "bopodev-db";
 import { checkRuntimeCommandHealth } from "bopodev-agent-sdk";
 import type { RuntimeCommandHealth } from "bopodev-agent-sdk";
 import { createApp } from "./app";
@@ -33,7 +33,28 @@ async function main() {
   validateDeploymentConfiguration(deploymentMode, allowedOrigins, allowedHostnames, publicBaseUrl);
   const dbPath = normalizeOptionalDbPath(process.env.BOPO_DB_PATH);
   const port = Number(process.env.PORT ?? 4020);
-  const { db } = await bootstrapDatabase(dbPath);
+  const effectiveDbPath = dbPath ?? resolveDefaultDbPath();
+  let db: Awaited<ReturnType<typeof bootstrapDatabase>>["db"];
+  let dbClient: Awaited<ReturnType<typeof bootstrapDatabase>>["client"];
+  try {
+    const boot = await bootstrapDatabase(dbPath);
+    db = boot.db;
+    dbClient = boot.client;
+  } catch (error) {
+    if (isProbablyPgliteWasmAbort(error)) {
+      // eslint-disable-next-line no-console
+      console.error(
+        "[startup] PGlite (embedded Postgres) failed during database bootstrap. This is unrelated to Codex or heartbeat prompt settings."
+      );
+      // eslint-disable-next-line no-console
+      console.error(`[startup] Data path in use: ${effectiveDbPath}`);
+      // eslint-disable-next-line no-console
+      console.error(
+        "[startup] Recovery: stop all API/node processes using this DB, back up the path above, delete the file/dir, then restart (schema will be recreated). Or set BOPO_DB_PATH to a fresh path. See docs/operations/troubleshooting.md (PGlite)."
+      );
+    }
+    throw error;
+  }
   const existingCompanies = await listCompanies(db);
   await ensureBuiltinPluginsRegistered(
     db,
@@ -120,16 +141,69 @@ async function main() {
 
   const defaultCompanyId = process.env.BOPO_DEFAULT_COMPANY_ID;
   const schedulerCompanyId = await resolveSchedulerCompanyId(db, defaultCompanyId ?? null);
+  let stopScheduler: (() => void) | undefined;
   if (schedulerCompanyId && shouldStartScheduler()) {
-    createHeartbeatScheduler(db, schedulerCompanyId, realtimeHub);
+    stopScheduler = createHeartbeatScheduler(db, schedulerCompanyId, realtimeHub);
   } else if (schedulerCompanyId) {
     // eslint-disable-next-line no-console
     console.log("[startup] Scheduler disabled for this instance (BOPO_SCHEDULER_ROLE is follower/off).");
   }
+
+  let shutdownInFlight: Promise<void> | null = null;
+  function shutdown(signal: string) {
+    shutdownInFlight ??= (async () => {
+      // eslint-disable-next-line no-console
+      console.log(`[shutdown] ${signal} — closing realtime, HTTP server, and embedded DB…`);
+      stopScheduler?.();
+      try {
+        await realtimeHub.close();
+      } catch (closeError) {
+        // eslint-disable-next-line no-console
+        console.error("[shutdown] realtime hub close error", closeError);
+      }
+      await new Promise<void>((resolve, reject) => {
+        server.close((err) => {
+          if (err) {
+            reject(err);
+            return;
+          }
+          resolve();
+        });
+      });
+      try {
+        await closePgliteClient(dbClient);
+      } catch (closeDbError) {
+        // eslint-disable-next-line no-console
+        console.error("[shutdown] PGlite close error", closeDbError);
+      }
+      // eslint-disable-next-line no-console
+      console.log("[shutdown] clean exit");
+      process.exit(0);
+    })().catch((error) => {
+      // eslint-disable-next-line no-console
+      console.error("[shutdown] failed", error);
+      process.exit(1);
+    });
+    return shutdownInFlight;
+  }
+
+  process.once("SIGINT", () => void shutdown("SIGINT"));
+  process.once("SIGTERM", () => void shutdown("SIGTERM"));
 }
 
 void main();
 
+async function closePgliteClient(client: unknown) {
+  if (!client || typeof client !== "object") {
+    return;
+  }
+  const closeFn = (client as { close?: unknown }).close;
+  if (typeof closeFn !== "function") {
+    return;
+  }
+  await (closeFn as () => Promise<void>)();
+}
+
 async function hasCodexAgentsConfigured(db: Awaited<ReturnType<typeof bootstrapDatabase>>["db"]) {
   const result = await db.execute(sql`
     SELECT id
@@ -262,3 +336,15 @@ function normalizeOptionalDbPath(value: string | undefined) {
   const normalized = value?.trim();
   return normalized && normalized.length > 0 ? normalized : undefined;
 }
+
+function isProbablyPgliteWasmAbort(error: unknown): boolean {
+  const message = error instanceof Error ? error.message : String(error);
+  const cause = error instanceof Error ? error.cause : undefined;
+  const causeMessage = cause instanceof Error ? cause.message : String(cause ?? "");
+  return (
+    message.includes("Aborted") ||
+    causeMessage.includes("Aborted") ||
+    message.includes("pglite") ||
+    causeMessage.includes("RuntimeError")
+  );
+}

package/src/services/attention-service.ts

@@ -17,6 +17,40 @@ import type { BoardAttentionItem } from "bopodev-contracts";
 
 type AttentionStateRow = Awaited<ReturnType<typeof listAttentionInboxStates>>[number];
 
+/** Keep in sync with `RESOLVED_APPROVAL_INBOX_WINDOW_DAYS` in governance routes (resolved history in Inbox). */
+const RESOLVED_APPROVAL_ATTENTION_WINDOW_MS = 30 * 24 * 60 * 60 * 1000;
+
+type StoredApprovalRow = Awaited<ReturnType<typeof listApprovalRequests>>[number];
+
+function approvalIncludedInAttentionList(approval: Pick<StoredApprovalRow, "status" | "resolvedAt">): boolean {
+  if (approval.status === "pending") {
+    return true;
+  }
+  if (!approval.resolvedAt) {
+    return false;
+  }
+  return Date.now() - approval.resolvedAt.getTime() <= RESOLVED_APPROVAL_ATTENTION_WINDOW_MS;
+}
+
+function finalizeApprovalAttentionItem(item: BoardAttentionItem, approval: Pick<StoredApprovalRow, "status" | "resolvedAt" | "action">): BoardAttentionItem {
+  if (approval.status === "pending") {
+    return item;
+  }
+  const outcome =
+    approval.status === "approved" ? "Approved" : approval.status === "rejected" ? "Rejected" : "Overridden";
+  const title =
+    approval.action === "override_budget" ? `Budget hard-stop · ${outcome}` : `Approval · ${outcome}`;
+  const resolvedAtIso = approval.resolvedAt?.toISOString() ?? item.resolvedAt;
+  return {
+    ...item,
+    title,
+    state: "resolved",
+    resolvedAt: resolvedAtIso,
+    severity: "info",
+    sourceTimestamp: resolvedAtIso ?? item.sourceTimestamp
+  };
+}
+
 export async function listBoardAttentionItems(db: BopoDb, companyId: string, actorId: string): Promise<BoardAttentionItem[]> {
   const [approvals, blockedIssues, heartbeatRuns, stateRows, boardComments] = await Promise.all([
     listApprovalRequests(db, companyId),
@@ -42,7 +76,7 @@ export async function listBoardAttentionItems(db: BopoDb, companyId: string, act
   const items: BoardAttentionItem[] = [];
 
   for (const approval of approvals) {
-    if (approval.status !== "pending") {
+    if (!approvalIncludedInAttentionList(approval)) {
       continue;
     }
     const payload = parsePayload(approval.payloadJson);
@@ -55,25 +89,61 @@ export async function listBoardAttentionItems(db: BopoDb, companyId: string, act
       const usedBudget = asNumber(payload.usedBudgetUsd);
       const key = `budget:${approval.id}`;
       items.push(
+        finalizeApprovalAttentionItem(
+          withState(
+            {
+              key,
+              category: "budget_hard_stop",
+              severity: ageHours >= 12 ? "critical" : "warning",
+              requiredActor: "board",
+              title: "Budget hard-stop requires board decision",
+              contextSummary: projectId
+                ? `Project ${shortId(projectId)} is blocked by budget hard-stop.`
+                : agentId
+                  ? `Agent ${shortId(agentId)} is blocked by budget hard-stop.`
+                  : "Agent work is blocked by budget hard-stop.",
+              actionLabel: "Review budget override",
+              actionHref: "/governance",
+              impactSummary: "Heartbeat work stays paused until budget override is approved or rejected.",
+              evidence: {
+                approvalId: approval.id,
+                projectId: projectId ?? undefined,
+                agentId: agentId ?? undefined
+              },
+              sourceTimestamp: approval.createdAt.toISOString(),
+              state: "open",
+              seenAt: null,
+              acknowledgedAt: null,
+              dismissedAt: null,
+              resolvedAt: null
+            },
+            stateByKey.get(key),
+            `Budget utilization ${formatPercent(utilizationPct)} (${formatUsd(usedBudget)} / ${formatUsd(currentBudget)}).`
+          ),
+          approval
+        )
+      );
+      continue;
+    }
+
+    const key = `approval:${approval.id}`;
+    items.push(
+      finalizeApprovalAttentionItem(
         withState(
           {
             key,
-            category: "budget_hard_stop",
-            severity: ageHours >= 12 ? "critical" : "warning",
+            category: "approval_required",
+            severity: ageHours >= 24 ? "critical" : "warning",
             requiredActor: "board",
-            title: "Budget hard-stop requires board decision",
-            contextSummary: projectId
-              ? `Project ${shortId(projectId)} is blocked by budget hard-stop.`
-              : agentId
-                ? `Agent ${shortId(agentId)} is blocked by budget hard-stop.`
-                : "Agent work is blocked by budget hard-stop.",
-            actionLabel: "Review budget override",
+            title: "Approval required",
+            contextSummary: formatApprovalContext(approval.action, payload),
+            actionLabel: "Open approvals",
             actionHref: "/governance",
-            impactSummary: "Heartbeat work stays paused until budget override is approved or rejected.",
+            impactSummary: "Execution remains blocked until this governance decision is resolved.",
             evidence: {
               approvalId: approval.id,
-              projectId: projectId ?? undefined,
-              agentId: agentId ?? undefined
+              projectId: asString(payload.projectId) ?? undefined,
+              agentId: asString(payload.agentId) ?? undefined
             },
             sourceTimestamp: approval.createdAt.toISOString(),
             state: "open",
@@ -82,39 +152,9 @@ export async function listBoardAttentionItems(db: BopoDb, companyId: string, act
             dismissedAt: null,
             resolvedAt: null
           },
-          stateByKey.get(key),
-          `Budget utilization ${formatPercent(utilizationPct)} (${formatUsd(usedBudget)} / ${formatUsd(currentBudget)}).`
-        )
-      );
-      continue;
-    }
-
-    const key = `approval:${approval.id}`;
-    items.push(
-      withState(
-        {
-          key,
-          category: "approval_required",
-          severity: ageHours >= 24 ? "critical" : "warning",
-          requiredActor: "board",
-          title: "Approval required",
-          contextSummary: formatApprovalContext(approval.action, payload),
-          actionLabel: "Open approvals",
-          actionHref: "/governance",
-          impactSummary: "Execution remains blocked until this governance decision is resolved.",
-          evidence: {
-            approvalId: approval.id,
-            projectId: asString(payload.projectId) ?? undefined,
-            agentId: asString(payload.agentId) ?? undefined
-          },
-          sourceTimestamp: approval.createdAt.toISOString(),
-          state: "open",
-          seenAt: null,
-          acknowledgedAt: null,
-          dismissedAt: null,
-          resolvedAt: null
-        },
-        stateByKey.get(key)
+          stateByKey.get(key)
+        ),
+        approval
       )
     );
   }
@@ -219,6 +259,7 @@ export async function listBoardAttentionItems(db: BopoDb, companyId: string, act
     const key = `comment:${comment.id}`;
     const body = comment.body.trim().replace(/\s+/g, " ");
     const summaryBody = body.length > 140 ? `${body.slice(0, 137)}...` : body;
+    const conciseUsageLimitSummary = summarizeUsageLimitBoardComment(body);
     items.push(
       withState(
         {
@@ -226,8 +267,8 @@ export async function listBoardAttentionItems(db: BopoDb, companyId: string, act
           category: "board_mentioned_comment",
           severity: "warning",
           requiredActor: "board",
-          title: "Board input requested on issue comment",
-          contextSummary: `${comment.issueTitle}: ${summaryBody}`,
+          title: conciseUsageLimitSummary ? "Provider usage limit reached" : "Board input requested on issue comment",
+          contextSummary: conciseUsageLimitSummary ?? summaryBody,
           actionLabel: "Open issue thread",
           actionHref: `/issues/${comment.issueId}`,
           impactSummary: "The team is waiting for board clarification to continue confidently.",
@@ -250,6 +291,26 @@ export async function listBoardAttentionItems(db: BopoDb, companyId: string, act
   return dedupeItems(items).sort(compareAttentionItems);
 }
 
+function summarizeUsageLimitBoardComment(body: string) {
+  const normalized = body.replace(/\s+/g, " ").trim();
+  if (!normalized) {
+    return null;
+  }
+  const providerMatch = normalized.match(
+    /\b(claude[_\s-]*code|codex|cursor|openai[_\s-]*api|anthropic[_\s-]*api|gemini[_\s-]*cli|opencode)\b(?=.*\busage limit reached\b)/i
+  );
+  if (!providerMatch) {
+    return null;
+  }
+  const providerToken = providerMatch[1];
+  if (!providerToken) {
+    return null;
+  }
+  const rawProvider = providerToken.toLowerCase().replace(/[_-]+/g, " ").replace(/\s+/g, " ").trim();
+  const providerLabel = rawProvider.charAt(0).toUpperCase() + rawProvider.slice(1);
+  return `${providerLabel} usage limit reached.`;
+}
+
 export async function markBoardAttentionSeen(db: BopoDb, companyId: string, actorId: string, itemKey: string) {
   await markAttentionInboxSeen(db, { companyId, actorId, itemKey });
 }

package/src/services/governance-service.ts

@@ -39,7 +39,6 @@ import {
 import { resolveOpencodeRuntimeModel } from "../lib/opencode-model";
 import {
   normalizeCompanyWorkspacePath,
-  resolveAgentFallbackWorkspacePath,
   resolveProjectWorkspacePath
 } from "../lib/instance-paths";
 import { assertRuntimeCwdForCompany, hasText, resolveDefaultRuntimeCwdForCompany } from "../lib/workspace-policy";
@@ -770,14 +769,15 @@ function resolveAgentDisplayTitle(title: string | null | undefined, roleKeyInput
 }
 
 function buildAgentStartupTaskBody(companyId: string, agentId: string) {
-  const agentWorkspaceRoot = resolveAgentFallbackWorkspacePath(companyId, agentId);
-  const agentOperatingFolder = `${agentWorkspaceRoot}/operating`;
+  const companyScopedAgentRoot = `workspace/${companyId}/agents/${agentId}`;
+  const agentOperatingFolder = `${companyScopedAgentRoot}/operating`;
   return [
     AGENT_STARTUP_TASK_MARKER,
     "",
     `Create your operating baseline before starting feature delivery work.`,
     "",
-    `1. Create your operating folder at \`${agentOperatingFolder}/\` (system path, outside project workspaces).`,
+    `1. Create your operating folder at \`${agentOperatingFolder}/\`.`,
+    "   During heartbeats, prefer the absolute path in `$BOPODEV_AGENT_OPERATING_DIR` (set by the runtime) so files land under your agent folder even when the shell cwd is a project workspace.",
     "2. Author these files with your own responsibilities and working style:",
     `   - \`${agentOperatingFolder}/AGENTS.md\``,
     `   - \`${agentOperatingFolder}/HEARTBEAT.md\``,
@@ -787,7 +787,7 @@ function buildAgentStartupTaskBody(companyId: string, agentId: string) {
     "4. Post an issue comment summarizing completed setup artifacts.",
     "",
     "Safety checks:",
-    "- Do not write operating/system files under any project workspace folder.",
+    `- Keep operating files inside \`workspace/${companyId}/agents/${agentId}/\` only.`,
     "- Do not overwrite another agent's operating folder.",
     "- Keep content original to your role and scope."
   ].join("\n");