bootstrap-input-spinner 5.0.3 → 5.0.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bootstrap-input-spinner",
-  "version": "5.0.3",
+  "version": "5.0.4",
   "description": "A Bootstrap 5 plugin to create input spinner elements for number input.",
   "browser": "./src/InputSpinner.js",
   "type": "module",

package/src/InputSpinner.js

@@ -272,12 +272,16 @@ export class InputSpinner {
         }
 
         function stepHandling(step) {
-            calcStep(step)
+            // Capture only the direction; re-read self.step on every tick so
+            // consumers can change the step attribute mid-hold and have the
+            // new value take effect on the next auto-repeat tick.
+            const direction = step < 0 ? -1 : 1
+            calcStep(direction * self.step)
             resetTimer()
             if (self.props.autoInterval !== undefined) {
                 self.autoDelayHandler = setTimeout(function () {
                     self.autoIntervalHandler = setInterval(function () {
-                        calcStep(step)
+                        calcStep(direction * self.step)
                     }, self.props.autoInterval)
                 }, self.props.autoDelay)
             }

package/test/TestInputSpinner.js

@@ -187,6 +187,33 @@ describe("InputSpinner stepping", () => {
     })
 })
 
+describe("InputSpinner dynamic step while holding", () => {
+    it("picks up a step attribute change on the next auto-repeat tick (regression for #110)", async () => {
+        const el = createInput({value: "0", min: "0", max: "1000", step: "1"})
+        new InputSpinner(el, {autoDelay: 10, autoInterval: 10})
+        const group = el.nextElementSibling
+        const btn = group.querySelector(".btn-increment")
+
+        // Start holding the button: initial step=1 → value becomes 1 synchronously.
+        btn.dispatchEvent(new MouseEvent("mousedown", {button: 0, cancelable: true, bubbles: true}))
+        assert.equal(el.value, "1")
+
+        // Swap the step attribute mid-hold. MutationObserver fires the
+        // updateAttributes callback, which sets self.step = 10.
+        el.setAttribute("step", "10")
+        await wait(5)
+
+        // Wait for a few auto-repeat ticks with the new step.
+        await wait(50)
+        const mid = parseFloat(el.value)
+        assert.true(mid >= 10, "expected value to have advanced by step=10, got " + mid)
+
+        // Release.
+        document.body.dispatchEvent(new MouseEvent("mouseup", {button: 0, bubbles: true}))
+        clear()
+    })
+})
+
 describe("InputSpinner events", () => {
     it("dispatches 'input' when stepping", async () => {
         const {el, group} = spin({value: "5", min: "0", max: "10"})