bootpress 9.0.1 → 9.1.0

package/README.md

@@ -61,13 +61,17 @@ class PostServiceImpl {
         return new HttpResponse(201, casted.id);
     }
     delete(deleteInQuery: string | undefined, idInQuery: string | undefined) {
-        const idx = deleteInQuery === "yes" ? this.posts.indexOf(as(idInQuery, "integer")) : -1;
-        if (idx > -1) {
-            this.#logDeleted(idInQuery);
-            return this.posts.splice(idx, 1);
-        }else {
-            throw new HttpError(404, "Post is not found")
+        if (deleteInQuery === "yes") {
+            const id = as(idInQuery, "integer");
+            const index = this.posts.indexOf(id);
+            if (index > -1) {
+                this.#logDeleted(idInQuery!);
+                return this.posts.splice(index, 1);
+            } else {
+                throw new HttpError(404, "Post is not found")
+            }
         }
+        throw new HttpError(400, "Bad Request");
     }
     // use private methods to  
     #logDeleted(id: number | string) {
@@ -219,7 +223,15 @@ There must be only one element in an array schema which defines ````ArrayOf<Sche
 ### **asStrict(any, string | object | array)**
 Same as 'as' method but doesn't try to parse different types instead throws error.
 
-## v9.0.0 Release Notes:
+# Release Notes
+
+## v9.0.2:
+- Added support for null/undefined returning async functions
+
+## v9.0.1:
+- Fixed errors in argument passers
+
+## v9.0.0:
 - New Feature:
   - Type checking for each argument while passing arguments to service methods
 - Deprecated:
@@ -228,14 +240,14 @@ Same as 'as' method but doesn't try to parse different types instead throws erro
 - Added:
   - PassQuery, PassCookie, PassParam
 
-## v8.0.0 Release Notes:
+## v8.0.0:
 - Added support for async service functions. (You don't need to await if you wrapped your service with Bootpress functions)
 - Bugfix for falsy response values
 - Simplified implementation
 
-## v7.1.0 Release Notes:
+## v7.1.0:
 - getOrThrow: Throws specified error when value is an empty array too.
-## v7.0.0 Release Notes:
+## v7.0.0:
 
 ### Deprecated helper methods:
 - asSchema

package/helpers/index.d.ts

@@ -21,6 +21,7 @@ type JsSchema = {
 }
 
 type ArraySchema = [JsSchema]
+type TypedArraySchema<A extends ArraySchema> = TypedSchema<A[0]>
 
 type RemoveQuestionMark<T extends string> = T extends `${infer Prefix}?` ? Prefix : T;
 

package/index.d.ts

@@ -1,13 +1,17 @@
 import { Response, Request } from "express"
-import { ArraySchema, JsSchema, ValidTypeKeys, TypedSchema } from "./helpers"
+import { ArraySchema, JsSchema, ValidTypeKeys, TypedSchema, ValOf, TypedArraySchema } from "./helpers"
 
 type RequestHandler = (req: Request, res: Response) => void
-type RequsetHandlerWithArgs = <A extends any[]>(...args: A) => RequestHandler
-type RequsetHandlerWithFirstArg<T> = (arg1: T, ...rest: any[]) => RequestHandler
+type ArrayWithLastElement<L> = [...rest: any[], lastArg: L];
+type RequsetHandlerWithLastArg<T, F extends (...args: any) => RequestHandler = (...args: any[]) => RequestHandler, P extends ArrayWithLastElement<T> = Parameters<F>> = (...args: P) => RequestHandler;
 type NonEmptyArray = readonly [any, ...any[]];
-type ShiftRequestHandler<F extends (arg1: any, ...rest: any[]) => RequestHandler> = F extends (arg1: infer T, ...rest: infer U) => RequestHandler ? U extends NonEmptyArray ? (...rest: U) => RequestHandler : RequestHandler : RequestHandler
+type ShiftRequestHandler<F extends RequsetHandlerWithLastArg<any> | RequestHandler> =
+    F extends (arg1: infer T, ...rest: infer U) => RequestHandler ?
+    U extends NonEmptyArray ? (...rest: U) => RequestHandler : RequestHandler
+    : RequestHandler
 
-type RestedService<T extends Record<PropertyKey, any>> = { [K in keyof T]:
+type RestedService<T extends Record<PropertyKey, any>> = {
+    [K in keyof T]:
     T[K] extends Function
     ? (...args: Parameters<T[K]>) => RequestHandler
     : T[K]
@@ -15,21 +19,28 @@ type RestedService<T extends Record<PropertyKey, any>> = { [K in keyof T]:
 
 type InstanceOrClass<T extends Record<PropertyKey, any>> = T | (new () => T);
 
+type TypeValueOf<S extends ValidTypeKeys | JsSchema | TypedSchema<any> | ArraySchema> =
+    S extends ValidTypeKeys ? ValOf<S>
+    : S extends JsSchema ? TypedSchema<S>
+    : S extends TypedSchema<any> ? S
+    : S extends ArraySchema ? TypedArraySchema<S>
+    : never;
+
 declare function RestService<T extends Record<PropertyKey, any>>(service: InstanceOrClass<T>): RestedService<T>;
 declare function RestMethod<T>(callback: () => T): RequestHandler;
 declare function Restify(target: any, key: PropertyKey, desc: PropertyDescriptor): PropertyDescriptor;
 
-declare function PassBody<F extends RequsetHandlerWithFirstArg<any>>(serviceFunction: F): ShiftRequestHandler<F>
-declare function ParseBodyAs<T extends ValidTypeKeys | JsSchema | TypedSchema<any> | ArraySchema, F extends RequsetHandlerWithFirstArg<T>>(type: T): (serviceFunction: F) => ShiftRequestHandler<F>
-declare function PassBodyAs<T extends ValidTypeKeys | JsSchema | TypedSchema<any> | ArraySchema, F extends RequsetHandlerWithFirstArg<T>>(type: T): (serviceFunction: F) => ShiftRequestHandler<F>
-declare function PassAllParams<F extends RequsetHandlerWithFirstArg<string[]>>(serviceFunction: F): ShiftRequestHandler<F>
-declare function PassAllQueries<F extends RequsetHandlerWithFirstArg<string[]>>(serviceFunction: F): ShiftRequestHandler<F>
-declare function PassAllCookies<F extends RequsetHandlerWithFirstArg<string[]>>(serviceFunction: F): ShiftRequestHandler<F>
-declare function PassParam<F extends RequsetHandlerWithFirstArg<string | undefined>>(paramName: string): (serviceFunction: F) => ShiftRequestHandler<F>
-declare function PassQuery<F extends RequsetHandlerWithFirstArg<string | undefined>>(queryName: string): (serviceFunction: F) => ShiftRequestHandler<F>
-declare function PassCookie<F extends RequsetHandlerWithFirstArg<string | undefined>>(cookieName: string): (serviceFunction: F) => ShiftRequestHandler<F>
-declare function PassRequest<F extends RequsetHandlerWithFirstArg<Request>>(serviceFunction: F): ShiftRequestHandler<F>
-declare function PassResponse<F extends RequsetHandlerWithFirstArg<Response>>(serviceFunction: F): ShiftRequestHandler<F>
+declare function PassBody<F extends RequsetHandlerWithLastArg<any>>(serviceFunction: F): ShiftRequestHandler<F>
+declare function ParseBodyAs<S extends ValidTypeKeys | JsSchema | TypedSchema<any> | ArraySchema, T = TypeValueOf<S>>(type: S): <F extends RequsetHandlerWithLastArg<T>>(serviceFunction: F) => ShiftRequestHandler<F>
+declare function PassBodyAs<S extends ValidTypeKeys | JsSchema | TypedSchema<any> | ArraySchema, T = TypeValueOf<S>>(type: S): <F extends RequsetHandlerWithLastArg<T>>(serviceFunction: F) => ShiftRequestHandler<F>
+declare function PassAllParams<F extends RequsetHandlerWithLastArg<string[]>>(serviceFunction: F): ShiftRequestHandler<F>
+declare function PassAllQueries<F extends RequsetHandlerWithLastArg<string[]>>(serviceFunction: F): ShiftRequestHandler<F>
+declare function PassAllCookies<F extends RequsetHandlerWithLastArg<string[]>>(serviceFunction: F): ShiftRequestHandler<F>
+declare function PassParam(paramName: string): <F extends RequsetHandlerWithLastArg<string | undefined>>(serviceFunction: F) => ShiftRequestHandler<F>
+declare function PassQuery(queryName: string): <F extends RequsetHandlerWithLastArg<string | undefined>>(serviceFunction: F) => ShiftRequestHandler<F>
+declare function PassCookie(cookieName: string): <F extends RequsetHandlerWithLastArg<string | undefined>>(serviceFunction: F) => ShiftRequestHandler<F>
+declare function PassRequest<F extends RequsetHandlerWithLastArg<Request>>(serviceFunction: F): ShiftRequestHandler<F>
+declare function PassResponse<F extends RequsetHandlerWithLastArg<Response>>(serviceFunction: F): ShiftRequestHandler<F>
 
 export {
     RestService,

package/index.js

@@ -42,7 +42,11 @@ function RestService(service) {
                         }
                         else if (result instanceof Promise) {
                             result.then(r => {
-                                reply(res, r.status ?? 200, r.data ?? r);
+                                if (r == undefined) {
+                                    reply(res, 204, null);
+                                } else {
+                                    reply(res, r.status ?? 200, r.data ?? r);
+                                }
                             }).catch(e => {
                                 reply(res, e.status ?? 500, e.message ?? e);
                             })
@@ -70,7 +74,11 @@ function RestMethod(callback) {
             }
             else if (result instanceof Promise) {
                 result.then(r => {
-                    reply(res, r.status ?? 200, r.data ?? r);
+                    if (r == undefined) {
+                        reply(res, 204, undefined);
+                    } else {
+                        reply(res, r.status ?? 200, r.data ?? r);
+                    }
                 }).catch(e => {
                     reply(res, e.status ?? 500, e.message ?? e);
                 })
@@ -96,7 +104,11 @@ function Restify(target, key, desc) {
                     }
                     else if (result instanceof Promise) {
                         result.then(r => {
-                            reply(res, r.status ?? 200, r.data ?? r);
+                            if (r == undefined) {
+                                reply(res, 204, null);
+                            } else {
+                                reply(res, r.status ?? 200, r.data ?? r);
+                            }
                         }).catch(e => {
                             reply(res, e.status ?? 500, e.message ?? e);
                         })

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bootpress",
-  "version": "9.0.1",
+  "version": "9.1.0",
   "description": "REST service methods for express",
   "main": "index.js",
   "repository": {