bms-speckit-plugin 4.3.0 → 4.3.2

package/blueprints/bms-speckit-pipeline.yaml

@@ -46,7 +46,7 @@ chain_sequence:
       system_context: >
         Write a detailed specification from the user's requirement.
         Explore edge cases, constraints, and design alternatives.
-        Use mcp__knowledge-mcp__search_knowledge to search the hosxp
+        Use mcp__bms-knowledge-mcp__search_knowledge to search the hosxp
         collection for relevant data dictionaries, table schemas, and
         system architecture. Also search bms, moph, nhso collections
         if relevant to the feature.
@@ -126,7 +126,7 @@ chain_sequence:
       system_context: >
         Generate a complete, testable specification. Include acceptance criteria,
         data models, API contracts, and edge cases.
-        Use mcp__knowledge-mcp__search_knowledge to search the hosxp
+        Use mcp__bms-knowledge-mcp__search_knowledge to search the hosxp
         collection for exact table names, field names, data types, and
         relationships needed by this feature. Reference actual HOSxP
         data structures in the spec, not assumed ones.
@@ -240,23 +240,31 @@ chain_sequence:
         apply improvements, re-run all tests, confirm zero regression.
         Only output FINISHED after everything is validated.
 
-  - step_id: step_10_verify
+  - step_id: step_10_verify_and_fix
     skill_id: speckit.analyze
     action: execute
     phase: 2
-    description: Final validation pass — confirm production-grade quality
-    timeout_seconds: 300
+    description: Run all tests, lint, and build — find and fix all coding errors
+    timeout_seconds: 600
     post_action:
       commit: true
-      message: "chore(speckit): final verification pass complete"
+      message: "fix(speckit): verify and fix all coding errors"
       push: true
     error_handling:
       on_failure: stop
-      max_retries: 1
+      max_retries: 3
     opinionated_prompts:
       system_context: >
-        Final gate. Verify all tasks completed, tests passing,
-        no regressions, code quality standards met.
+        Final quality gate. This step MUST find and fix all coding errors:
+        1. Run the full test suite — fix any failing tests
+        2. Run linter (eslint/flake8/etc.) — fix all lint errors and warnings
+        3. Run build/compile — fix any type errors or build failures
+        4. Run static analysis if available — fix flagged issues
+        5. Check for runtime errors by reviewing error-prone patterns
+        6. Verify all imports resolve and no dead code references exist
+        7. Re-run all checks after fixes to confirm zero errors
+        Repeat until all checks pass cleanly. Do NOT skip or suppress errors.
+        Only proceed to merge when build + tests + lint all pass with zero errors.
 
   - step_id: step_11_merge
     skill_id: internal.git_merge_to_main

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bms-speckit-plugin",
-  "version": "4.3.0",
+  "version": "4.3.2",
   "description": "Chain-orchestrated development pipeline: /bms-speckit takes requirements and runs brainstorm → constitution → specify → plan → tasks → analyze → implement → verify with per-step error handling",
   "files": [
     ".claude-plugin/",

package/skills/bms-speckit-auto/SKILL.md

@@ -33,7 +33,7 @@ You are running the BMS Speckit specification and planning chain. Execute each s
 - **Skill:** `superpowers.brainstorm`
 - **Input:** "$ARGUMENTS"
 - **Purpose:** Explore intent, requirements, design alternatives, and edge cases
-- **Knowledge lookup:** Use `mcp__knowledge-mcp__search_knowledge` to search the `hosxp` collection for relevant data dictionaries, table schemas, and system architecture. Also search `bms`, `moph`, `nhso` collections if relevant.
+- **Knowledge lookup:** Use `mcp__bms-knowledge-mcp__search_knowledge` to search the `hosxp` collection for relevant data dictionaries, table schemas, and system architecture. Also search `bms`, `moph`, `nhso` collections if relevant.
 - **Output:** Detailed specification document
 - **Timeout:** 300s
 - **Post-action:** Commit all files and push. Message: `feat(speckit): brainstorm — explore requirements and design`
@@ -52,7 +52,7 @@ You are running the BMS Speckit specification and planning chain. Execute each s
 ### Step 4 — Specify `[on_failure: STOP]`
 - **Skill:** `speckit.specify`
 - **Input:** Use the detailed specification output from Step 1 (brainstorm) as the argument
-- **Knowledge lookup:** Use `mcp__knowledge-mcp__search_knowledge` to search the `hosxp` collection for exact table names, field names, data types, and relationships needed by this feature. Reference actual HOSxP data structures in the spec.
+- **Knowledge lookup:** Use `mcp__bms-knowledge-mcp__search_knowledge` to search the `hosxp` collection for exact table names, field names, data types, and relationships needed by this feature. Reference actual HOSxP data structures in the spec.
 - **Output:** `specs/*/spec.md`
 - **Timeout:** 300s
 - **Retry:** up to 2 attempts
@@ -102,11 +102,19 @@ After all steps complete, return: the feature name, number of tasks created, and
 
 `/ralph-loop:ralph-loop "systematically execute speckit.implement via the Skill tool to complete every task defined in {TASKS_PATH} with strict adherence to specification requirements, enforce TDD workflow including writing and passing unit, integration, and end-to-end tests before marking any task complete, ensure code quality through linting, static analysis, and consistent architecture with reusable components and centralized business logic, maintain atomic commits after each successful task with clear traceability, avoid requesting confirmation and proceed autonomously, once all tasks are implemented invoke speckit.analyze via the Skill tool to perform a full validation pass, automatically apply all recommended improvements or corrections, re-run all tests to confirm stability and zero regression, and only output <promise>FINISHED</promise> after every task is fully completed, validated, and aligned with production-grade quality standards" --completion-promise "FINISHED" --max-iterations 10`
 
-### Step 10 — Verify `[on_failure: STOP]`
-- **Skill:** `speckit.analyze`
-- **Purpose:** Final validation — confirm all tasks completed, tests passing, no regressions, code quality standards met.
-- **Timeout:** 300s
-- **Post-action:** Commit all files and push. Message: `chore(speckit): final verification pass complete`
+### Step 10 — Verify & Fix `[on_failure: STOP | max_retries: 3]`
+- **Purpose:** Find and fix ALL coding errors. This is the final quality gate before merge.
+- **Timeout:** 600s
+- **Actions (repeat until all pass cleanly):**
+  1. Run the full test suite — fix any failing tests
+  2. Run linter (eslint/flake8/etc.) — fix all lint errors and warnings
+  3. Run build/compile — fix any type errors or build failures
+  4. Run static analysis if available — fix flagged issues
+  5. Check for runtime errors by reviewing error-prone patterns
+  6. Verify all imports resolve and no dead code references exist
+  7. Re-run all checks after fixes to confirm zero errors
+- **Do NOT** skip or suppress errors. Repeat until build + tests + lint all pass with zero errors.
+- **Post-action:** Commit all fixes and push. Message: `fix(speckit): verify and fix all coding errors`
 
 ### Step 11 — Merge to Main `[on_failure: STOP]`
 - **Action:** Switch to main branch, merge the feature branch (fast-forward if possible), push main to remote, then clean up the feature branch.
@@ -122,7 +130,7 @@ Phase 1 (subagent)                          Phase 2 (main context)
 Step 1: brainstorm ──STOP── commit          Step 8:  compact
         + knowledge search (hosxp)          Step 9:  implement (ralph-loop)
 Step 2: constitution ─STOP─┐                         commit per task
-Step 3: CLAUDE.md sync ───┘ commit          Step 10: verify ── commit
+Step 3: CLAUDE.md sync ───┘ commit          Step 10: verify & fix ── commit
 Step 4: specify ──────STOP── commit         Step 11: merge to main + push
         + knowledge search (hosxp)
 Step 5: plan ─────────STOP── commit