bmad-studio 0.1.0

package/_bmad/tea/workflows/testarch/bmad-testarch-test-review/steps-c/step-03b-subagent-isolation.md

@@ -0,0 +1,125 @@
+---
+name: 'step-03b-subagent-isolation'
+description: 'Subagent: Check test isolation (no shared state/dependencies)'
+subagent: true
+outputFile: '/tmp/tea-test-review-isolation-{{timestamp}}.json'
+---
+
+# Subagent 3B: Isolation Quality Check
+
+## SUBAGENT CONTEXT
+
+This is an **isolated subagent** running in parallel with other quality dimension checks.
+
+**Your task:** Analyze test files for ISOLATION violations only.
+
+---
+
+## MANDATORY EXECUTION RULES
+
+- ✅ Check ISOLATION only (not other quality dimensions)
+- ✅ Output structured JSON to temp file
+- ❌ Do NOT check determinism, maintainability, coverage, or performance
+- ❌ Do NOT modify test files (read-only analysis)
+
+---
+
+## SUBAGENT TASK
+
+### 1. Identify Isolation Violations
+
+**Scan test files for isolation issues:**
+
+**HIGH SEVERITY Violations**:
+
+- Global state mutations (global variables modified)
+- Test order dependencies (test B depends on test A running first)
+- Shared database records without cleanup
+- beforeAll/afterAll with side effects leaking to other tests
+
+**MEDIUM SEVERITY Violations**:
+
+- Missing test cleanup (created data not deleted)
+- Shared fixtures that mutate state
+- Tests that assume specific execution order
+- Environment variables modified without restoration
+
+**LOW SEVERITY Violations**:
+
+- Tests sharing test data (but not mutating)
+- Missing test.describe grouping
+- Tests that could be more isolated
+
+### 2. Calculate Isolation Score
+
+```javascript
+const totalChecks = testFiles.length * checksPerFile;
+const failedChecks = violations.length;
+const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
+const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
+const score = Math.max(0, 100 - totalPenalty);
+```
+
+---
+
+## OUTPUT FORMAT
+
+```json
+{
+  "dimension": "isolation",
+  "score": 90,
+  "max_score": 100,
+  "grade": "A-",
+  "violations": [
+    {
+      "file": "tests/api/integration.spec.ts",
+      "line": 15,
+      "severity": "HIGH",
+      "category": "test-order-dependency",
+      "description": "Test depends on previous test creating user record",
+      "suggestion": "Each test should create its own test data in beforeEach",
+      "code_snippet": "test('should update user', async () => { /* assumes user exists */ });"
+    }
+  ],
+  "passed_checks": 14,
+  "failed_checks": 1,
+  "total_checks": 15,
+  "violation_summary": {
+    "HIGH": 1,
+    "MEDIUM": 0,
+    "LOW": 0
+  },
+  "recommendations": [
+    "Add beforeEach hooks to create test data",
+    "Add afterEach hooks to cleanup created records",
+    "Use test.describe.configure({ mode: 'parallel' }) to enforce isolation"
+  ],
+  "summary": "Tests are well isolated with 1 HIGH severity violation"
+}
+```
+
+---
+
+## EXIT CONDITION
+
+Subagent completes when:
+
+- ✅ All test files analyzed for isolation violations
+- ✅ Score calculated
+- ✅ JSON output written to temp file
+
+**Subagent terminates here.**
+
+---
+
+## 🚨 SUBAGENT SUCCESS METRICS
+
+### ✅ SUCCESS:
+
+- Only isolation checked (not other dimensions)
+- JSON output valid and complete
+
+### ❌ FAILURE:
+
+- Checked quality dimensions other than isolation
+- Invalid or missing JSON output

package/_bmad/tea/workflows/testarch/bmad-testarch-test-review/steps-c/step-03c-subagent-maintainability.md

@@ -0,0 +1,102 @@
+---
+name: 'step-03c-subagent-maintainability'
+description: 'Subagent: Check test maintainability (readability, structure, DRY)'
+subagent: true
+outputFile: '/tmp/tea-test-review-maintainability-{{timestamp}}.json'
+---
+
+# Subagent 3C: Maintainability Quality Check
+
+## SUBAGENT CONTEXT
+
+This is an **isolated subagent** running in parallel with other quality dimension checks.
+
+**Your task:** Analyze test files for MAINTAINABILITY violations only.
+
+---
+
+## MANDATORY EXECUTION RULES
+
+- ✅ Check MAINTAINABILITY only (not other quality dimensions)
+- ✅ Output structured JSON to temp file
+- ❌ Do NOT check determinism, isolation, coverage, or performance
+
+---
+
+## SUBAGENT TASK
+
+### 1. Identify Maintainability Violations
+
+**HIGH SEVERITY Violations**:
+
+- Tests >100 lines (too complex)
+- No test.describe grouping
+- Duplicate test logic (copy-paste)
+- Unclear test names (no Given/When/Then structure)
+- Magic numbers/strings without constants
+
+**MEDIUM SEVERITY Violations**:
+
+- Tests missing comments for complex logic
+- Inconsistent naming conventions
+- Excessive nesting (>3 levels)
+- Large setup/teardown blocks
+
+**LOW SEVERITY Violations**:
+
+- Minor code style issues
+- Could benefit from helper functions
+- Inconsistent assertion styles
+
+### 2. Calculate Maintainability Score
+
+```javascript
+const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
+const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
+const score = Math.max(0, 100 - totalPenalty);
+```
+
+---
+
+## OUTPUT FORMAT
+
+```json
+{
+  "dimension": "maintainability",
+  "score": 75,
+  "max_score": 100,
+  "grade": "C",
+  "violations": [
+    {
+      "file": "tests/e2e/complex-flow.spec.ts",
+      "line": 1,
+      "severity": "HIGH",
+      "category": "test-too-long",
+      "description": "Test file is 250 lines - too complex to maintain",
+      "suggestion": "Split into multiple smaller test files by feature area",
+      "code_snippet": "test.describe('Complex flow', () => { /* 250 lines */ });"
+    }
+  ],
+  "passed_checks": 10,
+  "failed_checks": 5,
+  "violation_summary": {
+    "HIGH": 2,
+    "MEDIUM": 2,
+    "LOW": 1
+  },
+  "recommendations": [
+    "Split large test files into smaller, focused files (<100 lines each)",
+    "Add test.describe grouping for related tests",
+    "Extract duplicate logic into helper functions"
+  ],
+  "summary": "Tests have maintainability issues - 5 violations (2 HIGH)"
+}
+```
+
+---
+
+## EXIT CONDITION
+
+Subagent completes when JSON output written to temp file.
+
+**Subagent terminates here.**

package/_bmad/tea/workflows/testarch/bmad-testarch-test-review/steps-c/step-03e-subagent-performance.md

@@ -0,0 +1,117 @@
+---
+name: 'step-03e-subagent-performance'
+description: 'Subagent: Check test performance (speed, efficiency, parallelization)'
+subagent: true
+outputFile: '/tmp/tea-test-review-performance-{{timestamp}}.json'
+---
+
+# Subagent 3E: Performance Quality Check
+
+## SUBAGENT CONTEXT
+
+This is an **isolated subagent** running in parallel with other quality dimension checks.
+
+**Your task:** Analyze test files for PERFORMANCE violations only.
+
+---
+
+## MANDATORY EXECUTION RULES
+
+- ✅ Check PERFORMANCE only (not other quality dimensions)
+- ✅ Output structured JSON to temp file
+- ❌ Do NOT check determinism, isolation, maintainability, or coverage
+
+---
+
+## SUBAGENT TASK
+
+### 1. Identify Performance Violations
+
+**HIGH SEVERITY Violations**:
+
+- Tests not parallelizable (using test.describe.serial unnecessarily)
+- Slow setup/teardown (creating fresh DB for every test)
+- Excessive navigation (reloading pages unnecessarily)
+- No fixture reuse (repeating expensive operations)
+
+**MEDIUM SEVERITY Violations**:
+
+- Hard waits >2 seconds (waitForTimeout(5000))
+- Inefficient selectors (page.$$ instead of locators)
+- Large data sets in tests without pagination
+- Missing performance optimizations
+
+**LOW SEVERITY Violations**:
+
+- Could use parallelization (test.describe.configure({ mode: 'parallel' }))
+- Minor inefficiencies
+- Excessive logging
+
+### 2. Calculate Performance Score
+
+```javascript
+const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
+const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
+const score = Math.max(0, 100 - totalPenalty);
+```
+
+---
+
+## OUTPUT FORMAT
+
+```json
+{
+  "dimension": "performance",
+  "score": 80,
+  "max_score": 100,
+  "grade": "B",
+  "violations": [
+    {
+      "file": "tests/e2e/search.spec.ts",
+      "line": 10,
+      "severity": "HIGH",
+      "category": "not-parallelizable",
+      "description": "Tests use test.describe.serial unnecessarily - reduces parallel execution",
+      "suggestion": "Remove .serial unless tests truly share state",
+      "code_snippet": "test.describe.serial('Search tests', () => { ... });"
+    },
+    {
+      "file": "tests/api/bulk-operations.spec.ts",
+      "line": 35,
+      "severity": "MEDIUM",
+      "category": "slow-setup",
+      "description": "Test creates 1000 records in setup - very slow",
+      "suggestion": "Use smaller data sets or fixture factories",
+      "code_snippet": "beforeEach(async () => { for (let i=0; i<1000; i++) { ... } });"
+    }
+  ],
+  "passed_checks": 13,
+  "failed_checks": 2,
+  "violation_summary": {
+    "HIGH": 1,
+    "MEDIUM": 1,
+    "LOW": 0
+  },
+  "performance_metrics": {
+    "parallelizable_tests": 80,
+    "serial_tests": 20,
+    "avg_test_duration_estimate": "~2 seconds",
+    "slow_tests": ["bulk-operations.spec.ts (>30s)"]
+  },
+  "recommendations": [
+    "Enable parallel mode where possible",
+    "Reduce setup data to minimum needed",
+    "Use fixtures to share expensive setup across tests",
+    "Remove unnecessary .serial constraints"
+  ],
+  "summary": "Good performance with 2 violations - 80% tests can run in parallel"
+}
+```
+
+---
+
+## EXIT CONDITION
+
+Subagent completes when JSON output written to temp file.
+
+**Subagent terminates here.**

package/_bmad/tea/workflows/testarch/bmad-testarch-test-review/steps-c/step-03f-aggregate-scores.md

@@ -0,0 +1,277 @@
+---
+name: 'step-03f-aggregate-scores'
+description: 'Aggregate quality dimension scores into overall 0-100 score'
+nextStepFile: './step-04-generate-report.md'
+outputFile: '{test_artifacts}/test-review.md'
+---
+
+# Step 3F: Aggregate Quality Scores
+
+## STEP GOAL
+
+Read outputs from 4 quality subagents, calculate weighted overall score (0-100), and aggregate violations for report generation.
+
+---
+
+## MANDATORY EXECUTION RULES
+
+- 📖 Read the entire step file before acting
+- ✅ Speak in `{communication_language}`
+- ✅ Read all 4 subagent outputs
+- ✅ Calculate weighted overall score
+- ✅ Aggregate violations by severity
+- ❌ Do NOT re-evaluate quality (use subagent outputs)
+
+---
+
+## EXECUTION PROTOCOLS:
+
+- 🎯 Follow the MANDATORY SEQUENCE exactly
+- 💾 Record outputs before proceeding
+- 📖 Load the next step only when instructed
+
+---
+
+## MANDATORY SEQUENCE
+
+### 1. Read All Subagent Outputs
+
+```javascript
+// Use the SAME timestamp generated in Step 3 (do not regenerate).
+const timestamp = subagentContext?.timestamp;
+if (!timestamp) {
+  throw new Error('Missing timestamp from Step 3 context. Pass Step 3 timestamp into Step 3F.');
+}
+const dimensions = ['determinism', 'isolation', 'maintainability', 'performance'];
+const results = {};
+
+dimensions.forEach((dim) => {
+  const outputPath = `/tmp/tea-test-review-${dim}-${timestamp}.json`;
+  results[dim] = JSON.parse(fs.readFileSync(outputPath, 'utf8'));
+});
+```
+
+**Verify all succeeded:**
+
+```javascript
+const allSucceeded = dimensions.every((dim) => results[dim].score !== undefined);
+if (!allSucceeded) {
+  throw new Error('One or more quality subagents failed!');
+}
+```
+
+---
+
+### 2. Calculate Weighted Overall Score
+
+**Dimension Weights** (based on TEA quality priorities):
+
+```javascript
+const weights = {
+  determinism: 0.3, // 30% - Reliability and flake prevention
+  isolation: 0.3, // 30% - Parallel safety and independence
+  maintainability: 0.25, // 25% - Readability and long-term health
+  performance: 0.15, // 15% - Speed and execution efficiency
+};
+```
+
+**Calculate overall score:**
+
+```javascript
+const overallScore = dimensions.reduce((sum, dim) => {
+  return sum + results[dim].score * weights[dim];
+}, 0);
+
+const roundedScore = Math.round(overallScore);
+```
+
+**Determine grade:**
+
+```javascript
+const getGrade = (score) => {
+  if (score >= 90) return 'A';
+  if (score >= 80) return 'B';
+  if (score >= 70) return 'C';
+  if (score >= 60) return 'D';
+  return 'F';
+};
+
+const overallGrade = getGrade(roundedScore);
+```
+
+---
+
+### 3. Aggregate Violations by Severity
+
+**Collect all violations from all dimensions:**
+
+```javascript
+const allViolations = dimensions.flatMap((dim) =>
+  results[dim].violations.map((v) => ({
+    ...v,
+    dimension: dim,
+  })),
+);
+
+// Group by severity
+const highSeverity = allViolations.filter((v) => v.severity === 'HIGH');
+const mediumSeverity = allViolations.filter((v) => v.severity === 'MEDIUM');
+const lowSeverity = allViolations.filter((v) => v.severity === 'LOW');
+
+const violationSummary = {
+  total: allViolations.length,
+  HIGH: highSeverity.length,
+  MEDIUM: mediumSeverity.length,
+  LOW: lowSeverity.length,
+};
+```
+
+---
+
+### 4. Prioritize Recommendations
+
+**Extract recommendations from all dimensions:**
+
+```javascript
+const allRecommendations = dimensions.flatMap((dim) =>
+  results[dim].recommendations.map((rec) => ({
+    dimension: dim,
+    recommendation: rec,
+    impact: results[dim].score < 70 ? 'HIGH' : 'MEDIUM',
+  })),
+);
+
+// Sort by impact (HIGH first)
+const prioritizedRecommendations = allRecommendations.sort((a, b) => (a.impact === 'HIGH' ? -1 : 1)).slice(0, 10); // Top 10 recommendations
+```
+
+---
+
+### 5. Create Review Summary Object
+
+**Aggregate all results:**
+
+```javascript
+const reviewSummary = {
+  overall_score: roundedScore,
+  overall_grade: overallGrade,
+  quality_assessment: getQualityAssessment(roundedScore),
+
+  dimension_scores: {
+    determinism: results.determinism.score,
+    isolation: results.isolation.score,
+    maintainability: results.maintainability.score,
+    performance: results.performance.score,
+  },
+
+  dimension_grades: {
+    determinism: results.determinism.grade,
+    isolation: results.isolation.grade,
+    maintainability: results.maintainability.grade,
+    performance: results.performance.grade,
+  },
+
+  violations_summary: violationSummary,
+
+  all_violations: allViolations,
+
+  high_severity_violations: highSeverity,
+
+  top_10_recommendations: prioritizedRecommendations,
+
+  subagent_execution: 'PARALLEL (4 quality dimensions)',
+  performance_gain: '~60% faster than sequential',
+};
+
+// Save for Step 4 (report generation)
+fs.writeFileSync(`/tmp/tea-test-review-summary-${timestamp}.json`, JSON.stringify(reviewSummary, null, 2), 'utf8');
+```
+
+---
+
+### 6. Display Summary to User
+
+```
+✅ Quality Evaluation Complete (Parallel Execution)
+
+📊 Overall Quality Score: {roundedScore}/100 (Grade: {overallGrade})
+
+📈 Dimension Scores:
+- Determinism:      {determinism_score}/100 ({determinism_grade})
+- Isolation:        {isolation_score}/100 ({isolation_grade})
+- Maintainability:  {maintainability_score}/100 ({maintainability_grade})
+- Performance:      {performance_score}/100 ({performance_grade})
+
+ℹ️ Coverage is excluded from `test-review` scoring. Use `trace` for coverage analysis and gates.
+
+⚠️ Violations Found:
+- HIGH:   {high_count} violations
+- MEDIUM: {medium_count} violations
+- LOW:    {low_count} violations
+- TOTAL:  {total_count} violations
+
+🚀 Performance: Parallel execution ~60% faster than sequential
+
+✅ Ready for report generation (Step 4)
+```
+
+---
+
+---
+
+### 7. Save Progress
+
+**Save this step's accumulated work to `{outputFile}`.**
+
+- **If `{outputFile}` does not exist** (first save), create it using the workflow template (if available) with YAML frontmatter:
+
+  ```yaml
+  ---
+  stepsCompleted: ['step-03f-aggregate-scores']
+  lastStep: 'step-03f-aggregate-scores'
+  lastSaved: '{date}'
+  ---
+  ```
+
+  Then write this step's output below the frontmatter.
+
+- **If `{outputFile}` already exists**, update:
+  - Add `'step-03f-aggregate-scores'` to `stepsCompleted` array (only if not already present)
+  - Set `lastStep: 'step-03f-aggregate-scores'`
+  - Set `lastSaved: '{date}'`
+  - Append this step's output to the appropriate section of the document.
+
+---
+
+## EXIT CONDITION
+
+Proceed to Step 4 when:
+
+- ✅ All subagent outputs read successfully
+- ✅ Overall score calculated
+- ✅ Violations aggregated
+- ✅ Recommendations prioritized
+- ✅ Summary saved to temp file
+- ✅ Output displayed to user
+- ✅ Progress saved to output document
+
+Load next step: `{nextStepFile}`
+
+---
+
+## 🚨 SYSTEM SUCCESS METRICS
+
+### ✅ SUCCESS:
+
+- All 4 subagent outputs read and parsed
+- Overall score calculated with proper weights
+- Violations aggregated correctly
+- Summary complete and saved
+
+### ❌ FAILURE:
+
+- Failed to read one or more subagent outputs
+- Score calculation incorrect
+- Summary missing or incomplete
+
+**Master Rule:** Aggregate determinism, isolation, maintainability, and performance only.