bmad-plus 0.9.1 → 0.9.2

package/CHANGELOG.md

@@ -5,6 +5,27 @@ All notable changes to BMAD+ will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.9.2] — 2026-07-01
+
+### Security — Phase 1 remediation (exploitable findings)
+- **RCE closed** (`ci_cd.py`): command allowlist now uses exact-token matching (shlex.split) + realpath/commonpath containment instead of prefix/`startswith` — defeats argument injection (`make -f attacker.mk`) and sibling-path bypass; `shell=False` throughout; dead Makefile fallback removed.
+- **SSRF hardened** (`seo_fetch.py`): fails **closed** on DNS error, blocks private/loopback/reserved/link-local IPs (incl. IPv4-mapped IPv6), re-validates every redirect hop manually.
+- **Stored + DOM XSS closed** (`seo_report.py`, `dashboard.html`): all audited/external values HTML-escaped in the report; dashboard renders via `textContent`/`createElement` + `addEventListener` instead of `innerHTML`/inline `onclick`.
+- **MCP server** (`server.py`): constant-time `hmac.compare_digest` for token + dashboard password; app assembled in module-level `create_app()` so `uvicorn server:app` runs with auth intact; dead `verify_mcp_token` removed; rate-limit map eviction.
+- **XXE**: `seo_crawl.py` hard-fails without `defusedxml` (no unsafe stdlib fallback).
+
+### Supply chain
+- `requests>=2.32.4` (CVE-2024-35195) across all requirements files.
+- `PyPDF2`→`pypdf==4.3.1` (dep + consumer import in `gamma_report.py`).
+- `defusedxml==0.7.1` added; Dockerfile non-root user + tag pin; docker-compose off `:latest`; GitHub Actions pinned to commit SHAs; Dependabot covers pip + docker + github-actions.
+
+### Fixed — robustness
+- Non-destructive install (backs up existing CLAUDE/GEMINI/AGENTS.md); marker-based uninstall; IDE-scoped autoconfig; `doctor` no longer emits false "Missing agent" warnings; guarded manifest `JSON.parse`; Windows-safe project-path hashing; hardened `validateUserName`; lazy RAG model load; async gamma polling; repo-URL validation; `git_ops` path confinement.
+
+### Notes
+- Documented residual follow-ups (SSRF crawler-class redirect hops, DNS-rebinding IP pinning, Dockerfile digest pin) are tracked in `audit/2026-07-01/PHASE-1-STATUS.md`.
+- Verified: `npm test` 176/176, `npm run lint` 0 errors, all edited Python parses; SEO report smoke-tested (renders + XSS escaped).
+
 ## [0.9.1] — 2026-07-01
 
 ### Fixed — Credibility (honest status)

package/README.md

@@ -1,6 +1,6 @@
 # 🚀 BMAD+ — Augmented Multi-Agent AI Framework
 
-[![Version](https://img.shields.io/badge/version-0.9.0-blue.svg)](CHANGELOG.md)
+[![Version](https://img.shields.io/badge/version-0.9.2-blue.svg)](CHANGELOG.md)
 [![Based on](https://img.shields.io/badge/based%20on-BMAD--METHOD-green.svg)](https://github.com/bmad-code-org/BMAD-METHOD)
 [![License](https://img.shields.io/badge/license-MIT-yellow.svg)](LICENSE)
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "bmad-plus",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "description": "BMAD+ — Augmented AI-Driven Development Framework with multi-role agents, autopilot, and parallel execution",
   "keywords": [
     "bmad",

package/tools/cli/commands/autoconfig.js

@@ -11,6 +11,7 @@ const fs = require('node:fs');
 const clack = require('@clack/prompts');
 const pc = require('picocolors');
 const { detectStack } = require('../lib/stack-detect');
+const { IDE_CONFIGS } = require('../lib/ide-config');
 
 // ── Project Analysis Engine ──
 
@@ -282,7 +283,23 @@ module.exports = {
 
       // Use the install module directly
       const installModule = require('./install');
-      const toolsArg = structure.hasIdeConfigs.length > 0 ? 'none' : undefined;
+
+      // NODE-06: only generate IDE configs for IDEs this project actually uses.
+      // - If IDE config files already exist, preserve them ('none').
+      // - Otherwise detect IDE markers and pass only those; never let install's
+      //   --yes fallback write ALL three configs into a project that uses none.
+      let toolsArg;
+      if (structure.hasIdeConfigs.length > 0) {
+        toolsArg = 'none';
+      } else {
+        const detectedIDEs = [];
+        for (const [id, ide] of Object.entries(IDE_CONFIGS)) {
+          if (ide.detect.some(marker => fs.existsSync(path.join(projectDir, marker)))) {
+            detectedIDEs.push(id);
+          }
+        }
+        toolsArg = detectedIDEs.length > 0 ? detectedIDEs.join(',') : 'none';
+      }
 
       // Build install args
       try {

package/tools/cli/commands/doctor.js

@@ -88,6 +88,18 @@ module.exports = {
           const packPath = path.join(agentsDir, entry.packDir);
           if (fs.existsSync(packPath)) {
             passed++;
+
+            // These packs bundle their agents as files inside packDir — verify
+            // them there (not as loose directories, which would falsely warn).
+            for (const agentFile of (entry.packAgents || [])) {
+              checks++;
+              if (fs.existsSync(path.join(packPath, agentFile))) {
+                passed++;
+              } else {
+                clack.log.warn(`⚠️  Missing agent: ${agentFile} (pack: ${pack})`);
+                warnings++;
+              }
+            }
           } else {
             clack.log.warn(`⚠️  Missing pack directory: ${entry.packDir} (pack: ${pack})`);
             warnings++;

package/tools/cli/commands/install.js

@@ -246,12 +246,32 @@ module.exports = {
       ideSpinner.start(i.configuring_ides);
 
       const configContent = generateIDEConfig(userName, commLang, selectedPacks);
+      // Marker present in every BMAD+-generated IDE config (see lib/ide-config.js).
+      const BMAD_MARKER = 'BMAD+ — AI Agent Configuration';
 
       for (const ideId of detectedIDEs) {
         const ide = IDE_CONFIGS[ideId];
         if (!ide) continue;
 
         const configPath = path.join(projectDir, ide.configFile);
+
+        // NODE-02: never clobber a hand-authored config without protecting it.
+        if (fs.existsSync(configPath)) {
+          const existing = fs.readFileSync(configPath, 'utf8');
+          if (!existing.includes(BMAD_MARKER)) {
+            if (!options.yes) {
+              // Interactive: keep the user's file untouched.
+              clack.log.warn(`⚠️  ${ide.configFile} already exists and was not created by BMAD+ — kept your file (skipped). Re-run with --yes to back it up and overwrite.`);
+              continue;
+            }
+            // Non-interactive: back up before overwriting, never destroy data.
+            let backupPath = `${configPath}.bak`;
+            if (fs.existsSync(backupPath)) backupPath = `${configPath}.${Date.now()}.bak`;
+            fs.copyFileSync(configPath, backupPath);
+            clack.log.warn(`⚠️  Backed up existing ${ide.configFile} → ${path.basename(backupPath)}`);
+          }
+        }
+
         fs.writeFileSync(configPath, configContent, 'utf8');
       }
 

package/tools/cli/commands/scan.js

@@ -118,6 +118,22 @@ function scanDirectory(rootDir, maxDepth = 4, currentDepth = 0, activeDays = 30,
   return projects;
 }
 
+/**
+ * Normalize a filesystem path for stable hashing.
+ * On Windows the same project can be referenced as `D:\proj` or `d:\proj`
+ * (case-insensitive drive) with mixed separators. Resolving + lowercasing the
+ * drive letter ensures the same project produces the same index key and is not
+ * double-indexed.
+ * @param {string} p - Raw filesystem path
+ * @returns {string} Normalized path suitable for hashing
+ */
+function normalizePathForHash(p) {
+  let resolved = path.resolve(p);
+  // Lowercase a leading Windows drive letter (e.g. "D:" → "d:").
+  resolved = resolved.replace(/^([A-Za-z]):/, (_m, drive) => drive.toLowerCase() + ':');
+  return resolved;
+}
+
 /**
  * Index a single project in the global brain by writing its metadata YAML file.
  * @param {object} project - Project metadata object
@@ -125,7 +141,7 @@ function scanDirectory(rootDir, maxDepth = 4, currentDepth = 0, activeDays = 30,
  * @returns {void}
  */
 function indexProject(project, globalBrainDir) {
-  const hash = crypto.createHash('sha256').update(project.path).digest('hex').slice(0, 8);
+  const hash = crypto.createHash('sha256').update(normalizePathForHash(project.path)).digest('hex').slice(0, 8);
   const meta = {
     path: project.path,
     name: project.name,
@@ -341,6 +357,7 @@ module.exports = {
     getProjectName,
     hasBmadInstalled,
     scanDirectory,
+    normalizePathForHash,
     indexProject,
     indexProjects,
   },

package/tools/cli/commands/uninstall.js

@@ -86,7 +86,9 @@ module.exports = {
       const p = path.join(projectDir, configFile);
       if (fs.existsSync(p)) {
         const content = fs.readFileSync(p, 'utf8');
-        if (content.includes('BMAD+')) {
+        // NODE-05: only remove a config BMAD+ actually generated (it carries the
+        // marker below). A hand-authored file that merely mentions "BMAD+" is kept.
+        if (content.includes('BMAD+ — AI Agent Configuration')) {
           fs.unlinkSync(p);
           removed++;
         }

package/tools/cli/commands/update.js

@@ -39,7 +39,21 @@ module.exports = {
       return;
     }
 
-    const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
+    let manifest;
+    try {
+      manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
+    } catch (err) {
+      clack.log.error(`Install manifest is unreadable or corrupt: ${err.message}`);
+      clack.log.info('Re-run `npx bmad-plus install` to repair the installation.');
+      clack.outro(pc.red('Update aborted.'));
+      return;
+    }
+    if (!manifest || typeof manifest !== 'object') {
+      clack.log.error('Install manifest is malformed (not an object).');
+      clack.log.info('Re-run `npx bmad-plus install` to repair the installation.');
+      clack.outro(pc.red('Update aborted.'));
+      return;
+    }
     const lang = options.lang || manifest.uiLanguage || 'en';
     const i = t(lang);
 
@@ -51,7 +65,10 @@ module.exports = {
       return;
     }
 
-    const selectedPacks = manifest.packs || ['core'];
+    // Guard against a missing/malformed `packs` field (NODE-04): coerce to an array.
+    const selectedPacks = Array.isArray(manifest.packs) && manifest.packs.length > 0
+      ? manifest.packs
+      : ['core'];
     clack.log.info(`${i.selected_packs}: ${selectedPacks.join(', ')}`);
 
     const confirm = await clack.confirm({

package/tools/cli/lib/packs.js

@@ -1,114 +1,122 @@
-/**
- * BMAD+ Shared PACKS Module
- * Single source of truth for pack definitions, expected agents, and pack ordering.
- *
- * Author: Laurent Rochetta
- */
-
-const PACKS = {
-  core: {
-    name: 'Core',
-    icon: 'b',
-    agents: ['agent-strategist', 'agent-architect-dev', 'agent-quality', 'agent-orchestrator'],
-    skills: ['bmad-plus-autopilot', 'bmad-plus-parallel', 'bmad-plus-sync'],
-    data: ['role-triggers.yaml'],
-    packDir: 'pack-core',
-    packSrcDir: 'packs',
-    required: true,
-    desc: 'Core agents & skills',
-  },
-  osint: {
-    name: 'OSINT',
-    icon: 'j',
-    agents: ['agent-shadow'],
-    skills: [],
-    externalPackage: 'osint-agent-package',
-    packDir: 'pack-osint',
-    packSrcDir: 'packs',
-    desc: 'OSINT & investigation',
-  },
-  maker: {
-    name: 'Maker',
-    icon: 'f',
-    agents: ['agent-maker'],
-    skills: [],
-    data: [],
-    packDir: 'pack-maker',
-    packSrcDir: 'packs',
-    desc: 'Agent creation toolkit',
-  },
-  shield: {
-    name: 'Shield',
-    icon: 'm',
-    agents: ['shield-orchestrator'],
-    skills: [],
-    packDir: 'pack-shield',
-    packSrcDir: 'packs',
-    desc: 'GRC compliance (25+ frameworks)',
-  },
-  seo: {
-    name: 'SEO',
-    icon: 'k',
-    agents: ['seo-scout', 'seo-chief', 'seo-judge'],
-    skills: [],
-    packDir: 'pack-seo',
-    packSrcDir: 'packs',
-    desc: 'SEO audit & optimization',
-  },
-  memory: {
-    name: 'Memory',
-    icon: 'x',
-    agents: ['zecher'],
-    skills: [],
-    packDir: 'pack-memory',
-    packSrcDir: 'packs',
-    desc: 'Persistent cross-session memory',
-  },
-  'dev-studio': {
-    name: 'Dev Studio',
-    icon: 'v',
-    agents: ['dev-studio-orchestrator'],
-    skills: ['dev-studio'],
-    packDir: 'pack-dev-studio',
-    packSrcDir: 'packs',
-    desc: 'SDLC automation (6 agents, 56+ skills)',
-  },
-  backup: {
-    name: 'Backup',
-    icon: 'y',
-    agents: ['backup-agent'],
-    skills: [],
-    packDir: 'pack-backup',
-    packSrcDir: 'packs',
-    desc: 'Backup & restore',
-  },
-  animated: {
-    name: 'Animated',
-    icon: 'z',
-    agents: ['animated-website-agent'],
-    skills: [],
-    packDir: 'pack-animated',
-    packSrcDir: 'packs',
-    desc: 'Animated website agents',
-  },
-};
-
-const PACK_ORDER = ['core', 'osint', 'maker', 'shield', 'seo', 'memory', 'dev-studio', 'backup', 'animated'];
-
-/**
- * Maps each pack to the list of directory names expected under .agents/skills/
- * after installation. Each entry contains agent directory names AND/OR pack directory names.
- */
-const EXPECTED_AGENTS = {
-  core:       { agents: ['agent-strategist', 'agent-architect-dev', 'agent-quality', 'agent-orchestrator'], packDir: null },
-  osint:      { agents: ['agent-shadow'],                                                                    packDir: null },
-  maker:      { agents: ['agent-maker'],                                                                     packDir: null },
-  shield:     { agents: ['shield-orchestrator'],                                                             packDir: 'pack-shield' },
-  seo:        { agents: ['seo-scout', 'seo-chief', 'seo-judge'],                                             packDir: 'pack-seo' },
-  memory:     { agents: ['zecher'],                                                                          packDir: 'pack-memory' },
-  'dev-studio':  { agents: ['dev-studio-orchestrator'],                                                       packDir: 'pack-dev-studio' },
-  backup:     { agents: ['backup-agent'],                                                                    packDir: 'pack-backup' },
-  animated:   { agents: ['animated-website-agent'],                                                          packDir: 'pack-animated' },
-};
-
-module.exports = { PACKS, PACK_ORDER, EXPECTED_AGENTS };
+/**
+ * BMAD+ Shared PACKS Module
+ * Single source of truth for pack definitions, expected agents, and pack ordering.
+ *
+ * Author: Laurent Rochetta
+ */
+
+const PACKS = {
+  core: {
+    name: 'Core',
+    icon: 'b',
+    agents: ['agent-strategist', 'agent-architect-dev', 'agent-quality', 'agent-orchestrator'],
+    skills: ['bmad-plus-autopilot', 'bmad-plus-parallel', 'bmad-plus-sync'],
+    data: ['role-triggers.yaml'],
+    packDir: 'pack-core',
+    packSrcDir: 'packs',
+    required: true,
+    desc: 'Core agents & skills',
+  },
+  osint: {
+    name: 'OSINT',
+    icon: 'j',
+    agents: ['agent-shadow'],
+    skills: [],
+    externalPackage: 'osint-agent-package',
+    packDir: 'pack-osint',
+    packSrcDir: 'packs',
+    desc: 'OSINT & investigation',
+  },
+  maker: {
+    name: 'Maker',
+    icon: 'f',
+    agents: ['agent-maker'],
+    skills: [],
+    data: [],
+    packDir: 'pack-maker',
+    packSrcDir: 'packs',
+    desc: 'Agent creation toolkit',
+  },
+  shield: {
+    name: 'Shield',
+    icon: 'm',
+    agents: ['shield-orchestrator'],
+    skills: [],
+    packDir: 'pack-shield',
+    packSrcDir: 'packs',
+    desc: 'GRC compliance (25+ frameworks)',
+  },
+  seo: {
+    name: 'SEO',
+    icon: 'k',
+    agents: ['seo-scout', 'seo-chief', 'seo-judge'],
+    skills: [],
+    packDir: 'pack-seo',
+    packSrcDir: 'packs',
+    desc: 'SEO audit & optimization',
+  },
+  memory: {
+    name: 'Memory',
+    icon: 'x',
+    agents: ['zecher'],
+    skills: [],
+    packDir: 'pack-memory',
+    packSrcDir: 'packs',
+    desc: 'Persistent cross-session memory',
+  },
+  'dev-studio': {
+    name: 'Dev Studio',
+    icon: 'v',
+    agents: ['dev-studio-orchestrator'],
+    skills: ['dev-studio'],
+    packDir: 'pack-dev-studio',
+    packSrcDir: 'packs',
+    desc: 'SDLC automation (6 agents, 56+ skills)',
+  },
+  backup: {
+    name: 'Backup',
+    icon: 'y',
+    agents: ['backup-agent'],
+    skills: [],
+    packDir: 'pack-backup',
+    packSrcDir: 'packs',
+    desc: 'Backup & restore',
+  },
+  animated: {
+    name: 'Animated',
+    icon: 'z',
+    agents: ['animated-website-agent'],
+    skills: [],
+    packDir: 'pack-animated',
+    packSrcDir: 'packs',
+    desc: 'Animated website agents',
+  },
+};
+
+const PACK_ORDER = ['core', 'osint', 'maker', 'shield', 'seo', 'memory', 'dev-studio', 'backup', 'animated'];
+
+/**
+ * Maps each pack to what `bmad-plus doctor` should expect under .agents/skills/
+ * after installation.
+ *
+ * - `agents`    — loose agent DIRECTORIES copied straight into .agents/skills/
+ *                 (only core/osint/maker ship their agents this way).
+ * - `packDir`   — the pack DIRECTORY copied into .agents/skills/ (null when none).
+ * - `packAgents`— agent FILES that live INSIDE `packDir` (shield/seo/memory/
+ *                 dev-studio/backup/animated bundle their agents this way, so they
+ *                 must not be checked as loose directories — doing so produced
+ *                 false "Missing agent" warnings on every healthy install).
+ */
+const EXPECTED_AGENTS = {
+  core:       { agents: ['agent-strategist', 'agent-architect-dev', 'agent-quality', 'agent-orchestrator'], packDir: null },
+  osint:      { agents: ['agent-shadow'],                                                                    packDir: null },
+  maker:      { agents: ['agent-maker'],                                                                     packDir: null },
+  shield:     { agents: [], packDir: 'pack-shield',     packAgents: ['shield-orchestrator.md'] },
+  seo:        { agents: [], packDir: 'pack-seo',        packAgents: ['seo-scout.md', 'seo-chief.md', 'seo-judge.md'] },
+  memory:     { agents: [], packDir: 'pack-memory',     packAgents: ['zecher-agent.md', 'memory-orchestrator.md'] },
+  'dev-studio': { agents: [], packDir: 'pack-dev-studio', packAgents: ['dev-studio-orchestrator.md'] },
+  backup:     { agents: [], packDir: 'pack-backup',     packAgents: ['backup-agent.md'] },
+  animated:   { agents: [], packDir: 'pack-animated',   packAgents: ['animated-website-agent.md'] },
+};
+
+module.exports = { PACKS, PACK_ORDER, EXPECTED_AGENTS };

package/tools/cli/lib/validate.js

@@ -3,8 +3,12 @@
  * Extracted from install.js for modularity and reuse.
  */
 
-// Shell metacharacters that are dangerous in user-provided names
-const SHELL_META = /[;&|`$(){}[\]!#~<>*?\\\n\r]/;
+// Shell/quote metacharacters that are dangerous in user-provided names.
+// Includes single/double quotes so a name cannot break out of a quoted context.
+const SHELL_META = /[;&|`$(){}[\]!#~<>*?\\'"\n\r]/;
+// Global variant used to strip EVERY occurrence during sanitization.
+// (A non-global regex in String.replace only removes the first match.)
+const SHELL_META_GLOBAL = /[;&|`$(){}[\]!#~<>*?\\'"\n\r]/g;
 
 /**
  * Validate and sanitize a user name.
@@ -31,7 +35,7 @@ function validateUserName(rawName, fallback) {
   }
 
   if (SHELL_META.test(rawName)) {
-    const sanitized = rawName.replace(SHELL_META, '').trim() || 'Developer';
+    const sanitized = rawName.replace(SHELL_META_GLOBAL, '').trim() || 'Developer';
     warnings.push('Name contains shell metacharacters. Using sanitized version.');
     return { name: sanitized, warnings };
   }
@@ -42,4 +46,5 @@ function validateUserName(rawName, fallback) {
 module.exports = {
   validateUserName,
   SHELL_META,
+  SHELL_META_GLOBAL,
 };