bmad-plus 0.9.0 → 0.9.2

package/tools/cli/commands/doctor.js

@@ -17,6 +17,7 @@ module.exports = {
   description: 'Check BMAD+ installation integrity',
   options: [
     ['-d, --directory <path>', 'Project directory (default: current directory)'],
+    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it'],
   ],
   action: async (options) => {
     const projectDir = path.resolve(options.directory || process.cwd());
@@ -39,6 +40,7 @@ module.exports = {
     }
 
     const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
+    const lang = options.lang || manifest.uiLanguage || 'en';
     clack.log.success(`✅ Manifest found — v${manifest.version}`);
     passed++;
 
@@ -86,6 +88,18 @@ module.exports = {
           const packPath = path.join(agentsDir, entry.packDir);
           if (fs.existsSync(packPath)) {
             passed++;
+
+            // These packs bundle their agents as files inside packDir — verify
+            // them there (not as loose directories, which would falsely warn).
+            for (const agentFile of (entry.packAgents || [])) {
+              checks++;
+              if (fs.existsSync(path.join(packPath, agentFile))) {
+                passed++;
+              } else {
+                clack.log.warn(`⚠️  Missing agent: ${agentFile} (pack: ${pack})`);
+                warnings++;
+              }
+            }
           } else {
             clack.log.warn(`⚠️  Missing pack directory: ${entry.packDir} (pack: ${pack})`);
             warnings++;

package/tools/cli/commands/install.js

@@ -8,7 +8,6 @@
 
 const path = require('node:path');
 const fs = require('node:fs');
-const os = require('node:os');
 const fsExtra = require('fs-extra');
 const clack = require('@clack/prompts');
 const pc = require('picocolors');
@@ -16,33 +15,11 @@ const { t, getLanguageOptions, getCommLanguageOptions } = require('../i18n');
 const { PACKS } = require('../lib/packs');
 const { copyPackFiles } = require('../lib/pack-copy');
 const { initMemory } = require('../lib/memory-init');
+const { generateIDEConfig, IDE_CONFIGS } = require('../lib/ide-config');
+const { validateUserName } = require('../lib/validate');
 
 // Pack definitions are imported from the shared module: require('../lib/packs').PACKS
 
-// IDE configurations
-const IDE_CONFIGS = {
-  'claude-code': {
-    name: 'Claude Code',
-    detect: ['.claude'],
-    configFile: 'CLAUDE.md',
-  },
-  'gemini-cli': {
-    name: 'Gemini CLI',
-    detect: ['.gemini'],
-    configFile: 'GEMINI.md',
-  },
-  'codex-cli': {
-    name: 'Codex CLI / OpenCode',
-    detect: ['.codex', '.opencode'],
-    configFile: 'AGENTS.md',
-  },
-  'antigravity': {
-    name: 'Antigravity',
-    detect: ['.gemini/antigravity'],
-    configFile: 'GEMINI.md',
-  },
-};
-
 module.exports = {
   command: 'install',
   description: 'Install BMAD+ agents and skills into your project',
@@ -50,6 +27,7 @@ module.exports = {
     ['-d, --directory <path>', 'Installation directory (default: current directory)'],
     ['-p, --packs <packs>', 'Comma-separated pack IDs: core,osint,all (default: interactive)'],
     ['-y, --yes', 'Accept all defaults, skip prompts'],
+    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it (overrides auto-detection)'],
     ['--tools <tools>', 'Comma-separated IDE IDs (default: auto-detect)'],
   ],
   action: async (options) => {
@@ -61,8 +39,8 @@ module.exports = {
     clack.intro(pc.bgCyan(pc.black(` BMAD+ Installer v${pkgJson.version} `)));
     clack.log.info(pc.dim('✨ Created by Laurent Rochetta — github.com/lrochetta/BMAD-PLUS'));
 
-    let lang = 'en';
-    if (!options.yes) {
+    let lang = options.lang || 'en';
+    if (!options.yes && !options.lang) {
       const langChoice = await clack.select({
         message: '🌐 Select your language / Choisissez votre langue / 选择语言',
         options: getLanguageOptions(),
@@ -200,19 +178,10 @@ module.exports = {
 
       // Validate user-provided name
       const rawName = userConfig.userName;
-      const SHELL_META = /[;&|`$(){}[\]!#~<>*?\\\n\r]/;
-      if (!rawName || rawName.trim().length === 0) {
-        clack.log.warn('Name cannot be empty. Using default.');
-        userName = process.env.USER || process.env.USERNAME || 'Developer';
-      } else if (rawName.length > 100) {
-        clack.log.warn('Name too long (>100 chars). Truncating.');
-        userName = rawName.slice(0, 100);
-      } else if (SHELL_META.test(rawName)) {
-        clack.log.warn('Name contains shell metacharacters. Using sanitized version.');
-        userName = rawName.replace(SHELL_META, '').trim() || 'Developer';
-      } else {
-        userName = rawName;
-      }
+      const fb = process.env.USER || process.env.USERNAME || 'Developer';
+      const { name: validatedName, warnings } = validateUserName(rawName, fb);
+      for (const w of warnings) clack.log.warn(w);
+      userName = validatedName;
       commLang = userConfig.commLang;
     }
 
@@ -277,12 +246,32 @@ module.exports = {
       ideSpinner.start(i.configuring_ides);
 
       const configContent = generateIDEConfig(userName, commLang, selectedPacks);
+      // Marker present in every BMAD+-generated IDE config (see lib/ide-config.js).
+      const BMAD_MARKER = 'BMAD+ — AI Agent Configuration';
 
       for (const ideId of detectedIDEs) {
         const ide = IDE_CONFIGS[ideId];
         if (!ide) continue;
 
         const configPath = path.join(projectDir, ide.configFile);
+
+        // NODE-02: never clobber a hand-authored config without protecting it.
+        if (fs.existsSync(configPath)) {
+          const existing = fs.readFileSync(configPath, 'utf8');
+          if (!existing.includes(BMAD_MARKER)) {
+            if (!options.yes) {
+              // Interactive: keep the user's file untouched.
+              clack.log.warn(`⚠️  ${ide.configFile} already exists and was not created by BMAD+ — kept your file (skipped). Re-run with --yes to back it up and overwrite.`);
+              continue;
+            }
+            // Non-interactive: back up before overwriting, never destroy data.
+            let backupPath = `${configPath}.bak`;
+            if (fs.existsSync(backupPath)) backupPath = `${configPath}.${Date.now()}.bak`;
+            fs.copyFileSync(configPath, backupPath);
+            clack.log.warn(`⚠️  Backed up existing ${ide.configFile} → ${path.basename(backupPath)}`);
+          }
+        }
+
         fs.writeFileSync(configPath, configContent, 'utf8');
       }
 
@@ -441,94 +430,6 @@ module.exports = {
 
 // ── Helpers ──
 
-function generateIDEConfig(userName, language, packs) {
-  const agents = [
-    '- **Atlas** (Strategist) — Business analysis + Product management',
-    '- **Forge** (Architect-Dev) — Architecture + Development + Documentation',
-    '- **Sentinel** (Quality) — QA + UX review',
-    '- **Nexus** (Orchestrator) — Sprint management + Autopilot + Parallel execution',
-  ];
-
-  if (packs.includes('osint')) {
-    agents.push('- **Shadow** (OSINT) — Investigation + Scraping + Psychoprofiling');
-  }
-
-  if (packs.includes('shield')) {
-    agents.push('- **Shield** (GRC) — 38 compliance agents (GDPR, ISO 27001, SOC 2, HIPAA, EU AI Act, DORA, NIS2...)');
-  }
-
-  if (packs.includes('dev-studio')) {
-    agents.push('- **Miriam** (מרים) — Business Analyst — Strategic analysis, research, product briefs');
-    agents.push('- **Huldah** (חולדה) — Technical Writer — Documentation, diagrams, editorial review');
-    agents.push('- **Yosef** (יוסף) — Product Manager — PRD, requirements, feature prioritization');
-    agents.push('- **Rachel** (רחל) — UX Designer — User experience, wireframes, empathy mapping');
-    agents.push('- **Bezalel** (בצלאל) — System Architect — Architecture, ADRs, epics & stories');
-    agents.push('- **Oholiab** (אהליאב) — Senior Engineer — TDD, sprint, code review, implementation');
-  }
-
-  if (packs.includes('memory')) {
-    agents.push('- **Zecher** (זכר) — Memory Archivist — Consolidation, project scanning, context recall');
-  }
-
-  // Build memory section if memory pack is installed
-  let memorySection = '';
-  if (packs.includes('memory')) {
-    memorySection = [
-      '',
-      '## Memory Protocol (Karpathy Guardrails)',
-      '',
-      'Agents MUST follow these behavioral principles:',
-      '',
-      '### G1 — Think Before Coding',
-      '- State assumptions explicitly. If uncertain, ask.',
-      '- Check `.agents/memory/decisions.md` for prior decisions before re-deciding.',
-      '',
-      '### G2 — Simplicity First',
-      '- Minimum code that solves the problem. Nothing speculative.',
-      '- Check `.agents/memory/patterns.md` for existing solutions.',
-      '',
-      '### G3 — Surgical Changes',
-      '- Touch only what you must. Match existing style.',
-      '- Log surprises in `.agents/memory/lessons.md`.',
-      '',
-      '### G4 — Goal-Driven Execution',
-      '- Define success criteria before implementing.',
-      '- Log non-obvious decisions in `.agents/memory/decisions.md`.',
-      '',
-      '### Memory Files',
-      '- `.agents/memory/decisions.md` — Read at session start, write when making decisions',
-      '- `.agents/memory/lessons.md` — Write when something unexpected happens',
-      '- `.agents/memory/patterns.md` — Write when a reusable pattern is validated',
-      '- `.agents/memory/context.md` — Update at session end with project state',
-    ].join('\n');
-  }
-
-  return `# BMAD+ — AI Agent Configuration
-
-## Project Context
-This project uses BMAD+, an augmented AI-driven development framework.
-Based on BMAD-METHOD v6.6.0 with multi-role agents, autopilot mode, and parallel execution.
-
-## Agents
-To activate an agent, say its name or persona:
-${agents.join('\n')}
-
-## Skills
-- Load skills from \`.agents/skills/\`
-- Each agent has a SKILL.md with capabilities, activation protocol, and role-switching rules
-- Auto-activation triggers: \`.agents/data/role-triggers.yaml\`
-
-## Key Commands
-- \`bmad-help\` — Show all available agents and skills
-- \`autopilot\` — Launch Nexus in full pipeline mode
-- \`parallel\` — Enable parallel multi-agent execution
-
-## Communication
-- User name: ${userName}
-- Default language: ${language} for user-facing content, English for code and technical docs.
-${memorySection}`;
-}
-
 function generateConfigYaml(userName, language, projectDir) {
   const projectName = path.basename(projectDir);
   return `# BMAD+ Project Configuration

package/tools/cli/commands/memory.js

@@ -40,6 +40,7 @@ module.exports = {
   description: 'Manage BMAD+ persistent brain (status, export)',
   options: [
     ['-d, --directory <path>', 'Project directory (default: current directory)'],
+    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it'],
   ],
   subcommands: {
     status: 'Show memory health report',

package/tools/cli/commands/scan.js

@@ -12,34 +12,7 @@ const os = require('node:os');
 const crypto = require('node:crypto');
 const clack = require('@clack/prompts');
 const pc = require('picocolors');
-
-// Project detection markers (priority order)
-const PROJECT_MARKERS = [
-  { file: 'package.json', stack: 'Node.js', detect: (dir) => {
-    try {
-      const pkg = JSON.parse(fs.readFileSync(path.join(dir, 'package.json'), 'utf8'));
-      const deps = { ...pkg.dependencies, ...pkg.devDependencies };
-      if (deps['next']) return 'Next.js';
-      if (deps['nuxt']) return 'Nuxt';
-      if (deps['react']) return 'React';
-      if (deps['vue']) return 'Vue.js';
-      if (deps['svelte']) return 'Svelte';
-      if (deps['express']) return 'Express';
-      if (deps['fastify']) return 'Fastify';
-      if (deps['electron']) return 'Electron';
-      if (deps['tauri']) return 'Tauri';
-      return 'Node.js';
-    } catch { return 'Node.js'; }
-  }},
-  { file: 'Cargo.toml', stack: 'Rust' },
-  { file: 'pyproject.toml', stack: 'Python' },
-  { file: 'requirements.txt', stack: 'Python' },
-  { file: 'go.mod', stack: 'Go' },
-  { file: 'composer.json', stack: 'PHP' },
-  { file: 'Gemfile', stack: 'Ruby' },
-  { file: 'pom.xml', stack: 'Java' },
-  { file: 'build.gradle', stack: 'Java/Kotlin' },
-];
+const { PROJECT_MARKERS } = require('../lib/stack-detect');
 
 // Directories to skip during scanning
 const SKIP_DIRS = new Set([
@@ -77,7 +50,9 @@ function getProjectName(dir) {
       const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
       if (pkg.name) return pkg.name;
     }
-  } catch {}
+  } catch {
+    // Malformed/unreadable package.json; fall back to directory name.
+  }
   return path.basename(dir);
 }
 
@@ -143,6 +118,22 @@ function scanDirectory(rootDir, maxDepth = 4, currentDepth = 0, activeDays = 30,
   return projects;
 }
 
+/**
+ * Normalize a filesystem path for stable hashing.
+ * On Windows the same project can be referenced as `D:\proj` or `d:\proj`
+ * (case-insensitive drive) with mixed separators. Resolving + lowercasing the
+ * drive letter ensures the same project produces the same index key and is not
+ * double-indexed.
+ * @param {string} p - Raw filesystem path
+ * @returns {string} Normalized path suitable for hashing
+ */
+function normalizePathForHash(p) {
+  let resolved = path.resolve(p);
+  // Lowercase a leading Windows drive letter (e.g. "D:" → "d:").
+  resolved = resolved.replace(/^([A-Za-z]):/, (_m, drive) => drive.toLowerCase() + ':');
+  return resolved;
+}
+
 /**
  * Index a single project in the global brain by writing its metadata YAML file.
  * @param {object} project - Project metadata object
@@ -150,7 +141,7 @@ function scanDirectory(rootDir, maxDepth = 4, currentDepth = 0, activeDays = 30,
  * @returns {void}
  */
 function indexProject(project, globalBrainDir) {
-  const hash = crypto.createHash('sha256').update(project.path).digest('hex').slice(0, 8);
+  const hash = crypto.createHash('sha256').update(normalizePathForHash(project.path)).digest('hex').slice(0, 8);
   const meta = {
     path: project.path,
     name: project.name,
@@ -168,6 +159,21 @@ function indexProject(project, globalBrainDir) {
   );
 }
 
+/**
+ * Index multiple projects in the global brain.
+ * @param {object[]} projectList - Array of project metadata objects
+ * @param {string} brainDir - Path to the brain projects directory
+ * @returns {number} Number of projects indexed
+ */
+function indexProjects(projectList, brainDir) {
+  let count = 0;
+  for (const proj of projectList) {
+    indexProject(proj, brainDir);
+    count++;
+  }
+  return count;
+}
+
 module.exports = {
   command: 'scan',
   description: 'Scan directories to discover and index projects in the global brain',
@@ -177,6 +183,7 @@ module.exports = {
     ['--active-days <n>', 'Days since last modified to consider a project "active" (default: 30)', '30'],
     ['--paused-days <n>', 'Days since last modified to consider a project "paused" (default: 180)', '180'],
     ['-y, --yes', 'Index all projects without prompting'],
+    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it'],
   ],
   action: async (options) => {
     const scanDir = path.resolve(options.directory || process.cwd());
@@ -249,11 +256,7 @@ module.exports = {
       const fsExtra = require('fs-extra');
       fsExtra.ensureDirSync(globalBrainDir);
 
-      let indexed = 0;
-      for (const proj of projects) {
-        indexProject(proj, globalBrainDir);
-        indexed++;
-      }
+      const indexed = indexProjects(projects, globalBrainDir);
       clack.log.success(`✅ ${indexed} project(s) indexed in ${globalBrainDir}`);
     } else {
       // Interactive mode
@@ -295,12 +298,7 @@ module.exports = {
         toIndex = selected.map(i => projects[i]);
       }
 
-      let indexed = 0;
-      for (const proj of toIndex) {
-        indexProject(proj, globalBrainDir);
-        indexed++;
-      }
-
+      const indexed = indexProjects(toIndex, globalBrainDir);
       clack.log.success(`✅ ${indexed} project(s) indexed in global brain`);
     }
 
@@ -320,7 +318,9 @@ module.exports = {
             }
           }
           existingProjects.push(meta);
-        } catch {}
+        } catch {
+          // Skip a project entry whose index file is unreadable/corrupt.
+        }
       }
     }
 
@@ -357,6 +357,8 @@ module.exports = {
     getProjectName,
     hasBmadInstalled,
     scanDirectory,
+    normalizePathForHash,
     indexProject,
+    indexProjects,
   },
 };

package/tools/cli/commands/uninstall.js

@@ -11,12 +11,15 @@ const fs = require('node:fs');
 const fsExtra = require('fs-extra');
 const clack = require('@clack/prompts');
 const pc = require('picocolors');
-const { t, getLanguageOptions } = require('../i18n');
+const { t } = require('../i18n');
 
 module.exports = {
   command: 'uninstall',
   description: 'Remove BMAD+ from your project',
-  action: async () => {
+  options: [
+    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it'],
+  ],
+  action: async (options) => {
     const projectDir = process.cwd();
 
     clack.intro(pc.bgRed(pc.white(' BMAD+ Uninstaller ')));
@@ -31,8 +34,8 @@ module.exports = {
 
     const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
 
-    // Use the language from install manifest, or ask
-    let lang = manifest.uiLanguage || 'en';
+    // Use --lang flag, or fall back to manifest language
+    let lang = options.lang || manifest.uiLanguage || 'en';
     const i = t(lang);
 
     clack.log.info(`BMAD+ v${manifest.version} (${i.installed_on || 'installed'} ${manifest.installed.split('T')[0]})`);
@@ -83,7 +86,9 @@ module.exports = {
       const p = path.join(projectDir, configFile);
       if (fs.existsSync(p)) {
         const content = fs.readFileSync(p, 'utf8');
-        if (content.includes('BMAD+')) {
+        // NODE-05: only remove a config BMAD+ actually generated (it carries the
+        // marker below). A hand-authored file that merely mentions "BMAD+" is kept.
+        if (content.includes('BMAD+ — AI Agent Configuration')) {
           fs.unlinkSync(p);
           removed++;
         }

package/tools/cli/commands/update.js

@@ -21,6 +21,7 @@ module.exports = {
   description: 'Update BMAD+ agents and skills (preserves config)',
   options: [
     ['-d, --directory <path>', 'Project directory (default: current directory)'],
+    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it'],
   ],
   action: async (options) => {
     const projectDir = path.resolve(options.directory || process.cwd());
@@ -38,8 +39,22 @@ module.exports = {
       return;
     }
 
-    const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
-    const lang = manifest.uiLanguage || 'en';
+    let manifest;
+    try {
+      manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
+    } catch (err) {
+      clack.log.error(`Install manifest is unreadable or corrupt: ${err.message}`);
+      clack.log.info('Re-run `npx bmad-plus install` to repair the installation.');
+      clack.outro(pc.red('Update aborted.'));
+      return;
+    }
+    if (!manifest || typeof manifest !== 'object') {
+      clack.log.error('Install manifest is malformed (not an object).');
+      clack.log.info('Re-run `npx bmad-plus install` to repair the installation.');
+      clack.outro(pc.red('Update aborted.'));
+      return;
+    }
+    const lang = options.lang || manifest.uiLanguage || 'en';
     const i = t(lang);
 
     clack.log.info(`📦 Installed: v${manifest.version} → Available: v${packageJson.version}`);
@@ -50,7 +65,10 @@ module.exports = {
       return;
     }
 
-    const selectedPacks = manifest.packs || ['core'];
+    // Guard against a missing/malformed `packs` field (NODE-04): coerce to an array.
+    const selectedPacks = Array.isArray(manifest.packs) && manifest.packs.length > 0
+      ? manifest.packs
+      : ['core'];
     clack.log.info(`${i.selected_packs}: ${selectedPacks.join(', ')}`);
 
     const confirm = await clack.confirm({