bmad-plus 0.12.2 → 0.14.0

package/tools/cli/lib/pack-copy.js

@@ -1,84 +1,80 @@
 /**
- * BMAD+ Shared Pack-Copy Module
- * Extracted duplicate file-copy loops from install.js and update.js.
- *
+ * Shared deterministic pack enumeration and conservative installation copying.
  * Author: Laurent Rochetta
  */
-
 const path = require('node:path');
 const fs = require('node:fs');
-const fsExtra = require('fs-extra');
-
-/**
- * Copy files for a single pack definition into the target directories.
- *
- * @param {object} opts
- * @param {string} opts.bmadSrc      - Path to src/bmad-plus/
- * @param {string} opts.targetAgentsDir - Destination for agents / skills
- * @param {string} opts.targetDataDir   - Destination for data files
- * @param {string} opts.projectRoot    - Project root (for external package resolution)
- * @param {object} opts.pack           - Pack definition from PACKS
- * @returns {{ copiedAgents: number, copiedSkills: number, copiedFiles: number }}
- */
-function copyPackFiles({ bmadSrc, targetAgentsDir, targetDataDir, projectRoot, pack }) {
-  let copiedAgents = 0;
-  let copiedSkills = 0;
-  let copiedFiles = 0;
+const crypto = require('node:crypto');
+const { safeTarget } = require('../../build/generate-adapters');
 
-  if (!pack) return { copiedAgents, copiedSkills, copiedFiles };
+const fileHash = content => crypto.createHash('sha256').update(content).digest('hex');
 
-  // Copy agents
-  for (const agent of (pack.agents || [])) {
-    const src = path.join(bmadSrc, 'agents', agent);
-    const dest = path.join(targetAgentsDir, agent);
-    if (fs.existsSync(src)) {
-      fsExtra.copySync(src, dest, { overwrite: true });
-      copiedAgents++;
+function listPackFiles({ bmadSrc, targetAgentsDir, targetDataDir, projectRoot, pack }) {
+  const result = { copiedAgents: 0, copiedSkills: 0, copiedFiles: 0, files: [] };
+  if (!pack) return result;
+  function walk(source, target) {
+    let stat;
+    try { stat = fs.lstatSync(source); } catch (error) {
+      if (error.code === 'ENOENT') return false;
+      throw error;
     }
+    if (stat.isSymbolicLink()) throw new Error('Pack source is a symbolic link: ' + source);
+    if (stat.isDirectory()) {
+      for (const name of fs.readdirSync(source).sort()) walk(path.join(source, name), path.join(target, name));
+    } else if (stat.isFile()) {
+      result.files.push({ source, target });
+    } else throw new Error('Pack source is not a regular file: ' + source);
+    return true;
   }
-
-  // Copy skills
-  for (const skill of (pack.skills || [])) {
-    const src = path.join(bmadSrc, 'skills', skill);
-    const dest = path.join(targetAgentsDir, skill);
-    if (fs.existsSync(src)) {
-      fsExtra.copySync(src, dest, { overwrite: true });
-      copiedSkills++;
-    }
+  for (const name of pack.agents || []) {
+    if (walk(path.join(bmadSrc, 'agents', name), path.join(targetAgentsDir, name))) result.copiedAgents++;
   }
-
-  // Copy data files
-  for (const dataFile of (pack.data || [])) {
-    const src = path.join(bmadSrc, 'data', dataFile);
-    const dest = path.join(targetDataDir, dataFile);
-    if (fs.existsSync(src)) {
-      fsExtra.copySync(src, dest, { overwrite: true });
-      copiedFiles++;
-    }
+  for (const name of pack.skills || []) {
+    if (walk(path.join(bmadSrc, 'skills', name), path.join(targetAgentsDir, name))) result.copiedSkills++;
   }
-
-  // Copy external package (e.g. OSINT)
-  if (pack.externalPackage) {
-    const extSrc = path.join(projectRoot, pack.externalPackage, 'skills');
-    if (fs.existsSync(extSrc)) {
-      fsExtra.copySync(extSrc, targetAgentsDir, { overwrite: true });
-      copiedSkills++;
-    }
+  for (const name of pack.data || []) {
+    if (walk(path.join(bmadSrc, 'data', name), path.join(targetDataDir, name))) result.copiedFiles++;
+  }
+  if (pack.externalPackage && walk(path.join(projectRoot, pack.externalPackage, 'skills'), targetAgentsDir)) result.copiedSkills++;
+  if (pack.packDir && walk(path.join(bmadSrc, pack.packSrcDir || 'agents', pack.packDir), path.join(targetAgentsDir, pack.packDir))) {
+    result.copiedAgents++;
+    result.copiedFiles++;
   }
+  return result;
+}
 
-  // Copy pack directory (SEO, Backup, Animated, Shield, etc.)
-  if (pack.packDir) {
-    const srcParent = pack.packSrcDir || 'agents';
-    const packSrc = path.join(bmadSrc, srcParent, pack.packDir);
-    const packDest = path.join(targetAgentsDir, pack.packDir);
-    if (fs.existsSync(packSrc)) {
-      fsExtra.copySync(packSrc, packDest, { overwrite: true });
-      copiedAgents++;
-      copiedFiles++;
+function copyManagedFile({ source, target, projectDir, inventory, previousInventory = {}, onConflict = () => {} }) {
+  const file = path.relative(projectDir, target).split(path.sep).join('/');
+  safeTarget(projectDir, file);
+  const sourceStat = fs.lstatSync(source);
+  if (!sourceStat.isFile() || sourceStat.isSymbolicLink()) throw new Error('Pack source is not a regular file: ' + source);
+  const content = fs.readFileSync(source);
+  const hash = fileHash(content);
+  if (fs.existsSync(target)) {
+    const existingHash = fileHash(fs.readFileSync(target));
+    if (existingHash === hash) {
+      if (inventory) inventory[file] = hash;
+      return false;
+    }
+    if (previousInventory[file] !== existingHash) {
+      if (inventory && previousInventory[file]) inventory[file] = previousInventory[file];
+      onConflict(file);
+      return false;
     }
   }
+  fs.mkdirSync(path.dirname(target), { recursive: true });
+  safeTarget(projectDir, file);
+  fs.writeFileSync(target, content, { mode: sourceStat.mode });
+  if (inventory) inventory[file] = hash;
+  return true;
+}
 
-  return { copiedAgents, copiedSkills, copiedFiles };
+function copyPackFiles(options) {
+  const { files, ...counts } = listPackFiles(options);
+  const projectDir = options.projectDir || path.dirname(options.targetAgentsDir);
+  for (const { target } of files) safeTarget(projectDir, path.relative(projectDir, target).split(path.sep).join('/'));
+  for (const entry of files) copyManagedFile({ ...options, ...entry, projectDir });
+  return counts;
 }
 
-module.exports = { copyPackFiles };
+module.exports = { copyPackFiles, listPackFiles, copyManagedFile, fileHash };