bmad-plus 0.12.1 → 0.13.0

package/tools/cli/commands/update.js

@@ -1,134 +1,123 @@
-/**
- * BMAD+ Update Command
- * Updates agents and skills while preserving user config
- *
- * Author: Laurent Rochetta
- */
-
-const path = require('node:path');
-const fs = require('node:fs');
-const fsExtra = require('fs-extra');
-const clack = require('@clack/prompts');
-const pc = require('picocolors');
-const { t } = require('../i18n');
-const { PACKS } = require('../lib/packs');
-const { copyPackFiles } = require('../lib/pack-copy');
-
-// Pack definitions imported from shared module: require('../lib/packs').PACKS
-
-module.exports = {
-  command: 'update',
-  description: 'Update BMAD+ agents and skills (preserves config)',
-  options: [
-    ['-d, --directory <path>', 'Project directory (default: current directory)'],
-    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it'],
-  ],
-  action: async (options) => {
-    const projectDir = path.resolve(options.directory || process.cwd());
-    const bmadSrc = path.join(__dirname, '..', '..', '..', 'src', 'bmad-plus');
-    const packageJson = require('../../../package.json');
-
-    clack.intro(pc.bgMagenta(pc.white(` BMAD+ Updater v${packageJson.version} `)));
-
-    // Check if installed
-    const manifestPath = path.join(projectDir, '_bmad', '.bmad-plus-install.json');
-    if (!fs.existsSync(manifestPath)) {
-      clack.log.error('BMAD+ is not installed in this directory.');
-      clack.log.info('Run `npx bmad-plus install` first.');
-      clack.outro(pc.red('Update aborted.'));
-      return;
-    }
-
-    let manifest;
-    try {
-      manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
-    } catch (err) {
-      clack.log.error(`Install manifest is unreadable or corrupt: ${err.message}`);
-      clack.log.info('Re-run `npx bmad-plus install` to repair the installation.');
-      clack.outro(pc.red('Update aborted.'));
-      return;
-    }
-    if (!manifest || typeof manifest !== 'object') {
-      clack.log.error('Install manifest is malformed (not an object).');
-      clack.log.info('Re-run `npx bmad-plus install` to repair the installation.');
-      clack.outro(pc.red('Update aborted.'));
-      return;
-    }
-    const lang = options.lang || manifest.uiLanguage || 'en';
-    const i = t(lang);
-
-    clack.log.info(`📦 Installed: v${manifest.version} → Available: v${packageJson.version}`);
-
-    if (manifest.version === packageJson.version) {
-      clack.log.success(i.update_current || '✅ Already up to date!');
-      clack.outro(pc.green('Nothing to update.'));
-      return;
-    }
-
-    // Guard against a missing/malformed `packs` field (NODE-04): coerce to an array.
-    const selectedPacks = Array.isArray(manifest.packs) && manifest.packs.length > 0
-      ? manifest.packs
-      : ['core'];
-    clack.log.info(`${i.selected_packs}: ${selectedPacks.join(', ')}`);
-
-    const confirm = await clack.confirm({
-      message: i.update_confirm || `Update from v${manifest.version} to v${packageJson.version}?`,
-    });
-
-    if (!confirm || clack.isCancel(confirm)) {
-      clack.cancel(i.cancelled);
-      return;
-    }
-
-    const spinner = clack.spinner();
-    spinner.start(i.update_updating || 'Updating agents and skills...');
-
-    const targetAgentsDir = path.join(projectDir, '.agents', 'skills');
-    const targetDataDir = path.join(projectDir, '.agents', 'data');
-
-    fsExtra.ensureDirSync(targetAgentsDir);
-    fsExtra.ensureDirSync(targetDataDir);
-
-    let updated = 0;
-
-    const projectRoot = path.join(bmadSrc, '..', '..');
-
-    for (const packId of selectedPacks) {
-      const pack = PACKS[packId];
-      if (!pack) continue;
-
-      const result = copyPackFiles({
-        bmadSrc,
-        targetAgentsDir,
-        targetDataDir,
-        projectRoot,
-        pack,
-      });
-      updated += result.copiedAgents + result.copiedSkills + result.copiedFiles;
-    }
-
-    // Update module config (always)
-    const moduleYaml = path.join(bmadSrc, 'module.yaml');
-    const targetBmadDir = path.join(projectDir, '_bmad');
-    if (fs.existsSync(moduleYaml)) {
-      fsExtra.copySync(moduleYaml, path.join(targetBmadDir, 'module.yaml'));
-      updated++;
-    }
-
-    const helpCsv = path.join(bmadSrc, 'module-help.csv');
-    if (fs.existsSync(helpCsv)) {
-      fsExtra.copySync(helpCsv, path.join(targetBmadDir, 'module-help.csv'));
-      updated++;
-    }
-
-    // Update manifest version (preserve everything else)
-    manifest.version = packageJson.version;
-    manifest.lastUpdated = new Date().toISOString();
-    fs.writeFileSync(manifestPath, JSON.stringify(manifest, null, 2), 'utf8');
-
-    spinner.stop(i.update_done ? i.update_done(updated) : `✅ ${updated} files updated to v${packageJson.version}`);
-
-    clack.log.info('📋 Config preserved: config.yaml, IDE configs, output directories');
-    clack.outro(pc.green(i.update_ready || `BMAD+ v${packageJson.version} is ready! 🚀`));
-  },
-};
+/**
+ * BMAD+ Update Command — planned updates with recoverable backups.
+ * Author: Laurent Rochetta
+ */
+const path = require('node:path');
+const fs = require('node:fs');
+const semver = require('semver');
+const clack = require('@clack/prompts');
+const pc = require('picocolors');
+const { t } = require('../i18n');
+const { safeTarget } = require('../../build/generate-adapters');
+const { readInstallManifest } = require('../lib/install-manifest');
+const { isExactVersion } = require('../lib/update-policy');
+const { planUpdate, applyPlan, restoreUpdate, MANIFEST } = require('../lib/update-transaction');
+
+function authorizeAuto(projectDir, version) {
+  const { readUpdatePolicy, authorizeTarget } = require('../lib/update-policy');
+  const decision = authorizeTarget(readUpdatePolicy(projectDir), version);
+  if (!decision.allowed) throw new Error('Automatic update refused: ' + decision.reason);
+}
+
+async function confirmAction(options, message, lang = 'en') {
+  if (options.yes || options.auto) return true;
+  const i = t(lang);
+  if (!process.stdin.isTTY) throw new Error(i.noninteractive_requires_yes('update'));
+  const confirmed = await clack.confirm({ message });
+  if (!confirmed || clack.isCancel(confirmed)) {
+    clack.cancel(i.cancelled);
+    return false;
+  }
+  return true;
+}
+
+module.exports = {
+  command: 'update',
+  description: 'Update BMAD+ agents and skills (preserves local changes)',
+  options: [
+    ['-d, --directory <path>', 'Project directory (default: current directory)'],
+    ['-y, --yes', 'Confirm update without prompting'],
+    ['-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it'],
+    ['--latest', 'Resolve and run the exact latest compatible published package'],
+    ['--expected-version <version>', 'Require this exact executing package version'],
+    ['--auto', 'Apply only when automatic update policy and ownership allow it'],
+    ['--restore <receipt-id>', 'Restore files from an update receipt'],
+  ],
+  action: async (options) => {
+    const projectDir = path.resolve(options.directory || process.cwd());
+    const version = require('../../../package.json').version;
+    let spinner;
+    try {
+      if (options.restore && (options.latest || options.expectedVersion)) {
+        throw new Error('--restore cannot be combined with --latest or --expected-version.');
+      }
+      // The dispatcher resolves the target package; this local package may be older.
+      if (options.latest) {
+        const result = await require('../lib/update-dispatch').runLatestUpdate({
+          projectDir, auto: Boolean(options.auto), yes: Boolean(options.yes),
+        });
+        clack.log.info(result.reason || result.status);
+        if (result.output) clack.log.info(result.output);
+        if (result.targetVersion) clack.log.info('Target: v' + result.targetVersion);
+        if (result.reloadInstructions) clack.log.info('Reload your agent instructions or start a new session.');
+        return;
+      }
+
+      clack.intro(pc.bgMagenta(pc.white(' BMAD+ Updater v' + version + ' ')));
+      if (options.restore) {
+        if (options.auto) throw new Error('Recovery requires manual approval.');
+        if (!await confirmAction(options, 'Restore the files saved in receipt ' + options.restore + '?', options.lang)) return;
+        const restored = restoreUpdate({ projectDir, receiptId: options.restore });
+        clack.log.success('Restored BMAD+ v' + restored.restoredVersion);
+        clack.log.info('Receipt: ' + restored.receiptPath);
+        clack.outro('Reload your agent instructions or start a new session.');
+        return;
+      }
+
+      if (options.auto && !options.expectedVersion) throw new Error('Automatic update requires --expected-version.');
+      if (options.expectedVersion && options.expectedVersion !== version) {
+        throw new Error('Executing package version ' + version + ' does not match expected version ' + options.expectedVersion + '.');
+      }
+      const manifestPath = safeTarget(projectDir, MANIFEST);
+      if (!fs.existsSync(manifestPath)) throw new Error('BMAD+ is not installed in this directory. Run bmad-plus install first.');
+      let manifest;
+      try { manifest = readInstallManifest(manifestPath); } catch (error) {
+        throw new Error('Install manifest is unreadable or corrupt: ' + error.message, { cause: error });
+      }
+      if (!isExactVersion(version) || !isExactVersion(manifest.version)) throw new Error('Update versions must be strict semantic versions.');
+      if (semver.lt(version, manifest.version)) throw new Error('Downgrade refused: ' + manifest.version + ' -> ' + version);
+      const lang = options.lang || manifest.uiLanguage || 'en';
+      clack.log.info('Installed: v' + manifest.version + ' -> Executing package: v' + version);
+      if (manifest.version === version) {
+        clack.log.success('The installed version matches this executing package. Use --latest to check the registry.');
+        clack.outro(pc.green('Nothing to update.'));
+        return;
+      }
+      const plan = planUpdate({ projectDir, manifest, version, auto: Boolean(options.auto) });
+      if (options.auto) {
+        authorizeAuto(projectDir, version);
+        const fresh = await require('../lib/update-check').checkForUpdate({ projectDir, runningVersion: version, refresh: true });
+        if (fresh.source !== 'registry' || fresh.stale || !fresh.versionEligible || fresh.targetVersion !== options.expectedVersion) {
+          throw new Error('Automatic update requires a fresh, eligible registry target matching --expected-version.');
+        }
+      }
+
+      clack.log.info('Planned changes: ' + (plan.files.length - 1) + ' files; preserved conflicts: ' + plan.conflicts.length + '.');
+      if (plan.legacy) clack.log.warn('Legacy installation: original pack files will be backed up before replacement because ownership hashes are unavailable. Review the receipt to recover local edits.');
+      for (const conflict of plan.conflicts) clack.log.warn(conflict.file + ': preserved (' + conflict.reason + ').');
+      if (!await confirmAction(options, 'Apply this update from v' + manifest.version + ' to v' + version + '?', lang)) return;
+
+      spinner = clack.spinner();
+      spinner.start('Updating managed files...');
+      const result = applyPlan(plan, { reauthorize: () => authorizeAuto(projectDir, version) });
+      spinner.stop(result.changedFiles.length + ' files updated; ' + result.conflicts.length + ' local conflicts preserved.');
+      spinner = null;
+      clack.log.info('Receipt and backups: ' + result.receiptPath);
+      clack.outro(pc.green('BMAD+ v' + version + (result.conflicts.length ? ' applied partially.' : ' installed.') + ' Reload your agent instructions or start a new session.'));
+    } catch (error) {
+      if (spinner) spinner.stop('Update failed.');
+      clack.log.error(error.message);
+      process.exitCode = 1;
+    }
+  },
+};