bmad-method 6.9.1-next.0 → 6.9.1-next.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "$schema": "https://json.schemastore.org/package.json",
3
3
  "name": "bmad-method",
4
- "version": "6.9.1-next.0",
4
+ "version": "6.9.1-next.2",
5
5
  "description": "Breakthrough Method of Agile AI-driven Development",
6
6
  "keywords": [
7
7
  "agile",
@@ -42,10 +42,11 @@
42
42
  "prepare": "command -v husky >/dev/null 2>&1 && husky || exit 0",
43
43
  "quality": "npm run format:check && npm run lint && npm run lint:md && npm run docs:build && npm run test:install && npm run test:urls && npm run validate:refs && npm run validate:skills && npm run docs:validate-sidebar",
44
44
  "rebundle": "node tools/installer/bundlers/bundle-web.js rebundle",
45
- "test": "npm run test:refs && npm run test:install && npm run test:urls && npm run test:channels && npm run lint && npm run lint:md && npm run format:check",
45
+ "test": "npm run test:refs && npm run test:install && npm run test:urls && npm run test:channels && npm run test:skills && npm run lint && npm run lint:md && npm run format:check",
46
46
  "test:channels": "node test/test-installer-channels.js",
47
47
  "test:install": "node test/test-installation-components.js",
48
48
  "test:refs": "node test/test-file-refs-csv.js",
49
+ "test:skills": "node test/test-validate-skills.js",
49
50
  "test:urls": "node test/test-parse-source-urls.js",
50
51
  "validate:refs": "node tools/validate-file-refs.js --strict",
51
52
  "validate:skills": "node tools/validate-skills.js --strict"
@@ -29,7 +29,13 @@
29
29
  - Append any unique detail, reasoning, or location references from the other finding(s) into the surviving `detail` field.
30
30
  - Set `source` to the merged sources (e.g., `blind+edge`).
31
31
 
32
- 3. **Classify** each finding into exactly one bucket:
32
+ 3. **Assign severity** to each finding by consequence for the artifact's main consumer (software user, document reader, etc).
33
+ Disregard any severity assigned by a reviewing subagent. Review subagents operate under by-design information asymmetry and do not have enough context to set final severity for this workflow.
34
+ - `low` -- none or cosmetic
35
+ - `medium` -- tolerable
36
+ - `high` -- intolerable
37
+
38
+ 4. **Route** each finding into exactly one triage bucket:
33
39
  - **decision_needed** -- There is an ambiguous choice that requires human input. The code cannot be correctly patched without knowing the user's intent. Only possible if `{review_mode}` = `"full"`.
34
40
  - **patch** -- Code issue that is fixable without human input. The correct fix is unambiguous.
35
41
  - **defer** -- Pre-existing issue not caused by the current change. Real but not actionable now.
@@ -37,11 +43,11 @@
37
43
 
38
44
  If `{review_mode}` = `"no-spec"` and a finding would otherwise be `decision_needed`, reclassify it as `patch` (if the fix is unambiguous) or `defer` (if not).
39
45
 
40
- 4. **Drop** all `dismiss` findings. Record the dismiss count for the summary.
46
+ 5. **Drop** all `dismiss` findings. Record the dismiss count for the summary.
41
47
 
42
- 5. If `{failed_layers}` is non-empty, report which layers failed before announcing results. If zero findings remain after dropping dismissed AND `{failed_layers}` is non-empty, warn the user that the review may be incomplete rather than announcing a clean review.
48
+ 6. If `{failed_layers}` is non-empty, report which layers failed before announcing results. If zero findings remain after dropping dismissed AND `{failed_layers}` is non-empty, warn the user that the review may be incomplete rather than announcing a clean review.
43
49
 
44
- 6. If zero findings remain after triage (all rejected or none raised): state "✅ Clean review — all layers passed." (Step 3 already warned if any review layers failed via `{failed_layers}`.)
50
+ 7. If zero findings remain after triage (all rejected or none raised): state "✅ Clean review — all layers passed." (Step 3 already warned if any review layers failed via `{failed_layers}`.)
45
51
 
46
52
 
47
53
  ## NEXT
@@ -86,7 +86,7 @@ Skip this section if `{spec_file}` is not set.
86
86
 
87
87
  #### Determine new status based on review outcome
88
88
 
89
- - If all `decision-needed` and `patch` findings were resolved (fixed or dismissed) AND no unresolved HIGH/MEDIUM issues remain: set `{new_status}` = `done`. Update the story file Status section to `done`.
89
+ - If all `decision-needed` and `patch` findings were resolved (fixed or dismissed) AND no unresolved `high`/`medium` findings remain: set `{new_status}` = `done`. Update the story file Status section to `done`.
90
90
  - If `patch` findings were left as action items, or unresolved issues remain: set `{new_status}` = `in-progress`. Update the story file Status section to `in-progress`.
91
91
 
92
92
  Save the story file.
@@ -4,6 +4,7 @@ type: 'feature' # feature | bugfix | refactor | chore
4
4
  created: '{date}'
5
5
  status: 'draft' # draft | ready-for-dev | in-progress | in-review | done | blocked
6
6
  review_loop_iteration: 0 # incremented by step-04 before each review loopback
7
+ followup_review_recommended: false # set by step-04 on status: done from the final review pass significance judgment
7
8
  context: [] # optional: `{project-root}/`-prefixed paths to project-wide standards/docs the implementation agent should load. Keep short — only what isn't already distilled into the spec body.
8
9
  warnings: [] # optional: machine-readable warnings for orchestration, e.g. oversized, multiple-goals
9
10
  ---
@@ -71,6 +72,13 @@ warnings: [] # optional: machine-readable warnings for orchestration, e.g. overs
71
72
  the amendment avoids, and any KEEP instructions (what worked well and must survive re-derivation).
72
73
  Empty until the first bad_spec loopback. -->
73
74
 
75
+ ## Review Triage Log
76
+
77
+ <!-- Append-only. Populated by step-04 on EVERY review pass, including loopbacks and blocked exits.
78
+ Each entry records triage decision counts for intent_gap, bad_spec, patch, defer, and reject,
79
+ with per-category severity breakdowns using low/medium/high, plus the findings addressed in
80
+ that pass. Empty until the first review pass. -->
81
+
74
82
  ## Design Notes
75
83
 
76
84
  <!-- If the approach is straightforward, DELETE THIS ENTIRE SECTION. Do not write "N/A" or "None". -->
@@ -31,16 +31,38 @@ Launch two subagents without prior session context.
31
31
  ### Classify
32
32
 
33
33
  1. Deduplicate all review findings.
34
- 2. Classify each finding. The first three categories are **this story's problem** caused or exposed by the current change. The last two are **not this story's problem**.
34
+ 2. Assign severity to each finding by consequence for the artifact's main consumer (software user, document reader, etc).
35
+ Disregard any severity assigned by a reviewing subagent. Review subagents operate under by-design information asymmetry and do not have enough context to set final severity for this workflow.
36
+ - `low`: none or cosmetic
37
+ - `medium`: tolerable
38
+ - `high`: intolerable
39
+ 3. Route each finding into exactly one triage category. The first three categories are **this story's problem** — caused or exposed by the current change. The last two are **not this story's problem**.
35
40
  - **intent_gap** — caused by the change; cannot be resolved from the spec because the captured intent is incomplete. Do not infer intent unless there is exactly one possible reading.
36
41
  - **bad_spec** — caused by the change, including direct deviations from spec. The spec should have been clear enough to prevent it. When in doubt between bad_spec and patch, prefer bad_spec — a spec-level fix is more likely to produce coherent code.
37
42
  - **patch** — caused by the change; trivially fixable without human input. Just part of the diff.
38
43
  - **defer** — pre-existing issue not caused by this story, surfaced incidentally by the review. Collect for later focused attention.
39
44
  - **reject** — noise. Drop silently. When unsure between defer and reject, prefer reject — only defer findings you are confident are real.
40
- 3. Process findings in cascading order. If intent_gap exists, lower findings are moot; follow the intent_gap branch below. If bad_spec exists, lower findings are moot since code will be re-derived. If neither exists, process patch and defer normally. Before each bad_spec loopback, read `{spec_file}` frontmatter `review_loop_iteration` (missing means `0`), increment it by 1, and write it back. If it exceeds 5, HALT with status `blocked` and blocking condition `review repair loop exceeded 5 iterations`.
41
- - **intent_gap** — Root cause is inside `<intent-contract>`. Revert code changes. HALT with status `blocked`, blocking condition `intent gap in intent contract`, and include the intent-gap findings.
42
- - **bad_spec** — Root cause is outside `<intent-contract>`. Do not modify content inside `<intent-contract>`. Before reverting code: extract KEEP instructions for positive preservation (what worked well and must survive re-derivation). Revert code changes. Read the `## Spec Change Log` in `{spec_file}` and strictly respect all logged constraints when amending the sections outside `<intent-contract>` that contain the root cause. Append a new change-log entry recording: the triggering finding, what was amended, the known-bad state avoided, and the KEEP instructions. Read fully and follow `./step-03-implement.md` to re-derive the code, then this step will run again.
43
- - **patch** — Auto-fix. These are the only findings that survive loopbacks.
45
+ 4. Append a new entry to the `## Review Triage Log` section in `{spec_file}`, in this format:
46
+ ```markdown
47
+ ### {date} Review pass
48
+ - intent_gap: count
49
+ - bad_spec: count
50
+ - patch: count
51
+ - defer: count
52
+ - reject: count
53
+ - addressed_findings:
54
+ - `[high|medium|low]` `[patch|bad_spec]` <finding summary and action taken in this pass>
55
+ ```
56
+ Where `count` is either just `0`, or total with breakdown by severity `N: (high Nhigh, medium Nmedium, low Nlow)`.
57
+ If no patch was fixed and no bad_spec repair loopback was triggered in this pass, write:
58
+ ```markdown
59
+ - addressed_findings:
60
+ - none
61
+ ```
62
+ 5. Process findings in cascading order. If intent_gap exists, lower findings are moot; follow the intent_gap branch below. If bad_spec exists, lower findings are moot since code will be re-derived. If neither exists, process patch and defer normally. Before each bad_spec loopback, read `{spec_file}` frontmatter `review_loop_iteration` (missing means `0`), increment it by 1, and write it back. If it exceeds 5, append the triage-log entry for this pass with `addressed_findings: none`, then HALT with status `blocked` and blocking condition `review repair loop exceeded 5 iterations (non-convergence)`.
63
+ - **intent_gap** — Root cause is inside `<intent-contract>`. Revert code changes. Append the triage-log entry for this pass with `addressed_findings: none`, then HALT with status `blocked`, blocking condition `intent gap in intent contract`, and include the intent-gap findings.
64
+ - **bad_spec** — Root cause is outside `<intent-contract>`. Do not modify content inside `<intent-contract>`. Before reverting code: extract KEEP instructions for positive preservation (what worked well and must survive re-derivation). Revert code changes. Read the `## Spec Change Log` in `{spec_file}` and strictly respect all logged constraints when amending the sections outside `<intent-contract>` that contain the root cause. Append a new change-log entry recording: the triggering finding, what was amended, the known-bad state avoided, and the KEEP instructions. Append the triage-log entry for this pass, listing every bad_spec finding that triggered the spec amendment and implementation loopback under `addressed_findings`. Read fully and follow `./step-03-implement.md` to re-derive the code, then this step will run again.
65
+ - **patch** — Auto-fix. These are the only findings that survive loopbacks. After auto-fixing, append the triage-log entry for this pass, listing every patch fixed in this pass under `addressed_findings`.
44
66
  - **defer** — Append one new entry to `{deferred_work_file}` using this format. Do not modify existing entries or look for duplicates.
45
67
  ```markdown
46
68
  - source_spec: `{spec_file}`
@@ -55,7 +77,10 @@ Prepare `Auto Run Result` details:
55
77
  - Summary of implemented change
56
78
  - Files changed with one-line descriptions
57
79
  - Review findings breakdown: patches applied, items deferred, items rejected
80
+ - Follow-up review recommendation: `true` when the final review pass made review-driven changes significant enough to benefit from an independent follow-up review; otherwise `false`. Use judgment, not a fixed numeric threshold. Base the judgment on the final pass's triage log and fixes, including patched-finding volume, consequence/severity, breadth, behavior/API/security/data impact, and implementation complexity. Many low-severity patched findings can be significant by volume. Do not recommend follow-up for only a few localized low-consequence fixes.
58
81
  - Verification performed, including command outcomes or manual inspection notes
59
82
  - Any residual risks
60
83
 
84
+ Before HALT with status `done`, set `{spec_file}` frontmatter `followup_review_recommended` from the final-pass judgment above. Do not set or recommend follow-up review on blocked exits, including review-loop non-convergence.
85
+
61
86
  HALT with status `done`.
@@ -20,6 +20,8 @@ A specification is "Ready for Development" when:
20
20
  - **Logical**: Tasks ordered by dependency.
21
21
  - **Testable**: All ACs use Given/When/Then.
22
22
  - **Complete**: No placeholders or TBDs.
23
+ - **Sufficient**: No known requirement, acceptance, dependency, or implementation gaps remain unresolved.
24
+ - **Coherent**: No unresolved ambiguities or internal contradictions.
23
25
 
24
26
  ## SCOPE STANDARD
25
27
 
@@ -1,41 +1,33 @@
1
1
  # DO NOT EDIT -- overwritten on every update.
2
2
  #
3
- # Workflow customization surface for bmad-quick-dev. Mirrors the
4
- # agent customization shape under the [workflow] namespace.
3
+ # Default customization values for bmad-quick-dev.
4
+ # Override in _bmad/custom/bmad-quick-dev.toml or
5
+ # _bmad/custom/bmad-quick-dev.user.toml.
6
+ #
7
+ # Merge rules:
8
+ # - Strings replace the default.
9
+ # - Lists append to the default list.
10
+ # - Tables merge key by key.
5
11
 
6
12
  [workflow]
7
13
 
8
- # --- Configurable below. Overrides merge per BMad structural rules: ---
9
- # scalars: override wins • arrays (persistent_facts, activation_steps_*): append
10
- # arrays-of-tables with `code`/`id`: replace matching items, append new ones.
11
-
12
- # Steps to run before the standard activation (config load, greet).
13
- # Overrides append. Use for pre-flight loads, compliance checks, etc.
14
+ # Extra instructions to run before config is loaded and before the user is greeted.
14
15
 
15
16
  activation_steps_prepend = []
16
17
 
17
- # Steps to run after greet but before the workflow begins.
18
- # Overrides append. Use for context-heavy setup that should happen
19
- # once the user has been acknowledged.
18
+ # Extra instructions to run after the greeting and before step 01.
20
19
 
21
20
  activation_steps_append = []
22
21
 
23
- # Persistent facts the workflow keeps in mind for the whole run
24
- # (standards, compliance constraints, stylistic guardrails).
25
- # Distinct from the runtime memory sidecar these are static context
26
- # loaded on activation. Overrides append.
27
- #
28
- # Each entry is either:
29
- # - a literal sentence, e.g. "All stories must include testable acceptance criteria."
30
- # - a file reference prefixed with `file:`, e.g. "file:{project-root}/docs/standards.md"
31
- # (glob patterns are supported; the file's contents are loaded and treated as facts).
22
+ # Facts kept in context for the whole run.
23
+ # Entries are literal text or file references prefixed with "file:".
24
+ # File entries may use globs and are loaded during activation.
32
25
 
33
26
  persistent_facts = [
34
27
  "file:{project-root}/**/project-context.md",
35
28
  ]
36
29
 
37
- # Scalar: executed when the workflow reaches its final step,
38
- # after implementation is complete and explanations are provided. Override wins.
39
- # Leave empty for no custom post-completion behavior.
30
+ # Instruction run after Quick Dev completes.
31
+ # Empty means no extra completion behavior.
40
32
 
41
33
  on_complete = ""
@@ -3,6 +3,7 @@ title: '{title}'
3
3
  type: 'feature' # feature | bugfix | refactor | chore
4
4
  created: '{date}'
5
5
  status: 'draft' # draft | ready-for-dev | in-progress | in-review | done
6
+ review_loop_iteration: 0 # incremented by step-04 before each review loopback
6
7
  context: [] # optional: `{project-root}/`-prefixed paths to project-wide standards/docs the implementation agent should load. Keep short — only what isn't already distilled into the spec body.
7
8
  ---
8
9
 
@@ -59,8 +59,8 @@ If the spec is an epic story and `{sprint_status}` exists: find the `development
59
59
  - **If missing, empty, or invalid:** continue to step 3.
60
60
 
61
61
  3. **Compile epic context.** Produce `{implementation_artifacts}/epic-<N>-context.md` by following `./compile-epic-context.md`, in order of preference:
62
- - **Preferred — sub-agent:** spawn a sub-agent with `./compile-epic-context.md` as its prompt. Pass it the epic number, the epics file path, the `{planning_artifacts}` directory, and the output path `{implementation_artifacts}/epic-<N>-context.md`.
63
- - **Fallback — inline** (for runtimes without sub-agent support, e.g. Copilot, Codex, local Ollama, older Claude): if your runtime cannot spawn sub-agents, or the spawn fails/times out, read `./compile-epic-context.md` yourself and follow its instructions to produce the same output file.
62
+ - **Preferred — subagent:** spawn a subagent with `./compile-epic-context.md` as its prompt. Pass it the epic number, the epics file path, the `{planning_artifacts}` directory, and the output path `{implementation_artifacts}/epic-<N>-context.md`.
63
+ - **Fallback — inline** (for runtimes without subagent support, e.g. Copilot, Codex, local Ollama, older Claude): if your runtime cannot spawn subagents, or the spawn fails/times out, read `./compile-epic-context.md` yourself and follow its instructions to produce the same output file.
64
64
 
65
65
  4. **Verify.** After compilation, verify the output file exists, is non-empty, and starts with `# Epic <N> Context:`. If valid, load it. If verification fails, HALT and report the failure.
66
66
 
@@ -82,7 +82,12 @@ If the spec is an epic story and `{sprint_status}` exists: find the `development
82
82
  - Present detected distinct goals as a bullet list.
83
83
  - Explain briefly (2–4 sentences): why each goal qualifies as independently shippable, any coupling risks if split, and which goal you recommend tackling first.
84
84
  - HALT and ask human: `[S] Split — pick first goal, defer the rest` | `[K] Keep all goals — accept the risks`
85
- - On **S**: Append deferred goals to `{deferred_work_file}`. Narrow scope to the first-mentioned goal. Continue routing.
85
+ - On **S**: For each deferred goal, append one new entry to `{deferred_work_file}` using this format. Do not modify existing entries or look for duplicates. Narrow scope to the first-mentioned goal. Continue routing.
86
+ ```markdown
87
+ - source_spec: none
88
+ summary: <one sentence naming the deferred goal>
89
+ evidence: <why this was split from the current intent>
90
+ ```
86
91
  - On **K**: Proceed as-is.
87
92
  5. Route — choose exactly one:
88
93
 
@@ -12,14 +12,19 @@ deferred_work_file: '{implementation_artifacts}/deferred-work.md'
12
12
  ## INSTRUCTIONS
13
13
 
14
14
  1. Draft resume check. If `{spec_file}` exists with `status: draft`, read it and capture the verbatim `<frozen-after-approval>...</frozen-after-approval>` block as `preserved_intent`. Otherwise `preserved_intent` is empty.
15
- 2. Investigate codebase. _Isolate deep exploration in sub-agents/tasks where available. To prevent context snowballing, instruct subagents to give you distilled summaries only._
15
+ 2. Investigate codebase. _Isolate deep exploration in subagents/tasks where available. To prevent context snowballing, instruct subagents to give you distilled summaries only._
16
16
  3. Read `./spec-template.md` fully. Fill it out based on the intent and investigation. If `{preserved_intent}` is non-empty, substitute it for the `<frozen-after-approval>` block in your filled spec before writing. Write the result to `{spec_file}`.
17
17
  4. Self-review against READY FOR DEVELOPMENT standard.
18
18
  5. If intent gaps exist, do not fantasize, do not leave open questions, HALT and ask the human.
19
19
  6. Token count check (see SCOPE STANDARD). If spec exceeds 1600 tokens:
20
20
  - Show user the token count.
21
21
  - HALT and ask human: `[S] Split — carve off secondary goals` | `[K] Keep full spec — accept the risks`
22
- - On **S**: Propose the split — name each secondary goal. Append deferred goals to `{deferred_work_file}`. Rewrite the current spec to cover only the main goal — do not surgically carve sections out; regenerate the spec for the narrowed scope. Continue to checkpoint.
22
+ - On **S**: Propose the split — name each secondary goal. For each deferred goal, append one new entry to `{deferred_work_file}` using this format. Do not modify existing entries or look for duplicates. Rewrite the current spec to cover only the main goal — do not surgically carve sections out; regenerate the spec for the narrowed scope. Continue to checkpoint.
23
+ ```markdown
24
+ - source_spec: `{spec_file}`
25
+ summary: <one sentence naming the deferred goal>
26
+ evidence: <why this was split from the current spec>
27
+ ```
23
28
  - On **K**: Continue to checkpoint with full spec.
24
29
 
25
30
  ### CHECKPOINT 1
@@ -26,15 +26,15 @@ Change `{spec_file}` status to `in-progress` in the frontmatter before starting
26
26
 
27
27
  Follow `./sync-sprint-status.md` with `{target_status}` = `in-progress`.
28
28
 
29
- If `{spec_file}` has a non-empty `context:` list in its frontmatter, load those files before implementation begins. When handing to a sub-agent, include them in the sub-agent prompt so it has access to the referenced context.
29
+ If `{spec_file}` has a non-empty `context:` list in its frontmatter, load those files before implementation begins. When handing to a subagent, include them in the subagent prompt so it has access to the referenced context.
30
30
 
31
- Hand `{spec_file}` to a sub-agent/task and let it implement. If no sub-agents are available, implement directly.
31
+ Hand `{spec_file}` to a subagent/task and let it implement. If no subagents are available, implement directly.
32
32
 
33
33
  **Path formatting rule:** Any markdown links written into `{spec_file}` must use paths relative to `{spec_file}`'s directory so they are clickable in VS Code. Any file paths displayed in terminal/conversation output must use CWD-relative format with `:line` notation (e.g., `src/path/file.ts:42`) for terminal clickability. No leading `/` in either case.
34
34
 
35
- ### Self-Check
35
+ ### Tasks & Acceptance Verification
36
36
 
37
- Before leaving this step, verify every task in the `## Tasks & Acceptance` section of `{spec_file}` is complete. Mark each finished task `[x]`. If any task is not done, finish it before proceeding.
37
+ Before leaving this step, verify every task in the `## Tasks & Acceptance` section of `{spec_file}` is complete and every acceptance criterion is satisfied. Mark each finished task `[x]`. If any task is not done or any acceptance criterion is not satisfied, finish the missing work before proceeding.
38
38
 
39
39
  ## NEXT
40
40
 
@@ -1,6 +1,5 @@
1
1
  ---
2
2
  deferred_work_file: '{implementation_artifacts}/deferred-work.md'
3
- specLoopIteration: 1
4
3
  ---
5
4
 
6
5
  # Step 4: Review
@@ -23,26 +22,35 @@ Do NOT `git add` anything — this is read-only inspection.
23
22
 
24
23
  ### Review
25
24
 
26
- Launch three subagents without conversation context. If no sub-agents are available, generate three review prompt files in `{implementation_artifacts}` — one per reviewer role below — and HALT. Ask the human to run each in a separate session (ideally a different LLM) and paste back the findings.
25
+ Launch two subagents without conversation context. If no subagents are available, generate two review prompt files in `{implementation_artifacts}` — one per reviewer role below — and HALT. Ask the human to run each in a separate session (ideally a different LLM) and paste back the findings.
27
26
 
28
27
  - **Blind hunter** — receives inline `{diff_output}` only. No spec, no context docs, no project access. Invoke via the `bmad-review-adversarial-general` skill.
29
28
  - **Edge case hunter** — receives `{diff_output}` and read access to the project. Invoke via the `bmad-review-edge-case-hunter` skill.
30
- - **Acceptance auditor** — receives `{diff_output}`, `{spec_file}`, and read access to the project. Must also read the docs listed in `{spec_file}` frontmatter `context`. Checks for violations of acceptance criteria, rules, and principles from the spec and context docs.
31
29
 
32
30
  ### Classify
33
31
 
34
32
  1. Deduplicate all review findings.
35
- 2. Classify each finding. The first three categories are **this story's problem** caused or exposed by the current change. The last two are **not this story's problem**.
33
+ 2. Assign severity to each finding by consequence for the artifact's main consumer (software user, document reader, etc).
34
+ Disregard any severity assigned by a reviewing subagent. Review subagents operate under by-design information asymmetry and do not have enough context to set final severity for this workflow.
35
+ - `low`: none or cosmetic
36
+ - `medium`: tolerable
37
+ - `high`: intolerable
38
+ 3. Route each finding into exactly one triage category. The first three categories are **this story's problem** — caused or exposed by the current change. The last two are **not this story's problem**.
36
39
  - **intent_gap** — caused by the change; cannot be resolved from the spec because the captured intent is incomplete. Do not infer intent unless there is exactly one possible reading.
37
40
  - **bad_spec** — caused by the change, including direct deviations from spec. The spec should have been clear enough to prevent it. When in doubt between bad_spec and patch, prefer bad_spec — a spec-level fix is more likely to produce coherent code.
38
41
  - **patch** — caused by the change; trivially fixable without human input. Just part of the diff.
39
42
  - **defer** — pre-existing issue not caused by this story, surfaced incidentally by the review. Collect for later focused attention.
40
43
  - **reject** — noise. Drop silently. When unsure between defer and reject, prefer reject — only defer findings you are confident are real.
41
- 3. Process findings in cascading order. If intent_gap or bad_spec findings exist, they trigger a loopback — lower findings are moot since code will be re-derived. If neither exists, process patch and defer normally. Increment `{specLoopIteration}` on each loopback. If it exceeds 5, HALT and escalate to the human.
44
+ 4. Process findings in cascading order. If intent_gap or bad_spec findings exist, they trigger a loopback — lower findings are moot since code will be re-derived. If neither exists, process patch and defer normally. Before each loopback, read `{spec_file}` frontmatter `review_loop_iteration` (missing means `0`), increment it by 1, and write it back. If it exceeds 5, HALT and escalate to the human.
42
45
  - **intent_gap** — Root cause is inside `<frozen-after-approval>`. Revert code changes. Loop back to the human to resolve. Once resolved, read fully and follow `./step-02-plan.md` to re-run steps 2–4.
43
46
  - **bad_spec** — Root cause is outside `<frozen-after-approval>`. Before reverting code: extract KEEP instructions for positive preservation (what worked well and must survive re-derivation). Revert code changes. Read the `## Spec Change Log` in `{spec_file}` and strictly respect all logged constraints when amending the non-frozen sections that contain the root cause. Append a new change-log entry recording: the triggering finding, what was amended, the known-bad state avoided, and the KEEP instructions. Read fully and follow `./step-03-implement.md` to re-derive the code, then this step will run again.
44
47
  - **patch** — Auto-fix. These are the only findings that survive loopbacks.
45
- - **defer** — Append to `{deferred_work_file}`.
48
+ - **defer** — Append one new entry to `{deferred_work_file}` using this format. Do not modify existing entries or look for duplicates.
49
+ ```markdown
50
+ - source_spec: `{spec_file}`
51
+ summary: <one sentence>
52
+ evidence: <why this is real>
53
+ ```
46
54
  - **reject** — Drop silently.
47
55
 
48
56
  ## NEXT
@@ -19,14 +19,19 @@ Implement the clarified intent directly.
19
19
 
20
20
  ### Review
21
21
 
22
- Invoke the `bmad-review-adversarial-general` skill in a subagent with the changed files. The subagent gets NO conversation context — to avoid anchoring bias. Launch at the same model capability as the current session. If no sub-agents are available, write the changed files to a review prompt file in `{implementation_artifacts}` and HALT. Ask the human to run the review in a separate session and paste back the findings.
22
+ Invoke the `bmad-review-adversarial-general` skill in a subagent with the changed files. The subagent gets NO conversation context — to avoid anchoring bias. Launch at the same model capability as the current session. If no subagents are available, write the changed files to a review prompt file in `{implementation_artifacts}` and HALT. Ask the human to run the review in a separate session and paste back the findings.
23
23
 
24
24
  ### Classify
25
25
 
26
26
  Deduplicate all review findings. Three categories only:
27
27
 
28
28
  - **patch** — trivially fixable. Auto-fix immediately.
29
- - **defer** — pre-existing issue not caused by this change. Append to `{deferred_work_file}`.
29
+ - **defer** — pre-existing issue not caused by this change. Append one new entry to `{deferred_work_file}` using this format. Do not modify existing entries or look for duplicates.
30
+ ```markdown
31
+ - source_spec: `{spec_file}`
32
+ summary: <one sentence>
33
+ evidence: <why this is real>
34
+ ```
30
35
  - **reject** — noise. Drop silently.
31
36
 
32
37
  If a finding is caused by this change but too significant for a trivial patch, HALT and present it to the human for decision before proceeding.
@@ -28,7 +28,7 @@ Review with extreme skepticism — assume problems exist. Find at least ten issu
28
28
 
29
29
  ### Step 3: Present Findings
30
30
 
31
- Output findings as a Markdown list (descriptions only).
31
+ Output findings as a Markdown list: descriptions only, no severity, priority, or ranking.
32
32
 
33
33
 
34
34
  ## HALT CONDITIONS
@@ -16,7 +16,7 @@ Ignore the rest of the codebase unless the provided content explicitly reference
16
16
 
17
17
  **MANDATORY: Execute steps in the Execution section IN EXACT ORDER. DO NOT skip steps or change the sequence. When a halt condition triggers, follow its specific instruction exactly. Each action within a step is a REQUIRED action to complete that step.**
18
18
 
19
- **Your method is exhaustive path enumeration — mechanically walk every branch, not hunt by intuition. Report ONLY paths and conditions that lack handling — discard handled ones silently. Do NOT editorialize or add filler findings only.**
19
+ **Your method is exhaustive path enumeration — mechanically walk every branch, not hunt by intuition. Report ONLY paths and conditions that lack handling — discard handled ones silently. Do NOT editorialize or add filler. Do not assign severity labels, rankings, or priority levels.**
20
20
 
21
21
 
22
22
  ## EXECUTION
@@ -312,6 +312,11 @@ function validateSkill(skillDir) {
312
312
  const name = skillFm && skillFm.name;
313
313
  const description = skillFm && skillFm.description;
314
314
 
315
+ // Deprecated skills are thin compatibility shims that forward to a replacement.
316
+ // They intentionally omit a "Use when" trigger so users are steered to the new
317
+ // skill instead, so exempt them from the SKILL-06 trigger-phrase requirement.
318
+ const isDeprecated = typeof description === 'string' && /^\s*deprecated\b/i.test(description);
319
+
315
320
  // --- SKILL-04: name format ---
316
321
  if (name && !NAME_REGEX.test(name)) {
317
322
  findings.push({
@@ -349,7 +354,7 @@ function validateSkill(skillDir) {
349
354
  });
350
355
  }
351
356
 
352
- if (!/use\s+when\b/i.test(description) && !/use\s+if\b/i.test(description)) {
357
+ if (!isDeprecated && !/use\s+when\b/i.test(description) && !/use\s+if\b/i.test(description)) {
353
358
  findings.push({
354
359
  rule: 'SKILL-06',
355
360
  title: 'description Quality',