bmad-method 6.3.1-next.2 → 6.3.1-next.20

package/tools/installer/core/manifest.js

@@ -1,7 +1,7 @@
 const path = require('node:path');
-const fs = require('fs-extra');
+const fs = require('../fs-native');
 const crypto = require('node:crypto');
-const { getProjectRoot } = require('../project-root');
+const { resolveModuleVersion } = require('../modules/version-resolver');
 const prompts = require('../prompts');
 
 class Manifest {
@@ -107,117 +107,6 @@ class Manifest {
     return null;
   }
 
-  /**
-   * Update existing manifest
-   * @param {string} bmadDir - Path to bmad directory
-   * @param {Object} updates - Fields to update
-   * @param {Array} installedFiles - Updated list of installed files
-   */
-  async update(bmadDir, updates, installedFiles = null) {
-    const yaml = require('yaml');
-    const manifest = (await this._readRaw(bmadDir)) || {
-      installation: {},
-      modules: [],
-      ides: [],
-    };
-
-    // Handle module updates
-    if (updates.modules) {
-      // If modules is being updated, we need to preserve detailed module info
-      const existingDetailed = manifest.modules || [];
-      const incomingNames = updates.modules;
-
-      // Build updated modules array
-      const updatedModules = [];
-      for (const name of incomingNames) {
-        const existing = existingDetailed.find((m) => m.name === name);
-        if (existing) {
-          // Preserve existing details, update lastUpdated if this module is being updated
-          updatedModules.push({
-            ...existing,
-            lastUpdated: new Date().toISOString(),
-          });
-        } else {
-          // New module - add with minimal details
-          updatedModules.push({
-            name,
-            version: null,
-            installDate: new Date().toISOString(),
-            lastUpdated: new Date().toISOString(),
-            source: 'unknown',
-          });
-        }
-      }
-
-      manifest.modules = updatedModules;
-    }
-
-    // Merge other updates
-    if (updates.version) {
-      manifest.installation.version = updates.version;
-    }
-    if (updates.installDate) {
-      manifest.installation.installDate = updates.installDate;
-    }
-    manifest.installation.lastUpdated = new Date().toISOString();
-
-    if (updates.ides) {
-      manifest.ides = updates.ides;
-    }
-
-    // Handle per-module version updates
-    if (updates.moduleVersions) {
-      for (const [moduleName, versionInfo] of Object.entries(updates.moduleVersions)) {
-        const moduleIndex = manifest.modules.findIndex((m) => m.name === moduleName);
-        if (moduleIndex !== -1) {
-          manifest.modules[moduleIndex] = {
-            ...manifest.modules[moduleIndex],
-            ...versionInfo,
-            lastUpdated: new Date().toISOString(),
-          };
-        }
-      }
-    }
-
-    // Handle adding a new module with version info
-    if (updates.addModule) {
-      const { name, version, source, npmPackage, repoUrl, localPath } = updates.addModule;
-      const existing = manifest.modules.find((m) => m.name === name);
-      if (!existing) {
-        const entry = {
-          name,
-          version: version || null,
-          installDate: new Date().toISOString(),
-          lastUpdated: new Date().toISOString(),
-          source: source || 'external',
-          npmPackage: npmPackage || null,
-          repoUrl: repoUrl || null,
-        };
-        if (localPath) entry.localPath = localPath;
-        manifest.modules.push(entry);
-      }
-    }
-
-    const manifestPath = path.join(bmadDir, '_config', 'manifest.yaml');
-    await fs.ensureDir(path.dirname(manifestPath));
-
-    // Clean the manifest data to remove any non-serializable values
-    const cleanManifestData = structuredClone(manifest);
-
-    const yamlContent = yaml.stringify(cleanManifestData, {
-      indent: 2,
-      lineWidth: 0,
-      sortKeys: false,
-    });
-
-    // Ensure POSIX-compliant final newline
-    const content = yamlContent.endsWith('\n') ? yamlContent : yamlContent + '\n';
-    await fs.writeFile(manifestPath, content, 'utf8');
-
-    // Return the flattened format for compatibility
-    return this._flattenManifest(manifest);
-  }
-
   /**
    * Read raw manifest data without flattening
    * @param {string} bmadDir - Path to bmad directory
@@ -310,62 +199,6 @@ class Manifest {
     await this._writeRaw(bmadDir, manifest);
   }
 
-  /**
-   * Remove a module from the manifest
-   * @param {string} bmadDir - Path to bmad directory
-   * @param {string} moduleName - Module name to remove
-   */
-  async removeModule(bmadDir, moduleName) {
-    const manifest = await this._readRaw(bmadDir);
-    if (!manifest || !manifest.modules) {
-      return;
-    }
-
-    const index = manifest.modules.findIndex((m) => m.name === moduleName);
-    if (index !== -1) {
-      manifest.modules.splice(index, 1);
-      await this._writeRaw(bmadDir, manifest);
-    }
-  }
-
-  /**
-   * Update a single module's version info
-   * @param {string} bmadDir - Path to bmad directory
-   * @param {string} moduleName - Module name
-   * @param {Object} versionInfo - Version info to update
-   */
-  async updateModuleVersion(bmadDir, moduleName, versionInfo) {
-    const manifest = await this._readRaw(bmadDir);
-    if (!manifest || !manifest.modules) {
-      return;
-    }
-
-    const index = manifest.modules.findIndex((m) => m.name === moduleName);
-    if (index !== -1) {
-      manifest.modules[index] = {
-        ...manifest.modules[index],
-        ...versionInfo,
-        lastUpdated: new Date().toISOString(),
-      };
-      await this._writeRaw(bmadDir, manifest);
-    }
-  }
-
-  /**
-   * Get version info for a specific module
-   * @param {string} bmadDir - Path to bmad directory
-   * @param {string} moduleName - Module name
-   * @returns {Object|null} Module version info or null
-   */
-  async getModuleVersion(bmadDir, moduleName) {
-    const manifest = await this._readRaw(bmadDir);
-    if (!manifest || !manifest.modules) {
-      return null;
-    }
-
-    return manifest.modules.find((m) => m.name === moduleName) || null;
-  }
-
   /**
    * Get all modules with their version info
    * @param {string} bmadDir - Path to bmad directory
@@ -403,27 +236,6 @@ class Manifest {
     await fs.writeFile(manifestPath, content, 'utf8');
   }
 
-  /**
-   * Add an IDE configuration to the manifest
-   * @param {string} bmadDir - Path to bmad directory
-   * @param {string} ideName - IDE name to add
-   */
-  async addIde(bmadDir, ideName) {
-    const manifest = await this.read(bmadDir);
-    if (!manifest) {
-      throw new Error('No manifest found');
-    }
-
-    if (!manifest.ides) {
-      manifest.ides = [];
-    }
-
-    if (!manifest.ides.includes(ideName)) {
-      manifest.ides.push(ideName);
-      await this.update(bmadDir, { ides: manifest.ides });
-    }
-  }
-
   /**
    * Calculate SHA256 hash of a file
    * @param {string} filePath - Path to file
@@ -438,354 +250,6 @@ class Manifest {
     }
   }
 
-  /**
-   * Parse installed files to extract metadata
-   * @param {Array} installedFiles - List of installed file paths
-   * @param {string} bmadDir - Path to bmad directory for relative paths
-   * @returns {Array} Array of file metadata objects
-   */
-  async parseInstalledFiles(installedFiles, bmadDir) {
-    const fileMetadata = [];
-
-    for (const filePath of installedFiles) {
-      const fileExt = path.extname(filePath).toLowerCase();
-      // Make path relative to parent of bmad directory, starting with 'bmad/'
-      const relativePath = 'bmad' + filePath.replace(bmadDir, '').replaceAll('\\', '/');
-
-      // Calculate file hash
-      const hash = await this.calculateFileHash(filePath);
-
-      // Handle markdown files - extract XML metadata if present
-      if (fileExt === '.md') {
-        try {
-          if (await fs.pathExists(filePath)) {
-            const content = await fs.readFile(filePath, 'utf8');
-            const metadata = this.extractXmlNodeAttributes(content, filePath, relativePath);
-
-            if (metadata) {
-              // Has XML metadata
-              metadata.hash = hash;
-              fileMetadata.push(metadata);
-            } else {
-              // No XML metadata - still track the file
-              fileMetadata.push({
-                file: relativePath,
-                type: 'md',
-                name: path.basename(filePath, fileExt),
-                title: null,
-                hash: hash,
-              });
-            }
-          }
-        } catch (error) {
-          await prompts.log.warn(`Could not parse ${filePath}: ${error.message}`);
-        }
-      }
-      // Handle other file types (CSV, JSON, YAML, etc.)
-      else {
-        fileMetadata.push({
-          file: relativePath,
-          type: fileExt.slice(1), // Remove the dot
-          name: path.basename(filePath, fileExt),
-          title: null,
-          hash: hash,
-        });
-      }
-    }
-
-    return fileMetadata;
-  }
-
-  /**
-   * Extract XML node attributes from MD file content
-   * @param {string} content - File content
-   * @param {string} filePath - File path for context
-   * @param {string} relativePath - Relative path starting with 'bmad/'
-   * @returns {Object|null} Extracted metadata or null
-   */
-  extractXmlNodeAttributes(content, filePath, relativePath) {
-    // Look for XML blocks in code fences
-    const xmlBlockMatch = content.match(/```xml\s*([\s\S]*?)```/);
-    if (!xmlBlockMatch) {
-      return null;
-    }
-
-    const xmlContent = xmlBlockMatch[1];
-
-    // Extract root XML node (agent, task, template, etc.)
-    const rootNodeMatch = xmlContent.match(/<(\w+)([^>]*)>/);
-    if (!rootNodeMatch) {
-      return null;
-    }
-
-    const nodeType = rootNodeMatch[1];
-    const attributes = rootNodeMatch[2];
-
-    // Extract name and title attributes (id not needed since we have path)
-    const nameMatch = attributes.match(/name="([^"]*)"/);
-    const titleMatch = attributes.match(/title="([^"]*)"/);
-
-    return {
-      file: relativePath,
-      type: nodeType,
-      name: nameMatch ? nameMatch[1] : null,
-      title: titleMatch ? titleMatch[1] : null,
-    };
-  }
-
-  /**
-   * Generate CSV manifest content
-   * @param {Object} data - Manifest data
-   * @param {Array} fileMetadata - File metadata array
-   * @param {Object} moduleConfigs - Module configuration data
-   * @returns {string} CSV content
-   */
-  generateManifestCsv(data, fileMetadata, moduleConfigs = {}) {
-    const timestamp = new Date().toISOString();
-    let csv = [];
-
-    // Header section
-    csv.push(
-      '# BMAD Manifest',
-      `# Generated: ${timestamp}`,
-      '',
-      '## Installation Info',
-      'Property,Value',
-      `Version,${data.version}`,
-      `InstallDate,${data.installDate || timestamp}`,
-      `LastUpdated,${data.lastUpdated || timestamp}`,
-    );
-    if (data.language) {
-      csv.push(`Language,${data.language}`);
-    }
-    csv.push('');
-
-    // Modules section
-    if (data.modules && data.modules.length > 0) {
-      csv.push('## Modules', 'Name,Version,ShortTitle');
-      for (const moduleName of data.modules) {
-        const config = moduleConfigs[moduleName] || {};
-        csv.push([moduleName, config.version || '', config['short-title'] || ''].map((v) => this.escapeCsv(v)).join(','));
-      }
-      csv.push('');
-    }
-
-    // IDEs section
-    if (data.ides && data.ides.length > 0) {
-      csv.push('## IDEs', 'IDE');
-      for (const ide of data.ides) {
-        csv.push(this.escapeCsv(ide));
-      }
-      csv.push('');
-    }
-
-    // Files section - NO LONGER USED
-    // Files are now tracked in files-manifest.csv by ManifestGenerator
-
-    return csv.join('\n');
-  }
-
-  /**
-   * Parse CSV manifest content back to object
-   * @param {string} csvContent - CSV content to parse
-   * @returns {Object} Parsed manifest data
-   */
-  parseManifestCsv(csvContent) {
-    const result = {
-      modules: [],
-      ides: [],
-      files: [],
-    };
-
-    const lines = csvContent.split('\n');
-    let section = '';
-
-    for (const line_ of lines) {
-      const line = line_.trim();
-
-      // Skip empty lines and comments
-      if (!line || line.startsWith('#')) {
-        // Check for section headers
-        if (line.startsWith('## ')) {
-          section = line.slice(3).toLowerCase();
-        }
-        continue;
-      }
-
-      // Parse based on current section
-      switch (section) {
-        case 'installation info': {
-          // Skip header row
-          if (line === 'Property,Value') continue;
-
-          const [property, ...valueParts] = line.split(',');
-          const value = this.unescapeCsv(valueParts.join(','));
-
-          switch (property) {
-            // Path no longer stored in manifest
-            case 'Version': {
-              result.version = value;
-              break;
-            }
-            case 'InstallDate': {
-              result.installDate = value;
-              break;
-            }
-            case 'LastUpdated': {
-              result.lastUpdated = value;
-              break;
-            }
-            case 'Language': {
-              result.language = value;
-              break;
-            }
-          }
-
-          break;
-        }
-        case 'modules': {
-          // Skip header row
-          if (line === 'Name,Version,ShortTitle') continue;
-
-          const parts = this.parseCsvLine(line);
-          if (parts[0]) {
-            result.modules.push(parts[0]);
-          }
-
-          break;
-        }
-        case 'ides': {
-          // Skip header row
-          if (line === 'IDE') continue;
-
-          result.ides.push(this.unescapeCsv(line));
-
-          break;
-        }
-        case 'files': {
-          // Skip header rows (support both old and new format)
-          if (line === 'Type,Path,Name,Title' || line === 'Type,Path,Name,Title,Hash') continue;
-
-          const parts = this.parseCsvLine(line);
-          if (parts.length >= 2) {
-            result.files.push({
-              type: parts[0] || '',
-              file: parts[1] || '',
-              name: parts[2] || null,
-              title: parts[3] || null,
-              hash: parts[4] || null, // Hash column (may not exist in old manifests)
-            });
-          }
-
-          break;
-        }
-        // No default
-      }
-    }
-
-    return result;
-  }
-
-  /**
-   * Parse a CSV line handling quotes and commas
-   * @param {string} line - CSV line to parse
-   * @returns {Array} Array of values
-   */
-  parseCsvLine(line) {
-    const result = [];
-    let current = '';
-    let inQuotes = false;
-
-    for (let i = 0; i < line.length; i++) {
-      const char = line[i];
-
-      if (char === '"') {
-        if (inQuotes && line[i + 1] === '"') {
-          // Escaped quote
-          current += '"';
-          i++;
-        } else {
-          // Toggle quote state
-          inQuotes = !inQuotes;
-        }
-      } else if (char === ',' && !inQuotes) {
-        // Field separator
-        result.push(this.unescapeCsv(current));
-        current = '';
-      } else {
-        current += char;
-      }
-    }
-
-    // Add the last field
-    result.push(this.unescapeCsv(current));
-
-    return result;
-  }
-
-  /**
-   * Escape CSV special characters
-   * @param {string} text - Text to escape
-   * @returns {string} Escaped text
-   */
-  escapeCsv(text) {
-    if (!text) return '';
-    const str = String(text);
-
-    // If contains comma, newline, or quote, wrap in quotes and escape quotes
-    if (str.includes(',') || str.includes('\n') || str.includes('"')) {
-      return '"' + str.replaceAll('"', '""') + '"';
-    }
-
-    return str;
-  }
-
-  /**
-   * Unescape CSV field
-   * @param {string} text - Text to unescape
-   * @returns {string} Unescaped text
-   */
-  unescapeCsv(text) {
-    if (!text) return '';
-
-    // Remove surrounding quotes if present
-    if (text.startsWith('"') && text.endsWith('"')) {
-      text = text.slice(1, -1);
-      // Unescape doubled quotes
-      text = text.replaceAll('""', '"');
-    }
-
-    return text;
-  }
-
-  /**
-   * Load module configuration files
-   * @param {Array} modules - List of module names
-   * @returns {Object} Module configurations indexed by name
-   */
-  async loadModuleConfigs(modules) {
-    const configs = {};
-
-    for (const moduleName of modules) {
-      // Handle core module differently - it's in src/core-skills not src/modules/core
-      const configPath =
-        moduleName === 'core'
-          ? path.join(process.cwd(), 'src', 'core-skills', 'config.yaml')
-          : path.join(process.cwd(), 'src', 'modules', moduleName, 'config.yaml');
-
-      try {
-        if (await fs.pathExists(configPath)) {
-          const yaml = require('yaml');
-          const content = await fs.readFile(configPath, 'utf8');
-          configs[moduleName] = yaml.parse(content);
-        }
-      } catch (error) {
-        await prompts.log.warn(`Could not load config for module ${moduleName}: ${error.message}`);
-      }
-    }
-
-    return configs;
-  }
   /**
    * Get module version info from source
    * @param {string} moduleName - Module name/code
@@ -794,13 +258,11 @@ class Manifest {
    * @returns {Object} Version info object with version, source, npmPackage, repoUrl
    */
   async getModuleVersionInfo(moduleName, bmadDir, moduleSourcePath = null) {
-    const yaml = require('yaml');
-
     // Resolve source type first, then read version with the correct path context
     if (['core', 'bmm'].includes(moduleName)) {
-      const version = await this._readMarketplaceVersion(moduleName, moduleSourcePath);
+      const versionInfo = await resolveModuleVersion(moduleName, { moduleSourcePath });
       return {
-        version,
+        version: versionInfo.version,
         source: 'built-in',
         npmPackage: null,
         repoUrl: null,
@@ -813,10 +275,9 @@ class Manifest {
     const moduleInfo = await extMgr.getModuleByCode(moduleName);
 
     if (moduleInfo) {
-      // External module: use moduleSourcePath if provided, otherwise fall back to cache
-      const version = await this._readMarketplaceVersion(moduleName, moduleSourcePath);
+      const versionInfo = await resolveModuleVersion(moduleName, { moduleSourcePath });
       return {
-        version,
+        version: versionInfo.version,
         source: 'external',
         npmPackage: moduleInfo.npmPackage || null,
         repoUrl: moduleInfo.url || null,
@@ -828,9 +289,12 @@ class Manifest {
     const communityMgr = new CommunityModuleManager();
     const communityInfo = await communityMgr.getModuleByCode(moduleName);
     if (communityInfo) {
-      const communityVersion = await this._readMarketplaceVersion(moduleName, moduleSourcePath);
+      const versionInfo = await resolveModuleVersion(moduleName, {
+        moduleSourcePath,
+        fallbackVersion: communityInfo.version,
+      });
       return {
-        version: communityVersion || communityInfo.version,
+        version: versionInfo.version || communityInfo.version,
         source: 'community',
         npmPackage: communityInfo.npmPackage || null,
         repoUrl: communityInfo.url || null,
@@ -843,9 +307,13 @@ class Manifest {
     const resolved = customMgr.getResolution(moduleName);
     const customSource = await customMgr.findModuleSourceByCode(moduleName, { bmadDir });
     if (customSource || resolved) {
-      const customVersion = resolved?.version || (await this._readMarketplaceVersion(moduleName, moduleSourcePath));
+      const versionInfo = await resolveModuleVersion(moduleName, {
+        moduleSourcePath: moduleSourcePath || customSource,
+        fallbackVersion: resolved?.version,
+        marketplacePluginNames: resolved?.pluginName ? [resolved.pluginName] : [],
+      });
       return {
-        version: customVersion,
+        version: versionInfo.version,
         source: 'custom',
         npmPackage: null,
         repoUrl: resolved?.repoUrl || null,
@@ -854,64 +322,15 @@ class Manifest {
     }
 
     // Unknown module
-    const version = await this._readMarketplaceVersion(moduleName, moduleSourcePath);
+    const versionInfo = await resolveModuleVersion(moduleName, { moduleSourcePath });
     return {
-      version,
+      version: versionInfo.version,
       source: 'unknown',
       npmPackage: null,
       repoUrl: null,
     };
   }
 
-  /**
-   * Read version from .claude-plugin/marketplace.json for a module
-   * @param {string} moduleName - Module code
-   * @returns {string|null} Version or null
-   */
-  async _readMarketplaceVersion(moduleName, moduleSourcePath = null) {
-    const os = require('node:os');
-    let marketplacePath;
-
-    if (['core', 'bmm'].includes(moduleName)) {
-      marketplacePath = path.join(getProjectRoot(), '.claude-plugin', 'marketplace.json');
-    } else if (moduleSourcePath) {
-      // Walk up from source path to find marketplace.json
-      let dir = moduleSourcePath;
-      for (let i = 0; i < 5; i++) {
-        const candidate = path.join(dir, '.claude-plugin', 'marketplace.json');
-        if (await fs.pathExists(candidate)) {
-          marketplacePath = candidate;
-          break;
-        }
-        const parent = path.dirname(dir);
-        if (parent === dir) break;
-        dir = parent;
-      }
-    }
-
-    // Fallback to external module cache
-    if (!marketplacePath) {
-      const cacheDir = path.join(os.homedir(), '.bmad', 'cache', 'external-modules', moduleName);
-      marketplacePath = path.join(cacheDir, '.claude-plugin', 'marketplace.json');
-    }
-
-    try {
-      if (await fs.pathExists(marketplacePath)) {
-        const data = JSON.parse(await fs.readFile(marketplacePath, 'utf8'));
-        const plugins = data?.plugins;
-        if (!Array.isArray(plugins) || plugins.length === 0) return null;
-        let best = null;
-        for (const p of plugins) {
-          if (p.version && (!best || p.version > best)) best = p.version;
-        }
-        return best;
-      }
-    } catch {
-      // ignore
-    }
-    return null;
-  }
-
   /**
    * Fetch latest version from npm for a package
    * @param {string} packageName - npm package name
@@ -960,6 +379,7 @@ class Manifest {
    * @returns {Array} Array of update info objects
    */
   async checkForUpdates(bmadDir) {
+    const semver = require('semver');
     const modules = await this.getAllModuleVersions(bmadDir);
     const updates = [];
 
@@ -973,7 +393,10 @@ class Manifest {
         continue;
       }
 
-      if (module.version !== latestVersion) {
+      const installedVersion = semver.valid(module.version) || semver.valid(semver.coerce(module.version || ''));
+      const availableVersion = semver.valid(latestVersion) || semver.valid(semver.coerce(latestVersion));
+
+      if (installedVersion && availableVersion && semver.gt(availableVersion, installedVersion)) {
         updates.push({
           name: module.name,
           installedVersion: module.version,
@@ -986,47 +409,6 @@ class Manifest {
 
     return updates;
   }
-
-  /**
-   * Compare two semantic versions
-   * @param {string} v1 - First version
-   * @param {string} v2 - Second version
-   * @returns {number} -1 if v1 < v2, 0 if v1 == v2, 1 if v1 > v2
-   */
-  compareVersions(v1, v2) {
-    if (!v1 || !v2) return 0;
-
-    const normalize = (v) => {
-      // Remove leading 'v' if present
-      v = v.replace(/^v/, '');
-      // Handle prerelease tags
-      const parts = v.split('-');
-      const main = parts[0].split('.');
-      const prerelease = parts[1];
-      return { main, prerelease };
-    };
-
-    const n1 = normalize(v1);
-    const n2 = normalize(v2);
-
-    // Compare main version parts
-    for (let i = 0; i < 3; i++) {
-      const num1 = parseInt(n1.main[i] || '0', 10);
-      const num2 = parseInt(n2.main[i] || '0', 10);
-      if (num1 !== num2) {
-        return num1 < num2 ? -1 : 1;
-      }
-    }
-
-    // If main versions are equal, compare prerelease
-    if (n1.prerelease && n2.prerelease) {
-      return n1.prerelease < n2.prerelease ? -1 : n1.prerelease > n2.prerelease ? 1 : 0;
-    }
-    if (n1.prerelease) return -1; // Prerelease is older than stable
-    if (n2.prerelease) return 1; // Stable is newer than prerelease
-
-    return 0;
-  }
 }
 
 module.exports = { Manifest };