bmad-method 6.11.1-next.2 → 6.11.1-next.21

package/tools/installer/modules/official-modules.js

@@ -5,6 +5,7 @@ const prompts = require('../prompts');
 const { getProjectRoot, getSourcePath, getModulePath } = require('../project-root');
 const { CLIUtils } = require('../cli-utils');
 const { ExternalModuleManager } = require('./external-manager');
+const { discoverShims } = require('../core/shim-policy');
 
 class OfficialModules {
   constructor(options = {}) {
@@ -131,6 +132,23 @@ class OfficialModules {
     return { modules };
   }
 
+  async discoverShims(moduleNames = [], options = {}) {
+    const shims = [];
+
+    for (const moduleName of moduleNames) {
+      const sourcePath = await this.findModuleSource(moduleName, {
+        silent: true,
+        channelOptions: options.channelOptions,
+      });
+      if (!sourcePath) continue;
+
+      const moduleShims = await discoverShims(sourcePath);
+      for (const shim of moduleShims) shims.push({ ...shim, module: moduleName });
+    }
+
+    return shims;
+  }
+
   /**
    * Get module information from a module path
    * @param {string} modulePath - Path to the module directory
@@ -296,9 +314,13 @@ class OfficialModules {
             `Aborting to avoid a partial install with no skills.`,
         );
       }
-      await this._copyResolvedSkills(pluginResolution, targetPath, fileTrackingCallback, options.moduleConfig);
+      await this._copyResolvedSkills(pluginResolution, targetPath, fileTrackingCallback, options.moduleConfig, {
+        installShims: options.installShims,
+      });
     } else {
-      await this.copyModuleWithFiltering(sourcePath, targetPath, fileTrackingCallback, options.moduleConfig);
+      await this.copyModuleWithFiltering(sourcePath, targetPath, fileTrackingCallback, options.moduleConfig, {
+        installShims: options.installShims,
+      });
     }
 
     if (!options.skipModuleInstaller) {
@@ -336,7 +358,7 @@ class OfficialModules {
    * @param {Function} fileTrackingCallback - Optional callback to track installed files
    * @param {Object} moduleConfig - Module configuration passed to copy filtering
    */
-  async _copyResolvedSkills(resolved, targetPath, fileTrackingCallback = null, moduleConfig = {}) {
+  async _copyResolvedSkills(resolved, targetPath, fileTrackingCallback = null, moduleConfig = {}, installOptions = {}) {
     await fs.ensureDir(targetPath);
 
     // Copy each skill directory, flattened by leaf name. Leaf names must be
@@ -354,7 +376,7 @@ class OfficialModules {
       }
       seenLeaves.set(skillDirName, skillPath);
       const skillTarget = path.join(targetPath, skillDirName);
-      await this.copyModuleWithFiltering(skillPath, skillTarget, fileTrackingCallback, moduleConfig);
+      await this.copyModuleWithFiltering(skillPath, skillTarget, fileTrackingCallback, moduleConfig, installOptions);
     }
 
     // Place module-help.csv at the module root.
@@ -385,7 +407,9 @@ class OfficialModules {
       await fs.remove(targetPath);
     }
 
-    await this._copyResolvedSkills(resolved, targetPath, fileTrackingCallback, options.moduleConfig);
+    await this._copyResolvedSkills(resolved, targetPath, fileTrackingCallback, options.moduleConfig, {
+      installShims: options.installShims,
+    });
 
     // Create directories declared in module.yaml (strategies 1-4 may have these)
     if (!options.skipModuleInstaller) {
@@ -522,11 +546,19 @@ class OfficialModules {
    * @param {Function} fileTrackingCallback - Optional callback to track installed files
    * @param {Object} moduleConfig - Module configuration with conditional flags
    */
-  async copyModuleWithFiltering(sourcePath, targetPath, fileTrackingCallback = null, moduleConfig = {}) {
+  async copyModuleWithFiltering(sourcePath, targetPath, fileTrackingCallback = null, moduleConfig = {}, installOptions = {}) {
     // Get all files in source
     const sourceFiles = await this.getFileList(sourcePath);
+    const shimDirectories =
+      installOptions.installShims === false
+        ? (await discoverShims(sourcePath)).map((shim) => shim.relativeDirectory.split(path.sep).join('/'))
+        : [];
 
     for (const file of sourceFiles) {
+      const normalizedFile = file.split(path.sep).join('/');
+      if (shimDirectories.some((shimDir) => shimDir === '' || normalizedFile === shimDir || normalizedFile.startsWith(`${shimDir}/`))) {
+        continue;
+      }
       // Skip sub-modules directory - these are IDE-specific and handled separately
       if (file.startsWith('sub-modules/')) {
         continue;

package/tools/installer/prompts.js

@@ -316,7 +316,9 @@ async function autocompleteMultiselect(options) {
 
       switch (this.state) {
         case 'submit': {
-          return `${title}${color.gray(clack.S_BAR)}  ${color.dim(`${this.selectedValues.length} items selected`)}`;
+          const count = this.selectedValues.length;
+          const emptyHint = count === 0 && options.emptyLabel ? ` (${options.emptyLabel})` : '';
+          return `${title}${color.gray(clack.S_BAR)}  ${color.dim(`${count} item${count === 1 ? '' : 's'} selected${emptyHint}`)}`;
         }
 
         case 'cancel': {
@@ -331,7 +333,18 @@ async function autocompleteMultiselect(options) {
 
           const errorLine = this.state === 'error' ? [`${bar}  ${color.yellow(this.error)}`] : [];
 
-          const headerLines = [...`${title}${bar}`.split('\n'), `${bar}  ${searchDisplay}${matchCount}`, ...noMatchesLine, ...errorLine];
+          const emptyLine =
+            this.selectedValues.length === 0 && options.emptyLabel
+              ? [`${bar}  ${color.dim(`Nothing selected: installs ${options.emptyLabel}`)}`]
+              : [];
+
+          const headerLines = [
+            ...`${title}${bar}`.split('\n'),
+            `${bar}  ${searchDisplay}${matchCount}`,
+            ...noMatchesLine,
+            ...errorLine,
+            ...emptyLine,
+          ];
 
           const footerLines = [`${bar}  ${color.dim(hints.join(' • '))}`, `${barEnd}`];
 

package/tools/installer/ui.js

@@ -17,6 +17,7 @@ const {
 const channelResolver = require('./modules/channel-resolver');
 const prompts = require('./prompts');
 const { parseSetEntries } = require('./set-overrides');
+const { inferShimPreference, readInstalledSkillIds } = require('./core/shim-policy');
 
 const manifest = new Manifest();
 
@@ -110,6 +111,43 @@ async function getModuleVersion(moduleCode, { repoUrl = null, registryDefault =
  * UI utilities for the installer
  */
 class UI {
+  async _selectShimPreference({ selectedModules, bmadDir, existing, options, channelOptions, quickUpdate = false }) {
+    const { OfficialModules } = require('./modules/official-modules');
+    const officialModules = new OfficialModules({ channelOptions });
+    const availableShims = await officialModules.discoverShims(selectedModules, { channelOptions });
+
+    // The prompt is capability-driven. Once the last shim leaves the incoming
+    // release this becomes an ordinary empty set, regardless of old state.
+    if (availableShims.length === 0) return;
+
+    const previousManifest = existing ? await manifest.read(bmadDir) : null;
+    const installedSkillIds = existing ? await readInstalledSkillIds(bmadDir) : new Set();
+    const currentValue = inferShimPreference({
+      requested: options.shims,
+      persisted: previousManifest?.installShims,
+      availableShims,
+      installedSkillIds,
+      existing,
+    });
+
+    if (typeof options.shims === 'boolean' || options.yes) return currentValue;
+
+    // clack's confirm never resolves without a TTY: a scripted run would exit mid-install.
+    if (!process.stdin.isTTY) return currentValue;
+
+    // Nothing to give up, so nothing to ask on every single update.
+    if (quickUpdate && !currentValue) return currentValue;
+
+    const verb = currentValue ? 'Keep' : 'Install';
+    const message =
+      `${verb} ${availableShims.length} deprecated compatibility shim skill(s)? Recommended: No. ` +
+      `If you say yes, the deprecated skills will exist as a skill that forwards to its replacement skill. ` +
+      `Shims will be removed with v7. You should only retain if you customized a shimmed skill and need to ` +
+      `still transition it to the replacement.`;
+
+    return prompts.confirm({ message, default: currentValue });
+  }
+
   /**
    * Warn once for each selected module the registry marks deprecated.
    *
@@ -302,7 +340,7 @@ class UI {
           throw new Error('No valid actions available for this installation');
         }
         const hasQuickUpdate = choices.some((c) => c.value === 'quick-update');
-        const needsFullUpdate = !!options.customSource;
+        const needsFullUpdate = !!options.customSource || typeof options.shims === 'boolean';
         actionType = hasQuickUpdate && !needsFullUpdate ? 'quick-update' : (choices.find((c) => c.value === 'update') || choices[0]).value;
         await prompts.log.info(`Non-interactive mode (--yes): defaulting to ${actionType}`);
       } else {
@@ -318,10 +356,21 @@ class UI {
         // Quick update never shows the module picker, so this is the only
         // place an existing install of a deprecated module hears about it.
         await this._warnDeprecatedModules(existingInstall.moduleIds || []);
+
+        const installShims = await this._selectShimPreference({
+          selectedModules: existingInstall.moduleIds || [],
+          bmadDir,
+          existing: true,
+          options,
+          channelOptions,
+          quickUpdate: true,
+        });
+
         return {
           actionType: 'quick-update',
           directory: confirmedDirectory,
           skipPrompts: options.yes || false,
+          installShims: installShims === undefined ? options.shims : installShims,
         };
       }
 
@@ -406,6 +455,13 @@ class UI {
           ...options,
           channelOptions,
         });
+        const installShims = await this._selectShimPreference({
+          selectedModules,
+          bmadDir,
+          existing: true,
+          options,
+          channelOptions,
+        });
 
         // Warn about --pin/--next flags that refer to modules the user didn't
         // select, or that target bundled modules (core/bmm) where channel
@@ -432,6 +488,7 @@ class UI {
           skipPrompts: options.yes || false,
           channelOptions,
           _preserveModules: preservedModules,
+          installShims,
         };
       }
     }
@@ -487,6 +544,13 @@ class UI {
       ...options,
       channelOptions,
     });
+    const installShims = await this._selectShimPreference({
+      selectedModules,
+      bmadDir,
+      existing: false,
+      options,
+      channelOptions,
+    });
 
     // Warn about --pin/--next flags that refer to modules the user didn't
     // select, or that target bundled modules (core/bmm) where channel
@@ -512,6 +576,7 @@ class UI {
       setOverrides,
       skipPrompts: options.yes || false,
       channelOptions,
+      installShims,
     };
   }
 
@@ -1071,9 +1136,9 @@ class UI {
       message: 'Select official modules to install:',
       options: allOptions,
       initialValues: initialValues.length > 0 ? initialValues : undefined,
-      // Not required: core is installed either way, so an empty selection is a
-      // legitimate "core only" install rather than a mistake to block on.
+      // Core installs either way and is not a row here, so empty is a valid core-only install.
       required: false,
+      emptyLabel: 'core only',
       maxItems: allOptions.length,
     });