bmad-method 6.10.1-next.0 → 6.10.1-next.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/src/bmm-skills/4-implementation/bmad-code-review/steps/step-03-triage.md +9 -7
- package/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md +1 -1
- package/src/bmm-skills/4-implementation/bmad-dev-auto/step-04-review.md +1 -1
- package/src/bmm-skills/4-implementation/bmad-quick-dev/step-04-review.md +1 -1
package/package.json
CHANGED
|
@@ -16,20 +16,22 @@
|
|
|
16
16
|
- `detail` -- full description
|
|
17
17
|
- `location` -- file and line reference (if available)
|
|
18
18
|
|
|
19
|
-
2. **Deduplicate.** If two or more findings
|
|
19
|
+
2. **Deduplicate.** Deduplicate only findings with the same claim and same required action. If two or more findings meet both conditions, merge them into one:
|
|
20
20
|
- Use the most specific finding as the base (prefer edge-case JSON with location over adversarial prose).
|
|
21
21
|
- Append any unique detail, reasoning, or location references from the other finding(s) into the surviving `detail` field.
|
|
22
22
|
- Set `source` to the merged sources (e.g., `blind+edge`).
|
|
23
23
|
|
|
24
|
-
3.
|
|
24
|
+
3. Then evaluate each remaining finding independently. Do not reject a finding because a related finding was rejected.
|
|
25
25
|
|
|
26
|
-
4. **
|
|
26
|
+
4. **Read the code before rating.** Before assigning severity, open the source at each finding's location and read enough surrounding code to judge reachability -- call sites, guards, and validation that live outside the diff hunk. Do not rate from the diff hunk alone. Severity reflects the real consequence at a real call site, not the worst theoretical reading.
|
|
27
|
+
|
|
28
|
+
5. **Assign severity** to each finding by consequence for the artifact's main consumer (software user, document reader, etc).
|
|
27
29
|
Disregard any severity assigned by a reviewing subagent. Review subagents operate under by-design information asymmetry and do not have enough context to set final severity for this workflow.
|
|
28
30
|
- `low` -- none or cosmetic
|
|
29
31
|
- `medium` -- tolerable
|
|
30
32
|
- `high` -- intolerable
|
|
31
33
|
|
|
32
|
-
|
|
34
|
+
6. **Route** each finding into exactly one triage bucket:
|
|
33
35
|
- **decision_needed** -- There is an ambiguous choice that requires human input. The code cannot be correctly patched without knowing the user's intent. Only possible if `{review_mode}` = `"full"`.
|
|
34
36
|
- **patch** -- Code issue that is fixable without human input. The correct fix is unambiguous.
|
|
35
37
|
- **defer** -- Pre-existing issue not caused by the current change. Real but not actionable now.
|
|
@@ -37,11 +39,11 @@
|
|
|
37
39
|
|
|
38
40
|
If `{review_mode}` = `"no-spec"` and a finding would otherwise be `decision_needed`, reclassify it as `patch` (if the fix is unambiguous) or `defer` (if not).
|
|
39
41
|
|
|
40
|
-
|
|
42
|
+
7. **Drop** all `dismiss` findings. Record the dismiss count for the summary.
|
|
41
43
|
|
|
42
|
-
|
|
44
|
+
8. If `{failed_layers}` is non-empty, report which layers failed before announcing results. If zero findings remain after dropping dismissed AND `{failed_layers}` is non-empty, warn the user that the review may be incomplete rather than announcing a clean review.
|
|
43
45
|
|
|
44
|
-
|
|
46
|
+
9. If zero findings remain after triage (all rejected or none raised): state "✅ Clean review — all layers passed." (Step 3 already warned if any review layers failed via `{failed_layers}`.)
|
|
45
47
|
|
|
46
48
|
|
|
47
49
|
## NEXT
|
|
@@ -12,7 +12,7 @@ deferred_work_file: '{implementation_artifacts}/deferred-work.md'
|
|
|
12
12
|
## INSTRUCTIONS
|
|
13
13
|
|
|
14
14
|
1. Draft resume check. If `{spec_file}` exists with `status: draft`, read it and capture the verbatim `<intent-contract>...</intent-contract>` block as `preserved_intent_contract`. Otherwise `preserved_intent_contract` is empty.
|
|
15
|
-
2. Investigate codebase.
|
|
15
|
+
2. Investigate codebase. _Read the code yourself for narrow, localized tasks. Isolate deep exploration in subagents: instruct them to give you distilled summaries only, and plan from those summaries._
|
|
16
16
|
3. Read `./spec-template.md` fully. Fill it out based on the intent and investigation. If `{preserved_intent_contract}` is non-empty, substitute it for the `<intent-contract>` block in your filled spec before writing. Write the result to `{spec_file}`.
|
|
17
17
|
4. Self-review against READY FOR DEVELOPMENT standard.
|
|
18
18
|
5. If intent gaps exist, do not fantasize and do not leave open questions. HALT with status `blocked`, blocking condition `intent gaps`, and include the unanswered questions and evidence gathered.
|
|
@@ -39,7 +39,7 @@ Launch Blind Hunter, Edge Case Hunter, and Verification Gap Reviewer in parallel
|
|
|
39
39
|
|
|
40
40
|
### Classify
|
|
41
41
|
|
|
42
|
-
1. Deduplicate
|
|
42
|
+
1. Deduplicate only findings with the same claim and same required action. Then evaluate each remaining finding independently. Do not reject a finding because a related finding was rejected.
|
|
43
43
|
2. Assign severity to each finding by consequence for the artifact's main consumer (software user, document reader, etc).
|
|
44
44
|
Disregard any severity assigned by a reviewing subagent. Review subagents operate under by-design information asymmetry and do not have enough context to set final severity for this workflow.
|
|
45
45
|
- `low`: none or cosmetic
|
|
@@ -38,7 +38,7 @@ Launch Blind Hunter, Edge Case Hunter, and Verification Gap Reviewer in parallel
|
|
|
38
38
|
|
|
39
39
|
### Classify
|
|
40
40
|
|
|
41
|
-
1. Deduplicate
|
|
41
|
+
1. Deduplicate only findings with the same claim and same required action. Then evaluate each remaining finding independently. Do not reject a finding because a related finding was rejected.
|
|
42
42
|
2. Assign severity to each finding by consequence for the artifact's main consumer (software user, document reader, etc).
|
|
43
43
|
Disregard any severity assigned by a reviewing subagent. Review subagents operate under by-design information asymmetry and do not have enough context to set final severity for this workflow.
|
|
44
44
|
- `low`: none or cosmetic
|