bmad-method 4.27.5 → 5.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.bmad-core/agent-teams/team-all.yml +16 -0
- package/.bmad-core/agent-teams/team-fullstack.yml +26 -0
- package/.bmad-core/agent-teams/team-no-ui.yml +15 -0
- package/{bmad-core → .bmad-core}/agents/analyst.md +23 -30
- package/.bmad-core/agents/architect.md +66 -0
- package/.bmad-core/agents/bmad-master.md +104 -0
- package/.bmad-core/agents/bmad-orchestrator.md +81 -0
- package/.bmad-core/agents/dev.md +70 -0
- package/{bmad-core → .bmad-core}/agents/pm.md +24 -25
- package/{bmad-core → .bmad-core}/agents/po.md +24 -28
- package/.bmad-core/agents/qa.md +52 -0
- package/.bmad-core/agents/sm.md +55 -0
- package/.bmad-core/agents/ux-expert.md +66 -0
- package/{bmad-core → .bmad-core}/checklists/change-checklist.md +2 -2
- package/{bmad-core → .bmad-core}/checklists/story-draft-checklist.md +1 -1
- package/.bmad-core/data/bmad-kb.md +47 -0
- package/.bmad-core/schemas/agent-team-schema.yml +153 -0
- package/.bmad-core/tasks/advanced-elicitation.md +92 -0
- package/.bmad-core/tasks/brainstorming-techniques.md +238 -0
- package/.bmad-core/tasks/core-dump.md +74 -0
- package/{expansion-packs/bmad-creator-tools → .bmad-core}/tasks/create-agent.md +11 -9
- package/.bmad-core/tasks/create-doc.md +74 -0
- package/.bmad-core/tasks/create-expansion-pack.md +425 -0
- package/.bmad-core/tasks/create-next-story.md +206 -0
- package/.bmad-core/tasks/create-team.md +229 -0
- package/{bmad-core → .bmad-core}/tasks/doc-migration-task.md +9 -9
- package/{common → .bmad-core}/tasks/execute-checklist.md +6 -2
- package/.bmad-core/tasks/generate-ai-frontend-prompt.md +58 -0
- package/{bmad-core → .bmad-core}/tasks/index-docs.md +7 -3
- package/{bmad-core → .bmad-core}/tasks/shard-doc.md +7 -25
- package/.bmad-core/templates/agent-tmpl.md +58 -0
- package/.bmad-core/templates/architecture-tmpl.md +771 -0
- package/.bmad-core/templates/brownfield-architecture-tmpl.md +542 -0
- package/.bmad-core/templates/brownfield-prd-tmpl.md +240 -0
- package/.bmad-core/templates/competitor-analysis-tmpl.md +289 -0
- package/.bmad-core/templates/expansion-pack-plan-tmpl.md +91 -0
- package/.bmad-core/templates/front-end-architecture-tmpl.md +173 -0
- package/.bmad-core/templates/front-end-spec-tmpl.md +411 -0
- package/.bmad-core/templates/fullstack-architecture-tmpl.md +1016 -0
- package/.bmad-core/templates/market-research-tmpl.md +261 -0
- package/.bmad-core/templates/prd-tmpl.md +200 -0
- package/.bmad-core/templates/project-brief-tmpl.md +228 -0
- package/.bmad-core/templates/simple-project-prd-tmpl.md +461 -0
- package/.bmad-core/templates/story-tmpl.md +61 -0
- package/.bmad-core/templates/web-agent-startup-instructions-template.md +39 -0
- package/.bmad-core/utils/agent-switcher.ide.md +112 -0
- package/.bmad-core/utils/template-format.md +26 -0
- package/.bmad-core/utils/workflow-management.md +224 -0
- package/.bmad-core/web-bundles/agents/analyst.txt +1684 -0
- package/.bmad-core/web-bundles/agents/architect.txt +3584 -0
- package/.bmad-core/web-bundles/agents/bmad-master.txt +9491 -0
- package/.bmad-core/web-bundles/agents/bmad-orchestrator.txt +1466 -0
- package/{dist → .bmad-core/web-bundles}/agents/dev.txt +71 -179
- package/{dist → .bmad-core/web-bundles}/agents/pm.txt +1058 -624
- package/{dist → .bmad-core/web-bundles}/agents/po.txt +138 -337
- package/.bmad-core/web-bundles/agents/qa.txt +129 -0
- package/.bmad-core/web-bundles/agents/sm.txt +658 -0
- package/.bmad-core/web-bundles/agents/ux-expert.txt +1099 -0
- package/.bmad-core/web-bundles/teams/team-all.txt +10757 -0
- package/.bmad-core/web-bundles/teams/team-fullstack.txt +10109 -0
- package/.bmad-core/web-bundles/teams/team-no-ui.txt +8950 -0
- package/.bmad-core/workflows/brownfield-fullstack.yml +116 -0
- package/.bmad-core/workflows/brownfield-service.yml +117 -0
- package/.bmad-core/workflows/brownfield-ui.yml +127 -0
- package/{bmad-core/workflows/greenfield-fullstack.yaml → .bmad-core/workflows/greenfield-fullstack.yml} +77 -140
- package/.bmad-core/workflows/greenfield-service.yml +143 -0
- package/.bmad-core/workflows/greenfield-ui.yml +172 -0
- package/.claude/commands/analyst.md +63 -0
- package/.claude/commands/architect.md +70 -0
- package/.claude/commands/bmad-master.md +108 -0
- package/.claude/commands/bmad-orchestrator.md +85 -0
- package/.claude/commands/dev.md +74 -0
- package/.claude/commands/pm.md +63 -0
- package/.claude/commands/po.md +64 -0
- package/.claude/commands/qa.md +56 -0
- package/.claude/commands/sm.md +59 -0
- package/.claude/commands/ux-expert.md +70 -0
- package/.cursor/rules/analyst.mdc +77 -0
- package/.cursor/rules/architect.mdc +84 -0
- package/.cursor/rules/bmad-master.mdc +122 -0
- package/.cursor/rules/bmad-orchestrator.mdc +99 -0
- package/.cursor/rules/dev.mdc +88 -0
- package/.cursor/rules/pm.mdc +77 -0
- package/.cursor/rules/po.mdc +78 -0
- package/.cursor/rules/qa.mdc +70 -0
- package/.cursor/rules/sm.mdc +73 -0
- package/.cursor/rules/ux-expert.mdc +84 -0
- package/.roo/.roomodes +95 -0
- package/.roo/README.md +38 -0
- package/.vscode/extensions.json +6 -0
- package/.vscode/settings.json +75 -49
- package/.windsurf/rules/analyst.md +71 -0
- package/.windsurf/rules/architect.md +78 -0
- package/.windsurf/rules/bmad-master.md +116 -0
- package/.windsurf/rules/bmad-orchestrator.md +93 -0
- package/.windsurf/rules/dev.md +82 -0
- package/.windsurf/rules/pm.md +71 -0
- package/.windsurf/rules/po.md +72 -0
- package/.windsurf/rules/qa.md +64 -0
- package/.windsurf/rules/sm.md +67 -0
- package/.windsurf/rules/ux-expert.md +78 -0
- package/CHANGELOG.md +16 -452
- package/CONTRIBUTING.md +5 -168
- package/LICENSE +1 -1
- package/README.md +230 -77
- package/docs/bmad-workflow-guide.md +15 -19
- package/docs/claude-code-guide.md +119 -0
- package/docs/cursor-guide.md +127 -0
- package/docs/roo-code-guide.md +140 -0
- package/docs/sample-output/simple-fullstack-greenfield/prd.md +42 -0
- package/docs/versioning-and-releases.md +16 -8
- package/docs/versions.md +5 -4
- package/docs/windsurf-guide.md +127 -0
- package/expansion-packs/README.md +112 -2
- package/expansion-packs/{bmad-infrastructure-devops → infrastructure-devops}/README.md +9 -9
- package/expansion-packs/{bmad-infrastructure-devops → infrastructure-devops}/agents/infra-devops-platform.md +15 -15
- package/expansion-packs/{bmad-infrastructure-devops → infrastructure-devops}/checklists/infrastructure-checklist.md +1 -1
- package/expansion-packs/infrastructure-devops/manifest.yml +38 -0
- package/expansion-packs/{bmad-infrastructure-devops → infrastructure-devops}/tasks/review-infrastructure.md +4 -4
- package/expansion-packs/{bmad-infrastructure-devops → infrastructure-devops}/tasks/validate-infrastructure.md +4 -4
- package/expansion-packs/infrastructure-devops/templates/infrastructure-architecture-tmpl.md +415 -0
- package/expansion-packs/infrastructure-devops/templates/infrastructure-platform-from-arch-tmpl.md +0 -0
- package/package.json +11 -19
- package/tools/bmad-npx-wrapper.js +1 -1
- package/tools/builders/web-builder.js +28 -563
- package/tools/cli.js +22 -55
- package/tools/installer/README.md +53 -3
- package/tools/installer/bin/bmad.js +56 -294
- package/tools/installer/config/install.config.yml +139 -0
- package/tools/installer/lib/config-loader.js +34 -198
- package/tools/installer/lib/file-manager.js +5 -123
- package/tools/installer/lib/ide-setup.js +189 -545
- package/tools/installer/lib/installer.js +55 -1136
- package/tools/installer/package-lock.json +3 -3
- package/tools/installer/package.json +4 -4
- package/tools/installer/templates/claude-commands.md +7 -0
- package/tools/installer/templates/cursor-rules.md +22 -0
- package/tools/installer/templates/windsurf-rules.md +22 -0
- package/tools/lib/dependency-resolver.js +22 -22
- package/tools/upgraders/v3-to-v4-upgrader.js +43 -35
- package/tools/version-bump.js +1 -1
- package/tools/yaml-format.js +2 -2
- package/.github/FUNDING.yaml +0 -15
- package/.github/ISSUE_TEMPLATE/bug_report.md +0 -32
- package/.github/ISSUE_TEMPLATE/feature_request.md +0 -22
- package/.prettierignore +0 -21
- package/.prettierrc +0 -23
- package/bmad-core/agent-teams/team-all.yaml +0 -14
- package/bmad-core/agent-teams/team-fullstack.yaml +0 -18
- package/bmad-core/agent-teams/team-ide-minimal.yaml +0 -10
- package/bmad-core/agent-teams/team-no-ui.yaml +0 -13
- package/bmad-core/agents/architect.md +0 -63
- package/bmad-core/agents/bmad-master.md +0 -110
- package/bmad-core/agents/bmad-orchestrator.md +0 -140
- package/bmad-core/agents/dev.md +0 -57
- package/bmad-core/agents/qa.md +0 -55
- package/bmad-core/agents/sm.md +0 -46
- package/bmad-core/agents/ux-expert.md +0 -54
- package/bmad-core/core-config.yaml +0 -25
- package/bmad-core/data/bmad-kb.md +0 -803
- package/bmad-core/data/brainstorming-techniques.md +0 -36
- package/bmad-core/data/elicitation-methods.md +0 -134
- package/bmad-core/tasks/advanced-elicitation.md +0 -117
- package/bmad-core/tasks/create-brownfield-story.md +0 -355
- package/bmad-core/tasks/create-next-story.md +0 -114
- package/bmad-core/tasks/create-workflow-plan.md +0 -289
- package/bmad-core/tasks/document-project.md +0 -317
- package/bmad-core/tasks/facilitate-brainstorming-session.md +0 -136
- package/bmad-core/tasks/generate-ai-frontend-prompt.md +0 -51
- package/bmad-core/tasks/kb-mode-interaction.md +0 -70
- package/bmad-core/tasks/review-story.md +0 -145
- package/bmad-core/tasks/update-workflow-plan.md +0 -248
- package/bmad-core/tasks/validate-next-story.md +0 -134
- package/bmad-core/templates/architecture-tmpl.yaml +0 -650
- package/bmad-core/templates/brainstorming-output-tmpl.yaml +0 -156
- package/bmad-core/templates/brownfield-architecture-tmpl.yaml +0 -476
- package/bmad-core/templates/brownfield-prd-tmpl.yaml +0 -280
- package/bmad-core/templates/competitor-analysis-tmpl.yaml +0 -293
- package/bmad-core/templates/front-end-architecture-tmpl.yaml +0 -206
- package/bmad-core/templates/front-end-spec-tmpl.yaml +0 -349
- package/bmad-core/templates/fullstack-architecture-tmpl.yaml +0 -805
- package/bmad-core/templates/market-research-tmpl.yaml +0 -252
- package/bmad-core/templates/prd-tmpl.yaml +0 -202
- package/bmad-core/templates/project-brief-tmpl.yaml +0 -221
- package/bmad-core/templates/story-tmpl.yaml +0 -137
- package/bmad-core/utils/plan-management.md +0 -219
- package/bmad-core/workflows/brownfield-fullstack.yaml +0 -297
- package/bmad-core/workflows/brownfield-service.yaml +0 -187
- package/bmad-core/workflows/brownfield-ui.yaml +0 -197
- package/bmad-core/workflows/greenfield-service.yaml +0 -206
- package/bmad-core/workflows/greenfield-ui.yaml +0 -235
- package/common/tasks/create-doc.md +0 -79
- package/common/utils/bmad-doc-template.md +0 -325
- package/common/utils/workflow-management.md +0 -69
- package/dist/agents/analyst.txt +0 -2849
- package/dist/agents/architect.txt +0 -3505
- package/dist/agents/bmad-master.txt +0 -9588
- package/dist/agents/bmad-orchestrator.txt +0 -2232
- package/dist/agents/qa.txt +0 -388
- package/dist/agents/sm.txt +0 -673
- package/dist/agents/ux-expert.txt +0 -987
- package/dist/expansion-packs/bmad-2d-phaser-game-dev/agents/game-designer.txt +0 -2401
- package/dist/expansion-packs/bmad-2d-phaser-game-dev/agents/game-developer.txt +0 -1635
- package/dist/expansion-packs/bmad-2d-phaser-game-dev/agents/game-sm.txt +0 -825
- package/dist/expansion-packs/bmad-2d-phaser-game-dev/teams/phaser-2d-nodejs-game-team.txt +0 -11730
- package/dist/expansion-packs/bmad-creator-tools/agents/bmad-the-creator.txt +0 -2023
- package/dist/expansion-packs/bmad-infrastructure-devops/agents/infra-devops-platform.txt +0 -2052
- package/dist/teams/team-all.txt +0 -11799
- package/dist/teams/team-fullstack.txt +0 -11129
- package/dist/teams/team-ide-minimal.txt +0 -4573
- package/dist/teams/team-no-ui.txt +0 -9684
- package/docs/GUIDING-PRINCIPLES.md +0 -91
- package/docs/agentic-tools/claude-code-guide.md +0 -19
- package/docs/agentic-tools/cline-guide.md +0 -16
- package/docs/agentic-tools/cursor-guide.md +0 -14
- package/docs/agentic-tools/gemini-cli-guide.md +0 -32
- package/docs/agentic-tools/github-copilot-guide.md +0 -42
- package/docs/agentic-tools/roo-code-guide.md +0 -15
- package/docs/agentic-tools/trae-guide.md +0 -14
- package/docs/agentic-tools/windsurf-guide.md +0 -14
- package/docs/core-architecture.md +0 -219
- package/docs/expansion-packs.md +0 -280
- package/docs/how-to-contribute-with-pull-requests.md +0 -158
- package/docs/template-markup-references.md +0 -86
- package/docs/user-guide.md +0 -1142
- package/docs/working-in-the-brownfield.md +0 -361
- package/expansion-packs/bmad-2d-phaser-game-dev/agent-teams/phaser-2d-nodejs-game-team.yaml +0 -13
- package/expansion-packs/bmad-2d-phaser-game-dev/agents/game-designer.md +0 -60
- package/expansion-packs/bmad-2d-phaser-game-dev/agents/game-developer.md +0 -68
- package/expansion-packs/bmad-2d-phaser-game-dev/agents/game-sm.md +0 -53
- package/expansion-packs/bmad-2d-phaser-game-dev/checklists/game-design-checklist.md +0 -201
- package/expansion-packs/bmad-2d-phaser-game-dev/checklists/game-story-dod-checklist.md +0 -160
- package/expansion-packs/bmad-2d-phaser-game-dev/config.yaml +0 -7
- package/expansion-packs/bmad-2d-phaser-game-dev/data/bmad-kb.md +0 -254
- package/expansion-packs/bmad-2d-phaser-game-dev/data/development-guidelines.md +0 -651
- package/expansion-packs/bmad-2d-phaser-game-dev/tasks/advanced-elicitation.md +0 -111
- package/expansion-packs/bmad-2d-phaser-game-dev/tasks/create-game-story.md +0 -216
- package/expansion-packs/bmad-2d-phaser-game-dev/tasks/game-design-brainstorming.md +0 -308
- package/expansion-packs/bmad-2d-phaser-game-dev/templates/game-architecture-tmpl.yaml +0 -613
- package/expansion-packs/bmad-2d-phaser-game-dev/templates/game-brief-tmpl.yaml +0 -356
- package/expansion-packs/bmad-2d-phaser-game-dev/templates/game-design-doc-tmpl.yaml +0 -343
- package/expansion-packs/bmad-2d-phaser-game-dev/templates/game-story-tmpl.yaml +0 -253
- package/expansion-packs/bmad-2d-phaser-game-dev/templates/level-design-doc-tmpl.yaml +0 -484
- package/expansion-packs/bmad-2d-phaser-game-dev/workflows/game-dev-greenfield.yaml +0 -183
- package/expansion-packs/bmad-2d-phaser-game-dev/workflows/game-prototype.yaml +0 -175
- package/expansion-packs/bmad-creator-tools/README.md +0 -8
- package/expansion-packs/bmad-creator-tools/agents/bmad-the-creator.md +0 -55
- package/expansion-packs/bmad-creator-tools/config.yaml +0 -5
- package/expansion-packs/bmad-creator-tools/tasks/generate-expansion-pack.md +0 -1020
- package/expansion-packs/bmad-creator-tools/templates/agent-teams-tmpl.yaml +0 -178
- package/expansion-packs/bmad-creator-tools/templates/agent-tmpl.yaml +0 -154
- package/expansion-packs/bmad-creator-tools/templates/expansion-pack-plan-tmpl.yaml +0 -120
- package/expansion-packs/bmad-infrastructure-devops/config.yaml +0 -8
- package/expansion-packs/bmad-infrastructure-devops/data/bmad-kb.md +0 -308
- package/expansion-packs/bmad-infrastructure-devops/templates/infrastructure-architecture-tmpl.yaml +0 -424
- package/expansion-packs/bmad-infrastructure-devops/templates/infrastructure-platform-from-arch-tmpl.yaml +0 -629
- package/tools/bump-all-versions.js +0 -107
- package/tools/bump-core-version.js +0 -57
- package/tools/bump-expansion-version.js +0 -78
- package/tools/installer/config/ide-agent-config.yaml +0 -58
- package/tools/installer/config/install.config.yaml +0 -91
- package/tools/lib/yaml-utils.js +0 -29
- package/tools/md-assets/web-agent-startup-instructions.md +0 -39
- package/tools/update-expansion-version.js +0 -54
- /package/{bmad-core → .bmad-core}/checklists/architect-checklist.md +0 -0
- /package/{bmad-core → .bmad-core}/checklists/pm-checklist.md +0 -0
- /package/{bmad-core → .bmad-core}/checklists/po-master-checklist.md +0 -0
- /package/{bmad-core → .bmad-core}/checklists/story-dod-checklist.md +0 -0
- /package/{bmad-core → .bmad-core}/data/technical-preferences.md +0 -0
- /package/{bmad-core → .bmad-core}/tasks/brownfield-create-epic.md +0 -0
- /package/{bmad-core → .bmad-core}/tasks/brownfield-create-story.md +0 -0
- /package/{bmad-core → .bmad-core}/tasks/correct-course.md +0 -0
- /package/{bmad-core → .bmad-core}/tasks/create-deep-research-prompt.md +0 -0
- /package/.github/workflows/{release.yaml → release.yml} +0 -0
|
@@ -1,145 +0,0 @@
|
|
|
1
|
-
# review-story
|
|
2
|
-
|
|
3
|
-
When a developer marks a story as "Ready for Review", perform a comprehensive senior developer code review with the ability to refactor and improve code directly.
|
|
4
|
-
|
|
5
|
-
[[LLM: QA Agent executing review-story task as Senior Developer]]
|
|
6
|
-
|
|
7
|
-
## Prerequisites
|
|
8
|
-
|
|
9
|
-
- Story status must be "Review"
|
|
10
|
-
- Developer has completed all tasks and updated the File List
|
|
11
|
-
- All automated tests are passing
|
|
12
|
-
|
|
13
|
-
## Review Process
|
|
14
|
-
|
|
15
|
-
1. **Read the Complete Story**
|
|
16
|
-
- Review all acceptance criteria
|
|
17
|
-
- Understand the dev notes and requirements
|
|
18
|
-
- Note any completion notes from the developer
|
|
19
|
-
|
|
20
|
-
2. **Verify Implementation Against Dev Notes Guidance**
|
|
21
|
-
- Review the "Dev Notes" section for specific technical guidance provided to the developer
|
|
22
|
-
- Verify the developer's implementation follows the architectural patterns specified in Dev Notes
|
|
23
|
-
- Check that file locations match the project structure guidance in Dev Notes
|
|
24
|
-
- Confirm any specified libraries, frameworks, or technical approaches were used correctly
|
|
25
|
-
- Validate that security considerations mentioned in Dev Notes were implemented
|
|
26
|
-
|
|
27
|
-
3. **Focus on the File List**
|
|
28
|
-
- Verify all files listed were actually created/modified
|
|
29
|
-
- Check for any missing files that should have been updated
|
|
30
|
-
- Ensure file locations align with the project structure guidance from Dev Notes
|
|
31
|
-
|
|
32
|
-
4. **Senior Developer Code Review**
|
|
33
|
-
- Review code with the eye of a senior developer
|
|
34
|
-
- If changes form a cohesive whole, review them together
|
|
35
|
-
- If changes are independent, review incrementally file by file
|
|
36
|
-
- Focus on:
|
|
37
|
-
- Code architecture and design patterns
|
|
38
|
-
- Refactoring opportunities
|
|
39
|
-
- Code duplication or inefficiencies
|
|
40
|
-
- Performance optimizations
|
|
41
|
-
- Security concerns
|
|
42
|
-
- Best practices and patterns
|
|
43
|
-
|
|
44
|
-
5. **Active Refactoring**
|
|
45
|
-
- As a senior developer, you CAN and SHOULD refactor code where improvements are needed
|
|
46
|
-
- When refactoring:
|
|
47
|
-
- Make the changes directly in the files
|
|
48
|
-
- Explain WHY you're making the change
|
|
49
|
-
- Describe HOW the change improves the code
|
|
50
|
-
- Ensure all tests still pass after refactoring
|
|
51
|
-
- Update the File List if you modify additional files
|
|
52
|
-
|
|
53
|
-
6. **Standards Compliance Check**
|
|
54
|
-
- Verify adherence to `docs/coding-standards.md`
|
|
55
|
-
- Check compliance with `docs/unified-project-structure.md`
|
|
56
|
-
- Validate testing approach against `docs/testing-strategy.md`
|
|
57
|
-
- Ensure all guidelines mentioned in the story are followed
|
|
58
|
-
|
|
59
|
-
7. **Acceptance Criteria Validation**
|
|
60
|
-
- Verify each AC is fully implemented
|
|
61
|
-
- Check for any missing functionality
|
|
62
|
-
- Validate edge cases are handled
|
|
63
|
-
|
|
64
|
-
8. **Test Coverage Review**
|
|
65
|
-
- Ensure unit tests cover edge cases
|
|
66
|
-
- Add missing tests if critical coverage is lacking
|
|
67
|
-
- Verify integration tests (if required) are comprehensive
|
|
68
|
-
- Check that test assertions are meaningful
|
|
69
|
-
- Look for missing test scenarios
|
|
70
|
-
|
|
71
|
-
9. **Documentation and Comments**
|
|
72
|
-
- Verify code is self-documenting where possible
|
|
73
|
-
- Add comments for complex logic if missing
|
|
74
|
-
- Ensure any API changes are documented
|
|
75
|
-
|
|
76
|
-
## Update Story File - QA Results Section ONLY
|
|
77
|
-
|
|
78
|
-
**CRITICAL**: You are ONLY authorized to update the "QA Results" section of the story file. DO NOT modify any other sections.
|
|
79
|
-
|
|
80
|
-
After review and any refactoring, append your results to the story file in the QA Results section:
|
|
81
|
-
|
|
82
|
-
```markdown
|
|
83
|
-
## QA Results
|
|
84
|
-
|
|
85
|
-
### Review Date: [Date]
|
|
86
|
-
### Reviewed By: Quinn (Senior Developer QA)
|
|
87
|
-
|
|
88
|
-
### Code Quality Assessment
|
|
89
|
-
[Overall assessment of implementation quality]
|
|
90
|
-
|
|
91
|
-
### Refactoring Performed
|
|
92
|
-
[List any refactoring you performed with explanations]
|
|
93
|
-
- **File**: [filename]
|
|
94
|
-
- **Change**: [what was changed]
|
|
95
|
-
- **Why**: [reason for change]
|
|
96
|
-
- **How**: [how it improves the code]
|
|
97
|
-
|
|
98
|
-
### Compliance Check
|
|
99
|
-
- Coding Standards: [✓/✗] [notes if any]
|
|
100
|
-
- Project Structure: [✓/✗] [notes if any]
|
|
101
|
-
- Testing Strategy: [✓/✗] [notes if any]
|
|
102
|
-
- All ACs Met: [✓/✗] [notes if any]
|
|
103
|
-
|
|
104
|
-
### Improvements Checklist
|
|
105
|
-
[Check off items you handled yourself, leave unchecked for dev to address]
|
|
106
|
-
|
|
107
|
-
- [x] Refactored user service for better error handling (services/user.service.ts)
|
|
108
|
-
- [x] Added missing edge case tests (services/user.service.test.ts)
|
|
109
|
-
- [ ] Consider extracting validation logic to separate validator class
|
|
110
|
-
- [ ] Add integration test for error scenarios
|
|
111
|
-
- [ ] Update API documentation for new error codes
|
|
112
|
-
|
|
113
|
-
### Security Review
|
|
114
|
-
[Any security concerns found and whether addressed]
|
|
115
|
-
|
|
116
|
-
### Performance Considerations
|
|
117
|
-
[Any performance issues found and whether addressed]
|
|
118
|
-
|
|
119
|
-
### Final Status
|
|
120
|
-
[✓ Approved - Ready for Done] / [✗ Changes Required - See unchecked items above]
|
|
121
|
-
```
|
|
122
|
-
|
|
123
|
-
## Key Principles
|
|
124
|
-
|
|
125
|
-
- You are a SENIOR developer reviewing junior/mid-level work
|
|
126
|
-
- You have the authority and responsibility to improve code directly
|
|
127
|
-
- Always explain your changes for learning purposes
|
|
128
|
-
- Balance between perfection and pragmatism
|
|
129
|
-
- Focus on significant improvements, not nitpicks
|
|
130
|
-
|
|
131
|
-
## Blocking Conditions
|
|
132
|
-
|
|
133
|
-
Stop the review and request clarification if:
|
|
134
|
-
- Story file is incomplete or missing critical sections
|
|
135
|
-
- File List is empty or clearly incomplete
|
|
136
|
-
- No tests exist when they were required
|
|
137
|
-
- Code changes don't align with story requirements
|
|
138
|
-
- Critical architectural issues that require discussion
|
|
139
|
-
|
|
140
|
-
## Completion
|
|
141
|
-
|
|
142
|
-
After review:
|
|
143
|
-
1. If all items are checked and approved: Update story status to "Done"
|
|
144
|
-
2. If unchecked items remain: Keep status as "Review" for dev to address
|
|
145
|
-
3. Always provide constructive feedback and explanations for learning
|
|
@@ -1,248 +0,0 @@
|
|
|
1
|
-
# Update Workflow Plan Task
|
|
2
|
-
|
|
3
|
-
## Purpose
|
|
4
|
-
|
|
5
|
-
Update the status of steps in an active workflow plan, mark completions, add notes about deviations, and maintain an accurate record of workflow progress. This task can be called directly by users or automatically by other tasks upon completion.
|
|
6
|
-
|
|
7
|
-
## Task Instructions
|
|
8
|
-
|
|
9
|
-
### 0. Load Plan Configuration
|
|
10
|
-
|
|
11
|
-
[[LLM: First load core-config.yaml to get plan settings]]
|
|
12
|
-
|
|
13
|
-
Check workflow configuration:
|
|
14
|
-
|
|
15
|
-
- `workflow.planFile` - Location of the plan (default: docs/workflow-plan.md)
|
|
16
|
-
- `workflow.trackProgress` - Whether tracking is enabled
|
|
17
|
-
- `workflow.updateOnCompletion` - Whether to auto-update on task completion
|
|
18
|
-
|
|
19
|
-
If tracking is disabled, inform user and exit.
|
|
20
|
-
|
|
21
|
-
### 1. Verify Plan Exists
|
|
22
|
-
|
|
23
|
-
[[LLM: Check if workflow plan exists at configured location]]
|
|
24
|
-
|
|
25
|
-
If no plan exists:
|
|
26
|
-
|
|
27
|
-
```
|
|
28
|
-
No active workflow plan found at {location}.
|
|
29
|
-
Would you like to create one? Use *plan command.
|
|
30
|
-
```
|
|
31
|
-
|
|
32
|
-
### 2. Determine Update Type
|
|
33
|
-
|
|
34
|
-
[[LLM: Ask user what type of update they want to make]]
|
|
35
|
-
|
|
36
|
-
Present options:
|
|
37
|
-
|
|
38
|
-
```
|
|
39
|
-
What would you like to update in the workflow plan?
|
|
40
|
-
|
|
41
|
-
1. Mark step as complete
|
|
42
|
-
2. Update current step
|
|
43
|
-
3. Add deviation note
|
|
44
|
-
4. Mark decision point resolution
|
|
45
|
-
5. Update overall status
|
|
46
|
-
6. View current plan status only
|
|
47
|
-
|
|
48
|
-
Please select an option (1-6):
|
|
49
|
-
```
|
|
50
|
-
|
|
51
|
-
### 3. Parse Current Plan
|
|
52
|
-
|
|
53
|
-
[[LLM: Read and parse the plan to understand current state]]
|
|
54
|
-
|
|
55
|
-
Extract:
|
|
56
|
-
|
|
57
|
-
- All steps with their checkbox status
|
|
58
|
-
- Step IDs from comments (if present)
|
|
59
|
-
- Current completion percentage
|
|
60
|
-
- Any existing deviation notes
|
|
61
|
-
- Decision points and their status
|
|
62
|
-
|
|
63
|
-
### 4. Execute Updates
|
|
64
|
-
|
|
65
|
-
#### 4.1 Mark Step Complete
|
|
66
|
-
|
|
67
|
-
If user selected option 1:
|
|
68
|
-
|
|
69
|
-
1. Show numbered list of incomplete steps
|
|
70
|
-
2. Ask which step to mark complete
|
|
71
|
-
3. Update the checkbox from `[ ]` to `[x]`
|
|
72
|
-
4. Add completion timestamp: `<!-- completed: YYYY-MM-DD HH:MM -->`
|
|
73
|
-
5. If this was the current step, identify next step
|
|
74
|
-
|
|
75
|
-
#### 4.2 Update Current Step
|
|
76
|
-
|
|
77
|
-
If user selected option 2:
|
|
78
|
-
|
|
79
|
-
1. Show all steps with current status
|
|
80
|
-
2. Ask which step is now current
|
|
81
|
-
3. Add/move `<!-- current-step -->` marker
|
|
82
|
-
4. Optionally add note about why sequence changed
|
|
83
|
-
|
|
84
|
-
#### 4.3 Add Deviation Note
|
|
85
|
-
|
|
86
|
-
If user selected option 3:
|
|
87
|
-
|
|
88
|
-
1. Ask for deviation description
|
|
89
|
-
2. Ask which step this relates to (or general)
|
|
90
|
-
3. Insert note in appropriate location:
|
|
91
|
-
|
|
92
|
-
```markdown
|
|
93
|
-
> **Deviation Note** (YYYY-MM-DD): {user_note}
|
|
94
|
-
> Related to: Step X.Y or General workflow
|
|
95
|
-
```
|
|
96
|
-
|
|
97
|
-
#### 4.4 Mark Decision Resolution
|
|
98
|
-
|
|
99
|
-
If user selected option 4:
|
|
100
|
-
|
|
101
|
-
1. Show pending decision points
|
|
102
|
-
2. Ask which decision was made
|
|
103
|
-
3. Record the decision and chosen path
|
|
104
|
-
4. Update related steps based on decision
|
|
105
|
-
|
|
106
|
-
#### 4.5 Update Overall Status
|
|
107
|
-
|
|
108
|
-
If user selected option 5:
|
|
109
|
-
|
|
110
|
-
1. Show current overall status
|
|
111
|
-
2. Provide options:
|
|
112
|
-
- Active (continuing with plan)
|
|
113
|
-
- Paused (temporarily stopped)
|
|
114
|
-
- Abandoned (no longer following)
|
|
115
|
-
- Complete (all steps done)
|
|
116
|
-
3. Update plan header with new status
|
|
117
|
-
|
|
118
|
-
### 5. Automatic Updates (When Called by Tasks)
|
|
119
|
-
|
|
120
|
-
[[LLM: When called automatically by another task]]
|
|
121
|
-
|
|
122
|
-
If called with parameters:
|
|
123
|
-
|
|
124
|
-
```
|
|
125
|
-
task: {task_name}
|
|
126
|
-
step_id: {step_identifier}
|
|
127
|
-
status: complete|skipped|failed
|
|
128
|
-
note: {optional_note}
|
|
129
|
-
```
|
|
130
|
-
|
|
131
|
-
Automatically:
|
|
132
|
-
|
|
133
|
-
1. Find the corresponding step
|
|
134
|
-
2. Update its status
|
|
135
|
-
3. Add completion metadata
|
|
136
|
-
4. Add note if provided
|
|
137
|
-
5. Calculate new progress percentage
|
|
138
|
-
|
|
139
|
-
### 6. Generate Update Summary
|
|
140
|
-
|
|
141
|
-
After updates, show summary:
|
|
142
|
-
|
|
143
|
-
```
|
|
144
|
-
✅ Workflow Plan Updated
|
|
145
|
-
|
|
146
|
-
Changes made:
|
|
147
|
-
- {change_1}
|
|
148
|
-
- {change_2}
|
|
149
|
-
|
|
150
|
-
New Status:
|
|
151
|
-
- Progress: {X}% complete ({completed}/{total} steps)
|
|
152
|
-
- Current Step: {current_step}
|
|
153
|
-
- Next Recommended: {next_step}
|
|
154
|
-
|
|
155
|
-
Plan location: {file_path}
|
|
156
|
-
```
|
|
157
|
-
|
|
158
|
-
### 7. Integration with Other Tasks
|
|
159
|
-
|
|
160
|
-
[[LLM: How other tasks should call this]]
|
|
161
|
-
|
|
162
|
-
Other tasks can integrate by:
|
|
163
|
-
|
|
164
|
-
1. **After Task Completion**:
|
|
165
|
-
|
|
166
|
-
```
|
|
167
|
-
At end of task execution:
|
|
168
|
-
- Check if task corresponds to a plan step
|
|
169
|
-
- If yes, call update-workflow-plan with:
|
|
170
|
-
- task: {current_task_name}
|
|
171
|
-
- step_id: {matching_step}
|
|
172
|
-
- status: complete
|
|
173
|
-
```
|
|
174
|
-
|
|
175
|
-
2. **On Task Failure**:
|
|
176
|
-
|
|
177
|
-
```
|
|
178
|
-
If task fails:
|
|
179
|
-
- Call update-workflow-plan with:
|
|
180
|
-
- task: {current_task_name}
|
|
181
|
-
- status: failed
|
|
182
|
-
- note: {failure_reason}
|
|
183
|
-
```
|
|
184
|
-
|
|
185
|
-
### 8. Plan Status Display
|
|
186
|
-
|
|
187
|
-
[[LLM: When user selects view status only]]
|
|
188
|
-
|
|
189
|
-
Display comprehensive status:
|
|
190
|
-
|
|
191
|
-
```markdown
|
|
192
|
-
📋 Workflow Plan Status
|
|
193
|
-
━━━━━━━━━━━━━━━━━━━━
|
|
194
|
-
Workflow: {workflow_name}
|
|
195
|
-
Status: {Active|Paused|Complete}
|
|
196
|
-
Progress: {X}% complete ({completed}/{total} steps)
|
|
197
|
-
Last Updated: {timestamp}
|
|
198
|
-
|
|
199
|
-
✅ Completed Steps:
|
|
200
|
-
- [x] Step 1.1: {description} (completed: {date})
|
|
201
|
-
- [x] Step 1.2: {description} (completed: {date})
|
|
202
|
-
|
|
203
|
-
🔄 Current Step:
|
|
204
|
-
- [ ] Step 2.1: {description} <!-- current-step -->
|
|
205
|
-
Agent: {agent_name}
|
|
206
|
-
Task: {task_name}
|
|
207
|
-
|
|
208
|
-
📌 Upcoming Steps:
|
|
209
|
-
- [ ] Step 2.2: {description}
|
|
210
|
-
- [ ] Step 3.1: {description}
|
|
211
|
-
|
|
212
|
-
⚠️ Deviations/Notes:
|
|
213
|
-
{any_deviation_notes}
|
|
214
|
-
|
|
215
|
-
📊 Decision Points:
|
|
216
|
-
- Decision 1: {status} - {choice_made}
|
|
217
|
-
- Decision 2: Pending
|
|
218
|
-
|
|
219
|
-
💡 Next Action:
|
|
220
|
-
Based on the plan, you should {recommended_action}
|
|
221
|
-
```
|
|
222
|
-
|
|
223
|
-
## Success Criteria
|
|
224
|
-
|
|
225
|
-
The update is successful when:
|
|
226
|
-
|
|
227
|
-
1. Plan accurately reflects current workflow state
|
|
228
|
-
2. All updates are clearly timestamped
|
|
229
|
-
3. Deviations are documented with reasons
|
|
230
|
-
4. Progress calculation is correct
|
|
231
|
-
5. Next steps are clear to user
|
|
232
|
-
6. Plan remains readable and well-formatted
|
|
233
|
-
|
|
234
|
-
## Error Handling
|
|
235
|
-
|
|
236
|
-
- **Plan file not found**: Offer to create new plan
|
|
237
|
-
- **Malformed plan**: Attempt basic updates, warn user
|
|
238
|
-
- **Write permission error**: Show changes that would be made
|
|
239
|
-
- **Step not found**: Show available steps, ask for clarification
|
|
240
|
-
- **Concurrent updates**: Implement simple locking or warn about conflicts
|
|
241
|
-
|
|
242
|
-
## Notes
|
|
243
|
-
|
|
244
|
-
- Always preserve plan history (don't delete old information)
|
|
245
|
-
- Keep updates atomic to prevent corruption
|
|
246
|
-
- Consider creating backup before major updates
|
|
247
|
-
- Updates should enhance, not complicate, the workflow experience
|
|
248
|
-
- If plan becomes too cluttered, suggest creating fresh plan for next phase
|
|
@@ -1,134 +0,0 @@
|
|
|
1
|
-
# Validate Next Story Task
|
|
2
|
-
|
|
3
|
-
## Purpose
|
|
4
|
-
|
|
5
|
-
To comprehensively validate a story draft before implementation begins, ensuring it is complete, accurate, and provides sufficient context for successful development. This task identifies issues and gaps that need to be addressed, preventing hallucinations and ensuring implementation readiness.
|
|
6
|
-
|
|
7
|
-
## SEQUENTIAL Task Execution (Do not proceed until current Task is complete)
|
|
8
|
-
|
|
9
|
-
### 0. Load Core Configuration and Inputs
|
|
10
|
-
|
|
11
|
-
- Load `.bmad-core/core-config.yaml` from the project root
|
|
12
|
-
- If the file does not exist, HALT and inform the user: "core-config.yaml not found. This file is required for story validation."
|
|
13
|
-
- Extract key configurations: `devStoryLocation`, `prd.*`, `architecture.*`
|
|
14
|
-
- Identify and load the following inputs:
|
|
15
|
-
- **Story file**: The drafted story to validate (provided by user or discovered in `devStoryLocation`)
|
|
16
|
-
- **Parent epic**: The epic containing this story's requirements
|
|
17
|
-
- **Architecture documents**: Based on configuration (sharded or monolithic)
|
|
18
|
-
- **Story template**: `bmad-core/templates/story-tmpl.md` for completeness validation
|
|
19
|
-
|
|
20
|
-
### 1. Template Completeness Validation
|
|
21
|
-
|
|
22
|
-
- Load `bmad-core/templates/story-tmpl.md` and extract all section headings from the template
|
|
23
|
-
- **Missing sections check**: Compare story sections against template sections to verify all required sections are present
|
|
24
|
-
- **Placeholder validation**: Ensure no template placeholders remain unfilled (e.g., `{{EpicNum}}`, `{{role}}`, `_TBD_`)
|
|
25
|
-
- **Agent section verification**: Confirm all sections from template exist for future agent use
|
|
26
|
-
- **Structure compliance**: Verify story follows template structure and formatting
|
|
27
|
-
|
|
28
|
-
### 2. File Structure and Source Tree Validation
|
|
29
|
-
|
|
30
|
-
- **File paths clarity**: Are new/existing files to be created/modified clearly specified?
|
|
31
|
-
- **Source tree relevance**: Is relevant project structure included in Dev Notes?
|
|
32
|
-
- **Directory structure**: Are new directories/components properly located according to project structure?
|
|
33
|
-
- **File creation sequence**: Do tasks specify where files should be created in logical order?
|
|
34
|
-
- **Path accuracy**: Are file paths consistent with project structure from architecture docs?
|
|
35
|
-
|
|
36
|
-
### 3. UI/Frontend Completeness Validation (if applicable)
|
|
37
|
-
|
|
38
|
-
- **Component specifications**: Are UI components sufficiently detailed for implementation?
|
|
39
|
-
- **Styling/design guidance**: Is visual implementation guidance clear?
|
|
40
|
-
- **User interaction flows**: Are UX patterns and behaviors specified?
|
|
41
|
-
- **Responsive/accessibility**: Are these considerations addressed if required?
|
|
42
|
-
- **Integration points**: Are frontend-backend integration points clear?
|
|
43
|
-
|
|
44
|
-
### 4. Acceptance Criteria Satisfaction Assessment
|
|
45
|
-
|
|
46
|
-
- **AC coverage**: Will all acceptance criteria be satisfied by the listed tasks?
|
|
47
|
-
- **AC testability**: Are acceptance criteria measurable and verifiable?
|
|
48
|
-
- **Missing scenarios**: Are edge cases or error conditions covered?
|
|
49
|
-
- **Success definition**: Is "done" clearly defined for each AC?
|
|
50
|
-
- **Task-AC mapping**: Are tasks properly linked to specific acceptance criteria?
|
|
51
|
-
|
|
52
|
-
### 5. Validation and Testing Instructions Review
|
|
53
|
-
|
|
54
|
-
- **Test approach clarity**: Are testing methods clearly specified?
|
|
55
|
-
- **Test scenarios**: Are key test cases identified?
|
|
56
|
-
- **Validation steps**: Are acceptance criteria validation steps clear?
|
|
57
|
-
- **Testing tools/frameworks**: Are required testing tools specified?
|
|
58
|
-
- **Test data requirements**: Are test data needs identified?
|
|
59
|
-
|
|
60
|
-
### 6. Security Considerations Assessment (if applicable)
|
|
61
|
-
|
|
62
|
-
- **Security requirements**: Are security needs identified and addressed?
|
|
63
|
-
- **Authentication/authorization**: Are access controls specified?
|
|
64
|
-
- **Data protection**: Are sensitive data handling requirements clear?
|
|
65
|
-
- **Vulnerability prevention**: Are common security issues addressed?
|
|
66
|
-
- **Compliance requirements**: Are regulatory/compliance needs addressed?
|
|
67
|
-
|
|
68
|
-
### 7. Tasks/Subtasks Sequence Validation
|
|
69
|
-
|
|
70
|
-
- **Logical order**: Do tasks follow proper implementation sequence?
|
|
71
|
-
- **Dependencies**: Are task dependencies clear and correct?
|
|
72
|
-
- **Granularity**: Are tasks appropriately sized and actionable?
|
|
73
|
-
- **Completeness**: Do tasks cover all requirements and acceptance criteria?
|
|
74
|
-
- **Blocking issues**: Are there any tasks that would block others?
|
|
75
|
-
|
|
76
|
-
### 8. Anti-Hallucination Verification
|
|
77
|
-
|
|
78
|
-
- **Source verification**: Every technical claim must be traceable to source documents
|
|
79
|
-
- **Architecture alignment**: Dev Notes content matches architecture specifications
|
|
80
|
-
- **No invented details**: Flag any technical decisions not supported by source documents
|
|
81
|
-
- **Reference accuracy**: Verify all source references are correct and accessible
|
|
82
|
-
- **Fact checking**: Cross-reference claims against epic and architecture documents
|
|
83
|
-
|
|
84
|
-
### 9. Dev Agent Implementation Readiness
|
|
85
|
-
|
|
86
|
-
- **Self-contained context**: Can the story be implemented without reading external docs?
|
|
87
|
-
- **Clear instructions**: Are implementation steps unambiguous?
|
|
88
|
-
- **Complete technical context**: Are all required technical details present in Dev Notes?
|
|
89
|
-
- **Missing information**: Identify any critical information gaps
|
|
90
|
-
- **Actionability**: Are all tasks actionable by a development agent?
|
|
91
|
-
|
|
92
|
-
### 10. Generate Validation Report
|
|
93
|
-
|
|
94
|
-
Provide a structured validation report including:
|
|
95
|
-
|
|
96
|
-
#### Template Compliance Issues
|
|
97
|
-
|
|
98
|
-
- Missing sections from story template
|
|
99
|
-
- Unfilled placeholders or template variables
|
|
100
|
-
- Structural formatting issues
|
|
101
|
-
|
|
102
|
-
#### Critical Issues (Must Fix - Story Blocked)
|
|
103
|
-
|
|
104
|
-
- Missing essential information for implementation
|
|
105
|
-
- Inaccurate or unverifiable technical claims
|
|
106
|
-
- Incomplete acceptance criteria coverage
|
|
107
|
-
- Missing required sections
|
|
108
|
-
|
|
109
|
-
#### Should-Fix Issues (Important Quality Improvements)
|
|
110
|
-
|
|
111
|
-
- Unclear implementation guidance
|
|
112
|
-
- Missing security considerations
|
|
113
|
-
- Task sequencing problems
|
|
114
|
-
- Incomplete testing instructions
|
|
115
|
-
|
|
116
|
-
#### Nice-to-Have Improvements (Optional Enhancements)
|
|
117
|
-
|
|
118
|
-
- Additional context that would help implementation
|
|
119
|
-
- Clarifications that would improve efficiency
|
|
120
|
-
- Documentation improvements
|
|
121
|
-
|
|
122
|
-
#### Anti-Hallucination Findings
|
|
123
|
-
|
|
124
|
-
- Unverifiable technical claims
|
|
125
|
-
- Missing source references
|
|
126
|
-
- Inconsistencies with architecture documents
|
|
127
|
-
- Invented libraries, patterns, or standards
|
|
128
|
-
|
|
129
|
-
#### Final Assessment
|
|
130
|
-
|
|
131
|
-
- **GO**: Story is ready for implementation
|
|
132
|
-
- **NO-GO**: Story requires fixes before implementation
|
|
133
|
-
- **Implementation Readiness Score**: 1-10 scale
|
|
134
|
-
- **Confidence Level**: High/Medium/Low for successful implementation
|