bmad-fh 6.0.0-alpha.23.6390fcb0 → 6.0.0-alpha.23.6874ced1

package/test/test-scope-cli.js

@@ -14,7 +14,7 @@
 const fs = require('fs-extra');
 const path = require('node:path');
 const os = require('node:os');
-const { execSync, spawn } = require('node:child_process');
+const { execSync, spawnSync } = require('node:child_process');
 
 // ANSI color codes
 const colors = {
@@ -133,7 +133,7 @@ function cleanupTestProject(tmpDir) {
 // Get path to CLI
 const CLI_PATH = path.join(__dirname, '..', 'tools', 'cli', 'bmad-cli.js');
 
-// Execute CLI command and capture output
+// Execute CLI command and capture output (string-based, for simple cases)
 function runCli(args, cwd, options = {}) {
   const cmd = `node "${CLI_PATH}" ${args}`;
   try {
@@ -155,6 +155,32 @@ function runCli(args, cwd, options = {}) {
   }
 }
 
+/**
+ * Execute CLI command using spawnSync with an array of arguments.
+ * This properly preserves argument boundaries, essential for arguments with spaces.
+ *
+ * @param {string[]} args - Array of arguments (NOT a joined string)
+ * @param {string} cwd - Working directory
+ * @param {Object} options - Additional options
+ * @returns {Object} Result with success, output, stderr, exitCode
+ */
+function runCliArray(args, cwd, options = {}) {
+  const result = spawnSync('node', [CLI_PATH, ...args], {
+    cwd,
+    encoding: 'utf8',
+    timeout: options.timeout || 30_000,
+    env: { ...process.env, ...options.env, FORCE_COLOR: '0' },
+  });
+
+  return {
+    success: result.status === 0,
+    output: result.stdout || '',
+    stderr: result.stderr || '',
+    exitCode: result.status || 0,
+    error: result.error ? result.error.message : null,
+  };
+}
+
 // ============================================================================
 // Help System Tests
 // ============================================================================
@@ -1252,6 +1278,148 @@ function testIntegration() {
   });
 }
 
+// ============================================================================
+// Argument Handling Tests (using runCliArray for proper boundary preservation)
+// ============================================================================
+
+function testArgumentHandling() {
+  console.log(`\n${colors.blue}${colors.bold}Argument Handling Tests${colors.reset}`);
+
+  test('scope create with multi-word description (array args)', () => {
+    const tmpDir = createTestProject();
+    try {
+      runCliArray(['scope', 'init'], tmpDir);
+      const result = runCliArray(
+        ['scope', 'create', 'auth', '--name', 'Auth Service', '--description', 'Handles user authentication and sessions'],
+        tmpDir,
+      );
+      assertTrue(result.success, `Create should succeed: ${result.stderr || result.error}`);
+
+      const infoResult = runCliArray(['scope', 'info', 'auth'], tmpDir);
+      assertContains(infoResult.output, 'Auth Service');
+      assertContains(infoResult.output, 'Handles user authentication and sessions');
+    } finally {
+      cleanupTestProject(tmpDir);
+    }
+  });
+
+  test('scope create with 9-word description (regression test)', () => {
+    const tmpDir = createTestProject();
+    try {
+      runCliArray(['scope', 'init'], tmpDir);
+      // This exact case caused "too many arguments" error before the fix
+      const result = runCliArray(
+        ['scope', 'create', 'auto-queue', '--name', 'AutoQueue', '--description', 'PRD Auto queue for not inbound yet products'],
+        tmpDir,
+      );
+      assertTrue(result.success, `Should not fail with "too many arguments": ${result.stderr}`);
+      assertNotContains(result.stderr || '', 'too many arguments');
+
+      const infoResult = runCliArray(['scope', 'info', 'auto-queue'], tmpDir);
+      assertContains(infoResult.output, 'PRD Auto queue for not inbound yet products');
+    } finally {
+      cleanupTestProject(tmpDir);
+    }
+  });
+
+  test('all subcommands work with array args', () => {
+    const tmpDir = createTestProject();
+    try {
+      // init
+      let result = runCliArray(['scope', 'init'], tmpDir);
+      assertTrue(result.success, 'init should work');
+
+      // create
+      result = runCliArray(['scope', 'create', 'test', '--name', 'Test Scope', '--description', 'A test scope'], tmpDir);
+      assertTrue(result.success, 'create should work');
+
+      // list
+      result = runCliArray(['scope', 'list'], tmpDir);
+      assertTrue(result.success, 'list should work');
+      assertContains(result.output, 'test');
+
+      // info
+      result = runCliArray(['scope', 'info', 'test'], tmpDir);
+      assertTrue(result.success, 'info should work');
+
+      // set
+      result = runCliArray(['scope', 'set', 'test'], tmpDir);
+      assertTrue(result.success, 'set should work');
+
+      // archive
+      result = runCliArray(['scope', 'archive', 'test'], tmpDir);
+      assertTrue(result.success, 'archive should work');
+
+      // activate
+      result = runCliArray(['scope', 'activate', 'test'], tmpDir);
+      assertTrue(result.success, 'activate should work');
+
+      // sync-up
+      result = runCliArray(['scope', 'sync-up', 'test', '--dry-run'], tmpDir);
+      assertTrue(result.success, 'sync-up should work');
+
+      // sync-down
+      result = runCliArray(['scope', 'sync-down', 'test', '--dry-run'], tmpDir);
+      assertTrue(result.success, 'sync-down should work');
+
+      // unset
+      result = runCliArray(['scope', 'unset'], tmpDir);
+      assertTrue(result.success, 'unset should work');
+
+      // remove
+      result = runCliArray(['scope', 'remove', 'test', '--force'], tmpDir);
+      assertTrue(result.success, 'remove should work');
+
+      // help
+      result = runCliArray(['scope', 'help'], tmpDir);
+      assertTrue(result.success, 'help should work');
+    } finally {
+      cleanupTestProject(tmpDir);
+    }
+  });
+
+  test('subcommand aliases work with array args', () => {
+    const tmpDir = createTestProject();
+    try {
+      runCliArray(['scope', 'init'], tmpDir);
+
+      // new (alias for create) - include --description to avoid interactive prompt
+      let result = runCliArray(['scope', 'new', 'test', '--name', 'Test', '--description', ''], tmpDir);
+      assertTrue(result.success, 'new alias should work');
+
+      // ls (alias for list)
+      result = runCliArray(['scope', 'ls'], tmpDir);
+      assertTrue(result.success, 'ls alias should work');
+
+      // show (alias for info)
+      result = runCliArray(['scope', 'show', 'test'], tmpDir);
+      assertTrue(result.success, 'show alias should work');
+
+      // use (alias for set)
+      result = runCliArray(['scope', 'use', 'test'], tmpDir);
+      assertTrue(result.success, 'use alias should work');
+
+      // clear (alias for unset)
+      result = runCliArray(['scope', 'clear'], tmpDir);
+      assertTrue(result.success, 'clear alias should work');
+
+      // syncup (alias for sync-up)
+      result = runCliArray(['scope', 'syncup', 'test', '--dry-run'], tmpDir);
+      assertTrue(result.success, 'syncup alias should work');
+
+      // syncdown (alias for sync-down)
+      result = runCliArray(['scope', 'syncdown', 'test', '--dry-run'], tmpDir);
+      assertTrue(result.success, 'syncdown alias should work');
+
+      // rm (alias for remove)
+      result = runCliArray(['scope', 'rm', 'test', '--force'], tmpDir);
+      assertTrue(result.success, 'rm alias should work');
+    } finally {
+      cleanupTestProject(tmpDir);
+    }
+  });
+}
+
 // ============================================================================
 // Main Test Runner
 // ============================================================================
@@ -1274,6 +1442,7 @@ function main() {
   testSyncCommands();
   testEdgeCases();
   testIntegration();
+  testArgumentHandling();
 
   const duration = ((Date.now() - startTime) / 1000).toFixed(2);
 

package/tools/bmad-npx-wrapper.js

@@ -5,7 +5,7 @@
  * This file ensures proper execution when run via npx from GitHub or npm registry
  */
 
-const { execSync } = require('node:child_process');
+const { spawnSync } = require('node:child_process');
 const path = require('node:path');
 const fs = require('node:fs');
 
@@ -25,10 +25,20 @@ if (isNpxExecution) {
 
   try {
     // Execute CLI from user's working directory (process.cwd()), not npm cache
-    execSync(`node "${bmadCliPath}" ${args.join(' ')}`, {
+    // Use spawnSync with array args to preserve argument boundaries
+    // (args.join(' ') would break arguments containing spaces)
+    const result = spawnSync('node', [bmadCliPath, ...args], {
       stdio: 'inherit',
       cwd: process.cwd(), // This preserves the user's working directory
     });
+
+    if (result.error) {
+      throw result.error;
+    }
+
+    if (result.status !== 0) {
+      process.exit(result.status || 1);
+    }
   } catch (error) {
     process.exit(error.status || 1);
   }

package/tools/build-docs.js

@@ -36,6 +36,7 @@ const LLM_EXCLUDE_PATTERNS = [
   'v4-to-v6-upgrade',
   'downloads/',
   'faq',
+  'plans/', // Internal planning docs, not user-facing
   'reference/glossary/',
   'explanation/game-dev/',
   // Note: Files/dirs starting with _ (like _STYLE_GUIDE.md, _archive/) are excluded in shouldExcludeFromLlm()

package/tools/cli/commands/scope.js

@@ -232,8 +232,28 @@ async function handleCreate(projectRoot, scopeId, options) {
   console.log(`    ${paths.implementation}`);
   console.log(`    ${paths.tests}`);
   console.log();
-  console.log(chalk.cyan(`  Use with workflows by setting .bmad-scope or using BMAD_SCOPE=${scopeId}`));
-  console.log();
+
+  // Prompt to set as active scope (critical UX improvement)
+  const setActive = await confirm({
+    message: `Set '${scopeId}' as your active scope for this session?`,
+    initialValue: true,
+  });
+
+  if (!isCancel(setActive) && setActive) {
+    const scopeFilePath = path.join(projectRoot, '.bmad-scope');
+    const scopeContent = `# BMAD Active Scope Configuration
+# This file is auto-generated. Do not edit manually.
+# To change: npx bmad-fh scope set <scope-id>
+
+active_scope: ${scopeId}
+set_at: "${new Date().toISOString()}"
+`;
+    await fs.writeFile(scopeFilePath, scopeContent, 'utf8');
+    console.log(chalk.green(`\n✓ Active scope set to '${scopeId}'`));
+    console.log(chalk.dim('  Workflows will now use this scope automatically.\n'));
+  } else {
+    console.log(chalk.dim(`\n  To activate later, run: npx bmad-fh scope set ${scopeId}\n`));
+  }
 }
 
 /**
@@ -304,6 +324,21 @@ async function handleRemove(projectRoot, scopeId, options) {
   // Remove from configuration
   await manager.removeScope(scopeId, { force: true });
 
+  // Clean up .bmad-scope if this was the active scope
+  const scopeFilePath = path.join(projectRoot, '.bmad-scope');
+  if (await fs.pathExists(scopeFilePath)) {
+    try {
+      const content = await fs.readFile(scopeFilePath, 'utf8');
+      const match = content.match(/active_scope:\s*(\S+)/);
+      if (match && match[1] === scopeId) {
+        await fs.remove(scopeFilePath);
+        console.log(chalk.yellow(`\n  Note: Cleared active scope (was set to '${scopeId}')`));
+      }
+    } catch {
+      // Ignore errors reading .bmad-scope
+    }
+  }
+
   console.log(chalk.green(`\n✓ Scope '${scopeId}' removed successfully!`));
   if (shouldBackup) {
     console.log(chalk.dim('  A backup was created in _bmad-output/'));