bluetooth-serial-port 3.0.2 → 3.0.3

package/.circleci/config.yml

@@ -6,42 +6,54 @@ orbs:
   # The Node.js orb contains a set of prepackaged CircleCI configuration you can utilize
   # Orbs reduce the amount of configuration required for common tasks.
   # See the orb documentation here: https://circleci.com/developer/orbs/orb/circleci/node
-  node: circleci/node@4.1
+  node: circleci/node@4.7
 
 jobs:
-  build-14:
+  build-18:
     docker:
-      - image: node:14
+      - image: node:18
     steps:
-      - checkout
+      - checkout:
+          method: full
       - run:
-          name: Install dependencies
+          name: install build dependencies
           command: apt-get update && apt-get install -y build-essential libbluetooth-dev
       - node/install-packages
-
-  build-16:
+  build-20:
     docker:
-      - image: node:16
+      - image: node:20
     steps:
-      - checkout
+      - checkout:
+          method: full
       - run:
-          name: Install build dependencies
+          name: install build dependencies
           command: apt-get update && apt-get install -y build-essential libbluetooth-dev
       - node/install-packages
-
-  build-18:
+  build-22:
     docker:
-      - image: node:18
+      - image: node:22
+    steps:
+      - checkout:
+          method: full
+      - run:
+          name: install build dependencies
+          command: apt-get update && apt-get install -y build-essential libbluetooth-dev
+      - node/install-packages
+  build-24:
+    docker:
+      - image: node:24
     steps:
-      - checkout
+      - checkout:
+          method: full
       - run:
-          name: Install build dependencies
+          name: install build dependencies
           command: apt-get update && apt-get install -y build-essential libbluetooth-dev
       - node/install-packages
 
 workflows:
   build:
     jobs:
-      - build-14
-      - build-16
       - build-18
+      - build-20
+      - build-22
+      - build-24

package/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:14
+FROM node:18
 RUN apt-get update
 RUN apt-get install -y build-essential libbluetooth-dev
 ADD . node-bluetooth-serial-port

package/README.md

@@ -17,13 +17,14 @@ If you have any problems make sure to [checkout the FAQ](https://github.com/eelc
 
 ## New in the last release
 
--   Changes node version to `lts` in the Dockerfile
+* Fixes memory leaks.
+* Adds support for node 20, 22 and 24
 
 Check the [release notes](RELEASE_NOTES.md) for an overview of the change history.
 
 ## Prerequisites on Linux
 
--   Needs Bluetooth development packages to build
+* Needs Bluetooth development packages to build
 
 `apt-get install build-essential libbluetooth-dev`
 

package/RELEASE_NOTES.md

@@ -1,5 +1,15 @@
 ## RELEASE NOTES
 
+### 3.0.2
+
+* Fixes memory leaks.
+* Adds support for node 20, 22 and 24
+
+### 3.0.2
+
+* Changes node version to `lts` in the Dockerfile
+
+
 ### 3.0.1
 
 * Fixes typescript definition for `listPairedDevices`.

package/appveyor.yml

@@ -1,12 +1,14 @@
+image: Visual Studio 2019
+
 environment:
   # Visual Studio Version
   MSVS_VERSION: 2017
-  # Test against these versions of Node.js and io.js
+  # Test against these Node.js versions
   matrix:
-    # node.js
-    - nodejs_version: "14"
-    - nodejs_version: "16"
     - nodejs_version: "18"
+    - nodejs_version: "20"
+    - nodejs_version: "22"
+    - nodejs_version: "24"
 
 
 platform:
@@ -18,21 +20,14 @@ install:
   - ps: Install-Product node $env:nodejs_version $env:Platform
   # install modules
   - node --version
-  - npm -g install npm@latest
   - npm --version
-  - node -e "console.log(process.arch);"
-  #- if "%PLATFORM%" == "x64" SET PATH=C:\Python27-x64;%PATH%
-  #- if "%PLATFORM%" == "x86" SET PATH=C:\python27;%PATH%
-  - npm install node-gyp
-  - npm update
-  - npm run install-debug
+  - npm ci --ignore-scripts
+
+# Disable automatic MSBuild discovery (there is no .sln/.vcxproj in repo root).
+build: off
 
 # Post-install test scripts.
 test_script:
   # run tests
-  - node_modules\.bin\node-gyp configure
-  - node_modules\.bin\node-gyp build
+  - npm run install-debug
   - node test\index.js
-
-# Don't actually build.
-build: off

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "bluetooth-serial-port",
-    "version": "3.0.2",
+    "version": "3.0.3",
     "description": "Bluetooth serial port communication for Node.js",
     "author": "Eelco Cramer <eelco@hailendal.org>",
     "keywords": [
@@ -27,14 +27,14 @@
     ],
     "dependencies": {
         "bindings": "1.5.x",
-        "nan": "2.17.x",
+        "nan": "^2.28.0",
         "stable": "^0.1.8"
     },
     "optionalDependencies": {
         "@types/node": "^18.0.0"
     },
     "engines": {
-        "node": ">= 16.x",
+        "node": ">= 18.x",
         "npm": ">= 8.x"
     },
     "scripts": {

package/src/linux/BTSerialPortBinding.cc

@@ -391,6 +391,7 @@ NAN_METHOD(BTSerialPortBinding::Read) {
         Nan::AsyncResource resource("bluetooth-serial-port:Read");
         Nan::Callback *nc = new Nan::Callback(cb);
         nc->Call(2, argv, &resource);
+        delete nc;
     } else {
         read_baton_t *baton = new read_baton_t();
         baton->rfcomm = rfcomm;

package/src/linux/DeviceINQ.cc

@@ -252,9 +252,12 @@ NAN_METHOD(DeviceINQ::InquireSync) {
       };
       found->Call(2, argv, &resource);
     }
+    free(inquiryResult.devices);
 
     Local<Value> argv[] = {};
     callback->Call(0, argv, &resource);
+    delete callback;
+    delete found;
     return;
 }
 
@@ -262,7 +265,9 @@ class InquireWorker : public Nan::AsyncWorker {
  public:
   InquireWorker(Nan::Callback* found, Nan::Callback *callback)
     : Nan::AsyncWorker(callback), found(found) {}
-  ~InquireWorker() {}
+  ~InquireWorker() {
+        delete found;
+    }
 
   // Executed inside the worker-thread.
   // It is not safe to access V8, or V8 data structures
@@ -289,6 +294,7 @@ class InquireWorker : public Nan::AsyncWorker {
 
     Local<Value> argv[] = {};
     callback->Call(0, argv, &resource);
+    free(inquiryResult.devices);
   }
 
   private:

package/src/windows/BTSerialPortBinding.cc

@@ -354,6 +354,7 @@ NAN_METHOD(BTSerialPortBinding::Read) {
         Nan::AsyncResource resource("bluetooth-serial-port:Read");
         Nan::Callback *nc = new Nan::Callback(cb);
         nc->Call(2, argv, &resource);
+        delete nc;
     } else {
         read_baton_t *baton = new read_baton_t();
         baton->rfcomm = rfcomm;