bluera-knowledge 0.9.31 → 0.9.34

package/src/cli/commands/mcp.test.ts

@@ -4,7 +4,7 @@ import type { GlobalOptions } from '../program.js';
 
 // Mock all dependencies
 vi.mock('../../mcp/server.js', () => ({
-  runMCPServer: vi.fn()
+  runMCPServer: vi.fn(),
 }));
 
 describe('MCP Command - Execution Tests', () => {
@@ -35,7 +35,7 @@ describe('MCP Command - Execution Tests', () => {
 
       expect(runMCPServer).toHaveBeenCalledWith({
         dataDir: '/tmp/test-data',
-        config: undefined
+        config: undefined,
       });
     });
 
@@ -55,7 +55,7 @@ describe('MCP Command - Execution Tests', () => {
 
       expect(runMCPServer).toHaveBeenCalledWith({
         dataDir: '/tmp/test-data',
-        config: '/custom/config.json'
+        config: '/custom/config.json',
       });
     });
 
@@ -75,7 +75,7 @@ describe('MCP Command - Execution Tests', () => {
 
       expect(runMCPServer).toHaveBeenCalledWith({
         dataDir: '/custom/data',
-        config: undefined
+        config: undefined,
       });
     });
 
@@ -95,7 +95,7 @@ describe('MCP Command - Execution Tests', () => {
 
       expect(runMCPServer).toHaveBeenCalledWith({
         dataDir: '/custom/data',
-        config: '/custom/config.json'
+        config: '/custom/config.json',
       });
     });
   });
@@ -204,7 +204,7 @@ describe('MCP Command - Execution Tests', () => {
       let serverStarted = false;
 
       vi.mocked(runMCPServer).mockImplementation(async () => {
-        await new Promise(resolve => setTimeout(resolve, 10));
+        await new Promise((resolve) => setTimeout(resolve, 10));
         serverStarted = true;
       });
 

package/src/cli/commands/mcp.ts

@@ -1,6 +1,6 @@
 import { Command } from 'commander';
-import type { GlobalOptions } from '../program.js';
 import { runMCPServer } from '../../mcp/server.js';
+import type { GlobalOptions } from '../program.js';
 
 export function createMCPCommand(getOptions: () => GlobalOptions): Command {
   const mcp = new Command('mcp')
@@ -10,7 +10,7 @@ export function createMCPCommand(getOptions: () => GlobalOptions): Command {
 
       await runMCPServer({
         dataDir: opts.dataDir,
-        config: opts.config
+        config: opts.config,
       });
     });
 

package/src/cli/commands/plugin-api.test.ts

@@ -12,7 +12,7 @@ vi.mock('../../plugin/commands.js', () => ({
   handleAddRepo: vi.fn(),
   handleAddFolder: vi.fn(),
   handleStores: vi.fn(),
-  handleSuggest: vi.fn()
+  handleSuggest: vi.fn(),
 }));
 
 describe('Plugin API Commands - Execution Tests', () => {
@@ -24,12 +24,8 @@ describe('Plugin API Commands - Execution Tests', () => {
   });
 
   beforeEach(async () => {
-    const {
-      handleAddRepo,
-      handleAddFolder,
-      handleStores,
-      handleSuggest
-    } = await import('../../plugin/commands.js');
+    const { handleAddRepo, handleAddFolder, handleStores, handleSuggest } =
+      await import('../../plugin/commands.js');
 
     vi.mocked(handleAddRepo).mockClear().mockResolvedValue(undefined);
     vi.mocked(handleAddFolder).mockClear().mockResolvedValue(undefined);
@@ -50,7 +46,7 @@ describe('Plugin API Commands - Execution Tests', () => {
       await actionHandler(['https://github.com/user/repo.git']);
 
       expect(handleAddRepo).toHaveBeenCalledWith({
-        url: 'https://github.com/user/repo.git'
+        url: 'https://github.com/user/repo.git',
       });
     });
 
@@ -64,7 +60,7 @@ describe('Plugin API Commands - Execution Tests', () => {
 
       expect(handleAddRepo).toHaveBeenCalledWith({
         url: 'https://github.com/user/repo.git',
-        name: 'my-repo'
+        name: 'my-repo',
       });
     });
 
@@ -78,7 +74,7 @@ describe('Plugin API Commands - Execution Tests', () => {
 
       expect(handleAddRepo).toHaveBeenCalledWith({
         url: 'https://github.com/user/repo.git',
-        branch: 'develop'
+        branch: 'develop',
       });
     });
 
@@ -93,7 +89,7 @@ describe('Plugin API Commands - Execution Tests', () => {
       expect(handleAddRepo).toHaveBeenCalledWith({
         url: 'https://github.com/user/repo.git',
         name: 'custom-name',
-        branch: 'main'
+        branch: 'main',
       });
     });
 
@@ -105,7 +101,9 @@ describe('Plugin API Commands - Execution Tests', () => {
       const command = createAddRepoCommand(getOptions);
       const actionHandler = (command as any)._actionHandler;
 
-      await expect(actionHandler(['https://github.com/user/repo.git'])).rejects.toThrow('Clone failed');
+      await expect(actionHandler(['https://github.com/user/repo.git'])).rejects.toThrow(
+        'Clone failed'
+      );
     });
   });
 
@@ -118,7 +116,7 @@ describe('Plugin API Commands - Execution Tests', () => {
       await actionHandler(['/path/to/folder']);
 
       expect(handleAddFolder).toHaveBeenCalledWith({
-        path: '/path/to/folder'
+        path: '/path/to/folder',
       });
     });
 
@@ -132,7 +130,7 @@ describe('Plugin API Commands - Execution Tests', () => {
 
       expect(handleAddFolder).toHaveBeenCalledWith({
         path: '/path/to/folder',
-        name: 'my-folder'
+        name: 'my-folder',
       });
     });
 
@@ -144,7 +142,7 @@ describe('Plugin API Commands - Execution Tests', () => {
       await actionHandler(['./relative/path']);
 
       expect(handleAddFolder).toHaveBeenCalledWith({
-        path: './relative/path'
+        path: './relative/path',
       });
     });
 
@@ -156,7 +154,7 @@ describe('Plugin API Commands - Execution Tests', () => {
       await actionHandler(['/path/with spaces/folder']);
 
       expect(handleAddFolder).toHaveBeenCalledWith({
-        path: '/path/with spaces/folder'
+        path: '/path/with spaces/folder',
       });
     });
 
@@ -294,7 +292,7 @@ describe('Plugin API Commands - Execution Tests', () => {
       await actionHandler(['https://github.com/user/repo.git']);
 
       expect(handleAddRepo).toHaveBeenCalledWith({
-        url: 'https://github.com/user/repo.git'
+        url: 'https://github.com/user/repo.git',
       });
     });
 
@@ -306,7 +304,7 @@ describe('Plugin API Commands - Execution Tests', () => {
       await actionHandler(['/path']);
 
       expect(handleAddFolder).toHaveBeenCalledWith({
-        path: '/path'
+        path: '/path',
       });
     });
   });

package/src/cli/commands/plugin-api.ts

@@ -1,5 +1,10 @@
 import { Command } from 'commander';
-import { handleAddRepo, handleAddFolder, handleStores, handleSuggest } from '../../plugin/commands.js';
+import {
+  handleAddRepo,
+  handleAddFolder,
+  handleStores,
+  handleSuggest,
+} from '../../plugin/commands.js';
 import type { GlobalOptions } from '../program.js';
 
 /**
@@ -29,11 +34,9 @@ export function createAddFolderCommand(_getOptions: () => GlobalOptions): Comman
 }
 
 export function createStoresCommand(_getOptions: () => GlobalOptions): Command {
-  return new Command('stores')
-    .description('List all indexed library stores')
-    .action(async () => {
-      await handleStores();
-    });
+  return new Command('stores').description('List all indexed library stores').action(async () => {
+    await handleStores();
+  });
 }
 
 export function createSuggestCommand(_getOptions: () => GlobalOptions): Command {

package/src/cli/commands/search.test.ts

@@ -374,6 +374,8 @@ describe('search command execution', () => {
 
   describe('error handling', () => {
     it('exits with code 3 when specified store not found', async () => {
+      const { destroyServices } = await import('../../services/index.js');
+
       mockServices.store.list.mockResolvedValue([]);
       mockServices.store.getByIdOrName.mockResolvedValue(undefined);
 
@@ -386,9 +388,13 @@ describe('search command execution', () => {
       expect(consoleErrorSpy).toHaveBeenCalledWith('Error: Store not found: nonexistent');
       expect(processExitSpy).toHaveBeenCalledWith(3);
       expect(mockServices.search.search).not.toHaveBeenCalled();
+      // Must call destroyServices before process.exit per CLAUDE.md
+      expect(destroyServices).toHaveBeenCalled();
     });
 
     it('exits with code 1 when no stores exist', async () => {
+      const { destroyServices } = await import('../../services/index.js');
+
       mockServices.store.list.mockResolvedValue([]);
 
       const command = createSearchCommand(getOptions);
@@ -399,9 +405,13 @@ describe('search command execution', () => {
       expect(consoleErrorSpy).toHaveBeenCalledWith('No stores to search. Create a store first.');
       expect(processExitSpy).toHaveBeenCalledWith(1);
       expect(mockServices.search.search).not.toHaveBeenCalled();
+      // Must call destroyServices before process.exit per CLAUDE.md
+      expect(destroyServices).toHaveBeenCalled();
     });
 
     it('exits with code 3 when one of multiple stores not found', async () => {
+      const { destroyServices } = await import('../../services/index.js');
+
       const mockStores = [{ id: createStoreId('store-1'), name: 'store1', type: 'file' as const }];
 
       mockServices.store.list.mockResolvedValue(mockStores);
@@ -418,6 +428,8 @@ describe('search command execution', () => {
 
       expect(consoleErrorSpy).toHaveBeenCalledWith('Error: Store not found: nonexistent');
       expect(processExitSpy).toHaveBeenCalledWith(3);
+      // Must call destroyServices before process.exit per CLAUDE.md
+      expect(destroyServices).toHaveBeenCalled();
     });
   });
 
@@ -461,9 +473,7 @@ describe('search command execution', () => {
 
       await actionHandler(['test query']);
 
-      expect(consoleLogSpy).toHaveBeenCalledWith(
-        expect.stringContaining('"query": "test query"')
-      );
+      expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('"query": "test query"'));
       expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('"mode": "hybrid"'));
     });
 
@@ -561,9 +571,7 @@ describe('search command execution', () => {
       await actionHandler(['test query']);
 
       expect(consoleLogSpy).toHaveBeenCalledWith('\nSearch: "test query"');
-      expect(consoleLogSpy).toHaveBeenCalledWith(
-        expect.stringContaining('Mode: hybrid')
-      );
+      expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('Mode: hybrid'));
       expect(consoleLogSpy).toHaveBeenCalledWith(
         expect.stringContaining('1. [0.95] function: testFunction')
       );
@@ -580,7 +588,8 @@ describe('search command execution', () => {
           {
             id: createDocumentId('doc-1'),
             score: 0.95,
-            content: 'This is a long piece of content that should be truncated in the preview because it exceeds the maximum length allowed for display in the search results view.',
+            content:
+              'This is a long piece of content that should be truncated in the preview because it exceeds the maximum length allowed for display in the search results view.',
             highlight: 'This is a long piece of content',
             metadata: {
               type: 'file',

package/src/cli/commands/search.ts

@@ -1,113 +1,150 @@
 import { Command } from 'commander';
 import { createServices, destroyServices } from '../../services/index.js';
-import type { GlobalOptions } from '../program.js';
 import type { SearchMode, DetailLevel } from '../../types/search.js';
+import type { GlobalOptions } from '../program.js';
 
 export function createSearchCommand(getOptions: () => GlobalOptions): Command {
   const search = new Command('search')
     .description('Search indexed documents using vector similarity + full-text matching')
     .argument('<query>', 'Search query')
-    .option('-s, --stores <stores>', 'Limit search to specific stores (comma-separated IDs or names)')
-    .option('-m, --mode <mode>', 'vector (embeddings only), fts (text only), hybrid (both, default)', 'hybrid')
+    .option(
+      '-s, --stores <stores>',
+      'Limit search to specific stores (comma-separated IDs or names)'
+    )
+    .option(
+      '-m, --mode <mode>',
+      'vector (embeddings only), fts (text only), hybrid (both, default)',
+      'hybrid'
+    )
     .option('-n, --limit <count>', 'Maximum results to return (default: 10)', '10')
     .option('-t, --threshold <score>', 'Minimum score 0-1; omit low-relevance results')
     .option('--include-content', 'Show full document content, not just preview snippet')
-    .option('--detail <level>', 'Context detail: minimal, contextual, full (default: minimal)', 'minimal')
-    .action(async (query: string, options: {
-      stores?: string;
-      mode?: SearchMode;
-      limit?: string;
-      threshold?: string;
-      includeContent?: boolean;
-      detail?: DetailLevel;
-    }) => {
-      const globalOpts = getOptions();
-      const services = await createServices(globalOpts.config, globalOpts.dataDir);
-      try {
-        // Get store IDs
-        let storeIds = (await services.store.list()).map((s) => s.id);
-
-        if (options.stores !== undefined) {
-          const requestedStores = options.stores.split(',').map((s) => s.trim());
-          const resolvedStores = [];
-
-          for (const requested of requestedStores) {
-            const store = await services.store.getByIdOrName(requested);
-            if (store !== undefined) {
-              resolvedStores.push(store.id);
-            } else {
-              console.error(`Error: Store not found: ${requested}`);
-              process.exit(3);
-            }
-          }
-
-          storeIds = resolvedStores;
+    .option(
+      '--detail <level>',
+      'Context detail: minimal, contextual, full (default: minimal)',
+      'minimal'
+    )
+    .action(
+      async (
+        query: string,
+        options: {
+          stores?: string;
+          mode?: SearchMode;
+          limit?: string;
+          threshold?: string;
+          includeContent?: boolean;
+          detail?: DetailLevel;
         }
+      ) => {
+        const globalOpts = getOptions();
+        const services = await createServices(globalOpts.config, globalOpts.dataDir);
+        let exitCode = 0;
+        try {
+          // Get store IDs
+          let storeIds = (await services.store.list()).map((s) => s.id);
 
-        if (storeIds.length === 0) {
-          console.error('No stores to search. Create a store first.');
-          process.exit(1);
-        }
+          searchLogic: {
+            if (options.stores !== undefined) {
+              const requestedStores = options.stores.split(',').map((s) => s.trim());
+              const resolvedStores = [];
 
-        // Initialize LanceDB for each store
-        for (const storeId of storeIds) {
-          await services.lance.initialize(storeId);
-        }
+              for (const requested of requestedStores) {
+                const store = await services.store.getByIdOrName(requested);
+                if (store !== undefined) {
+                  resolvedStores.push(store.id);
+                } else {
+                  console.error(`Error: Store not found: ${requested}`);
+                  exitCode = 3;
 
-        const results = await services.search.search({
-          query,
-          stores: storeIds,
-          mode: options.mode ?? 'hybrid',
-          limit: parseInt(options.limit ?? '10', 10),
-          threshold: options.threshold !== undefined ? parseFloat(options.threshold) : undefined,
-          includeContent: options.includeContent,
-          detail: options.detail ?? 'minimal',
-        });
-
-        if (globalOpts.format === 'json') {
-          console.log(JSON.stringify(results, null, 2));
-        } else if (globalOpts.quiet === true) {
-          // Quiet mode: just list matching paths/URLs, one per line
-          for (const r of results.results) {
-            const path = r.metadata.path ?? r.metadata.url ?? 'unknown';
-            console.log(path);
-          }
-        } else {
-          console.log(`\nSearch: "${query}"`);
-          console.log(`Mode: ${results.mode} | Detail: ${String(options.detail)} | Stores: ${String(results.stores.length)} | Results: ${String(results.totalResults)} | Time: ${String(results.timeMs)}ms\n`);
-
-          if (results.results.length === 0) {
-            console.log('No results found.\n');
-          } else {
-            for (let i = 0; i < results.results.length; i++) {
-              const r = results.results[i];
-              if (r === undefined) continue;
-
-              if (r.summary) {
-                console.log(`${String(i + 1)}. [${r.score.toFixed(2)}] ${r.summary.type}: ${r.summary.name}`);
-                console.log(`   ${r.summary.location}`);
-                console.log(`   ${r.summary.purpose}`);
-
-                if (r.context && options.detail !== 'minimal') {
-                  console.log(`   Imports: ${r.context.keyImports.slice(0, 3).join(', ')}`);
-                  console.log(`   Related: ${r.context.relatedConcepts.slice(0, 3).join(', ')}`);
+                  break searchLogic;
                 }
+              }
 
-                console.log();
-              } else {
-                // Fallback to old format
+              storeIds = resolvedStores;
+            }
+
+            if (storeIds.length === 0) {
+              console.error('No stores to search. Create a store first.');
+              exitCode = 1;
+
+              break searchLogic;
+            }
+
+            // Initialize LanceDB for each store
+            for (const storeId of storeIds) {
+              await services.lance.initialize(storeId);
+            }
+
+            const results = await services.search.search({
+              query,
+              stores: storeIds,
+              mode: options.mode ?? 'hybrid',
+              limit: parseInt(options.limit ?? '10', 10),
+              threshold:
+                options.threshold !== undefined ? parseFloat(options.threshold) : undefined,
+              includeContent: options.includeContent,
+              detail: options.detail ?? 'minimal',
+            });
+
+            if (globalOpts.format === 'json') {
+              console.log(JSON.stringify(results, null, 2));
+            } else if (globalOpts.quiet === true) {
+              // Quiet mode: just list matching paths/URLs, one per line
+              for (const r of results.results) {
                 const path = r.metadata.path ?? r.metadata.url ?? 'unknown';
-                console.log(`${String(i + 1)}. [${r.score.toFixed(2)}] ${path}`);
-                const preview = r.highlight ?? r.content.slice(0, 150).replace(/\n/g, ' ') + (r.content.length > 150 ? '...' : '');
-                console.log(`   ${preview}\n`);
+                console.log(path);
+              }
+            } else {
+              console.log(`\nSearch: "${query}"`);
+              console.log(
+                `Mode: ${results.mode} | Detail: ${String(options.detail)} | Stores: ${String(results.stores.length)} | Results: ${String(results.totalResults)} | Time: ${String(results.timeMs)}ms\n`
+              );
+
+              if (results.results.length === 0) {
+                console.log('No results found.\n');
+              } else {
+                for (let i = 0; i < results.results.length; i++) {
+                  const r = results.results[i];
+                  if (r === undefined) continue;
+
+                  if (r.summary) {
+                    console.log(
+                      `${String(i + 1)}. [${r.score.toFixed(2)}] ${r.summary.type}: ${r.summary.name}`
+                    );
+                    console.log(`   ${r.summary.location}`);
+                    console.log(`   ${r.summary.purpose}`);
+
+                    if (r.context && options.detail !== 'minimal') {
+                      console.log(`   Imports: ${r.context.keyImports.slice(0, 3).join(', ')}`);
+                      console.log(
+                        `   Related: ${r.context.relatedConcepts.slice(0, 3).join(', ')}`
+                      );
+                    }
+
+                    console.log();
+                  } else {
+                    // Display without summary
+                    const path = r.metadata.path ?? r.metadata.url ?? 'unknown';
+                    console.log(`${String(i + 1)}. [${r.score.toFixed(2)}] ${path}`);
+                    const preview =
+                      r.highlight ??
+                      r.content.slice(0, 150).replace(/\n/g, ' ') +
+                        (r.content.length > 150 ? '...' : '');
+                    console.log(`   ${preview}\n`);
+                  }
+                }
               }
             }
           }
+        } finally {
+          await destroyServices(services);
+        }
+
+        if (exitCode !== 0) {
+          process.exit(exitCode);
         }
-      } finally {
-        await destroyServices(services);
       }
-    });
+    );
 
   return search;
 }