bluera-knowledge 0.9.31 → 0.9.32

package/dist/workers/background-worker-cli.js

@@ -1,13 +1,13 @@
 #!/usr/bin/env node
 import {
   IntelligentCrawler
-} from "../chunk-2SJHNRXD.js";
+} from "../chunk-RST4XGRL.js";
 import {
   JobService,
   createDocumentId,
   createServices,
   createStoreId
-} from "../chunk-RWSXP3PQ.js";
+} from "../chunk-6PBP5DVD.js";
 import "../chunk-L2YVNC63.js";
 
 // src/workers/background-worker-cli.ts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bluera-knowledge",
-  "version": "0.9.31",
+  "version": "0.9.32",
   "description": "CLI tool for managing knowledge stores with semantic search",
   "type": "module",
   "bin": {

package/src/cli/commands/crawl.ts

@@ -82,6 +82,7 @@ export function createCrawlCommand(getOptions: () => GlobalOptions): Command {
       const webChunker = ChunkingService.forContentType('web');
       let pagesIndexed = 0;
       let chunksCreated = 0;
+      let exitCode = 0;
 
       // Listen for progress events
       crawler.on('progress', (progress: CrawlProgress) => {
@@ -184,10 +185,14 @@ export function createCrawlCommand(getOptions: () => GlobalOptions): Command {
         } else {
           console.error(`Error: ${message}`);
         }
-        process.exit(6);
+        exitCode = 6;
       } finally {
         await crawler.stop();
         await destroyServices(services);
       }
+
+      if (exitCode !== 0) {
+        process.exit(exitCode);
+      }
     });
 }

package/src/db/lance.test.ts

@@ -323,6 +323,65 @@ describe('LanceStore', () => {
     });
   });
 
+  describe('closeAsync', () => {
+    it('returns a promise that resolves after cleanup', async () => {
+      const asyncCloseStoreId = createStoreId('async-close-test');
+      const asyncStore = new LanceStore(tempDir);
+      await asyncStore.initialize(asyncCloseStoreId);
+
+      const doc = {
+        id: createDocumentId('async-close-doc'),
+        content: 'test content for async close',
+        vector: new Array(384).fill(0.1),
+        metadata: {
+          type: 'file' as const,
+          storeId: asyncCloseStoreId,
+          indexedAt: new Date(),
+        },
+      };
+
+      await asyncStore.addDocuments(asyncCloseStoreId, [doc]);
+
+      // closeAsync should return a promise
+      const result = asyncStore.closeAsync();
+      expect(result).toBeInstanceOf(Promise);
+      await expect(result).resolves.not.toThrow();
+    });
+
+    it('handles closeAsync when never initialized', async () => {
+      const uninitializedStore = new LanceStore(tempDir);
+
+      // Should not throw even when never initialized
+      await expect(uninitializedStore.closeAsync()).resolves.not.toThrow();
+    });
+
+    it('allows native threads time to complete', async () => {
+      const timedStoreId = createStoreId('timed-close-test');
+      const timedStore = new LanceStore(tempDir);
+      await timedStore.initialize(timedStoreId);
+
+      const doc = {
+        id: createDocumentId('timed-doc'),
+        content: 'test',
+        vector: new Array(384).fill(0.1),
+        metadata: {
+          type: 'file' as const,
+          storeId: timedStoreId,
+          indexedAt: new Date(),
+        },
+      };
+
+      await timedStore.addDocuments(timedStoreId, [doc]);
+
+      const startTime = Date.now();
+      await timedStore.closeAsync();
+      const elapsed = Date.now() - startTime;
+
+      // Should take at least some time for native cleanup
+      expect(elapsed).toBeGreaterThanOrEqual(50);
+    });
+  });
+
   describe('multiple documents operations', () => {
     it('adds multiple documents at once', async () => {
       const multiStoreId = createStoreId('multi-doc-store');

package/src/db/lance.ts

@@ -153,6 +153,21 @@ export class LanceStore {
     }
   }
 
+  /**
+   * Async close that allows native code cleanup time.
+   * Use this before process.exit() to prevent mutex crashes.
+   */
+  async closeAsync(): Promise<void> {
+    this.tables.clear();
+    if (this.connection !== null) {
+      this.connection.close();
+      this.connection = null;
+      // Allow native threads time to complete cleanup
+      // LanceDB's native code has background threads that need time
+      await new Promise((resolve) => setTimeout(resolve, 100));
+    }
+  }
+
   private getTableName(storeId: StoreId): string {
     return `documents_${storeId}`;
   }

package/src/services/index.ts

@@ -80,7 +80,8 @@ export async function createServices(
 export async function destroyServices(services: ServiceContainer): Promise<void> {
   logger.info('Shutting down services');
   try {
-    services.lance.close();
+    // Use async close to allow native threads time to cleanup
+    await services.lance.closeAsync();
   } catch (e) {
     logger.error({ error: e }, 'Error closing LanceStore');
   }

package/src/services/services.test.ts

@@ -1,9 +1,11 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import { destroyServices, type ServiceContainer } from './index.js';
 import type { PythonBridge } from '../crawl/bridge.js';
+import type { LanceStore } from '../db/lance.js';
 
 describe('destroyServices', () => {
   let mockPythonBridge: { stop: ReturnType<typeof vi.fn> };
+  let mockLance: { closeAsync: ReturnType<typeof vi.fn>; close: ReturnType<typeof vi.fn> };
   let mockServices: ServiceContainer;
 
   beforeEach(() => {
@@ -11,8 +13,14 @@ describe('destroyServices', () => {
       stop: vi.fn().mockResolvedValue(undefined),
     };
 
+    mockLance = {
+      closeAsync: vi.fn().mockResolvedValue(undefined),
+      close: vi.fn(),
+    };
+
     mockServices = {
       pythonBridge: mockPythonBridge as unknown as PythonBridge,
+      lance: mockLance as unknown as LanceStore,
     } as unknown as ServiceContainer;
   });
 
@@ -35,4 +43,32 @@ describe('destroyServices', () => {
 
     expect(mockPythonBridge.stop).toHaveBeenCalledTimes(2);
   });
+
+  it('calls closeAsync on LanceStore for native cleanup', async () => {
+    await destroyServices(mockServices);
+
+    expect(mockLance.closeAsync).toHaveBeenCalledTimes(1);
+    // Should use async version, not sync
+    expect(mockLance.close).not.toHaveBeenCalled();
+  });
+
+  it('handles LanceStore closeAsync errors gracefully', async () => {
+    mockLance.closeAsync.mockRejectedValue(new Error('closeAsync failed'));
+
+    // Should not throw even if closeAsync fails
+    await expect(destroyServices(mockServices)).resolves.not.toThrow();
+  });
+
+  it('waits for LanceStore async cleanup before returning', async () => {
+    let closeCompleted = false;
+    mockLance.closeAsync.mockImplementation(async () => {
+      await new Promise(resolve => setTimeout(resolve, 50));
+      closeCompleted = true;
+    });
+
+    await destroyServices(mockServices);
+
+    // Should have waited for closeAsync to complete
+    expect(closeCompleted).toBe(true);
+  });
 });

package/tests/integration/e2e-workflow.test.ts

@@ -70,6 +70,8 @@ describe('E2E Workflow Tests', () => {
   }, 30000);
 
   afterAll(async () => {
+    // Close LanceStore to prevent mutex crash during process exit
+    lanceStore.close();
     await rm(tempDir, { recursive: true, force: true });
   });
 

package/BUGS-FOUND.md

@@ -1,71 +0,0 @@
-# Bugs Found During API Testing (v0.9.30)
-
-## Fix Status
-
-| Bug | Status | Tests Added | Notes |
-|-----|--------|-------------|-------|
-| #1 | **FIXED** | ✅ | URL detection in store.ts |
-| #2 | **PARTIAL** | ✅ | Mutex crash - CLI only, not affecting plugin |
-| #3 | **FIXED** | ✅ | Empty name validation added |
-
----
-
-## Bug #1: `store create --type repo --source <url>` doesn't clone repos
-
-**Status:** FIXED
-
-**File:** `src/cli/commands/store.ts:58-65`
-
-**Fix:** Added URL detection to route to `url` parameter instead of `path`:
-```typescript
-const isUrl = options.source.startsWith('http://') || options.source.startsWith('https://');
-```
-
----
-
-## Bug #2: Non-existent store lookup causes mutex crash (CLI only)
-
-**Status:** PARTIALLY FIXED - Does not affect Claude Code plugin
-
-**Note:** This bug only affects the npm CLI package, not the Claude Code plugin. The MCP server is a long-running process that doesn't call `destroyServices()` on each request.
-
-**Fixes applied:**
-1. Added `close()` method to LanceStore that calls `connection.close()`
-2. Added try-catch around cleanup in `destroyServices()`
-3. Moved `process.exit()` after `finally` block
-
-**Remaining issue:** Native code mutex crash still occurs during CLI cleanup. This appears to be a race condition in LanceDB's native code during process exit.
-
----
-
-## Bug #3: Empty store name accepted
-
-**Status:** FIXED
-
-**File:** `src/services/store.service.ts:39-42`
-
-**Fix:** Added validation at start of `create()`:
-```typescript
-if (!input.name || input.name.trim() === '') {
-  return err(new Error('Store name cannot be empty'));
-}
-```
-
----
-
-## Files Modified
-
-1. `src/cli/commands/store.ts` - Bug #1 fix (URL detection)
-2. `src/db/lance.ts` - Bug #2 fix (added close() method)
-3. `src/services/index.ts` - Bug #2 fix (cleanup with try-catch)
-4. `src/services/store.service.ts` - Bug #3 fix (empty name validation)
-
----
-
-## Test Results After Fixes
-
-| Feature | Status |
-|---------|--------|
-| `store create --type repo --source <url>` | **FIXED** - Now clones correctly |
-| Empty store name validation | **FIXED** - Returns error |
-| Mutex crash on error (CLI) | PARTIAL - Still crashes but doesn't affect plugin |