bloby-bot 0.46.3 → 0.47.1

package/bin/cli.js

@@ -17,13 +17,34 @@ const CONFIG_PATH = path.join(DATA_DIR, 'config.json');
 const BIN_DIR = path.join(DATA_DIR, 'bin');
 const CF_PATH = path.join(BIN_DIR, 'cloudflared');
 
-// ── Ensure dependencies exist (self-heal if postinstall npm install failed) ──
-if (!IS_DEV && !fs.existsSync(path.join(ROOT, 'node_modules', 'viem'))) {
+// ── Ensure dependencies exist (self-heal if postinstall/update npm install failed) ──
+// Check every declared dep, not just one sentinel: a release that adds a new
+// dep would otherwise silently boot into an `ERR_MODULE_NOT_FOUND` crash loop.
+function missingDeps(root) {
+  let deps;
   try {
-    execSync('npm install --omit=dev', { cwd: ROOT, stdio: 'inherit' });
+    deps = JSON.parse(fs.readFileSync(path.join(root, 'package.json'), 'utf-8')).dependencies || {};
   } catch {
-    console.error('\n  ✗  Failed to install dependencies. Run manually:\n      cd ~/.bloby && npm install\n');
-    process.exit(1);
+    return [];
+  }
+  return Object.keys(deps).filter(d => !fs.existsSync(path.join(root, 'node_modules', d, 'package.json')));
+}
+
+if (!IS_DEV) {
+  const missing = missingDeps(ROOT);
+  if (missing.length > 0) {
+    console.error(`\n  Installing missing dependencies: ${missing.slice(0, 5).join(', ')}${missing.length > 5 ? `, +${missing.length - 5} more` : ''}\n`);
+    try {
+      execSync('npm install --omit=dev', { cwd: ROOT, stdio: 'inherit' });
+    } catch {
+      console.error('\n  ✗  Failed to install dependencies. Run manually:\n      cd ~/.bloby && npm install\n');
+      process.exit(1);
+    }
+    const stillMissing = missingDeps(ROOT);
+    if (stillMissing.length > 0) {
+      console.error(`\n  ✗  Dependencies still missing after npm install: ${stillMissing.join(', ')}\n      Try: cd ~/.bloby && rm -rf node_modules package-lock.json && npm install --omit=dev\n`);
+      process.exit(1);
+    }
   }
 }
 
@@ -1498,11 +1519,24 @@ async function update() {
 
   const distDst = path.join(DATA_DIR, 'dist-bloby');
 
-  // Install dependencies (5 min timeout to prevent hanging forever)
+  // Install dependencies (5 min timeout to prevent hanging forever).
+  // A failed install while new source files are already in place leaves the
+  // app permanently broken (e.g. crash loop on a new import). Treat as fatal,
+  // surface the npm output so the cause is debuggable, and don't claim success.
   try {
-    execSync('npm install --omit=dev', { cwd: DATA_DIR, stdio: 'ignore', timeout: 300_000 });
+    execSync('npm install --omit=dev', { cwd: DATA_DIR, stdio: 'inherit', timeout: 300_000 });
   } catch (e) {
-    console.log(`  ${c.yellow}⚠${c.reset}  npm install issue: ${e.message}`);
+    console.log(`\n  ${c.red}✗${c.reset}  npm install failed during update: ${e.message}`);
+    console.log(`    Your install is now partially upgraded. To recover:\n      cd ~/.bloby && npm install --omit=dev\n`);
+    fs.rmSync(tmpDir, { recursive: true, force: true });
+    process.exit(1);
+  }
+  const stillMissing = missingDeps(DATA_DIR);
+  if (stillMissing.length > 0) {
+    console.log(`\n  ${c.red}✗${c.reset}  npm install reported success but these deps are missing: ${stillMissing.join(', ')}`);
+    console.log(`    Try: cd ~/.bloby && rm -rf node_modules package-lock.json && npm install --omit=dev\n`);
+    fs.rmSync(tmpDir, { recursive: true, force: true });
+    process.exit(1);
   }
   stepper.advance();