bl 3.0.1 → 4.0.3

package/test/test.js

@@ -1,21 +1,23 @@
 'use strict'
 
-var tape       = require('tape')
-  , crypto     = require('crypto')
-  , fs         = require('fs')
-  , hash       = require('hash_file')
-  , BufferList = require('../')
-  , Buffer     = require('safe-buffer').Buffer
-
-  , encodings  =
-      ('hex utf8 utf-8 ascii binary base64'
-          + (process.browser ? '' : ' ucs2 ucs-2 utf16le utf-16le')).split(' ')
-
-// run the indexOf tests
+const tape = require('tape')
+const crypto = require('crypto')
+const fs = require('fs')
+const path = require('path')
+const BufferList = require('../')
+const { Buffer } = require('buffer')
+
+const encodings =
+      ('hex utf8 utf-8 ascii binary base64' +
+          (process.browser ? '' : ' ucs2 ucs-2 utf16le utf-16le')).split(' ')
+
 require('./indexOf')
+require('./isBufferList')
+require('./convert')
 
 tape('single bytes from single buffer', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
+
   bl.append(Buffer.from('abcd'))
 
   t.equal(bl.length, 4)
@@ -30,7 +32,8 @@ tape('single bytes from single buffer', function (t) {
 })
 
 tape('single bytes from multiple buffers', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
+
   bl.append(Buffer.from('abcd'))
   bl.append(Buffer.from('efg'))
   bl.append(Buffer.from('hi'))
@@ -48,11 +51,13 @@ tape('single bytes from multiple buffers', function (t) {
   t.equal(bl.get(7), 104)
   t.equal(bl.get(8), 105)
   t.equal(bl.get(9), 106)
+
   t.end()
 })
 
 tape('multi bytes from single buffer', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
+
   bl.append(Buffer.from('abcd'))
 
   t.equal(bl.length, 4)
@@ -66,7 +71,8 @@ tape('multi bytes from single buffer', function (t) {
 })
 
 tape('multi bytes from single buffer (negative indexes)', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
+
   bl.append(Buffer.from('buffer'))
 
   t.equal(bl.length, 6)
@@ -79,7 +85,7 @@ tape('multi bytes from single buffer (negative indexes)', function (t) {
 })
 
 tape('multiple bytes from multiple buffers', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
 
   bl.append(Buffer.from('abcd'))
   bl.append(Buffer.from('efg'))
@@ -99,10 +105,10 @@ tape('multiple bytes from multiple buffers', function (t) {
 })
 
 tape('multiple bytes from multiple buffer lists', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
 
-  bl.append(new BufferList([ Buffer.from('abcd'), Buffer.from('efg') ]))
-  bl.append(new BufferList([ Buffer.from('hi'), Buffer.from('j') ]))
+  bl.append(new BufferList([Buffer.from('abcd'), Buffer.from('efg')]))
+  bl.append(new BufferList([Buffer.from('hi'), Buffer.from('j')]))
 
   t.equal(bl.length, 10)
 
@@ -118,16 +124,16 @@ tape('multiple bytes from multiple buffer lists', function (t) {
 
 // same data as previous test, just using nested constructors
 tape('multiple bytes from crazy nested buffer lists', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
 
   bl.append(new BufferList([
-      new BufferList([
-          new BufferList(Buffer.from('abc'))
-        , Buffer.from('d')
-        , new BufferList(Buffer.from('efg'))
-      ])
-    , new BufferList([ Buffer.from('hi') ])
-    , new BufferList(Buffer.from('j'))
+    new BufferList([
+      new BufferList(Buffer.from('abc')),
+      Buffer.from('d'),
+      new BufferList(Buffer.from('efg'))
+    ]),
+    new BufferList([Buffer.from('hi')]),
+    new BufferList(Buffer.from('j'))
   ]))
 
   t.equal(bl.length, 10)
@@ -143,49 +149,69 @@ tape('multiple bytes from crazy nested buffer lists', function (t) {
 })
 
 tape('append accepts arrays of Buffers', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
+
   bl.append(Buffer.from('abc'))
-  bl.append([ Buffer.from('def') ])
-  bl.append([ Buffer.from('ghi'), Buffer.from('jkl') ])
-  bl.append([ Buffer.from('mnop'), Buffer.from('qrstu'), Buffer.from('vwxyz') ])
+  bl.append([Buffer.from('def')])
+  bl.append([Buffer.from('ghi'), Buffer.from('jkl')])
+  bl.append([Buffer.from('mnop'), Buffer.from('qrstu'), Buffer.from('vwxyz')])
   t.equal(bl.length, 26)
   t.equal(bl.slice().toString('ascii'), 'abcdefghijklmnopqrstuvwxyz')
+
+  t.end()
+})
+
+tape('append accepts arrays of Uint8Arrays', function (t) {
+  const bl = new BufferList()
+
+  bl.append(new Uint8Array([97, 98, 99]))
+  bl.append([Uint8Array.from([100, 101, 102])])
+  bl.append([new Uint8Array([103, 104, 105]), new Uint8Array([106, 107, 108])])
+  bl.append([new Uint8Array([109, 110, 111, 112]), new Uint8Array([113, 114, 115, 116, 117]), new Uint8Array([118, 119, 120, 121, 122])])
+  t.equal(bl.length, 26)
+  t.equal(bl.slice().toString('ascii'), 'abcdefghijklmnopqrstuvwxyz')
+
   t.end()
 })
 
 tape('append accepts arrays of BufferLists', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
+
   bl.append(Buffer.from('abc'))
-  bl.append([ new BufferList('def') ])
-  bl.append(new BufferList([ Buffer.from('ghi'), new BufferList('jkl') ]))
-  bl.append([ Buffer.from('mnop'), new BufferList([ Buffer.from('qrstu'), Buffer.from('vwxyz') ]) ])
+  bl.append([new BufferList('def')])
+  bl.append(new BufferList([Buffer.from('ghi'), new BufferList('jkl')]))
+  bl.append([Buffer.from('mnop'), new BufferList([Buffer.from('qrstu'), Buffer.from('vwxyz')])])
   t.equal(bl.length, 26)
   t.equal(bl.slice().toString('ascii'), 'abcdefghijklmnopqrstuvwxyz')
+
   t.end()
 })
 
 tape('append chainable', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
+
   t.ok(bl.append(Buffer.from('abcd')) === bl)
-  t.ok(bl.append([ Buffer.from('abcd') ]) === bl)
+  t.ok(bl.append([Buffer.from('abcd')]) === bl)
   t.ok(bl.append(new BufferList(Buffer.from('abcd'))) === bl)
-  t.ok(bl.append([ new BufferList(Buffer.from('abcd')) ]) === bl)
+  t.ok(bl.append([new BufferList(Buffer.from('abcd'))]) === bl)
+
   t.end()
 })
 
 tape('append chainable (test results)', function (t) {
-  var bl = new BufferList('abc')
-    .append([ new BufferList('def') ])
-    .append(new BufferList([ Buffer.from('ghi'), new BufferList('jkl') ]))
-    .append([ Buffer.from('mnop'), new BufferList([ Buffer.from('qrstu'), Buffer.from('vwxyz') ]) ])
+  const bl = new BufferList('abc')
+    .append([new BufferList('def')])
+    .append(new BufferList([Buffer.from('ghi'), new BufferList('jkl')]))
+    .append([Buffer.from('mnop'), new BufferList([Buffer.from('qrstu'), Buffer.from('vwxyz')])])
 
   t.equal(bl.length, 26)
   t.equal(bl.slice().toString('ascii'), 'abcdefghijklmnopqrstuvwxyz')
+
   t.end()
 })
 
 tape('consuming from multiple buffers', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
 
   bl.append(Buffer.from('abcd'))
   bl.append(Buffer.from('efg'))
@@ -220,7 +246,7 @@ tape('consuming from multiple buffers', function (t) {
 })
 
 tape('complete consumption', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
 
   bl.append(Buffer.from('a'))
   bl.append(Buffer.from('b'))
@@ -234,10 +260,10 @@ tape('complete consumption', function (t) {
 })
 
 tape('test readUInt8 / readInt8', function (t) {
-  var buf1 = Buffer.alloc(1)
-    , buf2 = Buffer.alloc(3)
-    , buf3 = Buffer.alloc(3)
-    , bl  = new BufferList()
+  const buf1 = Buffer.alloc(1)
+  const buf2 = Buffer.alloc(3)
+  const buf3 = Buffer.alloc(3)
+  const bl = new BufferList()
 
   buf2[1] = 0x3
   buf2[2] = 0x4
@@ -256,14 +282,15 @@ tape('test readUInt8 / readInt8', function (t) {
   t.equal(bl.readInt8(4), 0x23)
   t.equal(bl.readUInt8(5), 0x42)
   t.equal(bl.readInt8(5), 0x42)
+
   t.end()
 })
 
 tape('test readUInt16LE / readUInt16BE / readInt16LE / readInt16BE', function (t) {
-  var buf1 = Buffer.alloc(1)
-    , buf2 = Buffer.alloc(3)
-    , buf3 = Buffer.alloc(3)
-    , bl   = new BufferList()
+  const buf1 = Buffer.alloc(1)
+  const buf2 = Buffer.alloc(3)
+  const buf3 = Buffer.alloc(3)
+  const bl = new BufferList()
 
   buf2[1] = 0x3
   buf2[2] = 0x4
@@ -286,14 +313,15 @@ tape('test readUInt16LE / readUInt16BE / readInt16LE / readInt16BE', function (t
   t.equal(bl.readUInt16LE(4), 0x4223)
   t.equal(bl.readInt16BE(4), 0x2342)
   t.equal(bl.readInt16LE(4), 0x4223)
+
   t.end()
 })
 
 tape('test readUInt32LE / readUInt32BE / readInt32LE / readInt32BE', function (t) {
-  var buf1 = Buffer.alloc(1)
-    , buf2 = Buffer.alloc(3)
-    , buf3 = Buffer.alloc(3)
-    , bl   = new BufferList()
+  const buf1 = Buffer.alloc(1)
+  const buf2 = Buffer.alloc(3)
+  const buf3 = Buffer.alloc(3)
+  const bl = new BufferList()
 
   buf2[1] = 0x3
   buf2[2] = 0x4
@@ -308,14 +336,15 @@ tape('test readUInt32LE / readUInt32BE / readInt32LE / readInt32BE', function (t
   t.equal(bl.readUInt32LE(2), 0x42230403)
   t.equal(bl.readInt32BE(2), 0x03042342)
   t.equal(bl.readInt32LE(2), 0x42230403)
+
   t.end()
 })
 
 tape('test readUIntLE / readUIntBE / readIntLE / readIntBE', function (t) {
-  var buf1 = Buffer.alloc(1)
-    , buf2 = Buffer.alloc(3)
-    , buf3 = Buffer.alloc(3)
-    , bl   = new BufferList()
+  const buf1 = Buffer.alloc(1)
+  const buf2 = Buffer.alloc(3)
+  const buf3 = Buffer.alloc(3)
+  const bl = new BufferList()
 
   buf2[0] = 0x2
   buf2[1] = 0x3
@@ -352,14 +381,15 @@ tape('test readUIntLE / readUIntBE / readIntLE / readIntBE', function (t) {
   t.equal(bl.readIntLE(1, 4), 0x23040302)
   t.equal(bl.readIntLE(1, 5), 0x4223040302)
   t.equal(bl.readIntLE(1, 6), 0x614223040302)
+
   t.end()
 })
 
 tape('test readFloatLE / readFloatBE', function (t) {
-  var buf1 = Buffer.alloc(1)
-    , buf2 = Buffer.alloc(3)
-    , buf3 = Buffer.alloc(3)
-    , bl   = new BufferList()
+  const buf1 = Buffer.alloc(1)
+  const buf2 = Buffer.alloc(3)
+  const buf3 = Buffer.alloc(3)
+  const bl = new BufferList()
 
   buf2[1] = 0x00
   buf2[2] = 0x00
@@ -371,14 +401,15 @@ tape('test readFloatLE / readFloatBE', function (t) {
   bl.append(buf3)
 
   t.equal(bl.readFloatLE(2), 0x01)
+
   t.end()
 })
 
 tape('test readDoubleLE / readDoubleBE', function (t) {
-  var buf1 = Buffer.alloc(1)
-    , buf2 = Buffer.alloc(3)
-    , buf3 = Buffer.alloc(10)
-    , bl   = new BufferList()
+  const buf1 = Buffer.alloc(1)
+  const buf2 = Buffer.alloc(3)
+  const buf3 = Buffer.alloc(10)
+  const bl = new BufferList()
 
   buf2[1] = 0x55
   buf2[2] = 0x55
@@ -394,11 +425,12 @@ tape('test readDoubleLE / readDoubleBE', function (t) {
   bl.append(buf3)
 
   t.equal(bl.readDoubleLE(2), 0.3333333333333333)
+
   t.end()
 })
 
 tape('test toString', function (t) {
-  var bl = new BufferList()
+  const bl = new BufferList()
 
   bl.append(Buffer.from('abcd'))
   bl.append(Buffer.from('efg'))
@@ -415,8 +447,8 @@ tape('test toString', function (t) {
 })
 
 tape('test toString encoding', function (t) {
-  var bl = new BufferList()
-    , b  = Buffer.from('abcdefghij\xff\x00')
+  const bl = new BufferList()
+  const b = Buffer.from('abcdefghij\xff\x00')
 
   bl.append(Buffer.from('abcd'))
   bl.append(Buffer.from('efg'))
@@ -425,8 +457,8 @@ tape('test toString encoding', function (t) {
   bl.append(Buffer.from('\xff\x00'))
 
   encodings.forEach(function (enc) {
-      t.equal(bl.toString(enc), b.toString(enc), enc)
-    })
+    t.equal(bl.toString(enc), b.toString(enc), enc)
+  })
 
   t.end()
 })
@@ -448,45 +480,47 @@ tape('uninitialized memory', function (t) {
 })
 
 !process.browser && tape('test stream', function (t) {
-  var random = crypto.randomBytes(65534)
-    , rndhash = hash(random, 'md5')
-    , md5sum = crypto.createHash('md5')
-    , bl     = new BufferList(function (err, buf) {
-        t.ok(Buffer.isBuffer(buf))
-        t.ok(err === null)
-        t.equal(rndhash, hash(bl.slice(), 'md5'))
-        t.equal(rndhash, hash(buf, 'md5'))
-
-        bl.pipe(fs.createWriteStream('/tmp/bl_test_rnd_out.dat'))
-          .on('close', function () {
-            var s = fs.createReadStream('/tmp/bl_test_rnd_out.dat')
-            s.on('data', md5sum.update.bind(md5sum))
-            s.on('end', function() {
-              t.equal(rndhash, md5sum.digest('hex'), 'woohoo! correct hash!')
-              t.end()
-            })
-          })
-
+  const random = crypto.randomBytes(65534)
+
+  const bl = new BufferList((err, buf) => {
+    t.ok(Buffer.isBuffer(buf))
+    t.ok(err === null)
+    t.ok(random.equals(bl.slice()))
+    t.ok(random.equals(buf.slice()))
+
+    bl.pipe(fs.createWriteStream('/tmp/bl_test_rnd_out.dat'))
+      .on('close', function () {
+        const rndhash = crypto.createHash('md5').update(random).digest('hex')
+        const md5sum = crypto.createHash('md5')
+        const s = fs.createReadStream('/tmp/bl_test_rnd_out.dat')
+
+        s.on('data', md5sum.update.bind(md5sum))
+        s.on('end', function () {
+          t.equal(rndhash, md5sum.digest('hex'), 'woohoo! correct hash!')
+          t.end()
+        })
       })
+  })
 
   fs.writeFileSync('/tmp/bl_test_rnd.dat', random)
   fs.createReadStream('/tmp/bl_test_rnd.dat').pipe(bl)
 })
 
 tape('instantiation with Buffer', function (t) {
-  var buf  = crypto.randomBytes(1024)
-    , buf2 = crypto.randomBytes(1024)
-    , b    = BufferList(buf)
+  const buf = crypto.randomBytes(1024)
+  const buf2 = crypto.randomBytes(1024)
+  let b = BufferList(buf)
 
   t.equal(buf.toString('hex'), b.slice().toString('hex'), 'same buffer')
-  b = BufferList([ buf, buf2 ])
-  t.equal(b.slice().toString('hex'), Buffer.concat([ buf, buf2 ]).toString('hex'), 'same buffer')
+  b = BufferList([buf, buf2])
+  t.equal(b.slice().toString('hex'), Buffer.concat([buf, buf2]).toString('hex'), 'same buffer')
+
   t.end()
 })
 
 tape('test String appendage', function (t) {
-  var bl = new BufferList()
-    , b  = Buffer.from('abcdefghij\xff\x00')
+  const bl = new BufferList()
+  const b = Buffer.from('abcdefghij\xff\x00')
 
   bl.append('abcd')
   bl.append('efg')
@@ -495,15 +529,15 @@ tape('test String appendage', function (t) {
   bl.append('\xff\x00')
 
   encodings.forEach(function (enc) {
-      t.equal(bl.toString(enc), b.toString(enc))
-    })
+    t.equal(bl.toString(enc), b.toString(enc))
+  })
 
   t.end()
 })
 
 tape('test Number appendage', function (t) {
-  var bl = new BufferList()
-    , b  = Buffer.from('1234567890')
+  const bl = new BufferList()
+  const b = Buffer.from('1234567890')
 
   bl.append(1234)
   bl.append(567)
@@ -511,8 +545,8 @@ tape('test Number appendage', function (t) {
   bl.append(0)
 
   encodings.forEach(function (enc) {
-      t.equal(bl.toString(enc), b.toString(enc))
-    })
+    t.equal(bl.toString(enc), b.toString(enc))
+  })
 
   t.end()
 })
@@ -529,10 +563,12 @@ tape('write nothing, should get empty buffer', function (t) {
 
 tape('unicode string', function (t) {
   t.plan(2)
-  var inp1 = '\u2600'
-    , inp2 = '\u2603'
-    , exp = inp1 + ' and ' + inp2
-    , bl = BufferList()
+
+  const inp1 = '\u2600'
+  const inp2 = '\u2603'
+  const exp = inp1 + ' and ' + inp2
+  const bl = BufferList()
+
   bl.write(inp1)
   bl.write(' and ')
   bl.write(inp2)
@@ -541,8 +577,8 @@ tape('unicode string', function (t) {
 })
 
 tape('should emit finish', function (t) {
-  var source = BufferList()
-    , dest = BufferList()
+  const source = BufferList()
+  const dest = BufferList()
 
   source.write('hello')
   source.pipe(dest)
@@ -554,90 +590,100 @@ tape('should emit finish', function (t) {
 })
 
 tape('basic copy', function (t) {
-  var buf  = crypto.randomBytes(1024)
-    , buf2 = Buffer.alloc(1024)
-    , b    = BufferList(buf)
+  const buf = crypto.randomBytes(1024)
+  const buf2 = Buffer.alloc(1024)
+  const b = BufferList(buf)
 
   b.copy(buf2)
   t.equal(b.slice().toString('hex'), buf2.toString('hex'), 'same buffer')
+
   t.end()
 })
 
 tape('copy after many appends', function (t) {
-  var buf  = crypto.randomBytes(512)
-    , buf2 = Buffer.alloc(1024)
-    , b    = BufferList(buf)
+  const buf = crypto.randomBytes(512)
+  const buf2 = Buffer.alloc(1024)
+  const b = BufferList(buf)
 
   b.append(buf)
   b.copy(buf2)
   t.equal(b.slice().toString('hex'), buf2.toString('hex'), 'same buffer')
+
   t.end()
 })
 
 tape('copy at a precise position', function (t) {
-  var buf  = crypto.randomBytes(1004)
-    , buf2 = Buffer.alloc(1024)
-    , b    = BufferList(buf)
+  const buf = crypto.randomBytes(1004)
+  const buf2 = Buffer.alloc(1024)
+  const b = BufferList(buf)
 
   b.copy(buf2, 20)
   t.equal(b.slice().toString('hex'), buf2.slice(20).toString('hex'), 'same buffer')
+
   t.end()
 })
 
 tape('copy starting from a precise location', function (t) {
-  var buf  = crypto.randomBytes(10)
-    , buf2 = Buffer.alloc(5)
-    , b    = BufferList(buf)
+  const buf = crypto.randomBytes(10)
+  const buf2 = Buffer.alloc(5)
+  const b = BufferList(buf)
 
   b.copy(buf2, 0, 5)
   t.equal(b.slice(5).toString('hex'), buf2.toString('hex'), 'same buffer')
+
   t.end()
 })
 
 tape('copy in an interval', function (t) {
-  var rnd      = crypto.randomBytes(10)
-    , b        = BufferList(rnd) // put the random bytes there
-    , actual   = Buffer.alloc(3)
-    , expected = Buffer.alloc(3)
+  const rnd = crypto.randomBytes(10)
+  const b = BufferList(rnd) // put the random bytes there
+  const actual = Buffer.alloc(3)
+  const expected = Buffer.alloc(3)
 
   rnd.copy(expected, 0, 5, 8)
   b.copy(actual, 0, 5, 8)
 
   t.equal(actual.toString('hex'), expected.toString('hex'), 'same buffer')
+
   t.end()
 })
 
 tape('copy an interval between two buffers', function (t) {
-  var buf      = crypto.randomBytes(10)
-    , buf2     = Buffer.alloc(10)
-    , b        = BufferList(buf)
+  const buf = crypto.randomBytes(10)
+  const buf2 = Buffer.alloc(10)
+  const b = BufferList(buf)
 
   b.append(buf)
   b.copy(buf2, 0, 5, 15)
 
   t.equal(b.slice(5, 15).toString('hex'), buf2.toString('hex'), 'same buffer')
+
   t.end()
 })
 
 tape('shallow slice across buffer boundaries', function (t) {
-  var bl = new BufferList(['First', 'Second', 'Third'])
+  const bl = new BufferList(['First', 'Second', 'Third'])
 
   t.equal(bl.shallowSlice(3, 13).toString(), 'stSecondTh')
+
   t.end()
 })
 
 tape('shallow slice within single buffer', function (t) {
   t.plan(2)
-  var bl = new BufferList(['First', 'Second', 'Third'])
+
+  const bl = new BufferList(['First', 'Second', 'Third'])
 
   t.equal(bl.shallowSlice(5, 10).toString(), 'Secon')
   t.equal(bl.shallowSlice(7, 10).toString(), 'con')
+
   t.end()
 })
 
 tape('shallow slice single buffer', function (t) {
   t.plan(3)
-  var bl = new BufferList(['First', 'Second', 'Third'])
+
+  const bl = new BufferList(['First', 'Second', 'Third'])
 
   t.equal(bl.shallowSlice(0, 5).toString(), 'First')
   t.equal(bl.shallowSlice(5, 11).toString(), 'Second')
@@ -646,7 +692,8 @@ tape('shallow slice single buffer', function (t) {
 
 tape('shallow slice with negative or omitted indices', function (t) {
   t.plan(4)
-  var bl = new BufferList(['First', 'Second', 'Third'])
+
+  const bl = new BufferList(['First', 'Second', 'Third'])
 
   t.equal(bl.shallowSlice().toString(), 'FirstSecondThird')
   t.equal(bl.shallowSlice(5).toString(), 'SecondThird')
@@ -656,8 +703,9 @@ tape('shallow slice with negative or omitted indices', function (t) {
 
 tape('shallow slice does not make a copy', function (t) {
   t.plan(1)
-  var buffers = [Buffer.from('First'), Buffer.from('Second'), Buffer.from('Third')]
-  var bl = (new BufferList(buffers)).shallowSlice(5, -3)
+
+  const buffers = [Buffer.from('First'), Buffer.from('Second'), Buffer.from('Third')]
+  const bl = (new BufferList(buffers)).shallowSlice(5, -3)
 
   buffers[1].fill('h')
   buffers[2].fill('h')
@@ -667,23 +715,27 @@ tape('shallow slice does not make a copy', function (t) {
 
 tape('shallow slice with 0 length', function (t) {
   t.plan(1)
-  var buffers = [Buffer.from('First'), Buffer.from('Second'), Buffer.from('Third')]
-  var bl = (new BufferList(buffers)).shallowSlice(0, 0)
+
+  const buffers = [Buffer.from('First'), Buffer.from('Second'), Buffer.from('Third')]
+  const bl = (new BufferList(buffers)).shallowSlice(0, 0)
+
   t.equal(bl.length, 0)
 })
 
 tape('shallow slice with 0 length from middle', function (t) {
   t.plan(1)
-  var buffers = [Buffer.from('First'), Buffer.from('Second'), Buffer.from('Third')]
-  var bl = (new BufferList(buffers)).shallowSlice(10, 10)
+
+  const buffers = [Buffer.from('First'), Buffer.from('Second'), Buffer.from('Third')]
+  const bl = (new BufferList(buffers)).shallowSlice(10, 10)
+
   t.equal(bl.length, 0)
 })
 
 tape('duplicate', function (t) {
   t.plan(2)
 
-  var bl = new BufferList('abcdefghij\xff\x00')
-    , dup = bl.duplicate()
+  const bl = new BufferList('abcdefghij\xff\x00')
+  const dup = bl.duplicate()
 
   t.equal(bl.prototype, dup.prototype)
   t.equal(bl.toString('hex'), dup.toString('hex'))
@@ -692,7 +744,8 @@ tape('duplicate', function (t) {
 tape('destroy no pipe', function (t) {
   t.plan(2)
 
-  var bl = new BufferList('alsdkfja;lsdkfja;lsdk')
+  const bl = new BufferList('alsdkfja;lsdkfja;lsdk')
+
   bl.destroy()
 
   t.equal(bl._bufs.length, 0)
@@ -702,8 +755,9 @@ tape('destroy no pipe', function (t) {
 tape('destroy with error', function (t) {
   t.plan(3)
 
-  var bl = new BufferList('alsdkfja;lsdkfja;lsdk')
-  var err = new Error('kaboom')
+  const bl = new BufferList('alsdkfja;lsdkfja;lsdk')
+  const err = new Error('kaboom')
+
   bl.destroy(err)
   bl.on('error', function (_err) {
     t.equal(_err, err)
@@ -716,22 +770,22 @@ tape('destroy with error', function (t) {
 !process.browser && tape('destroy with pipe before read end', function (t) {
   t.plan(2)
 
-  var bl = new BufferList()
-  fs.createReadStream(__dirname + '/test.js')
+  const bl = new BufferList()
+  fs.createReadStream(path.join(__dirname, '/test.js'))
     .pipe(bl)
 
   bl.destroy()
 
   t.equal(bl._bufs.length, 0)
   t.equal(bl.length, 0)
-
 })
 
 !process.browser && tape('destroy with pipe before read end with race', function (t) {
   t.plan(2)
 
-  var bl = new BufferList()
-  fs.createReadStream(__dirname + '/test.js')
+  const bl = new BufferList()
+
+  fs.createReadStream(path.join(__dirname, '/test.js'))
     .pipe(bl)
 
   setTimeout(function () {
@@ -746,8 +800,9 @@ tape('destroy with error', function (t) {
 !process.browser && tape('destroy with pipe after read end', function (t) {
   t.plan(2)
 
-  var bl = new BufferList()
-  fs.createReadStream(__dirname + '/test.js')
+  const bl = new BufferList()
+
+  fs.createReadStream(path.join(__dirname, '/test.js'))
     .on('end', onEnd)
     .pipe(bl)
 
@@ -762,10 +817,10 @@ tape('destroy with error', function (t) {
 !process.browser && tape('destroy with pipe while writing to a destination', function (t) {
   t.plan(4)
 
-  var bl = new BufferList()
-    , ds = new BufferList()
+  const bl = new BufferList()
+  const ds = new BufferList()
 
-  fs.createReadStream(__dirname + '/test.js')
+  fs.createReadStream(path.join(__dirname, '/test.js'))
     .on('end', onEnd)
     .pipe(bl)
 
@@ -782,13 +837,13 @@ tape('destroy with error', function (t) {
 
       t.equals(bl._bufs.length, 0)
       t.equals(bl.length, 0)
-
     }, 100)
   }
 })
 
 !process.browser && tape('handle error', function (t) {
   t.plan(2)
+
   fs.createReadStream('/does/not/exist').pipe(BufferList(function (err, data) {
     t.ok(err instanceof Error, 'has error')
     t.notOk(data, 'no data')