bl 1.1.2 → 1.2.3

package/.travis.yml

@@ -1,13 +1,13 @@
 sudo: false
 language: node_js
 node_js:
-  - '0.10'
-  - '0.12'
-  - '4'
-  - '5'
-branches:
-  only:
-    - master
+  - '6'
+  - '8'
+  - '10'
+  - '12'
+  - '14'
+  - lts/*
 notifications:
   email:
     - rod@vagg.org
+    - matteo.collina@gmail.com

package/LICENSE.md

@@ -1,7 +1,7 @@
 The MIT License (MIT)
 =====================
 
-Copyright (c) 2014 bl contributors
+Copyright (c) 2013-2016 bl contributors
 ----------------------------------
 
 *bl contributors listed at <https://github.com/rvagg/bl#contributors>*

package/README.md

@@ -87,6 +87,7 @@ bl.pipe(fs.createWriteStream('gibberish.txt'))
   * <a href="#append"><code>bl.<b>append(buffer)</b></code></a>
   * <a href="#get"><code>bl.<b>get(index)</b></code></a>
   * <a href="#slice"><code>bl.<b>slice([ start[, end ] ])</b></code></a>
+  * <a href="#shallowSlice"><code>bl.<b>shallowSlice([ start[, end ] ])</b></code></a>
   * <a href="#copy"><code>bl.<b>copy(dest, [ destStart, [ srcStart [, srcEnd ] ] ])</b></code></a>
   * <a href="#duplicate"><code>bl.<b>duplicate()</b></code></a>
   * <a href="#consume"><code>bl.<b>consume(bytes)</b></code></a>
@@ -107,7 +108,7 @@ Normally, no arguments are required for the constructor, but you can initialise
 var bl = require('bl')
 var myinstance = bl()
 
-// equivilant to:
+// equivalent to:
 
 var BufferList = require('bl')
 var myinstance = new BufferList()
@@ -135,6 +136,13 @@ Get the length of the list in bytes. This is the sum of the lengths of all of th
 
 If the requested range spans a single internal buffer then a slice of that buffer will be returned which shares the original memory range of that Buffer. If the range spans multiple buffers then copy operations will likely occur to give you a uniform Buffer.
 
+--------------------------------------------------------
+<a name="shallowSlice"></a>
+### bl.shallowSlice([ start, [ end ] ])
+`shallowSlice()` returns a new `BufferList` object containing the bytes within the range specified. Both `start` and `end` are optional and will default to the beginning and end of the list respectively.
+
+No copies will be performed. All buffers in the result share memory with the original list.
+
 --------------------------------------------------------
 <a name="copy"></a>
 ### bl.copy(dest, [ destStart, [ srcStart [, srcEnd ] ] ])
@@ -195,6 +203,6 @@ See the <b><code>[Buffer](http://nodejs.org/docs/latest/api/buffer.html)</code><
 <a name="license"></a>
 ## License &amp; copyright
 
-Copyright (c) 2013-2014 bl contributors (listed above).
+Copyright (c) 2013-2016 bl contributors (listed above).
 
 bl is licensed under the MIT license. All rights not explicitly granted in the MIT license are reserved. See the included LICENSE.md file for more details.

package/bl.js

@@ -1,5 +1,6 @@
 var DuplexStream = require('readable-stream/duplex')
   , util         = require('util')
+  , Buffer       = require('safe-buffer').Buffer
 
 
 function BufferList (callback) {
@@ -38,9 +39,10 @@ util.inherits(BufferList, DuplexStream)
 
 BufferList.prototype._offset = function _offset (offset) {
   var tot = 0, i = 0, _t
+  if (offset === 0) return [ 0, 0 ]
   for (; i < this._bufs.length; i++) {
     _t = tot + this._bufs[i].length
-    if (offset < _t)
+    if (offset < _t || i == this._bufs.length - 1)
       return [ i, offset - tot ]
     tot = _t
   }
@@ -49,9 +51,10 @@ BufferList.prototype._offset = function _offset (offset) {
 
 BufferList.prototype.append = function append (buf) {
   var i = 0
-    , newBuf
 
-  if (Array.isArray(buf)) {
+  if (Buffer.isBuffer(buf)) {
+    this._appendBuffer(buf);
+  } else if (Array.isArray(buf)) {
     for (; i < buf.length; i++)
       this.append(buf[i])
   } else if (buf instanceof BufferList) {
@@ -64,17 +67,21 @@ BufferList.prototype.append = function append (buf) {
     if (typeof buf == 'number')
       buf = buf.toString()
 
-    newBuf = Buffer.isBuffer(buf) ? buf : new Buffer(buf)
-    this._bufs.push(newBuf)
-    this.length += newBuf.length
+    this._appendBuffer(Buffer.from(buf));
   }
 
   return this
 }
 
 
+BufferList.prototype._appendBuffer = function appendBuffer (buf) {
+  this._bufs.push(buf)
+  this.length += buf.length
+}
+
+
 BufferList.prototype._write = function _write (buf, encoding, callback) {
-  this.append(buf)
+  this._appendBuffer(buf)
 
   if (typeof callback == 'function')
     callback()
@@ -107,6 +114,10 @@ BufferList.prototype.get = function get (index) {
 
 
 BufferList.prototype.slice = function slice (start, end) {
+  if (typeof start == 'number' && start < 0)
+    start += this.length
+  if (typeof end == 'number' && end < 0)
+    end += this.length
   return this.copy(null, 0, start, end)
 }
 
@@ -117,9 +128,9 @@ BufferList.prototype.copy = function copy (dst, dstStart, srcStart, srcEnd) {
   if (typeof srcEnd != 'number' || srcEnd > this.length)
     srcEnd = this.length
   if (srcStart >= this.length)
-    return dst || new Buffer(0)
+    return dst || Buffer.alloc(0)
   if (srcEnd <= 0)
-    return dst || new Buffer(0)
+    return dst || Buffer.alloc(0)
 
   var copy   = !!dst
     , off    = this._offset(srcStart)
@@ -132,8 +143,11 @@ BufferList.prototype.copy = function copy (dst, dstStart, srcStart, srcEnd) {
 
   // copy/slice everything
   if (srcStart === 0 && srcEnd == this.length) {
-    if (!copy) // slice, just return a full concat
-      return Buffer.concat(this._bufs)
+    if (!copy) { // slice, but full concat if multiple buffers
+      return this._bufs.length === 1
+        ? this._bufs[0]
+        : Buffer.concat(this._bufs, this.length)
+    }
 
     // copy, need to copy individual buffers
     for (i = 0; i < this._bufs.length; i++) {
@@ -152,33 +166,66 @@ BufferList.prototype.copy = function copy (dst, dstStart, srcStart, srcEnd) {
   }
 
   if (!copy) // a slice, we need something to copy in to
-    dst = new Buffer(len)
+    dst = Buffer.allocUnsafe(len)
 
   for (i = off[0]; i < this._bufs.length; i++) {
     l = this._bufs[i].length - start
 
     if (bytes > l) {
       this._bufs[i].copy(dst, bufoff, start)
+      bufoff += l
     } else {
       this._bufs[i].copy(dst, bufoff, start, start + bytes)
+      bufoff += l
       break
     }
 
-    bufoff += l
     bytes -= l
 
     if (start)
       start = 0
   }
 
+  // safeguard so that we don't return uninitialized memory
+  if (dst.length > bufoff) return dst.slice(0, bufoff)
+
   return dst
 }
 
+BufferList.prototype.shallowSlice = function shallowSlice (start, end) {
+  start = start || 0
+  end = end || this.length
+
+  if (start < 0)
+    start += this.length
+  if (end < 0)
+    end += this.length
+
+  var startOffset = this._offset(start)
+    , endOffset = this._offset(end)
+    , buffers = this._bufs.slice(startOffset[0], endOffset[0] + 1)
+
+  if (endOffset[1] == 0)
+    buffers.pop()
+  else
+    buffers[buffers.length-1] = buffers[buffers.length-1].slice(0, endOffset[1])
+
+  if (startOffset[1] != 0)
+    buffers[0] = buffers[0].slice(startOffset[1])
+
+  return new BufferList(buffers)
+}
+
 BufferList.prototype.toString = function toString (encoding, start, end) {
   return this.slice(start, end).toString(encoding)
 }
 
 BufferList.prototype.consume = function consume (bytes) {
+  // first, normalize the argument, in accordance with how Buffer does it
+  bytes = Math.trunc(bytes)
+  // do nothing if not a positive number
+  if (Number.isNaN(bytes) || bytes <= 0) return this
+
   while (this._bufs.length) {
     if (bytes >= this._bufs[0].length) {
       bytes -= this._bufs[0].length

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bl",
-  "version": "1.1.2",
+  "version": "1.2.3",
   "description": "Buffer List: collect buffers and access with a standard readable Buffer interface, streamable too!",
   "main": "bl.js",
   "scripts": {
@@ -24,11 +24,12 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "readable-stream": "~2.0.5"
+    "readable-stream": "^2.3.5",
+    "safe-buffer": "^5.1.1"
   },
   "devDependencies": {
     "faucet": "0.0.1",
     "hash_file": "~0.1.1",
-    "tape": "~4.4.0"
+    "tape": "~4.9.0"
   }
 }

package/test/test.js

@@ -3,6 +3,7 @@ var tape       = require('tape')
   , fs         = require('fs')
   , hash       = require('hash_file')
   , BufferList = require('../')
+  , Buffer     = require('safe-buffer').Buffer
 
   , encodings  =
       ('hex utf8 utf-8 ascii binary base64'
@@ -10,7 +11,7 @@ var tape       = require('tape')
 
 tape('single bytes from single buffer', function (t) {
   var bl = new BufferList()
-  bl.append(new Buffer('abcd'))
+  bl.append(Buffer.from('abcd'))
 
   t.equal(bl.length, 4)
 
@@ -24,10 +25,10 @@ tape('single bytes from single buffer', function (t) {
 
 tape('single bytes from multiple buffers', function (t) {
   var bl = new BufferList()
-  bl.append(new Buffer('abcd'))
-  bl.append(new Buffer('efg'))
-  bl.append(new Buffer('hi'))
-  bl.append(new Buffer('j'))
+  bl.append(Buffer.from('abcd'))
+  bl.append(Buffer.from('efg'))
+  bl.append(Buffer.from('hi'))
+  bl.append(Buffer.from('j'))
 
   t.equal(bl.length, 10)
 
@@ -46,13 +47,27 @@ tape('single bytes from multiple buffers', function (t) {
 
 tape('multi bytes from single buffer', function (t) {
   var bl = new BufferList()
-  bl.append(new Buffer('abcd'))
+  bl.append(Buffer.from('abcd'))
 
   t.equal(bl.length, 4)
 
   t.equal(bl.slice(0, 4).toString('ascii'), 'abcd')
   t.equal(bl.slice(0, 3).toString('ascii'), 'abc')
   t.equal(bl.slice(1, 4).toString('ascii'), 'bcd')
+  t.equal(bl.slice(-4, -1).toString('ascii'), 'abc')
+
+  t.end()
+})
+
+tape('multi bytes from single buffer (negative indexes)', function (t) {
+  var bl = new BufferList()
+  bl.append(Buffer.from('buffer'))
+
+  t.equal(bl.length, 6)
+
+  t.equal(bl.slice(-6, -1).toString('ascii'), 'buffe')
+  t.equal(bl.slice(-6, -2).toString('ascii'), 'buff')
+  t.equal(bl.slice(-5, -2).toString('ascii'), 'uff')
 
   t.end()
 })
@@ -60,10 +75,10 @@ tape('multi bytes from single buffer', function (t) {
 tape('multiple bytes from multiple buffers', function (t) {
   var bl = new BufferList()
 
-  bl.append(new Buffer('abcd'))
-  bl.append(new Buffer('efg'))
-  bl.append(new Buffer('hi'))
-  bl.append(new Buffer('j'))
+  bl.append(Buffer.from('abcd'))
+  bl.append(Buffer.from('efg'))
+  bl.append(Buffer.from('hi'))
+  bl.append(Buffer.from('j'))
 
   t.equal(bl.length, 10)
 
@@ -72,6 +87,7 @@ tape('multiple bytes from multiple buffers', function (t) {
   t.equal(bl.slice(3, 6).toString('ascii'), 'def')
   t.equal(bl.slice(3, 8).toString('ascii'), 'defgh')
   t.equal(bl.slice(5, 10).toString('ascii'), 'fghij')
+  t.equal(bl.slice(-7, -4).toString('ascii'), 'def')
 
   t.end()
 })
@@ -79,8 +95,8 @@ tape('multiple bytes from multiple buffers', function (t) {
 tape('multiple bytes from multiple buffer lists', function (t) {
   var bl = new BufferList()
 
-  bl.append(new BufferList([ new Buffer('abcd'), new Buffer('efg') ]))
-  bl.append(new BufferList([ new Buffer('hi'), new Buffer('j') ]))
+  bl.append(new BufferList([ Buffer.from('abcd'), Buffer.from('efg') ]))
+  bl.append(new BufferList([ Buffer.from('hi'), Buffer.from('j') ]))
 
   t.equal(bl.length, 10)
 
@@ -100,12 +116,12 @@ tape('multiple bytes from crazy nested buffer lists', function (t) {
 
   bl.append(new BufferList([
       new BufferList([
-          new BufferList(new Buffer('abc'))
-        , new Buffer('d')
-        , new BufferList(new Buffer('efg'))
+          new BufferList(Buffer.from('abc'))
+        , Buffer.from('d')
+        , new BufferList(Buffer.from('efg'))
       ])
-    , new BufferList([ new Buffer('hi') ])
-    , new BufferList(new Buffer('j'))
+    , new BufferList([ Buffer.from('hi') ])
+    , new BufferList(Buffer.from('j'))
   ]))
 
   t.equal(bl.length, 10)
@@ -122,10 +138,10 @@ tape('multiple bytes from crazy nested buffer lists', function (t) {
 
 tape('append accepts arrays of Buffers', function (t) {
   var bl = new BufferList()
-  bl.append(new Buffer('abc'))
-  bl.append([ new Buffer('def') ])
-  bl.append([ new Buffer('ghi'), new Buffer('jkl') ])
-  bl.append([ new Buffer('mnop'), new Buffer('qrstu'), new Buffer('vwxyz') ])
+  bl.append(Buffer.from('abc'))
+  bl.append([ Buffer.from('def') ])
+  bl.append([ Buffer.from('ghi'), Buffer.from('jkl') ])
+  bl.append([ Buffer.from('mnop'), Buffer.from('qrstu'), Buffer.from('vwxyz') ])
   t.equal(bl.length, 26)
   t.equal(bl.slice().toString('ascii'), 'abcdefghijklmnopqrstuvwxyz')
   t.end()
@@ -133,10 +149,10 @@ tape('append accepts arrays of Buffers', function (t) {
 
 tape('append accepts arrays of BufferLists', function (t) {
   var bl = new BufferList()
-  bl.append(new Buffer('abc'))
+  bl.append(Buffer.from('abc'))
   bl.append([ new BufferList('def') ])
-  bl.append(new BufferList([ new Buffer('ghi'), new BufferList('jkl') ]))
-  bl.append([ new Buffer('mnop'), new BufferList([ new Buffer('qrstu'), new Buffer('vwxyz') ]) ])
+  bl.append(new BufferList([ Buffer.from('ghi'), new BufferList('jkl') ]))
+  bl.append([ Buffer.from('mnop'), new BufferList([ Buffer.from('qrstu'), Buffer.from('vwxyz') ]) ])
   t.equal(bl.length, 26)
   t.equal(bl.slice().toString('ascii'), 'abcdefghijklmnopqrstuvwxyz')
   t.end()
@@ -144,18 +160,18 @@ tape('append accepts arrays of BufferLists', function (t) {
 
 tape('append chainable', function (t) {
   var bl = new BufferList()
-  t.ok(bl.append(new Buffer('abcd')) === bl)
-  t.ok(bl.append([ new Buffer('abcd') ]) === bl)
-  t.ok(bl.append(new BufferList(new Buffer('abcd'))) === bl)
-  t.ok(bl.append([ new BufferList(new Buffer('abcd')) ]) === bl)
+  t.ok(bl.append(Buffer.from('abcd')) === bl)
+  t.ok(bl.append([ Buffer.from('abcd') ]) === bl)
+  t.ok(bl.append(new BufferList(Buffer.from('abcd'))) === bl)
+  t.ok(bl.append([ new BufferList(Buffer.from('abcd')) ]) === bl)
   t.end()
 })
 
 tape('append chainable (test results)', function (t) {
   var bl = new BufferList('abc')
     .append([ new BufferList('def') ])
-    .append(new BufferList([ new Buffer('ghi'), new BufferList('jkl') ]))
-    .append([ new Buffer('mnop'), new BufferList([ new Buffer('qrstu'), new Buffer('vwxyz') ]) ])
+    .append(new BufferList([ Buffer.from('ghi'), new BufferList('jkl') ]))
+    .append([ Buffer.from('mnop'), new BufferList([ Buffer.from('qrstu'), Buffer.from('vwxyz') ]) ])
 
   t.equal(bl.length, 26)
   t.equal(bl.slice().toString('ascii'), 'abcdefghijklmnopqrstuvwxyz')
@@ -165,10 +181,10 @@ tape('append chainable (test results)', function (t) {
 tape('consuming from multiple buffers', function (t) {
   var bl = new BufferList()
 
-  bl.append(new Buffer('abcd'))
-  bl.append(new Buffer('efg'))
-  bl.append(new Buffer('hi'))
-  bl.append(new Buffer('j'))
+  bl.append(Buffer.from('abcd'))
+  bl.append(Buffer.from('efg'))
+  bl.append(Buffer.from('hi'))
+  bl.append(Buffer.from('j'))
 
   t.equal(bl.length, 10)
 
@@ -200,8 +216,8 @@ tape('consuming from multiple buffers', function (t) {
 tape('complete consumption', function (t) {
   var bl = new BufferList()
 
-  bl.append(new Buffer('a'))
-  bl.append(new Buffer('b'))
+  bl.append(Buffer.from('a'))
+  bl.append(Buffer.from('b'))
 
   bl.consume(2)
 
@@ -212,9 +228,9 @@ tape('complete consumption', function (t) {
 })
 
 tape('test readUInt8 / readInt8', function (t) {
-  var buf1 = new Buffer(1)
-    , buf2 = new Buffer(3)
-    , buf3 = new Buffer(3)
+  var buf1 = Buffer.alloc(1)
+    , buf2 = Buffer.alloc(3)
+    , buf3 = Buffer.alloc(3)
     , bl  = new BufferList()
 
   buf2[1] = 0x3
@@ -238,9 +254,9 @@ tape('test readUInt8 / readInt8', function (t) {
 })
 
 tape('test readUInt16LE / readUInt16BE / readInt16LE / readInt16BE', function (t) {
-  var buf1 = new Buffer(1)
-    , buf2 = new Buffer(3)
-    , buf3 = new Buffer(3)
+  var buf1 = Buffer.alloc(1)
+    , buf2 = Buffer.alloc(3)
+    , buf3 = Buffer.alloc(3)
     , bl   = new BufferList()
 
   buf2[1] = 0x3
@@ -268,9 +284,9 @@ tape('test readUInt16LE / readUInt16BE / readInt16LE / readInt16BE', function (t
 })
 
 tape('test readUInt32LE / readUInt32BE / readInt32LE / readInt32BE', function (t) {
-  var buf1 = new Buffer(1)
-    , buf2 = new Buffer(3)
-    , buf3 = new Buffer(3)
+  var buf1 = Buffer.alloc(1)
+    , buf2 = Buffer.alloc(3)
+    , buf3 = Buffer.alloc(3)
     , bl   = new BufferList()
 
   buf2[1] = 0x3
@@ -290,9 +306,9 @@ tape('test readUInt32LE / readUInt32BE / readInt32LE / readInt32BE', function (t
 })
 
 tape('test readFloatLE / readFloatBE', function (t) {
-  var buf1 = new Buffer(1)
-    , buf2 = new Buffer(3)
-    , buf3 = new Buffer(3)
+  var buf1 = Buffer.alloc(1)
+    , buf2 = Buffer.alloc(3)
+    , buf3 = Buffer.alloc(3)
     , bl   = new BufferList()
 
   buf2[1] = 0x00
@@ -309,9 +325,9 @@ tape('test readFloatLE / readFloatBE', function (t) {
 })
 
 tape('test readDoubleLE / readDoubleBE', function (t) {
-  var buf1 = new Buffer(1)
-    , buf2 = new Buffer(3)
-    , buf3 = new Buffer(10)
+  var buf1 = Buffer.alloc(1)
+    , buf2 = Buffer.alloc(3)
+    , buf3 = Buffer.alloc(10)
     , bl   = new BufferList()
 
   buf2[1] = 0x55
@@ -334,10 +350,10 @@ tape('test readDoubleLE / readDoubleBE', function (t) {
 tape('test toString', function (t) {
   var bl = new BufferList()
 
-  bl.append(new Buffer('abcd'))
-  bl.append(new Buffer('efg'))
-  bl.append(new Buffer('hi'))
-  bl.append(new Buffer('j'))
+  bl.append(Buffer.from('abcd'))
+  bl.append(Buffer.from('efg'))
+  bl.append(Buffer.from('hi'))
+  bl.append(Buffer.from('j'))
 
   t.equal(bl.toString('ascii', 0, 10), 'abcdefghij')
   t.equal(bl.toString('ascii', 3, 10), 'defghij')
@@ -350,13 +366,13 @@ tape('test toString', function (t) {
 
 tape('test toString encoding', function (t) {
   var bl = new BufferList()
-    , b  = new Buffer('abcdefghij\xff\x00')
+    , b  = Buffer.from('abcdefghij\xff\x00')
 
-  bl.append(new Buffer('abcd'))
-  bl.append(new Buffer('efg'))
-  bl.append(new Buffer('hi'))
-  bl.append(new Buffer('j'))
-  bl.append(new Buffer('\xff\x00'))
+  bl.append(Buffer.from('abcd'))
+  bl.append(Buffer.from('efg'))
+  bl.append(Buffer.from('hi'))
+  bl.append(Buffer.from('j'))
+  bl.append(Buffer.from('\xff\x00'))
 
   encodings.forEach(function (enc) {
       t.equal(bl.toString(enc), b.toString(enc), enc)
@@ -365,6 +381,22 @@ tape('test toString encoding', function (t) {
   t.end()
 })
 
+tape('uninitialized memory', function (t) {
+  const secret = crypto.randomBytes(256)
+  for (let i = 0; i < 1e6; i++) {
+    const clone = Buffer.from(secret)
+    const bl = new BufferList()
+    bl.append(Buffer.from('a'))
+    bl.consume(-1024)
+    const buf = bl.slice(1)
+    if (buf.indexOf(clone) !== -1) {
+      t.fail(`Match (at ${i})`)
+      break
+    }
+  }
+  t.end()
+})
+
 !process.browser && tape('test stream', function (t) {
   var random = crypto.randomBytes(65534)
     , rndhash = hash(random, 'md5')
@@ -404,7 +436,7 @@ tape('instantiation with Buffer', function (t) {
 
 tape('test String appendage', function (t) {
   var bl = new BufferList()
-    , b  = new Buffer('abcdefghij\xff\x00')
+    , b  = Buffer.from('abcdefghij\xff\x00')
 
   bl.append('abcd')
   bl.append('efg')
@@ -421,7 +453,7 @@ tape('test String appendage', function (t) {
 
 tape('test Number appendage', function (t) {
   var bl = new BufferList()
-    , b  = new Buffer('1234567890')
+    , b  = Buffer.from('1234567890')
 
   bl.append(1234)
   bl.append(567)
@@ -455,7 +487,7 @@ tape('unicode string', function (t) {
   bl.write(' and ')
   bl.write(inp2)
   t.equal(exp, bl.toString())
-  t.equal(new Buffer(exp).toString('hex'), bl.toString('hex'))
+  t.equal(Buffer.from(exp).toString('hex'), bl.toString('hex'))
 })
 
 tape('should emit finish', function (t) {
@@ -473,7 +505,7 @@ tape('should emit finish', function (t) {
 
 tape('basic copy', function (t) {
   var buf  = crypto.randomBytes(1024)
-    , buf2 = new Buffer(1024)
+    , buf2 = Buffer.alloc(1024)
     , b    = BufferList(buf)
 
   b.copy(buf2)
@@ -483,7 +515,7 @@ tape('basic copy', function (t) {
 
 tape('copy after many appends', function (t) {
   var buf  = crypto.randomBytes(512)
-    , buf2 = new Buffer(1024)
+    , buf2 = Buffer.alloc(1024)
     , b    = BufferList(buf)
 
   b.append(buf)
@@ -494,7 +526,7 @@ tape('copy after many appends', function (t) {
 
 tape('copy at a precise position', function (t) {
   var buf  = crypto.randomBytes(1004)
-    , buf2 = new Buffer(1024)
+    , buf2 = Buffer.alloc(1024)
     , b    = BufferList(buf)
 
   b.copy(buf2, 20)
@@ -504,7 +536,7 @@ tape('copy at a precise position', function (t) {
 
 tape('copy starting from a precise location', function (t) {
   var buf  = crypto.randomBytes(10)
-    , buf2 = new Buffer(5)
+    , buf2 = Buffer.alloc(5)
     , b    = BufferList(buf)
 
   b.copy(buf2, 0, 5)
@@ -515,8 +547,8 @@ tape('copy starting from a precise location', function (t) {
 tape('copy in an interval', function (t) {
   var rnd      = crypto.randomBytes(10)
     , b        = BufferList(rnd) // put the random bytes there
-    , actual   = new Buffer(3)
-    , expected = new Buffer(3)
+    , actual   = Buffer.alloc(3)
+    , expected = Buffer.alloc(3)
 
   rnd.copy(expected, 0, 5, 8)
   b.copy(actual, 0, 5, 8)
@@ -527,7 +559,7 @@ tape('copy in an interval', function (t) {
 
 tape('copy an interval between two buffers', function (t) {
   var buf      = crypto.randomBytes(10)
-    , buf2     = new Buffer(10)
+    , buf2     = Buffer.alloc(10)
     , b        = BufferList(buf)
 
   b.append(buf)
@@ -537,6 +569,52 @@ tape('copy an interval between two buffers', function (t) {
   t.end()
 })
 
+tape('shallow slice across buffer boundaries', function (t) {
+  var bl = new BufferList(['First', 'Second', 'Third'])
+
+  t.equal(bl.shallowSlice(3, 13).toString(), 'stSecondTh')
+  t.end()
+})
+
+tape('shallow slice within single buffer', function (t) {
+  t.plan(2)
+  var bl = new BufferList(['First', 'Second', 'Third'])
+
+  t.equal(bl.shallowSlice(5, 10).toString(), 'Secon')
+  t.equal(bl.shallowSlice(7, 10).toString(), 'con')
+  t.end()
+})
+
+tape('shallow slice single buffer', function (t) {
+  t.plan(3)
+  var bl = new BufferList(['First', 'Second', 'Third'])
+
+  t.equal(bl.shallowSlice(0, 5).toString(), 'First')
+  t.equal(bl.shallowSlice(5, 11).toString(), 'Second')
+  t.equal(bl.shallowSlice(11, 16).toString(), 'Third')
+})
+
+tape('shallow slice with negative or omitted indices', function (t) {
+  t.plan(4)
+  var bl = new BufferList(['First', 'Second', 'Third'])
+
+  t.equal(bl.shallowSlice().toString(), 'FirstSecondThird')
+  t.equal(bl.shallowSlice(5).toString(), 'SecondThird')
+  t.equal(bl.shallowSlice(5, -3).toString(), 'SecondTh')
+  t.equal(bl.shallowSlice(-8).toString(), 'ondThird')
+})
+
+tape('shallow slice does not make a copy', function (t) {
+  t.plan(1)
+  var buffers = [Buffer.from('First'), Buffer.from('Second'), Buffer.from('Third')]
+  var bl = (new BufferList(buffers)).shallowSlice(5, -3)
+
+  buffers[1].fill('h')
+  buffers[2].fill('h')
+
+  t.equal(bl.toString(), 'hhhhhhhh')
+})
+
 tape('duplicate', function (t) {
   t.plan(2)
 

package/.npmignore

@@ -1 +0,0 @@
-node_modules/