bktide 1.0.1755559112 → 1.0.1755568192

package/dist/formatters/build-detail/PlainTextFormatter.js

@@ -1,7 +1,7 @@
 import { BaseBuildDetailFormatter } from './Formatter.js';
 import { formatDistanceToNow } from 'date-fns';
 import { htmlToText } from 'html-to-text';
-import { formatEmptyState, formatError, SEMANTIC_COLORS, formatBuildStatus } from '../../ui/theme.js';
+import { formatEmptyState, formatError, SEMANTIC_COLORS, formatBuildStatus, formatTips, TipStyle, getStateIcon, getAnnotationIcon, getProgressIcon, BUILD_STATUS_THEME } from '../../ui/theme.js';
 // Standard emoji mappings only
 // Only map universally recognized emoji codes, not Buildkite-specific ones
 const STANDARD_EMOJI = {
@@ -127,10 +127,13 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         return formatError(options?.errorMessage || 'Unknown error');
     }
     formatSummaryLine(build) {
-        const status = this.getStatusIcon(build.state);
+        const statusIcon = this.getStatusIcon(build.state);
+        const coloredIcon = this.colorizeStatusIcon(statusIcon, build.state);
         const duration = this.formatDuration(build);
         const age = this.formatAge(build.createdAt);
-        return `${status} #${build.number} ${build.state.toLowerCase()} • ${duration} • ${build.branch} • ${age}`;
+        const stateFormatted = formatBuildStatus(build.state, { useSymbol: false });
+        const branch = SEMANTIC_COLORS.identifier(build.branch);
+        return `${coloredIcon} ${SEMANTIC_COLORS.label(`#${build.number}`)} ${stateFormatted} • ${duration} • ${branch} • ${age}`;
     }
     formatPassedBuild(build, options) {
         const lines = [];
@@ -142,13 +145,15 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             lines.push('');
             lines.push(this.formatAnnotationSummary(build.annotations.edges));
             if (!options?.annotations) {
-                lines.push(SEMANTIC_COLORS.dim(`→ bin/bktide build ${build.number} --annotations  # view annotations`));
+                lines.push('');
+                const tips = formatTips(['Use --annotations to view annotation details'], TipStyle.GROUPED);
+                lines.push(tips);
             }
         }
         // Show annotations detail if requested
         if (options?.annotations) {
             lines.push('');
-            lines.push(this.formatAnnotationDetails(build.annotations.edges, options));
+            lines.push(this.formatAnnotationDetails(build.annotations.edges));
         }
         return lines.join('\n');
     }
@@ -160,8 +165,11 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         lines.push('');
         // Failed jobs summary
         const failedJobs = this.getFailedJobs(build.jobs?.edges);
+        const allHints = [];
         if (failedJobs.length > 0) {
-            lines.push(this.formatFailedJobsSummary(failedJobs));
+            const { summary, hints } = this.formatFailedJobsSummaryWithHints(failedJobs, options);
+            lines.push(summary);
+            allHints.push(...hints);
         }
         // Annotation summary
         if (build.annotations?.edges?.length > 0) {
@@ -175,15 +183,19 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         // Show annotations detail if requested
         if (options?.annotations) {
             lines.push('');
-            lines.push(this.formatAnnotationDetails(build.annotations.edges, options));
+            lines.push(this.formatAnnotationDetails(build.annotations.edges));
         }
-        // Hints for more info (no Tips label)
+        // Collect all hints for more info
         if (!options?.failed && failedJobs.length > 0) {
-            lines.push('');
-            lines.push(SEMANTIC_COLORS.dim(`→ bin/bktide build ${build.number} --failed  # show failure details`));
+            allHints.push('Use --failed to show failure details');
         }
         if (!options?.annotations && build.annotations?.edges?.length > 0) {
-            lines.push(SEMANTIC_COLORS.dim(`→ bin/bktide build ${build.number} --annotations  # view annotations`));
+            allHints.push('Use --annotations to view annotation details');
+        }
+        // Display all hints together
+        if (allHints.length > 0) {
+            lines.push('');
+            lines.push(formatTips(allHints, TipStyle.GROUPED));
         }
         return lines.join('\n');
     }
@@ -202,11 +214,21 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             const labels = runningJobs.map(j => this.parseEmoji(j.node.label)).join(', ');
             lines.push(`${SEMANTIC_COLORS.info('Running')}: ${labels}`);
         }
+        // Annotation summary
+        if (build.annotations?.edges?.length > 0) {
+            lines.push('');
+            lines.push(this.formatAnnotationSummary(build.annotations.edges));
+        }
         // Show job details if requested
         if (options?.jobs) {
             lines.push('');
             lines.push(this.formatJobDetails(build.jobs?.edges, options));
         }
+        // Show annotations detail if requested
+        if (options?.annotations) {
+            lines.push('');
+            lines.push(this.formatAnnotationDetails(build.annotations.edges));
+        }
         return lines.join('\n');
     }
     formatBlockedBuild(build, options) {
@@ -218,18 +240,28 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         // Blocked information
         const blockedJobs = this.getBlockedJobs(build.jobs?.edges);
         if (blockedJobs.length > 0) {
-            lines.push(`🚫 Blocked: "${blockedJobs[0].node.label}" (manual unblock required)`);
+            lines.push(`${getProgressIcon('BLOCKED_MESSAGE')} Blocked: "${blockedJobs[0].node.label}" (manual unblock required)`);
         }
         // Show jobs summary
         const jobStats = this.getJobStats(build.jobs?.edges);
         if (jobStats.completed > 0) {
-            lines.push(`✅ ${jobStats.completed} jobs passed before block`);
+            lines.push(`${getStateIcon('PASSED')} ${jobStats.completed} jobs passed before block`);
+        }
+        // Annotation summary
+        if (build.annotations?.edges?.length > 0) {
+            lines.push('');
+            lines.push(this.formatAnnotationSummary(build.annotations.edges));
         }
         // Show job details if requested
         if (options?.jobs) {
             lines.push('');
             lines.push(this.formatJobDetails(build.jobs?.edges, options));
         }
+        // Show annotations detail if requested
+        if (options?.annotations) {
+            lines.push('');
+            lines.push(this.formatAnnotationDetails(build.annotations.edges));
+        }
         return lines.join('\n');
     }
     formatCanceledBuild(build, options) {
@@ -268,7 +300,24 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         lines.push(`  Organization: ${build.organization?.name || 'Unknown'}`);
         lines.push(`  Pipeline: ${build.pipeline?.name || 'Unknown'}`);
         if (build.pullRequest) {
-            lines.push(`  Pull Request: #${build.pullRequest.number}`);
+            // Try to construct PR URL from repository URL
+            const repoUrl = build.pipeline?.repository?.url;
+            if (repoUrl && repoUrl.includes('github.com')) {
+                // Extract owner/repo from various GitHub URL formats
+                const match = repoUrl.match(/github\.com[/:]([\w-]+)\/([\w-]+)/);
+                if (match && build.pullRequest.id) {
+                    // Extract PR number from GraphQL ID if possible
+                    // GitHub PR IDs often contain the number
+                    const prUrl = `https://github.com/${match[1]}/${match[2]}/pull/${build.pullRequest.id}`;
+                    lines.push(`  Pull Request: ${SEMANTIC_COLORS.url(prUrl)}`);
+                }
+                else {
+                    lines.push(`  Pull Request: ${build.pullRequest.id}`);
+                }
+            }
+            else {
+                lines.push(`  Pull Request: ${build.pullRequest.id}`);
+            }
         }
         if (build.triggeredFrom) {
             lines.push(`  Triggered from: ${build.triggeredFrom.pipeline?.name} #${build.triggeredFrom.number}`);
@@ -281,17 +330,19 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         if (build.annotations?.edges?.length > 0) {
             lines.push('');
             lines.push('Annotations:');
-            lines.push(this.formatAnnotationDetails(build.annotations.edges, { ...options, annotationsFull: true }));
+            lines.push(this.formatAnnotationDetails(build.annotations.edges));
         }
         return lines.join('\n');
     }
     formatHeader(build) {
-        const status = this.getStatusIcon(build.state);
+        const statusIcon = this.getStatusIcon(build.state);
+        // Apply appropriate color to the icon based on the state
+        const coloredIcon = this.colorizeStatusIcon(statusIcon, build.state);
         const stateFormatted = formatBuildStatus(build.state, { useSymbol: false });
         const duration = this.formatDuration(build);
         const age = this.formatAge(build.createdAt);
         const branch = SEMANTIC_COLORS.identifier(build.branch);
-        return `${status} ${SEMANTIC_COLORS.label(`#${build.number}`)} ${stateFormatted} • ${duration} • ${branch} • ${age}`;
+        return `${coloredIcon} ${SEMANTIC_COLORS.label(`#${build.number}`)} ${stateFormatted} • ${duration} • ${branch} • ${age}`;
     }
     formatCommitInfo(build) {
         const shortSha = build.commit ? build.commit.substring(0, 7) : 'unknown';
@@ -300,30 +351,51 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         return `   "${truncatedMessage}" (${shortSha})`;
     }
     formatAnnotationSummary(annotations) {
+        if (!annotations || annotations.length === 0) {
+            return '';
+        }
+        const lines = [];
+        const total = annotations.length;
+        // Header with count
         const counts = this.countAnnotationsByStyle(annotations);
-        const parts = [];
+        const countParts = [];
         if (counts.ERROR > 0)
-            parts.push(SEMANTIC_COLORS.error(`${counts.ERROR} error${counts.ERROR > 1 ? 's' : ''}`));
+            countParts.push(SEMANTIC_COLORS.error(`${counts.ERROR} error${counts.ERROR > 1 ? 's' : ''}`));
         if (counts.WARNING > 0)
-            parts.push(SEMANTIC_COLORS.warning(`${counts.WARNING} warning${counts.WARNING > 1 ? 's' : ''}`));
+            countParts.push(SEMANTIC_COLORS.warning(`${counts.WARNING} warning${counts.WARNING > 1 ? 's' : ''}`));
         if (counts.INFO > 0)
-            parts.push(SEMANTIC_COLORS.info(`${counts.INFO} info`));
+            countParts.push(SEMANTIC_COLORS.info(`${counts.INFO} info`));
         if (counts.SUCCESS > 0)
-            parts.push(SEMANTIC_COLORS.success(`${counts.SUCCESS} success`));
-        const total = annotations.length;
-        return `📝 ${SEMANTIC_COLORS.count(String(total))} annotation${total > 1 ? 's' : ''}: ${parts.join(', ')}`;
+            countParts.push(SEMANTIC_COLORS.success(`${counts.SUCCESS} success`));
+        lines.push(`${getAnnotationIcon('DEFAULT')} ${SEMANTIC_COLORS.count(String(total))} annotation${total > 1 ? 's' : ''}: ${countParts.join(', ')}`);
+        // List each annotation with style and context
+        const grouped = this.groupAnnotationsByStyle(annotations);
+        const styleOrder = ['ERROR', 'WARNING', 'INFO', 'SUCCESS'];
+        for (const style of styleOrder) {
+            if (grouped[style]) {
+                for (const annotation of grouped[style]) {
+                    const icon = this.getAnnotationIcon(style);
+                    const context = annotation.node.context || 'default';
+                    const styleColored = this.colorizeAnnotationStyle(style);
+                    lines.push(`   ${icon} ${styleColored}: ${context}`);
+                }
+            }
+        }
+        return lines.join('\n');
     }
-    formatAnnotationDetails(annotations, options) {
+    formatAnnotationDetails(annotations) {
         const lines = [];
         // Group annotations by style
         const grouped = this.groupAnnotationsByStyle(annotations);
-        for (const [style, items] of Object.entries(grouped)) {
-            for (const annotation of items) {
-                const icon = this.getAnnotationIcon(style);
-                const context = annotation.node.context || 'default';
-                if (options?.annotationsFull) {
-                    // Full content
-                    lines.push(`${icon} ${style} [${context}]:`);
+        const styleOrder = ['ERROR', 'WARNING', 'INFO', 'SUCCESS'];
+        for (const style of styleOrder) {
+            if (grouped[style]) {
+                for (const annotation of grouped[style]) {
+                    const icon = this.getAnnotationIcon(style);
+                    const context = annotation.node.context || 'default';
+                    const styleColored = this.colorizeAnnotationStyle(style);
+                    // When showing annotation details, always show the body text
+                    lines.push(`${icon} ${styleColored}: ${context}`);
                     const body = htmlToText(annotation.node.body?.html || '', {
                         wordwrap: 80,
                         preserveNewlines: true
@@ -331,13 +403,9 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
                     lines.push(body.split('\n').map(l => `   ${l}`).join('\n'));
                     lines.push('');
                 }
-                else {
-                    // Summary only
-                    lines.push(`${icon} ${style} [${context}]`);
-                }
             }
         }
-        return lines.join('\n');
+        return lines.join('\n').trim();
     }
     formatJobDetails(jobs, options) {
         if (!jobs || jobs.length === 0) {
@@ -348,15 +416,15 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         // Summary line
         const parts = [];
         if (jobStats.passed > 0)
-            parts.push(`✅ ${jobStats.passed} passed`);
+            parts.push(`${getStateIcon('PASSED')} ${jobStats.passed} passed`);
         if (jobStats.failed > 0)
-            parts.push(`❌ ${jobStats.failed} failed`);
+            parts.push(`${getStateIcon('FAILED')} ${jobStats.failed} failed`);
         if (jobStats.running > 0)
-            parts.push(`🔄 ${jobStats.running} running`);
+            parts.push(`${getStateIcon('RUNNING')} ${jobStats.running} running`);
         if (jobStats.blocked > 0)
-            parts.push(`⏸️ ${jobStats.blocked} blocked`);
+            parts.push(`${getStateIcon('BLOCKED')} ${jobStats.blocked} blocked`);
         if (jobStats.skipped > 0)
-            parts.push(`⏭️ ${jobStats.skipped} skipped`);
+            parts.push(`${getStateIcon('SKIPPED')} ${jobStats.skipped} skipped`);
         lines.push(`Jobs: ${parts.join('  ')}`);
         lines.push('');
         // Filter jobs based on options
@@ -375,22 +443,45 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             for (const job of stateJobs) {
                 const label = this.parseEmoji(job.node.label);
                 const duration = this.formatJobDuration(job.node);
-                const exitCode = job.node.exitStatus ? `, exit ${job.node.exitStatus}` : '';
-                lines.push(`  ${label} (${duration}${exitCode})`);
-                if (options?.full && job.node.agent) {
-                    lines.push(`    ${SEMANTIC_COLORS.dim(`Agent: ${job.node.agent.name || job.node.agent.hostname}`)}`);
+                // Basic job line
+                lines.push(`  ${label} (${duration})`);
+                // Show additional details if --jobs or --full
+                if (options?.jobs || options?.full) {
+                    // Timing details
+                    if (job.node.startedAt) {
+                        const startTime = new Date(job.node.startedAt).toLocaleTimeString();
+                        const endTime = job.node.finishedAt
+                            ? new Date(job.node.finishedAt).toLocaleTimeString()
+                            : 'still running';
+                        lines.push(`    ${SEMANTIC_COLORS.dim(`${getProgressIcon('TIMING')}  ${startTime} → ${endTime}`)}`);
+                    }
+                    // Parallel group info
+                    if (job.node.parallelGroupIndex !== undefined && job.node.parallelGroupTotal) {
+                        lines.push(`    ${SEMANTIC_COLORS.dim(`${getProgressIcon('PARALLEL')}  Parallel: ${job.node.parallelGroupIndex + 1}/${job.node.parallelGroupTotal}`)}`);
+                    }
+                    // Retry info
+                    if (job.node.retried) {
+                        lines.push(`    ${SEMANTIC_COLORS.warning(`${getProgressIcon('RETRY')} Retried`)}`);
+                    }
                 }
             }
             lines.push('');
         }
         return lines.join('\n').trim();
     }
-    formatFailedJobsSummary(failedJobs) {
+    formatFailedJobsSummaryWithHints(failedJobs, options) {
+        const hints = [];
+        const summary = this.formatFailedJobsSummary(failedJobs, options, hints);
+        return { summary, hints };
+    }
+    formatFailedJobsSummary(failedJobs, options, hints) {
         const lines = [];
         // Group identical jobs by label
         const jobGroups = this.groupJobsByLabel(failedJobs);
-        // Show first 10 unique job types
-        const displayGroups = jobGroups.slice(0, 10);
+        // Show all groups if --all-jobs, otherwise limit to 10
+        const displayGroups = options?.allJobs
+            ? jobGroups
+            : jobGroups.slice(0, 10);
         for (const group of displayGroups) {
             const label = this.parseEmoji(group.label);
             if (group.count === 1) {
@@ -415,34 +506,43 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
                 if (group.stateCounts.other > 0) {
                     statusParts.push(`${group.stateCounts.other} other`);
                 }
-                // Add exit codes if available
-                if (group.exitCodes.length > 0) {
-                    const exitCodeStr = group.exitCodes.length === 1
-                        ? `exit ${group.exitCodes[0]}`
-                        : `exits: ${group.exitCodes.join(', ')}`;
-                    statusParts.push(exitCodeStr);
-                }
                 const statusInfo = statusParts.join(', ') || 'various states';
-                lines.push(`   ${SEMANTIC_COLORS.error('Failed')}: ${label} (${SEMANTIC_COLORS.count(String(group.count))} jobs: ${statusInfo})`);
+                // Show parallel info if it's a parallel job group
+                const parallelInfo = group.parallelTotal > 0 ? ` (${group.count}/${group.parallelTotal} parallel)` : ` (${SEMANTIC_COLORS.count(String(group.count))} jobs)`;
+                lines.push(`   ${SEMANTIC_COLORS.error('Failed')}: ${label}${parallelInfo}: ${statusInfo}`);
             }
         }
-        // Add summary if there are more job types
-        const remaining = jobGroups.length - displayGroups.length;
-        if (remaining > 0) {
-            lines.push(`   ${SEMANTIC_COLORS.muted(`...and ${remaining} more job types`)}`);
+        // Add summary if there are more job types and not showing all
+        if (!options?.allJobs) {
+            const remaining = jobGroups.length - displayGroups.length;
+            if (remaining > 0) {
+                lines.push(`   ${SEMANTIC_COLORS.muted(`...and ${remaining} more job types`)}`);
+                // If hints array is provided, add hint there; otherwise format inline
+                if (hints) {
+                    hints.push('Use --all-jobs to show all jobs');
+                }
+                else {
+                    lines.push('');
+                    const tips = formatTips(['Use --all-jobs to show all jobs'], TipStyle.GROUPED);
+                    lines.push(tips);
+                }
+            }
         }
         return lines.join('\n');
     }
     groupJobsByLabel(jobs) {
         const groups = new Map();
         for (const job of jobs) {
-            const label = job.node.label || 'Unnamed job';
-            if (!groups.has(label)) {
-                groups.set(label, {
-                    label,
+            const fullLabel = job.node.label || 'Unnamed job';
+            // Strip parallel job index from label for grouping
+            // e.g., "deposit_and_filing_schedule_calculator rspec (1/22)" -> "deposit_and_filing_schedule_calculator rspec"
+            const baseLabel = fullLabel.replace(/\s*\(\d+\/\d+\)\s*$/, '').trim();
+            if (!groups.has(baseLabel)) {
+                groups.set(baseLabel, {
+                    label: baseLabel,
                     count: 0,
                     jobs: [],
-                    exitCodes: new Set(),
+                    parallelTotal: 0,
                     stateCounts: {
                         failed: 0,
                         broken: 0,
@@ -452,18 +552,41 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
                     }
                 });
             }
-            const group = groups.get(label);
+            const group = groups.get(baseLabel);
             group.count++;
             group.jobs.push(job);
-            // Track exit codes
-            if (job.node.exitStatus !== null && job.node.exitStatus !== undefined) {
-                group.exitCodes.add(job.node.exitStatus);
+            // Track the maximum parallel total for this job group
+            if (job.node.parallelGroupTotal && job.node.parallelGroupTotal > group.parallelTotal) {
+                group.parallelTotal = job.node.parallelGroupTotal;
             }
             // Count by state
             const state = job.node.state?.toUpperCase();
-            if (!job.node.startedAt) {
+            // Use exit status as source of truth when available
+            // Note: exitStatus comes as a string from Buildkite API
+            if (job.node.exitStatus !== null && job.node.exitStatus !== undefined) {
+                const exitCode = parseInt(job.node.exitStatus, 10);
+                if (exitCode === 0) {
+                    group.stateCounts.passed++;
+                }
+                else {
+                    group.stateCounts.failed++;
+                }
+            }
+            else if (!job.node.startedAt) {
                 group.stateCounts.notStarted++;
             }
+            else if (state === 'FINISHED' || state === 'COMPLETED') {
+                // For finished jobs without exit status, check passed field
+                if (job.node.passed === true) {
+                    group.stateCounts.passed++;
+                }
+                else if (job.node.passed === false) {
+                    group.stateCounts.failed++;
+                }
+                else {
+                    group.stateCounts.other++;
+                }
+            }
             else if (state === 'FAILED') {
                 group.stateCounts.failed++;
             }
@@ -479,7 +602,6 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         }
         // Convert to array and sort by count (most failures first)
         return Array.from(groups.values())
-            .map(g => ({ ...g, exitCodes: Array.from(g.exitCodes) }))
             .sort((a, b) => b.count - a.count);
     }
     formatDuration(build) {
@@ -528,37 +650,35 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
         }
     }
     getStatusIcon(state) {
-        const icons = {
-            'PASSED': '✅',
-            'FAILED': '❌',
-            'RUNNING': '🔄',
-            'BLOCKED': '⏸️',
-            'CANCELED': '🚫',
-            'SCHEDULED': '📅',
-            'SKIPPED': '⏭️'
-        };
-        return icons[state] || '❓';
+        return getStateIcon(state);
     }
     getJobStateIcon(state) {
-        const icons = {
-            'passed': '✅',
-            'failed': '❌',
-            'running': '🔄',
-            'blocked': '⏸️',
-            'canceled': '🚫',
-            'scheduled': '📅',
-            'skipped': '⏭️'
-        };
-        return icons[state.toLowerCase()] || '❓';
+        return getStateIcon(state);
     }
     getAnnotationIcon(style) {
-        const icons = {
-            'ERROR': '❌',
-            'WARNING': '⚠️',
-            'INFO': 'ℹ️',
-            'SUCCESS': '✅'
-        };
-        return icons[style.toUpperCase()] || '📝';
+        return getAnnotationIcon(style);
+    }
+    colorizeAnnotationStyle(style) {
+        switch (style.toUpperCase()) {
+            case 'ERROR':
+                return SEMANTIC_COLORS.error(style.toLowerCase());
+            case 'WARNING':
+                return SEMANTIC_COLORS.warning(style.toLowerCase());
+            case 'INFO':
+                return SEMANTIC_COLORS.info(style.toLowerCase());
+            case 'SUCCESS':
+                return SEMANTIC_COLORS.success(style.toLowerCase());
+            default:
+                return style.toLowerCase();
+        }
+    }
+    colorizeStatusIcon(icon, state) {
+        const upperState = state.toUpperCase();
+        const theme = BUILD_STATUS_THEME[upperState];
+        if (!theme) {
+            return SEMANTIC_COLORS.muted(icon);
+        }
+        return theme.color(icon);
     }
     getJobStats(jobs) {
         const stats = {
@@ -575,13 +695,18 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             return stats;
         for (const job of jobs) {
             const state = job.node.state?.toUpperCase() || '';
-            if (state === 'PASSED' || (job.node.passed === true && state !== 'BROKEN')) {
-                stats.passed++;
-                stats.completed++;
-            }
-            else if (state === 'FAILED' || state === 'BROKEN' || (job.node.exitStatus && job.node.exitStatus !== 0) || job.node.passed === false) {
-                stats.failed++;
-                stats.completed++;
+            // If we have an exit status, use that as the source of truth
+            // Note: exitStatus comes as a string from Buildkite API
+            if (job.node.exitStatus !== null && job.node.exitStatus !== undefined) {
+                const exitCode = parseInt(job.node.exitStatus, 10);
+                if (exitCode === 0) {
+                    stats.passed++;
+                    stats.completed++;
+                }
+                else {
+                    stats.failed++;
+                    stats.completed++;
+                }
             }
             else if (state === 'RUNNING') {
                 stats.running++;
@@ -596,6 +721,25 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             else if (state === 'SCHEDULED' || state === 'ASSIGNED') {
                 stats.queued++;
             }
+            else if (state === 'FINISHED' || state === 'COMPLETED') {
+                // For finished jobs without exit status, check passed field
+                if (job.node.passed === true) {
+                    stats.passed++;
+                    stats.completed++;
+                }
+                else if (job.node.passed === false) {
+                    stats.failed++;
+                    stats.completed++;
+                }
+            }
+            else if (state === 'PASSED' || job.node.passed === true) {
+                stats.passed++;
+                stats.completed++;
+            }
+            else if (state === 'FAILED' || state === 'BROKEN' || job.node.passed === false) {
+                stats.failed++;
+                stats.completed++;
+            }
         }
         return stats;
     }
@@ -604,7 +748,14 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             return [];
         return jobs.filter(job => {
             const state = job.node.state?.toUpperCase();
-            return state === 'FAILED' || state === 'BROKEN' || (job.node.exitStatus && job.node.exitStatus !== 0) || job.node.passed === false;
+            // If we have an exit status, use that as the source of truth
+            // Note: exitStatus comes as a string from Buildkite API
+            if (job.node.exitStatus !== null && job.node.exitStatus !== undefined) {
+                const exitCode = parseInt(job.node.exitStatus, 10);
+                return exitCode !== 0;
+            }
+            // Otherwise fall back to state
+            return state === 'FAILED' || state === 'BROKEN' || job.node.passed === false;
         });
     }
     getRunningJobs(jobs) {
@@ -629,11 +780,16 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             return grouped;
         for (const job of jobs) {
             const state = job.node.state?.toUpperCase() || '';
-            if (state === 'FAILED' || state === 'BROKEN' || (job.node.exitStatus && job.node.exitStatus !== 0) || job.node.passed === false) {
-                grouped['Failed'].push(job);
-            }
-            else if (state === 'PASSED' || (job.node.passed === true && state !== 'BROKEN')) {
-                grouped['Passed'].push(job);
+            // If we have an exit status, use that as the source of truth
+            // Note: exitStatus comes as a string from Buildkite API
+            if (job.node.exitStatus !== null && job.node.exitStatus !== undefined) {
+                const exitCode = parseInt(job.node.exitStatus, 10);
+                if (exitCode === 0) {
+                    grouped['Passed'].push(job);
+                }
+                else {
+                    grouped['Failed'].push(job);
+                }
             }
             else if (state === 'RUNNING') {
                 grouped['Running'].push(job);
@@ -644,6 +800,21 @@ export class PlainTextFormatter extends BaseBuildDetailFormatter {
             else if (state === 'SKIPPED' || state === 'CANCELED') {
                 grouped['Skipped'].push(job);
             }
+            else if (state === 'FINISHED' || state === 'COMPLETED') {
+                // For finished jobs without exit status, check passed field
+                if (job.node.passed === true) {
+                    grouped['Passed'].push(job);
+                }
+                else if (job.node.passed === false) {
+                    grouped['Failed'].push(job);
+                }
+            }
+            else if (state === 'PASSED' || job.node.passed === true) {
+                grouped['Passed'].push(job);
+            }
+            else if (state === 'FAILED' || state === 'BROKEN' || job.node.passed === false) {
+                grouped['Failed'].push(job);
+            }
         }
         return grouped;
     }