biz-a-cli 2.3.80-15419 → 2.3.80

package/engine/fina/submission.js

@@ -1,290 +0,0 @@
-/*
- * Doc 8 M7 — a JV submission (pengajuan): with Need Approval on, a NEW JV is not saved to FINA but submitted (A-05). It
- * is kept in Biz-A (FINA$JV_SUBMISSION, engine/fina's own; migrations/postgres/1790800000000__fina_jv_submission.sql)
- * with a temporary number (A-10, T-32), and goes through the approval workflow (approval.js).
- *
- * - Submitting checks what a JV save checks (the FINA right, the JV rules, the Biz-A lock, FINA's period), so what
- *   waits is a JV FINA would take — at that moment.
- * - Only a waiting one (MENUNGGU) is edited (the edit right, anyone: A-17) or deleted (M-20). A decided one is read only
- *   (A-14); resubmitting is Salin (A-19).
- * - Setujui posts it to FINA AS THE SUBMITTER'S FINA USER (Agung 2026-10-14), through the JV writer (documentWrite.js,
- *   `approved`). Success → DISETUJUI with FINA's number (A-07); any refusal → GAGAL_POSTING with the reason, nothing in
- *   FINA (A-12). The creator and the approver are told (A-13, A-20). Tolak → DITOLAK (A-08).
- *
- * ⚠️ ONE APPROVAL, ONE JV. Posting runs as the workflow's effect, AFTER the approval commits (BPM agent). It first
- * CLAIMS the submission (MENUNGGU → PROSES_POSTING): a second run of the effect finds it claimed and posts nothing. A
- * run that dies after FINA saved leaves it PROSES_POSTING, which is honest — nobody knows; Daftar JV does.
- * ⚠️ Posting never throws: the BPM agent retries a script that throws, and a retry cannot change a refusal.
- */
-import { finaError } from "./errors.js";
-import { requireRight } from "./identity.js";
-import { documentOf, documentId } from "./documents/index.js";
-import { listTemplates, assertTemplateOfType } from "./template.js";
-import { isDateLocked, toDateOnly } from "./lock.js";
-import { checkPeriods } from "./period.js";
-import { ownerOf, submissionOwnerOf } from "./attachments.js";
-import { APPROVAL } from "./approval.js";
-
-export const SUBMISSION = Object.freeze({ waiting: "MENUNGGU", posting: "PROSES_POSTING", approved: "DISETUJUI", rejected: "DITOLAK", failed: "GAGAL_POSTING" });
-
-/* A submission's attachments: the owner `fina.jvsub` (attachments.js serves them by the same rule). */
-export { submissionOwnerOf };
-
-/* FINA said no: the reason is the whole story. Anything else (no answer, a broken one) may have saved it after all. */
-const DEFINITE = new Set(["DOCUMENT_RULE", "DATE_LOCKED", "PERIOD_CLOSED", "FORBIDDEN", "UNAUTHENTICATED", "INVALID", "FINA_REFUSED", "DOCUMENT_CHANGED"]);
-const UNSURE_NOTE = "FINA may have saved it anyway: look for it in Daftar JV before submitting again (Salin).";
-
-const REQUEST_TTL_MS = 10 * 60 * 1000;
-const requests = new Map();
-
-/* Tests only: forget the request ids seen. */
-export const resetSubmissionRequests = () => requests.clear();
-
-const round4 = (n) => Math.round(Number(n) * 10000) / 10000;
-
-/* A kept line is as the form sends it: Debit / Credit, besides FINA's signed amount. */
-const keptLine = ({ n, seq, ...line }) => ({
-	...line,
-	debit: line.glamount > 0 ? line.glamount : null,
-	credit: line.glamount < 0 ? -line.glamount : null,
-});
-
-const messageOf = (error) => String(error?.message ?? error ?? "unknown error");
-
-export const createSubmissionService = ({ client, identity, settings, features, repo, bpm, attachments, writer, now = () => Date.now() }) => {
-	const document = documentOf("jv");
-	const label = (row) => row?.number ?? `JV submission ${row?.id}`;
-
-	const found = async (id) => {
-		const row = await repo.read(id);
-		if (!row) throw finaError("DOCUMENT_NOT_FOUND", `JV submission ${id} was not found.`);
-		return row;
-	};
-
-	/* Changed only while it waits — in the table AND in its workflow (a decision commits before its effect runs). */
-	const stillWaiting = async (row) => {
-		if (row.status !== SUBMISSION.waiting) {
-			throw finaError("DOCUMENT_RULE", `${label(row)} is ${String(row.status).toLowerCase()}: it is read only. Salin makes a new submission.`);
-		}
-		if (row.instanceId === null || row.instanceId === undefined) return;
-		const instance = await bpm.instance(row.instanceId);
-		if (instance && instance.current_state_code !== APPROVAL.waiting) {
-			throw finaError("DOCUMENT_RULE", `${label(row)} is already decided; its outcome follows in a moment.`);
-		}
-	};
-
-	const saveRun = async (principal, request) => {
-		const blank = request?.id === null || request?.id === undefined || request?.id === "";
-		const id = blank ? null : documentId(request.id);
-		const isNew = id === null;
-		const userId = Number(principal?.userId);
-		requireRight(await identity.resolve(principal), document.rights, isNew ? "create" : "edit");
-
-		const config = await settings.read();
-		if (!document.write.needsApproval(config)) {
-			throw finaError("DOCUMENT_RULE", "Need Approval is off in the FINA Cloud console: a new Journal Voucher is saved to FINA directly.");
-		}
-		let row = null;
-		if (isNew) {
-			if (!(await bpm.published())) {
-				throw finaError("DOCUMENT_RULE", "The JV approval workflow is not published yet: Publish the FINA Cloud console first.");
-			}
-		} else {
-			row = await found(id);
-			await stillWaiting(row);
-		}
-
-		const flags = await features.read();
-		const normalized = document.write.normalize(request?.master, request?.lines);
-		const problems = [...normalized.problems];
-		if (problems.length === 0) problems.push(...(await document.write.validate({ client, lines: normalized.lines, settings: config, features: flags })));
-		if (problems.length > 0) throw finaError("DOCUMENT_RULE", problems.join("\n"));
-
-		const date = normalized.master.transdate;
-		const upTo = config?.lock?.upTo ?? null;
-		if (isDateLocked(date, upTo)) {
-			throw finaError("DATE_LOCKED", `${date} is on or before the Biz-A lock date ${toDateOnly(upTo)}: it cannot be submitted from Biz-A.`);
-		}
-		await checkPeriods(client, [date]);
-		if (normalized.master.templateid) assertTemplateOfType(await listTemplates(client, document.templateType), normalized.master.templateid);
-
-		const values = {
-			transdate: date,
-			transdescription: normalized.master.transdescription,
-			amount: round4(normalized.lines.reduce((s, l) => s + (l.glamount > 0 ? l.glamount : 0), 0)),
-			templateid: normalized.master.templateid,
-			document: { master: normalized.master, lines: normalized.lines.map(keptLine) },
-		};
-
-		if (!isNew) {
-			if (!(await repo.update(id, { ...values, updatedBy: userId }))) {
-				throw finaError("DOCUMENT_RULE", `${label(row)} was decided meanwhile: it is read only now.`);
-			}
-			return { id, number: row.number };
-		}
-
-		const kept = await repo.insert({ ...values, userId });
-		try {
-			const { instanceId } = await bpm.initiate({ workflowKey: APPROVAL.key, entityType: APPROVAL.entityType, entityId: kept.id, userId });
-			await repo.setInstance(kept.id, instanceId);
-		} catch (error) {
-			await repo.remove(kept.id).catch(() => false);
-			throw finaError("DOCUMENT_RULE", `The JV approval workflow did not start, so nothing was submitted: ${messageOf(error)}`);
-		}
-		return { id: kept.id, number: kept.number };
-	};
-
-	const removeRun = async (principal, request) => {
-		const id = documentId(request?.id);
-		requireRight(await identity.resolve(principal), document.rights, "delete");
-		const row = await found(id);
-		await stillWaiting(row);
-		if (row.instanceId !== null && row.instanceId !== undefined) await bpm.terminate({ instanceId: row.instanceId, userId: Number(principal?.userId) });
-		const warnings = [];
-		try {
-			await attachments.removeOwner({ owner: submissionOwnerOf(id) });
-		} catch (error) {
-			warnings.push(`Its attachments could not be removed: ${messageOf(error)}`);
-		}
-		if (!(await repo.remove(id))) throw finaError("DOCUMENT_RULE", `${label(row)} was decided meanwhile: it is read only now.`);
-		return { id, number: row.number, ...(warnings.length > 0 && { warnings }) };
-	};
-
-	/* `requestId` (from the browser, one per action) makes a resend answer the first outcome; `dbIndex` scopes it. */
-	const once = (action, fn) => (principal, request = {}, { dbIndex } = {}) => {
-		const requestId = String(request?.requestId ?? "").trim();
-		if (!requestId) return fn(principal, request);
-		const at = now();
-		for (const [key, entry] of requests) if (at - entry.at > REQUEST_TTL_MS) requests.delete(key);
-		const key = `${action}:${dbIndex ?? ""}:${principal?.userId ?? ""}:${requestId}`;
-		if (!requests.has(key)) requests.set(key, { at, promise: fn(principal, request) });
-		return requests.get(key).promise;
-	};
-
-	/* The submission an effect is about: an instance of THIS workflow's entity, standing where the effect expects. */
-	const decided = async (instanceId, state) => {
-		const instance = await bpm.instance(instanceId);
-		if (!instance || instance.entity_type !== APPROVAL.entityType) return { refused: `Instance ${instanceId} is not a JV submission's.` };
-		if (instance.current_state_code !== state) return { refused: `Instance ${instanceId} stands at ${instance.current_state_code}, not ${state}.` };
-		const row = await repo.read(instance.entity_id);
-		if (!row) return { refused: `JV submission ${instance.entity_id} was not found.` };
-		return { row };
-	};
-
-	/* What a run answers for a submission already past waiting (a retried effect, a second run). */
-	const asBefore = (row) => ({
-		ok: row.status === SUBMISSION.approved || row.status === SUBMISSION.rejected,
-		status: row.status,
-		id: row.id,
-		number: row.number,
-		jvNumber: row.finaJvNumber ?? null,
-		...(row.postError && { error: row.postError }),
-		notify: null,
-	});
-
-	const told = (row, userIds, extra) => ({
-		userIds: [...new Set(userIds.filter((u) => Number.isInteger(u)))],
-		data: { id: row.id, number: row.number, createdBy: row.createdBy, ...extra },
-	});
-
-	const postRun = async ({ instanceId } = {}) => {
-		const { row, refused } = await decided(instanceId, APPROVAL.approved);
-		if (refused) return { ok: false, error: refused, notify: null };
-		if (row.status !== SUBMISSION.waiting || !(await repo.claim(row.id))) return asBefore(row.status === SUBMISSION.waiting ? await found(row.id) : row);
-
-		const decidedBy = await bpm.decider(instanceId).catch(() => null);
-		const createdBy = Number(row.createdBy);
-		const userIds = [createdBy, decidedBy];
-		let saved;
-		try {
-			saved = await writer.save(
-				{ userId: createdBy },
-				"jv",
-				{ id: null, master: row.document?.master, lines: row.document?.lines, requestId: `sub-${row.id}` },
-				{ approved: true },
-			);
-		} catch (error) {
-			const postError = DEFINITE.has(error?.code) ? messageOf(error) : `${messageOf(error)} ${UNSURE_NOTE}`;
-			await repo.decide(row.id, { status: SUBMISSION.failed, postError, decidedBy, finaJvId: null, finaJvNumber: null }, SUBMISSION.posting);
-			return { ok: false, status: SUBMISSION.failed, id: row.id, number: row.number, error: postError, notify: told(row, userIds, { status: SUBMISSION.failed, error: postError }) };
-		}
-
-		await repo.decide(row.id, { status: SUBMISSION.approved, postError: null, decidedBy, finaJvId: saved.id, finaJvNumber: saved.number ?? null }, SUBMISSION.posting);
-		const warnings = [...(saved.warnings ?? [])];
-		try {
-			const files = await attachments.list({ owner: submissionOwnerOf(row.id) });
-			if (files.length > 0) {
-				const limits = (await settings.read())?.[document.name]?.attachments ?? null;
-				await attachments.copy({ from: submissionOwnerOf(row.id), to: ownerOf(document.name, saved.id), ids: files.map((f) => f.id), userId: decidedBy }, limits);
-			}
-		} catch (error) {
-			warnings.push(`Its attachments could not be copied to JV ${saved.number ?? saved.id}: ${messageOf(error)}`);
-		}
-		const data = { status: SUBMISSION.approved, jvId: saved.id, jvNumber: saved.number ?? null };
-		return { ok: true, status: SUBMISSION.approved, id: row.id, number: row.number, jvNumber: data.jvNumber, ...(warnings.length > 0 && { warnings }), notify: told(row, userIds, data) };
-	};
-
-	const rejectRun = async ({ instanceId } = {}) => {
-		const { row, refused } = await decided(instanceId, APPROVAL.rejected);
-		if (refused) return { ok: false, error: refused, notify: null };
-		if (row.status !== SUBMISSION.waiting) return asBefore(row);
-		const decidedBy = await bpm.decider(instanceId).catch(() => null);
-		if (!(await repo.decide(row.id, { status: SUBMISSION.rejected, decidedBy }, SUBMISSION.waiting))) return asBefore(await found(row.id));
-		return { ok: true, status: SUBMISSION.rejected, id: row.id, number: row.number, notify: told(row, [Number(row.createdBy)], { status: SUBMISSION.rejected }) };
-	};
-
-	const never = (fn) => async (payload) => {
-		try {
-			return await fn(payload);
-		} catch (error) {
-			return { ok: false, error: messageOf(error), notify: null };
-		}
-	};
-
-	return {
-		save: once("save", saveRun),
-		remove: once("remove", removeRun),
-
-		/* Any mapped FINA user (D4: view). A waiting one says what would stop its posting now (A-18) — without blocking. */
-		get: async (principal, rawId) => {
-			requireRight(await identity.resolve(principal), document.rights, null);
-			const row = await found(documentId(rawId));
-			const warnings = [];
-			if (row.status === SUBMISSION.waiting) {
-				const config = await settings.read();
-				const date = toDateOnly(row.transdate ?? row.document?.master?.transdate);
-				const upTo = config?.lock?.upTo ?? null;
-				if (isDateLocked(date, upTo)) warnings.push(`${date} is on or before the Biz-A lock date ${toDateOnly(upTo)}: Setujui will fail unless the lock moves.`);
-				else {
-					try {
-						await checkPeriods(client, [date]);
-					} catch (error) {
-						warnings.push(messageOf(error));
-					}
-				}
-			}
-			/* The JV form reads it as it reads a JV (fina/document/get): its template, no version (only a JV in FINA has
-			   one), and the JV number once FINA gave one. */
-			const master = row.document?.master ?? {};
-			return {
-				id: row.id,
-				number: row.number,
-				status: row.status,
-				templateId: master.templateid ?? row.templateid ?? null,
-				version: null,
-				master: { ...master, jvnumber: row.finaJvNumber ?? null },
-				lines: row.document?.lines ?? [],
-				instanceId: row.instanceId ?? null,
-				createdBy: row.createdBy ?? null,
-				decidedBy: row.decidedBy ?? null,
-				finaJv: row.finaJvId ? { id: row.finaJvId, number: row.finaJvNumber ?? null } : null,
-				postError: row.postError ?? null,
-				warnings,
-			};
-		},
-
-		/* The workflow's effects (lib.fina.approval), never a route. */
-		post: never(postRun),
-		reject: never(rejectRun),
-	};
-};

package/engine/fina/submissionCompare.js

@@ -1,171 +0,0 @@
-/*
- * Doc 8 M7b — a posted JV submission next to the JV it became in FINA (L-02, A-16; spec §10.1).
- *
- * The Biz-A copy is kept as submitted and never synced (A-14, A-15): FINA may have changed the JV since, from the
- * desktop or from Biz-A, or deleted it (L-09: "Tidak ditemukan"). The answer carries both sides the same way, with the
- * display values FINA has now (account "1101.001 - Cash IDR", department, project, subsidiary, template, extended
- * lookups), and the differences — structured, so the app words them.
- *
- * Any mapped FINA user may look (D4: view). Lines are compared by position.
- */
-import { finaError } from "./errors.js";
-import { requireRight } from "./identity.js";
-import { documentOf, documentId } from "./documents/index.js";
-import { readDocument } from "./document.js";
-import { listTemplates, readMappings } from "./template.js";
-import { toDateOnly } from "./lock.js";
-import { sqlString } from "./sql.js";
-
-const round4 = (n) => Math.round(Number(n) * 10000) / 10000;
-const amount = (v) => (v === null || v === undefined || v === "" || Number(v) === 0 ? null : round4(v));
-const text = (v) => {
-	const s = v === null || v === undefined ? "" : String(v).trim();
-	return s === "" ? null : s;
-};
-const inList = (values) => [...new Set(values)].map((v) => sqlString(v)).join(", ");
-
-/* "code - name" for each code FINA knows; one IN query per kind. */
-const namesOf = async (client, table, codeColumn, nameColumn, codes) => {
-	const wanted = [...new Set(codes.filter(Boolean))];
-	if (wanted.length === 0) return new Map();
-	const rows = (await client.executeSql(`SELECT ${codeColumn}, ${nameColumn} FROM ${table} WHERE ${codeColumn} IN (${inList(wanted)})`)) ?? [];
-	return new Map(rows.map((r) => [String(r[codeColumn.toLowerCase()]).trim(), text(r[nameColumn.toLowerCase()])]));
-};
-const named = (names, code) => {
-	const c = text(code);
-	if (!c) return null;
-	const name = names.get(c);
-	return name ? `${c} - ${name}` : c;
-};
-
-/* A side's master and lines as they compare: the kept submission (request form) or FINA's JV (document.js). */
-const plain = (doc) => ({
-	master: { transdate: toDateOnly(doc.master?.transdate), transdescription: text(doc.master?.transdescription), templateid: doc.master?.templateid ?? null, ext: doc.master ?? {} },
-	lines: (doc.lines ?? []).map((l) => {
-		const base = l.glamount !== undefined && l.glamount !== null ? Number(l.glamount) : Number(l.debit ?? 0) - Number(l.credit ?? 0);
-		return {
-			glaccount: text(l.glaccount),
-			debit: amount(base > 0 ? base : null),
-			credit: amount(base < 0 ? -base : null),
-			rate: l.rate === null || l.rate === undefined ? 1 : round4(l.rate),
-			memo: text(l.description),
-			deptno: text(l.deptno),
-			projectno: text(l.projectno),
-			personno: text(l.personno),
-			ext: l,
-		};
-	}),
-});
-
-export const compareSubmission = async ({ client, identity, repo }, principal, rawId) => {
-	requireRight(await identity.resolve(principal), "jv", null);
-	const id = documentId(rawId);
-	const row = await repo.read(id);
-	if (!row) throw finaError("DOCUMENT_NOT_FOUND", `JV submission ${id} was not found.`);
-	const jvDocument = documentOf("jv");
-
-	let jvState = "NOT_POSTED";
-	let jvDoc = null;
-	if (row.finaJvId) {
-		try {
-			jvDoc = await readDocument(client, jvDocument, row.finaJvId);
-			jvState = "POSTED";
-		} catch (error) {
-			if (error?.code !== "DOCUMENT_NOT_FOUND") throw error;
-			jvState = "NOT_FOUND";
-		}
-	}
-
-	const left = plain(row.document ?? {});
-	const right = jvDoc ? plain(jvDoc) : null;
-	const both = [left, ...(right ? [right] : [])];
-	const all = (key) => both.flatMap((s) => s.lines.map((l) => l[key]));
-
-	const [accounts, depts, projects, persons, templates, mappings] = await Promise.all([
-		namesOf(client, "GLACCNT", "GLACCOUNT", "ACCOUNTNAME", all("glaccount")),
-		namesOf(client, "DEPARTMENT", "DEPTNO", "DEPTNAME", all("deptno")),
-		namesOf(client, "PROJECT", "PROJECTNO", "PROJECTNAME", all("projectno")),
-		namesOf(client, "PERSONDATA", "PERSONNO", "NAME", all("personno")),
-		listTemplates(client, jvDocument.templateType),
-		readMappings(client, jvDocument.extended),
-	]);
-	const templateName = (templateId) => templates.find((t) => t.id === Number(templateId))?.name ?? (templateId ? String(templateId) : null);
-
-	/* Extended values as a person reads them: a lookup by its EXTENDEDDET INFO1, a custom field as stored. */
-	const masterMappings = mappings.filter((m) => m.part === "master");
-	const lineMappings = mappings.filter((m) => m.part === "detail");
-	const lookupIds = [];
-	for (const s of both) {
-		for (const m of masterMappings) if (m.kind === "lookup") lookupIds.push(s.master.ext[m.key]);
-		for (const l of s.lines) for (const m of lineMappings) if (m.kind === "lookup") lookupIds.push(l.ext[m.key]);
-	}
-	const wantedIds = [...new Set(lookupIds.map(Number).filter((n) => Number.isInteger(n) && n > 0))];
-	const infos =
-		wantedIds.length === 0
-			? new Map()
-			: new Map(
-					((await client.executeSql(`SELECT EXTENDEDDETID, INFO1 FROM EXTENDEDDET WHERE EXTENDEDDETID IN (${wantedIds.join(", ")})`)) ?? []).map((r) => [
-						Number(r.extendeddetid),
-						text(r.info1),
-					]),
-				);
-	const extValue = (m, raw) => {
-		if (raw === null || raw === undefined || raw === "") return null;
-		if (m.kind === "lookup") return infos.get(Number(raw)) ?? String(raw);
-		return m.customType === 4 ? toDateOnly(raw) : raw;
-	};
-	const extendedOf = (source, list) => list.map((m) => ({ key: m.key, caption: m.caption, value: extValue(m, source[m.key]) }));
-
-	const sideOf = (s, head) => {
-		const lines = s.lines.map((l, i) => ({
-			n: i + 1,
-			account: named(accounts, l.glaccount),
-			debit: l.debit,
-			credit: l.credit,
-			rate: l.rate,
-			memo: l.memo,
-			dept: named(depts, l.deptno),
-			project: named(projects, l.projectno),
-			subsidiary: named(persons, l.personno),
-			extended: extendedOf(l.ext, lineMappings),
-		}));
-		return {
-			...head,
-			master: { transdate: s.master.transdate, transdescription: s.master.transdescription, templateName: templateName(s.master.templateid), extended: extendedOf(s.master.ext, masterMappings) },
-			lines,
-			totals: { debit: round4(lines.reduce((t, l) => t + (l.debit ?? 0), 0)), credit: round4(lines.reduce((t, l) => t + (l.credit ?? 0), 0)) },
-		};
-	};
-
-	const submission = sideOf(left, { id: row.id, number: row.number, status: row.status });
-	const jv = right ? sideOf(right, { id: Number(row.finaJvId), number: jvDoc.master?.jvnumber ?? row.finaJvNumber ?? null }) : null;
-
-	const differences = [];
-	if (jv) {
-		const differ = (field, a, b, extra = {}) => {
-			if ((a ?? null) !== (b ?? null)) differences.push({ field, ...extra, submission: a ?? null, jv: b ?? null });
-		};
-		differ("transdate", submission.master.transdate, jv.master.transdate);
-		differ("transdescription", submission.master.transdescription, jv.master.transdescription);
-		differ("template", submission.master.templateName, jv.master.templateName);
-		submission.master.extended.forEach((e, i) => differ(e.key, e.value, jv.master.extended[i]?.value, { caption: e.caption }));
-		const count = Math.max(submission.lines.length, jv.lines.length);
-		for (let i = 0; i < count; i++) {
-			const a = submission.lines[i];
-			const b = jv.lines[i];
-			const line = i + 1;
-			if (!b) {
-				differences.push({ line, only: "submission" });
-				continue;
-			}
-			if (!a) {
-				differences.push({ line, only: "jv" });
-				continue;
-			}
-			for (const field of ["account", "debit", "credit", "rate", "memo", "dept", "project", "subsidiary"]) differ(field, a[field], b[field], { line });
-			a.extended.forEach((e, k) => differ(e.key, e.value, b.extended[k]?.value, { line, caption: e.caption }));
-		}
-	}
-
-	return { submission, jv, jvState, differences };
-};

package/engine/fina/submissionRepo.js

@@ -1,114 +0,0 @@
-/*
- * Doc 8 M7 — FINA$JV_SUBMISSION (migrations/postgres/1790800000000__fina_jv_submission.sql), engine/fina's only reader
- * and writer of its contents. The browser role reads the list's columns only; the JV itself (DOCUMENT) goes out through
- * fina/submission/get, which checks the FINA right.
- *
- * - The temporary number PJV/{YYYY}/{MM}/{seq:4} (reset yearly, A-10) is taken by biza_next_number IN the INSERT, so a
- *   failed insert gives its number back and two at once get two numbers.
- * - Every change names the status it expects (`WHERE STATUS = …`), so an edit and a decision cannot both win, and a
- *   second posting run cannot claim what the first one holds.
- */
-import { finaError } from "./errors.js";
-import { sqlString } from "./sql.js";
-
-const TABLE = "FINA$JV_SUBMISSION";
-const STATUSES = new Set(["MENUNGGU", "PROSES_POSTING", "DISETUJUI", "DITOLAK", "GAGAL_POSTING"]);
-
-const idOf = (value) => {
-	const id = Number(value);
-	if (value === null || value === undefined || !Number.isInteger(id) || id <= 0 || !/^\d+$/.test(String(value).trim())) {
-		throw finaError("INVALID", `A JV submission id is a positive whole number, not ${JSON.stringify(value)}.`);
-	}
-	return id;
-};
-const statusOf = (value) => {
-	if (!STATUSES.has(value)) throw new Error(`Not a JV submission status: ${JSON.stringify(value)}.`);
-	return sqlString(value);
-};
-const text = (v) => (v === null || v === undefined || v === "" ? "NULL" : sqlString(v));
-const int = (v) => (v === null || v === undefined || v === "" || !Number.isInteger(Number(v)) ? "NULL" : String(Number(v)));
-const num = (v) => (v === null || v === undefined || v === "" || !Number.isFinite(Number(v)) ? "NULL" : String(Number(v)));
-const asNumber = (v) => (v === null || v === undefined ? null : Number(v));
-
-const PERIOD = "to_char(now(), 'YYYY')";
-const NUMBER = "'PJV/' || to_char(now(), 'YYYY') || '/' || to_char(now(), 'MM') || '/' || CASE WHEN N.V < 10000 THEN lpad(N.V::text, 4, '0') ELSE N.V::text END";
-
-const COLUMNS =
-	"ID, SUB_NUMBER, STATUS, to_char(TRANSDATE, 'YYYY-MM-DD') AS TRANSDATE, TRANSDESCRIPTION, AMOUNT, TEMPLATEID, DOCUMENT, " +
-	"WF_INSTANCE_ID, FINA_JVID, FINA_JVNUMBER, POST_ERROR, CREATED_BY, UPDATED_BY, DECIDED_BY";
-
-const parse = (raw) => {
-	try {
-		return typeof raw === "string" ? JSON.parse(raw) : (raw ?? null);
-	} catch {
-		return null;
-	}
-};
-
-const rowOf = (r) => ({
-	id: Number(r.id),
-	number: r.sub_number,
-	status: r.status,
-	transdate: r.transdate ?? null,
-	transdescription: r.transdescription ?? null,
-	amount: asNumber(r.amount),
-	templateid: asNumber(r.templateid),
-	document: parse(r.document),
-	instanceId: asNumber(r.wf_instance_id),
-	finaJvId: asNumber(r.fina_jvid),
-	finaJvNumber: r.fina_jvnumber ?? null,
-	postError: r.post_error ?? null,
-	createdBy: asNumber(r.created_by),
-	updatedBy: asNumber(r.updated_by),
-	decidedBy: asNumber(r.decided_by),
-});
-
-export const createSubmissionRepo = ({ exec }) => {
-	const changed = async (sql) => ((await exec(sql)) ?? []).length > 0;
-	const contents = (v) =>
-		`TRANSDATE = ${text(v.transdate)}, TRANSDESCRIPTION = ${text(v.transdescription)}, AMOUNT = ${num(v.amount)}, TEMPLATEID = ${int(v.templateid)}, DOCUMENT = ${sqlString(JSON.stringify(v.document ?? {}))}`;
-
-	return {
-		insert: async ({ transdate, transdescription, amount, templateid, document, userId }) => {
-			const rows = await exec(
-				`WITH N AS (SELECT biza_next_number(${sqlString(TABLE)}, 'SUB_NUMBER', ${PERIOD}) AS V) ` +
-					`INSERT INTO ${TABLE} (SUB_NUMBER, STATUS, TRANSDATE, TRANSDESCRIPTION, AMOUNT, TEMPLATEID, DOCUMENT, CREATED_BY) ` +
-					`SELECT ${NUMBER}, 'MENUNGGU', ${text(transdate)}, ${text(transdescription)}, ${num(amount)}, ${int(templateid)}, ` +
-					`${sqlString(JSON.stringify(document ?? {}))}, ${int(userId)} FROM N RETURNING ID, SUB_NUMBER`,
-			);
-			const r = rows?.[0];
-			if (!r) throw new Error("The JV submission was not kept: the database answered no row.");
-			return { id: Number(r.id), number: r.sub_number };
-		},
-
-		read: async (id) => {
-			const rows = (await exec(`SELECT ${COLUMNS} FROM ${TABLE} WHERE ID = ${idOf(id)}`)) ?? [];
-			return rows.length > 0 ? rowOf(rows[0]) : null;
-		},
-
-		update: async (id, values) =>
-			changed(`UPDATE ${TABLE} SET ${contents(values)}, UPDATED_BY = ${int(values.updatedBy)}, UPDATED_AT = now() WHERE ID = ${idOf(id)} AND STATUS = 'MENUNGGU' RETURNING ID`),
-
-		setInstance: async (id, instanceId) => {
-			await exec(`UPDATE ${TABLE} SET WF_INSTANCE_ID = ${int(instanceId)} WHERE ID = ${idOf(id)}`);
-		},
-
-		claim: async (id) => changed(`UPDATE ${TABLE} SET STATUS = 'PROSES_POSTING', UPDATED_AT = now() WHERE ID = ${idOf(id)} AND STATUS = 'MENUNGGU' RETURNING ID`),
-
-		decide: async (id, values, from) => {
-			const set = [`STATUS = ${statusOf(values.status)}`, `DECIDED_BY = ${int(values.decidedBy)}`, "DECIDED_AT = now()", "UPDATED_AT = now()"];
-			if ("finaJvId" in values) set.push(`FINA_JVID = ${int(values.finaJvId)}`);
-			if ("finaJvNumber" in values) set.push(`FINA_JVNUMBER = ${text(values.finaJvNumber)}`);
-			if ("postError" in values) set.push(`POST_ERROR = ${text(values.postError)}`);
-			return changed(`UPDATE ${TABLE} SET ${set.join(", ")} WHERE ID = ${idOf(id)} AND STATUS = ${statusOf(from)} RETURNING ID`);
-		},
-
-		remove: async (id) => changed(`DELETE FROM ${TABLE} WHERE ID = ${idOf(id)} AND STATUS = 'MENUNGGU' RETURNING ID`),
-
-		/* Doc 8 M7b (L-02): the submission a FINA JV came from — the newest, should one ever have been posted twice. */
-		findByJv: async (jvId) => {
-			const rows = (await exec(`SELECT ID, SUB_NUMBER FROM ${TABLE} WHERE FINA_JVID = ${idOf(jvId)} ORDER BY ID DESC LIMIT 1`)) ?? [];
-			return rows.length > 0 ? { id: Number(rows[0].id), number: rows[0].sub_number } : null;
-		},
-	};
-};